From nobody Tue May 7 12:00:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62342+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62342+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594381139; cv=none; d=zohomail.com; s=zohoarc; b=UfWrnWckQOMHQT7qIaxCOfevzP1MilSkKxJrSbAV1D7kGkLcc/HMPraQP4vA1RYnON1hYFhpw9dZTug7dQud5lYVLoVw619Y/woGnbsbcdPVg7mGL2tkss34f1HhxOAf8NiMpdCOmYTan77tKDcFf7kiS2sfNXu0seF/GwhyM7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594381139; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=XaLr0AkamNBfxu6O1XxnUaMZQcdvImAti28d5lJ4UPA=; b=Dq9d2qoKcq+QCznaHvVRMWH3ys2a7cBDBAyVj3zi9NcdlrJsZOBVdQEp1oEj36x0R18mTSuDbe4q6mYIntqFMNF+cYW98qn0aoWMF1K8S/IkZv2LqIH53Prfr5u6uud3c5Dki8H6lTEj+jRQ2XuLeIOZSO87jPgQq85XB30wlKg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62342+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594381139776315.28070556995567; Fri, 10 Jul 2020 04:38:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xq61YY1788612xJWZXHqEWd7; Fri, 10 Jul 2020 04:38:59 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.3549.1594351891758715861 for ; Thu, 09 Jul 2020 20:31:32 -0700 IronPort-SDR: k6qJnDK/IwU2pu4tHn2a0ZYbXi3ArjCU9cWHtqBpgZOvRCtQcGO+YSz85XTWLkPzCGHmvRt70G IZS3PbZNaaxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9677"; a="166235361" X-IronPort-AV: E=Sophos;i="5.75,334,1589266800"; d="scan'208";a="166235361" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2020 20:31:31 -0700 IronPort-SDR: zL/+3EpXk0u10BkdKkbKvwTbAzvfgrOTdq8eevmcyvqC1zq2BjCU3tNaywCvKgIeLCSu/Jj258 EXesjtfAHI8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,334,1589266800"; d="scan'208";a="484505487" X-Received: from jlux-desk.gar.corp.intel.com ([10.5.245.53]) by fmsmga005.fm.intel.com with ESMTP; 09 Jul 2020 20:31:29 -0700 From: Ji-yunX Lu To: devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Laszlo Ersek , Rahul Kumar Subject: [edk2-devel] [edk2: PATCH] UefiCpuPkg: To enable X2Apic by default Date: Fri, 10 Jul 2020 11:31:23 +0800 Message-Id: <20200710033123.2236-1-ji-yunx.lu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ji-yunx.lu@intel.com X-Gm-Message-State: LxMy8PvnDPZtn8tdEq8Tz6xZx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594381139; bh=WBIgRzCQYvCLDFct9qv7wuy35UQiMucpzMFH2tnv8Sg=; h=Cc:Date:From:Reply-To:Subject:To; b=Huqb9OP1317ZrPtRYIUrgVYXAx8UAKdJ8oYgc6HJniZ5DQEe9UIdgzZhjUixZ7w939Y m7dh0DHDJTw4LqQXgm6dmaIHkBxjew2mkzjehvf+si/YB2Lb/WD9tcPUWwEWXPTOOuYn6 tSm/STMW4B9jUvaTXJ05KgDqLfj26xa6amA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2845 Platform shall enable X2APIC by default to meet requirements for interrupt = steering policy on Windows OS. Change-Id: Ia9e24bce79c91762c560fa3de6260716939f0b1b Signed-off-by: Ji-yunX Lu Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 21 ++++----------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index ab7a8ed663..70bc5da195 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -488,8 +488,8 @@ CollectProcessorCount ( ) { UINTN Index; - CPU_INFO_IN_HOB *CpuInfoInHob; BOOLEAN X2Apic; + CPUID_VERSION_INFO_ECX VersionInfoEcx; =20 // // Send 1st broadcast IPI to APs to wakeup APs @@ -505,26 +505,13 @@ CollectProcessorCount ( CpuPause (); } =20 - - // - // Enable x2APIC mode if - // 1. Number of CPU is greater than 255; or - // 2. There are any logical processors reporting an Initial APIC ID of = 255 or greater. - // X2Apic =3D FALSE; - if (CpuMpData->CpuCount > 255) { + AsmCpuid (CPUID_VERSION_INFO, NULL, NULL, &VersionInfoEcx.Uint32, NULL); + if (VersionInfoEcx.Bits.x2APIC =3D=3D 1) { // - // If there are more than 255 processor found, force to enable X2APIC + // Enable x2APIC mode if capable // X2Apic =3D TRUE; - } else { - CpuInfoInHob =3D (CPU_INFO_IN_HOB *) (UINTN) CpuMpData->CpuInfoInHob; - for (Index =3D 0; Index < CpuMpData->CpuCount; Index++) { - if (CpuInfoInHob[Index].InitialApicId >=3D 0xFF) { - X2Apic =3D TRUE; - break; - } - } } =20 if (X2Apic) { --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62342): https://edk2.groups.io/g/devel/message/62342 Mute This Topic: https://groups.io/mt/75413450/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-