From nobody Sat Apr 27 15:45:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62276+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62276+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594262811; cv=none; d=zohomail.com; s=zohoarc; b=iq9WfyehcYiozuKB/edDndcftPC3KRUzFlKdp/ypsF8+5JH/zPMWEYAVXVdfbzn+X+YoT98ImF2fLJOftqZyK7J3JkjUJuYyQGW+zjfbNzlIZ7SRENVx20Oxshn4TVvVjdatsZ8GL1jjny0Tv55Nvaz/MzMTuC09OaREJi/u2So= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594262811; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=z/jhDUWmx/t1eR5ebMsg/2Ox8UJvVGQ0jnQkLn+mV3w=; b=OqmS1n0wJO7FAF5BH2yA7PQhQHt2Sz/BhC61W9YK84czcvNf4vaxx6t4b4LbjkurjKAEB70n2qg3E+prj4Ii2Kq3MCvhOz1sLRTv2BRlZpqAQLX+q3ANNydWp/nFVNEH+rtbJ1pMiME97d94T8ZnGlKem0xC8H53BxmO8mY2/yg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62276+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594262811956780.7524478567346; Wed, 8 Jul 2020 19:46:51 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ZO5kYY1788612xdcvvPfZ5l3; Wed, 08 Jul 2020 19:46:51 -0700 X-Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.3374.1594262810724939191 for ; Wed, 08 Jul 2020 19:46:50 -0700 IronPort-SDR: TUa0LOMyMvWJKSzctGzQf3mSJpQZYvpwqZlbaFsJf97JDsR+lMc/92iXqgP5lXUtLYHDPEWeZe LIqwgMuCm3wQ== X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="136160726" X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="136160726" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2020 19:46:50 -0700 IronPort-SDR: eIFBwmSRVm0outTDjeZjCnXNzOytw3yT8ZLqARrAgo7TJXhHtBEvlJs8YARBXOu4OfQ0WaKTjd xnmhCdxJkfFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="283992389" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.114]) by orsmga006.jf.intel.com with ESMTP; 08 Jul 2020 19:46:48 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Terry Lee , Jiewen Yao , Jian J Wang , Chao Zhang Subject: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision Date: Thu, 9 Jul 2020 10:46:47 +0800 Message-Id: <20200709024647.31672-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: HnUlegvEVdE10xkeHBgEF1d0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594262811; bh=tBvddpO++ufxL8tNSmipA9ytbS92b5k2YTvOlVEFSJ4=; h=Cc:Date:From:Reply-To:Subject:To; b=D2WEbO7eWgUJZGekWZRXlSt9MxFldCc5TKXTvtZmDpNsIxzY7derVtG/vY03/eMUzEF aNTrE4c7wrZkml4cI1OpFCUOnLFCYzmw46NtuBbe7lt/FoB34pDM6Vjhc4aGeCORAcVIB VEf9QLqrgRRm0ysLVH+WG7h6cdP7RgfWNs0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Terry Lee REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2697 Tcg2PhysicalPresenceLibConstructor set the module variable mIsTcg2PPVerLowerThan_1_3 with incorrect TCG version comparision. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Zhichao Gao --- .../SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenceLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2Physical= PresenceLib.c b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2Physi= calPresenceLib.c index 1c46d5e69d..8afaa0a785 100644 --- a/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenc= eLib.c +++ b/SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/SmmTcg2PhysicalPresenc= eLib.c @@ -387,7 +387,7 @@ Tcg2PhysicalPresenceLibConstructor ( { EFI_STATUS Status; =20 - if (AsciiStrnCmp(PP_INF_VERSION_1_2, (CHAR8 *)PcdGetPtr(PcdTcgPhysicalPr= esenceInterfaceVer), sizeof(PP_INF_VERSION_1_2) - 1) <=3D 0) { + if (AsciiStrnCmp(PP_INF_VERSION_1_2, (CHAR8 *)PcdGetPtr(PcdTcgPhysicalPr= esenceInterfaceVer), sizeof(PP_INF_VERSION_1_2) - 1) >=3D 0) { mIsTcg2PPVerLowerThan_1_3 =3D TRUE; } =20 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62276): https://edk2.groups.io/g/devel/message/62276 Mute This Topic: https://groups.io/mt/75390754/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-