From nobody Sat May 4 00:36:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62186+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62186+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594175252; cv=none; d=zohomail.com; s=zohoarc; b=NaIEzmJuVSbbW0PvNZTMSCSNid+yUhYGnGu6GuL/tnbOXLWIKFQnNqUOxRWYI7/D7n53O8bCth5ICzM4gje5r8TwT+v6jwIS/9BHCgu3Xnjb8oC594N8gpc4frjbhp2nfvDu2o9hdYe7MF1RrcMQhE4mL+N53r4OR81Ftf0Y/yw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594175252; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Zlai4l8hKkcMSCu6iCOIrYf1ibHsOCl5c5MkTZEwf2U=; b=RRuZTi9LMcbRtbV6c1Od2udQuYRLRHYj5x+xhDnWiUClc9kKGc4husALEke7o4pMepIsETLBhT7P1ds/FYIw00MrEG4avQgp0rgoPBo9tTrObGY5UeIoNz8t1oBpTD8esqPO3MQ7W4aP2tZSVXAg4L/mkkHUEryqdB/rNJ1J0So= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62186+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594175252723421.02059347233796; Tue, 7 Jul 2020 19:27:32 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id p6e2YY1788612xJpmvpwo4BP; Tue, 07 Jul 2020 19:27:32 -0700 X-Received: from mga12.intel.com (mga12.intel.com []) by mx.groups.io with SMTP id smtpd.web10.2735.1594175250936997826 for ; Tue, 07 Jul 2020 19:27:31 -0700 IronPort-SDR: c3lGtnuPD6s2RRyIc0womNzkL4wn1VCmVGF+z1RLdF5pgTsvKERWqtO6z+qdPEsXNUrLq/IEzr 26glsRAkbQbw== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="127325755" X-IronPort-AV: E=Sophos;i="5.75,326,1589266800"; d="scan'208";a="127325755" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 19:27:32 -0700 IronPort-SDR: 7gmD0zG+yYZV8GggQRJHLmwChrlQtybTEaWnvrv+BBhIxGY0Fx31+V1vO6Cwigu0shavKcLb/t u6LpdHchyU5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,326,1589266800"; d="scan'208";a="483722341" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.114]) by fmsmga005.fm.intel.com with ESMTP; 07 Jul 2020 19:27:30 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni , Laszlo Ersek Subject: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last block value Date: Wed, 8 Jul 2020 10:27:20 +0800 Message-Id: <20200708022722.27024-2-zhichao.gao@intel.com> In-Reply-To: <20200708022722.27024-1-zhichao.gao@intel.com> References: <20200708022722.27024-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: 46lhtDTOPwFhZYHpwqUFsIJEx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594175252; bh=ewYBy8sTiZdRFHWMxPcYhBfk3MgJa8ejxVhfEXuXA1Y=; h=Cc:Date:From:Reply-To:Subject:To; b=JesytxilIs2qdNYjYvPwIZhE9JFE49MOP2m48pCuWyq6rWXE77IOoIkKn6aswFFwClt MBUNEqjJYxSkZ7X+SQkM/RBkz+xg7ySGMz3Kub7/YBkB5yRxi2f8rAUJqOgbgEwYKQcoU od60oNug3st34jnEQyYwkEEP7bpmJGkaVhM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 The MBR last block value should be sector (512 bytes) numbers. Cc: Hao A Wu Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhichao Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c b/MdeModulePkg/= Universal/Disk/PartitionDxe/Mbr.c index dac451a144..aa0b6cadcc 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c @@ -137,12 +137,14 @@ PartitionInstallMbrChildHandles ( UINT32 MediaId; EFI_LBA LastBlock; EFI_PARTITION_INFO_PROTOCOL PartitionInfo; + UINT64 MediaSize; =20 Found =3D EFI_NOT_FOUND; =20 BlockSize =3D BlockIo->Media->BlockSize; MediaId =3D BlockIo->Media->MediaId; - LastBlock =3D BlockIo->Media->LastBlock; + MediaSize =3D MultU64x32 (BlockIo->Media->LastBlock + 1, BlockSize); + LastBlock =3D DivU64x32 (MediaSize, 512) - 1; =20 // // Ensure the block size can hold the MBR --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62186): https://edk2.groups.io/g/devel/message/62186 Mute This Topic: https://groups.io/mt/75369397/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 00:36:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62187+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62187+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594175254; cv=none; d=zohomail.com; s=zohoarc; b=XUjVpo637nM6fpHkWk9a2cDRC2f8yxjPIUu+fFmiHhkYYkHpHwsbhxl4BEpXunMCEt7OlyzWjECy2c8eh8xpmmtM0ft3ddeyV5WHdawHwg9ZRe6ctMouPq1q/DfkFFuTJhMVOaUhYJsLosgycdw+Ba6VYMWEBLA6e9sBzBlavA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594175254; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7kOJiaKPgZdEYgvNu2n+5pCMugmoj7W2Yr28lq1EWQ4=; b=JCEOfpDVqKyhPcnd9Yt4xbFeKUybhrQ5Y80+HFftCCLLT0E4dl4ITWmhcrxHX9GDddrNgWk/oQ4hnimaM+yRyD3HWvzOIypkriv08srQxZqv4sCkACVJkK10ONgtsob/K1b61BqIqfdNafb8FhLHv/70yiOAe1kZ7pm4y6v9V5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62187+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1594175254132811.7990845159273; Tue, 7 Jul 2020 19:27:34 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id FykeYY1788612xh2Wb0YzlcX; Tue, 07 Jul 2020 19:27:33 -0700 X-Received: from mga12.intel.com (mga12.intel.com []) by mx.groups.io with SMTP id smtpd.web10.2735.1594175250936997826 for ; Tue, 07 Jul 2020 19:27:33 -0700 IronPort-SDR: xzAbnBTKrCha82yARPkdU3c3BB1SY7k80OlWIGxzYAagKarBXMeSh2dO8uB2TaW/YFaL28tFSr 0s3qmnANh91Q== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="127325773" X-IronPort-AV: E=Sophos;i="5.75,326,1589266800"; d="scan'208";a="127325773" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 19:27:33 -0700 IronPort-SDR: qr/cQNCoNceofEj54TokTpmpVoOvdGfrHbaVfQYJLAJu2Xv1Y8tQCtuOfGtvxTcFc5pbDclErD mvBTSdYm3FQQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,326,1589266800"; d="scan'208";a="483722347" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.114]) by fmsmga005.fm.intel.com with ESMTP; 07 Jul 2020 19:27:31 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni , Laszlo Ersek Subject: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM Date: Wed, 8 Jul 2020 10:27:21 +0800 Message-Id: <20200708022722.27024-3-zhichao.gao@intel.com> In-Reply-To: <20200708022722.27024-1-zhichao.gao@intel.com> References: <20200708022722.27024-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: Bkd61ZrduR7E3ttGrVyF5LX9x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594175253; bh=6lFQZNqX9M1L6DpzmMlWz6Cjmv+0GwyVntp80FxxlZQ=; h=Cc:Date:From:Reply-To:Subject:To; b=ovdzJGMHeUE6yA64DAIyfzoNOwcTcxfkXsu2tDSjoLq6ECTA0eMXw7ggSv4Ff0ixB4P txSN0IfWWU7Szjnw9uhZZQH0l9MGff/u6WonRzD/3DL0kAsN9ldwcjTsf3N9Jt+W5jD/9 2kktjWMfcevw7NFoVHhTfd0BEKzORpFP06Q= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 Refer to http://manpages.ubuntu.com/manpages/bionic/man8/mkudffs.8.html. Some Linux ISOs may have the MBR table for compatibility reasons for Windows. The MBR tale would contain the partition entry with start LBA0 and whole media size. There are two methods to check the filesystem in the CD-ROM: 1. MBR partition check (Windows) 2. Whole disk check (MAC OS) UEFI doesn't have the MBR check for UDF and Eltorito. But it may pass the MBR check for such table and fail to detect the filesystem of UDF. Skip the MBR check if the MBR is added for Windows compatiblity so that the partition driver can continue UDF and ElTorito check. Cc: Hao A Wu Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhichao Gao Reviewed-by: Hao A Wu --- .../Universal/Disk/PartitionDxe/Mbr.c | 38 ++++++++++++++++--- 1 file changed, 32 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c b/MdeModulePkg/= Universal/Disk/PartitionDxe/Mbr.c index aa0b6cadcc..b5cb56842a 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Mbr.c @@ -39,6 +39,7 @@ PartitionValidMbr ( UINT32 StartingLBA; UINT32 EndingLBA; UINT32 NewEndingLBA; + UINT32 SizeInLBA; INTN Index1; INTN Index2; BOOLEAN MbrValid; @@ -51,13 +52,35 @@ PartitionValidMbr ( // MbrValid =3D FALSE; for (Index1 =3D 0; Index1 < MAX_MBR_PARTITIONS; Index1++) { - if (Mbr->Partition[Index1].OSIndicator =3D=3D 0x00 || UNPACK_UINT32 (M= br->Partition[Index1].SizeInLBA) =3D=3D 0) { + StartingLBA =3D UNPACK_UINT32 (Mbr->Partition[Index1].StartingLBA); + SizeInLBA =3D UNPACK_UINT32 (Mbr->Partition[Index1].SizeInLBA); + + // + // If the MBR with partition entry contains itself, i.e. start with LB= A0, + // and have the same size with the media, we treat it as a El Torito p= artition. + // + if ((StartingLBA =3D=3D 0) && + (SizeInLBA !=3D 0) && + (SizeInLBA =3D=3D (LastLba + 1))) { + // + // Refer to the http://manpages.ubuntu.com/manpages/bionic/man8/mkud= ffs.8.html + // "WHOLE DISK VS PARTITION" + // Some linux ISOs may put the MBR table in the first 512 bytes for = compatibility reasons with Windows. + // Linux kernel ignores MBR table if contains partition which star= ts at sector 0. + // Skip it because we don't have the partition check for UDF(El Tori= to compatible). + // It would continue to do the whole disk check in the UDF routine. + // + DEBUG ((DEBUG_INFO, "PartitionValidMbr: The MBR table has partition = entry start at sector 0.\n")); + + return FALSE; + } + + if (Mbr->Partition[Index1].OSIndicator =3D=3D 0x00 || SizeInLBA =3D=3D= 0) { continue; } =20 MbrValid =3D TRUE; - StartingLBA =3D UNPACK_UINT32 (Mbr->Partition[Index1].StartingLBA); - EndingLBA =3D StartingLBA + UNPACK_UINT32 (Mbr->Partition[Index1].Si= zeInLBA) - 1; + EndingLBA =3D StartingLBA + SizeInLBA - 1; if (EndingLBA > LastLba) { // // Compatibility Errata: @@ -77,12 +100,15 @@ PartitionValidMbr ( } =20 for (Index2 =3D Index1 + 1; Index2 < MAX_MBR_PARTITIONS; Index2++) { - if (Mbr->Partition[Index2].OSIndicator =3D=3D 0x00 || UNPACK_UINT32 = (Mbr->Partition[Index2].SizeInLBA) =3D=3D 0) { + StartingLBA =3D UNPACK_UINT32 (Mbr->Partition[Index2].StartingLBA); + SizeInLBA =3D UNPACK_UINT32 (Mbr->Partition[Index2].SizeInLBA); + + if (Mbr->Partition[Index2].OSIndicator =3D=3D 0x00 || SizeInLBA =3D= =3D 0) { continue; } =20 - NewEndingLBA =3D UNPACK_UINT32 (Mbr->Partition[Index2].StartingLBA) = + UNPACK_UINT32 (Mbr->Partition[Index2].SizeInLBA) - 1; - if (NewEndingLBA >=3D StartingLBA && UNPACK_UINT32 (Mbr->Partition[I= ndex2].StartingLBA) <=3D EndingLBA) { + NewEndingLBA =3D StartingLBA + SizeInLBA - 1; + if (NewEndingLBA >=3D StartingLBA && StartingLBA <=3D EndingLBA) { // // This region overlaps with the Index1'th region // --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62187): https://edk2.groups.io/g/devel/message/62187 Mute This Topic: https://groups.io/mt/75369398/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 00:36:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+62188+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62188+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1594175255; cv=none; d=zohomail.com; s=zohoarc; b=SFhl5qlmF67QkSwNpt0YmPIKkbqyHLm9ufH5Ghd64B0bgwo6GAjBOf4oacmxH/Tr0NZk3r1SF49ktSo6EYwtmEEHzaAokrg8dza1d7GhrmDnzzV4hTwz8vE9GHZuBI9bXItKncD5N3SJq6C3G/0mbCanh9K+XNrUY1jGN9kfwMA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594175255; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=fIFSi/5uSr3GgS3iN/zpdLkuq4goOnu4iABKGm/3/u8=; b=c3Xwckvb341xI3xRQ3OYAhBRVlTCjm1b9X9UkEeQV4nXWzOvvBpxFF4mi6MBdI2Sh3rqhETJziX1DS+GdbBi1fQDS7LyH4uLw4YEHK8ItJl66XjCUKsejxddjBo/aSE7fODR2KuVZU/cnWsj6/EI1ib1J2JhPc/lWNH7bgNKl50= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+62188+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 159417525531817.754033242015566; Tue, 7 Jul 2020 19:27:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Z1cmYY1788612xXmQ4jIWZlJ; Tue, 07 Jul 2020 19:27:35 -0700 X-Received: from mga12.intel.com (mga12.intel.com []) by mx.groups.io with SMTP id smtpd.web10.2735.1594175250936997826 for ; Tue, 07 Jul 2020 19:27:34 -0700 IronPort-SDR: wGpCK9kjv0OPJUL3hxOK3QAPcFPATSKPjs6R5UFlFD95ho524op3wuckld/lGCcNDsuRBxlSwA iFEscq+3qj+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="127325785" X-IronPort-AV: E=Sophos;i="5.75,326,1589266800"; d="scan'208";a="127325785" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 19:27:35 -0700 IronPort-SDR: 9Jz8fcslphtva3Q5hm1/gnptRZy75OXffmvHkBUrX3a1ulhnDhXuaNFoKXrgihR0qeLttJ+caZ aQoO+orbBq2Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,326,1589266800"; d="scan'208";a="483722351" X-Received: from fieedk001.ccr.corp.intel.com ([10.239.33.114]) by fmsmga005.fm.intel.com with ESMTP; 07 Jul 2020 19:27:33 -0700 From: "Gao, Zhichao" To: devel@edk2.groups.io Cc: Hao A Wu , Ray Ni , Laszlo Ersek Subject: [edk2-devel] [PATCH V2 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes Date: Wed, 8 Jul 2020 10:27:22 +0800 Message-Id: <20200708022722.27024-4-zhichao.gao@intel.com> In-Reply-To: <20200708022722.27024-1-zhichao.gao@intel.com> References: <20200708022722.27024-1-zhichao.gao@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhichao.gao@intel.com X-Gm-Message-State: IiqKivff9UotnUcDV9CYuAMgx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1594175255; bh=5fXH5EqEsk0YodVr1VpOrlF+X3BiueCVLSuSy4efw2s=; h=Cc:Date:From:Reply-To:Subject:To; b=PQsE1rUkoPpQQtqESMsCYwDaBCnDKeuUO+CLp2UlvYHf6lrxefM+BU7BJ0iQuqw8lRe OdNRe1g/yFwPElVcRBN3khFr1jTio7cn1BSVNIupeXT/keY94Jct18FfVJRnTiyVamgz6 p19JT9MXaEmfxWJXsJ9ypwvA39lPK/4vOKE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2823 Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition driver continuely check next routine function. Cc: Hao A Wu Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhichao Gao Reviewed-by: Hao A Wu --- MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c b/MdeModu= lePkg/Universal/Disk/PartitionDxe/Partition.c index d1c878ad2e..6a43c3cafb 100644 --- a/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c +++ b/MdeModulePkg/Universal/Disk/PartitionDxe/Partition.c @@ -1276,6 +1276,15 @@ PartitionInstallChildHandle ( } else { FreePool (Private->DevicePath); FreePool (Private); + + // + // if the Status =3D=3D EFI_ALREADY_STARTED, it means the child handles + // are already installed. So return EFI_SUCCESS to avoid do the next + // partition type check. + // + if (Status =3D=3D EFI_ALREADY_STARTED) { + Status =3D EFI_SUCCESS; + } } =20 return Status; --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62188): https://edk2.groups.io/g/devel/message/62188 Mute This Topic: https://groups.io/mt/75369399/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-