From nobody Mon Feb 9 21:22:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+61927+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61927+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1593633704; cv=none; d=zohomail.com; s=zohoarc; b=fDQNdGm5hvfrZ4XdPe4Qg1EFi8iLD3rjHG0zhuh9fhKmrYupovif+tsakMuSspHQi/t7C+zQBvPBGnjzDzLoLPzx47x2+2DM2EuO+WXxChrz1X3IkmA8/IERhKWNVOrewUax+SMGFARtqhQs00gre7G+SMEEXKjeoZ5m3P7sg2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593633704; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=oikTXvUoalcT7DELIRMU4CXOCtuRY5PTMqxbmCoK21E=; b=LyzpIfcmaNuNkotMl+s1Fk1oifSQ6xa10f9hT3yxIKwjEWHntr3C8A1KII3+XYLSJSPOX/R9psNPaVSaWJUjV9sJ+1NkaW+SczYbpxnWAQtYHmtT6oaMeu1AcfCEmKH/a8qdzSPifL8x5Blgj4W+ZkHxEpcPPLMTSxQRZ3o4Jnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61927+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1593633704368963.8398630216417; Wed, 1 Jul 2020 13:01:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id n5uAYY1788612xwmSXiXClTr; Wed, 01 Jul 2020 13:01:44 -0700 X-Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.6025.1593633686411021040 for ; Wed, 01 Jul 2020 13:01:26 -0700 X-Received: by mail-wr1-f67.google.com with SMTP id q5so25391197wru.6 for ; Wed, 01 Jul 2020 13:01:26 -0700 (PDT) X-Gm-Message-State: td3zto7oIyCYPrT8VAdz93KFx1787277AA= X-Google-Smtp-Source: ABdhPJwMkUp3D57ffZ6IILNygKheSEaznMsI0vdEJ+fVxuhkweo0Vfta82CAyXv2izEemSPggk3ckg== X-Received: by 2002:adf:e4c9:: with SMTP id v9mr27760635wrm.62.1593633684632; Wed, 01 Jul 2020 13:01:24 -0700 (PDT) X-Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id s8sm8519067wru.38.2020.07.01.13.01.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 13:01:23 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , macarl@microsoft.com Subject: [edk2-devel] [RFC 4/5] EmbeddedPkg/PrePiLib: drop spurious re-init of CompressedData Date: Wed, 1 Jul 2020 21:01:17 +0100 Message-Id: <20200701200118.3972-5-leif@nuviainc.com> In-Reply-To: <20200701200118.3972-1-leif@nuviainc.com> References: <20200701200118.3972-1-leif@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1593633704; bh=bvKoPbyffai7IN9RNakkH1u7BiWnsKACGoVhHKiD8Vo=; h=Cc:Date:From:Reply-To:Subject:To; b=RlScgLtb/ErEQz5FcugQQxdwV8MXX6LcIPxLx7m8IluQqts4aK8/4yaKWGPHGKouwc1 r36PL/H1F0oMOGRrCwWZ9h8UMgYw1gSpA39vJNprP+XjiHao4iD8lh9HEtA/Pl3HEHbju G5UbkLs/PXWSpi9QASqVxbgak6G7ldLhe60= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" After the refactoring, it is very clear that CompressedData is initialized twice, using exactly the same values. Drop the second one. Signed-off-by: Leif Lindholm --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/Pre= PiLib/FwVol.c index a0672c084471..083bc27efead 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -420,8 +420,6 @@ FfsProcessSection ( // Call decompress function // if (Section->Type =3D=3D EFI_SECTION_COMPRESSION) { - CompressedData =3D (VOID *)((UINTN)Section + FfsCompressionSection= HeaderSize (Section)); - Status =3D UefiDecompress ( CompressedData, DstBuffer, --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61927): https://edk2.groups.io/g/devel/message/61927 Mute This Topic: https://groups.io/mt/75244272/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-