From nobody Mon Feb 9 12:15:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+61925+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61925+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1593633693; cv=none; d=zohomail.com; s=zohoarc; b=hpmZJ6f8npklmaskqgavB7X7TPUG8Bq8DKI+W4lcriRkWJJys8ovTOUhhFermAF6z+94MKqCaiGN9DOuqYPT/vReO7/d4fbx3M4uMsZaN+ej66JsZdyCtVa+eGE7rmhxzNSBmyI/vuyU4P7/0RJ/h4f3YHKyCJygiQIqgALJ2ns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593633693; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=wAJUOWSxJdFsznNgbiEHW2MUFFu1DYhTpTEXti71zw8=; b=arVgpZcTcY/+lwW+/h5KxXRAEtzKVFcL3fwynpdVPHovsQe805xTObqmnt69OZnudPbn0IDqA6Zgh/iwdUCF6gpLbII/YB/pFVD6QBTB6Lol923P9Wi8BFTCvvXYDrH/xmvb5NFZQ4c4RCkPQAOitD5TEaXt3L20DUMYBdPKOaI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61925+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1593633693688613.1257481150706; Wed, 1 Jul 2020 13:01:33 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id fzG0YY1788612xvfl6i34El6; Wed, 01 Jul 2020 13:01:31 -0700 X-Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web11.6022.1593633684328058033 for ; Wed, 01 Jul 2020 13:01:24 -0700 X-Received: by mail-wm1-f65.google.com with SMTP id j18so23868253wmi.3 for ; Wed, 01 Jul 2020 13:01:24 -0700 (PDT) X-Gm-Message-State: oF4WanzJn7wvJbQCi02ud41cx1787277AA= X-Google-Smtp-Source: ABdhPJzBiJfqtUxZ4az4v7GSFLeCSMIwDv6ap3eyrfGYFqjzp5v+h1FM18kffXtJHHUzW5e5XnM1RA== X-Received: by 2002:a1c:1d46:: with SMTP id d67mr30152835wmd.152.1593633682694; Wed, 01 Jul 2020 13:01:22 -0700 (PDT) X-Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id s8sm8519067wru.38.2020.07.01.13.01.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 13:01:22 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , macarl@microsoft.com Subject: [edk2-devel] [RFC 2/5] EmbeddedPkg/PrePiLib: drop else if after return Date: Wed, 1 Jul 2020 21:01:15 +0100 Message-Id: <20200701200118.3972-3-leif@nuviainc.com> In-Reply-To: <20200701200118.3972-1-leif@nuviainc.com> References: <20200701200118.3972-1-leif@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1593633691; bh=hnpGw1uaBXEAVQVMa87Ad/Z36LHjQ/rf6Ex2T496N+Q=; h=Cc:Date:From:Reply-To:Subject:To; b=iMxagSx4DjaSh1C24dQ5DpL9yaEQSxPSGTYf1wlVgVFiE4J9JC/zU7bgQPPZ0PZeECu NxvSPA9Y6L+Xpf/By5oCqfedUyk6hgck4ZUia+5kwneRVwKWedFkz/RNvjQSiFQIXapaP Pg+X/yZOPhCTtPXt2ay8Sk+ufw+y7LdUUB4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Simplify FfsProcessSection logic by breaking the continuation of the main loop as a new if statement that executes if the very first test doesn't end up returning. Signed-off-by: Leif Lindholm --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/Pre= PiLib/FwVol.c index 90b5b4444002..fc40d8650be1 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -317,8 +317,9 @@ FfsProcessSection ( } =20 return EFI_SUCCESS; - } else if ((Section->Type =3D=3D EFI_SECTION_COMPRESSION) || (Section-= >Type =3D=3D EFI_SECTION_GUID_DEFINED)) { + } =20 + if ((Section->Type =3D=3D EFI_SECTION_COMPRESSION) || (Section->Type = =3D=3D EFI_SECTION_GUID_DEFINED)) { if (Section->Type =3D=3D EFI_SECTION_COMPRESSION) { if (IS_SECTION2 (Section)) { CompressionSection2 =3D (EFI_COMPRESSION_SECTION2 *) Section; --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61925): https://edk2.groups.io/g/devel/message/61925 Mute This Topic: https://groups.io/mt/75244269/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-