From nobody Mon Feb 9 12:15:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+61924+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61924+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1593633689; cv=none; d=zohomail.com; s=zohoarc; b=j4rrz5oa1lSrAyhQ0iD5UdYB9BoEY5z4cX76OysL4MYAhAxZUowxkN3vUg6s0i44vVw/kBIUUcG7W2ulfW9pWwXfl5FGKZZ72FpfO7qVqfIBZZwQKMbzqN3uKR6Aj65ayQyIHYEZ+5Dhdf7j3GHZd1zc2freJ/ekQX2E8Vynhx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593633689; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=3IZyaBq1ueCY1r/Tey2yVq+xlHiHavFboN2F60gmTvA=; b=kDNB0ZW40YiCwbCR1fajwl02OqYomLFsf1KZkiLzWWEWHr7a4Q+nntjkPcOZRsyBI0OngUjurPCquYy7ivzOhnjtWyycTtPmwp7vjdFRY5yTw/OKKixJSNO9AnSK5GwYC61TKFFIwEAV5pRKpB7dQDFa4IXVVABsICoouRl67BY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61924+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1593633689781763.7657454812887; Wed, 1 Jul 2020 13:01:29 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id gexcYY1788612xOYHPSprhQz; Wed, 01 Jul 2020 13:01:28 -0700 X-Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.groups.io with SMTP id smtpd.web11.6021.1593633683491217615 for ; Wed, 01 Jul 2020 13:01:23 -0700 X-Received: by mail-wm1-f42.google.com with SMTP id o2so24797721wmh.2 for ; Wed, 01 Jul 2020 13:01:23 -0700 (PDT) X-Gm-Message-State: d3mevQjmdxGFVjQ4XS6xEh2ix1787277AA= X-Google-Smtp-Source: ABdhPJxeJZ00z0IeU61W32XsR2qd0sNnEjIr5cDXrEkUH1NOUQUocIF4IepA9IxDCZSbJZL+0TBCbw== X-Received: by 2002:a1c:1dc7:: with SMTP id d190mr27411712wmd.36.1593633681778; Wed, 01 Jul 2020 13:01:21 -0700 (PDT) X-Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id s8sm8519067wru.38.2020.07.01.13.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jul 2020 13:01:21 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Ard Biesheuvel , macarl@microsoft.com Subject: [edk2-devel] [RFC 1/5] EmbeddedPkg/PrePiLib: style cleanup in FwVol.c Date: Wed, 1 Jul 2020 21:01:14 +0100 Message-Id: <20200701200118.3972-2-leif@nuviainc.com> In-Reply-To: <20200701200118.3972-1-leif@nuviainc.com> References: <20200701200118.3972-1-leif@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1593633688; bh=1uRIsMU0t0IbAGPCP+OT7RBtqUOW06n3iIQWCEsH/RE=; h=Cc:Date:From:Reply-To:Subject:To; b=YOjLZtWxugPPeBR4KAbR9B1Qhce0MCy+JtmkTfC3VvKbiMn+ksYq70g/XQkQN15pUfL 4pz5nz/eO5W4M0fT3/d4410HvLZE+6/8kAxkTvrF/1S8llEaGaQ1CnUEn6umnGdFV1wsn U86pnIRelgnt59EA+Oh++vB//cB3ZZ3wTf0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Move some curly brackets, change a couple of EFI_D_ to DEBUG_, and fix some intentation. Signed-off-by: Leif Lindholm --- EmbeddedPkg/Library/PrePiLib/FwVol.c | 44 +++++++++++++--------------- 1 file changed, 20 insertions(+), 24 deletions(-) diff --git a/EmbeddedPkg/Library/PrePiLib/FwVol.c b/EmbeddedPkg/Library/Pre= PiLib/FwVol.c index 881506edddaf..90b5b4444002 100644 --- a/EmbeddedPkg/Library/PrePiLib/FwVol.c +++ b/EmbeddedPkg/Library/PrePiLib/FwVol.c @@ -361,7 +361,7 @@ FfsProcessSection ( // // GetInfo failed // - DEBUG ((EFI_D_ERROR, "Decompress GetInfo Failed - %r\n", Status)); + DEBUG ((DEBUG_ERROR, "Decompress GetInfo Failed - %r\n", Status)); return EFI_NOT_FOUND; } // @@ -392,38 +392,37 @@ FfsProcessSection ( if (Section->Type =3D=3D EFI_SECTION_COMPRESSION) { if (IS_SECTION2 (Section)) { CompressedData =3D (CHAR8 *) ((EFI_COMPRESSION_SECTION2 *) Secti= on + 1); - } - else { + } else { CompressedData =3D (CHAR8 *) ((EFI_COMPRESSION_SECTION *) Sectio= n + 1); } =20 Status =3D UefiDecompress ( - CompressedData, - DstBuffer, - ScratchBuffer - ); + CompressedData, + DstBuffer, + ScratchBuffer + ); } else if (Section->Type =3D=3D EFI_SECTION_GUID_DEFINED) { Status =3D ExtractGuidedSectionDecode ( - Section, - &DstBuffer, - ScratchBuffer, - &AuthenticationStatus - ); + Section, + &DstBuffer, + ScratchBuffer, + &AuthenticationStatus + ); } =20 if (EFI_ERROR (Status)) { // // Decompress failed // - DEBUG ((EFI_D_ERROR, "Decompress Failed - %r\n", Status)); + DEBUG ((DEBUG_ERROR, "Decompress Failed - %r\n", Status)); return EFI_NOT_FOUND; } else { return FfsProcessSection ( - SectionType, - DstBuffer, - DstBufferSize, - OutputBuffer - ); + SectionType, + DstBuffer, + DstBufferSize, + OutputBuffer + ); } } =20 @@ -756,17 +755,14 @@ FfsAnyFvFindFirstFile ( Instance =3D 0; *FileHandle =3D NULL; =20 - while (1) - { + while (1) { Status =3D FfsFindNextVolume (Instance++, VolumeHandle); - if (EFI_ERROR (Status)) - { + if (EFI_ERROR (Status)) { break; } =20 Status =3D FfsFindNextFile (FileType, *VolumeHandle, FileHandle); - if (!EFI_ERROR (Status)) - { + if (!EFI_ERROR (Status)) { break; } } --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61924): https://edk2.groups.io/g/devel/message/61924 Mute This Topic: https://groups.io/mt/75244268/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-