From nobody Fri Apr 19 20:48:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+61397+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61397+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1592384655; cv=none; d=zohomail.com; s=zohoarc; b=gL6ZDnoqP8Fa9AUpCnURGkNWf5p7e4lSoidd3MPwvqnGlTenQ3i24FMsblMjgYwg/Yay6QGYuwDnkHOrUHYOK/smOnZQAK0ko3KTH5L0wl8HaZJO+S8bvvCOgwwB7wRkW56KgsTuuwcHHCkBr4evg53zwkHHavW74wWr8j1FhAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592384655; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=kWLiiqsEflIsTMKIAEXXoh378BZW/8fUh+81YndnmAc=; b=Qu/zRrvLdzBoU9IszG2Dd8tTJgAbsAxwl8/FT+r9DvOqSdq3vMFxdRkkYO3Do8GkYIrjiNu1xAMwQYbNNkeOKQxzYCV4XNg9vO9VHByH1n0JmRtAHvD4HCEfWIky5V81WuePg8WJxEfh34bpsUV1U/v8eP/A3Wi3htbua3sROKQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61397+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1592384655548267.43722238103544; Wed, 17 Jun 2020 02:04:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id DD7WYY1788612xu9cryGsnnC; Wed, 17 Jun 2020 02:04:14 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.3399.1592384653638729055 for ; Wed, 17 Jun 2020 02:04:13 -0700 IronPort-SDR: oa5vh5+xD6mzr8kvwVLWZNN2dGp5l2MG5BZXaa7IXZQETqrnbaSqsiRdGeZ3VbbTFFaSkkW/QU yRR9tGeoTwug== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 02:04:13 -0700 IronPort-SDR: YcgwMFhIDzQIeTPE2x6NLDVah/EjfOtploYo43fpLdhzoLO1HHMPbTpAVYni/6TsurmbyEXns2 Wz+bnmlIylMQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,522,1583222400"; d="scan'208";a="476759060" X-Received: from ray-dev.ccr.corp.intel.com ([10.239.158.87]) by fmsmga006.fm.intel.com with ESMTP; 17 Jun 2020 02:04:11 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Ray Ni , Eric Dong , Amy Chan , Rangasai V Chaganty , Isaac W Oram Subject: [edk2-devel] [PATCH] Features/Intel/Readme.md: clarify feature package dependency rule Date: Wed, 17 Jun 2020 17:03:25 +0800 Message-Id: <20200617090326.1213-1-ray.ni@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com X-Gm-Message-State: 3Fpw9ndrj9z9wmY9jxugak2xx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1592384654; bh=CcULnjlIVJDrMNHBPdH/vB9+f5upvElNP8PewHBQ8eQ=; h=Cc:Date:From:Reply-To:Subject:To; b=utHWAS7iu/B8LaR+2vEfEo8e+kW6WcvZxIluFjiZgzg8+OtYRIXsNn70jAMmVtQ5MYS zx/brlSM/kjk1vAFCVSv1k1zMq5DQs8WPF7fDnkW0a2vlkXd4RQGSLEtxnseGceJnHFsc OWTxCwyl3YoLEmknStdGDqGMj4h5qAEKQC0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Ray Ni Original statement only says depending on another feature package is not allowed. It gives developers impression that board level packages are allowed to depend on. This patch clarifies the package dependency rule. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Amy Chan Cc: Rangasai V Chaganty Cc: Isaac W Oram Reviewed-by: Eric Dong --- Features/Intel/Readme.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Features/Intel/Readme.md b/Features/Intel/Readme.md index 9729f90a41..1a03a4c0d2 100644 --- a/Features/Intel/Readme.md +++ b/Features/Intel/Readme.md @@ -17,8 +17,10 @@ document as needed. ### Advanced Feature Attributes Advanced features should be: * _Cohesive_, the feature should not contain any functionality unrelated t= o the feature. -* _Complete_, the feature must have a complete design that minimizes depen= dencies. A feature package cannot directly - depend on another feature package. +* _Complete_, the feature must have a complete design that minimizes depen= dencies. A feature package can only depend + on following packages: + * edk2 repo: `MdePkg`, `MdeModulePkg`, `UefiCpuPkg`, `FmpDevicePkg`, `Se= curityPkg`, `NetworkPkg`, `ShellPkg`. + * edk2-platforms repo: `MinPlatformPkg`, `IntelSiliconPkg`. * _Easy to Integrate_, the feature should expose well-defined software int= erfaces to use and configure the feature. * It should also present a set of simple and well-documented standard ED= K II configuration options such as PCDs to configure the feature. --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61397): https://edk2.groups.io/g/devel/message/61397 Mute This Topic: https://groups.io/mt/74933867/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-