From nobody Sun Feb 8 12:38:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+61393+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61393+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1592383306; cv=none; d=zohomail.com; s=zohoarc; b=VNCG+JEGY642Qiy6nsFNIa8v5U28f3IC9c3dFZFJP5jMCEkrIaMKPaWLBBJvyDvEIcq6wTDf+fa9MOkW9iUj1B+j1+4JT9iItDRS+0+xly1fNN6dcyG+hU4Omc/FTMg+wqr28kKB2qkQ1JK6VlCGlP4dTWIMotr/xdsVLXJUTTI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592383306; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=nARgpm0RAzFaGrlWqv3JXNyJgMmNA01kD0oKwSspx4E=; b=DkfVRzbzPPmGzT3y+/wL/bs6m3f/g6uN3GrnUGk/IL/oxPAFw9mkiqLfbsYbrPtFDAWbMSbzStxTXElc3PPGsda8EBDv6hxuv23dM9Ur/B5d4mLlP8qJRDAnifMKAYm38SR7RK4L+DkOBdxMrDYGw+ZkFtkBPEdIUg5z+FVXPrE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61393+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1592383306708545.6918380675395; Wed, 17 Jun 2020 01:41:46 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dOQHYY1788612xwRZXWkThmH; Wed, 17 Jun 2020 01:41:46 -0700 X-Received: from mga17.intel.com (mga17.intel.com []) by mx.groups.io with SMTP id smtpd.web11.3224.1592383304997702094 for ; Wed, 17 Jun 2020 01:41:45 -0700 IronPort-SDR: o5fZTFdYTplXTzLd4+6t6Xd9+fI/TiBMMRh1LsM3L1qamCryHTcuBCrT/4aqffykYO5SWibZ4Y 2gJYL8VwcoaA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 01:41:45 -0700 IronPort-SDR: 0lU5e3ftVu9BN+IsMs1C1Lrg3/8YdQOJe55MwAkBHb0K8qXzqL5R7cEF2R+YcAJpkoZaGtfiIQ IFKymmBELufA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,522,1583222400"; d="scan'208";a="299219010" X-Received: from ray-dev.ccr.corp.intel.com ([10.239.158.87]) by fmsmga004.fm.intel.com with ESMTP; 17 Jun 2020 01:41:44 -0700 From: "Ni, Ray" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH V3 1/2] MdePkg/PciSegmentInfoLib: Add missing EFIAPI to GetPciSegmentInfo() Date: Wed, 17 Jun 2020 16:40:57 +0800 Message-Id: <20200617084058.196-2-ray.ni@intel.com> In-Reply-To: <20200617084058.196-1-ray.ni@intel.com> References: <20200617084058.196-1-ray.ni@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com X-Gm-Message-State: wz1HHo0uXwblxrZbsIVgwgBmx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1592383306; bh=4KBABAUUn08IKbYJFcQZ8lUsQ92rjeKQ6UOh3KO0VZw=; h=Cc:Date:From:Reply-To:Subject:To; b=P7ccCM1kqQ1CzEzrvIvdZnR5qYnciC6rMSZ3XrUrwlMNtv1PPhnedRP16D4YjbGYL7a MS8lfkxDD8GEp62NTN/vkSnzOhkksEiwiS4cRCV7zbvWAbZfgwUnWmrxukuk3pid7a8QG aE1O2cjXw1uCLvmkoFXWCSXqshaWmDp2Evg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" All public APIs should have EFIAPI modifier. Somehow PciSegmentInfoLib missed the EFIAPI modifier. The patch updates the library header file and NULL instance in MdePkg to add the missing EFIAPI. Signed-off-by: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Liming Gao --- MdePkg/Include/Library/PciSegmentInfoLib.h | 3 ++- MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/MdePkg/Include/Library/PciSegmentInfoLib.h b/MdePkg/Include/Li= brary/PciSegmentInfoLib.h index 320a223628..659ff85649 100644 --- a/MdePkg/Include/Library/PciSegmentInfoLib.h +++ b/MdePkg/Include/Library/PciSegmentInfoLib.h @@ -3,7 +3,7 @@ =20 This library is consumed by PciSegmentLib to support multiple segment PC= I configuration access. =20 - Copyright (c) 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -28,6 +28,7 @@ typedef struct { @retval A callee owned array holding the segment information. **/ PCI_SEGMENT_INFO * +EFIAPI GetPciSegmentInfo ( UINTN *Count ); diff --git a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c b= /MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c index f9019c4e64..3ec7784057 100644 --- a/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c +++ b/MdePkg/Library/BasePciSegmentInfoLibNull/PciSegmentInfoLib.c @@ -2,7 +2,7 @@ Default PCI Segment Information Library that returns one segment whose segment base address equals to PcdPciExpressBaseAddress. =20 - Copyright (c) 2017, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -21,6 +21,7 @@ @retval A callee owned array holding the segment information. **/ PCI_SEGMENT_INFO * +EFIAPI GetPciSegmentInfo ( UINTN *Count ) --=20 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61393): https://edk2.groups.io/g/devel/message/61393 Mute This Topic: https://groups.io/mt/74933721/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-