From nobody Thu Apr 25 01:44:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+61353+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61353+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1592335777; cv=none; d=zohomail.com; s=zohoarc; b=nDEZupqD5hrXm8JLKJAQe5e5Zk2IbWugGqSHQxeWVdfZEuZbEHz1bfnNzfFrKY0obAW79tBquKihfVkgY205ES2VEoj/6ZoeDZxeL91Y6cdklL7Iw0jHInVMMSXgA28PYl06OkKKXouMg5MAHNoHRLoQa9qULveEhZBCWNbbKJA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592335777; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=nEbF7XD7zT+lqFiRn1bJzYFjVVFIU8ge8CHsICSf+C0=; b=MNPYoGpvmlnEmHlqklK/7oIXGL/3VK+38lsvX8EORue7wY3ewPvbgfMb3xd8+5AyNozEnRSuR1HT8cs5jd9QJ22uAVCIb6L9wXYgna9Bg1cmzxGjfHyoal0zijH6xBURZ7DEgXzdqXwGX+4X1NIKMcoca32tAN8w/WW8tVIlRZg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+61353+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1592335777937661.691177104799; Tue, 16 Jun 2020 12:29:37 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id zbUTYY1788612xtcbfVghEeI; Tue, 16 Jun 2020 12:29:37 -0700 X-Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by mx.groups.io with SMTP id smtpd.web10.869.1592335776364786416 for ; Tue, 16 Jun 2020 12:29:36 -0700 X-Received: by mail-pg1-f193.google.com with SMTP id e9so808pgo.9 for ; Tue, 16 Jun 2020 12:29:36 -0700 (PDT) X-Gm-Message-State: ZAuM5dMLunrUmwosLVfaBgXMx1787277AA= X-Google-Smtp-Source: ABdhPJyfDHGpApL0rUANmiKKgDwsHZ0H1pczoLP6ErGr5WiCSYx6/LzcaOpdUkm/Ez7FaSnbVn6/FA== X-Received: by 2002:a63:6dc2:: with SMTP id i185mr3185533pgc.250.1592335775816; Tue, 16 Jun 2020 12:29:35 -0700 (PDT) X-Received: from bean-canyon.localdomain ([106.200.227.148]) by smtp.googlemail.com with ESMTPSA id b29sm18226932pfr.159.2020.06.16.12.29.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 12:29:35 -0700 (PDT) From: "Tanmay Jagdale" To: leif@nuviainc.com, ard.biesheuvel@arm.com, graeme.gregory@linaro.org, devel@edk2.groups.io Cc: rad@semihalf.com, Tanmay Jagdale Subject: [edk2-devel] Silicon/SbsaQemu: Fix NOR flash RegionBaseAddress Date: Wed, 17 Jun 2020 00:59:13 +0530 Message-Id: <20200616192913.56882-1-tanmay.jagdale@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,tanmay.jagdale@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1592335777; bh=l5bTbi4GpIOuNK6Zr9M7wDr/FkX7LXsemmoXgVJ7UHI=; h=Cc:Date:From:Reply-To:Subject:To; b=DbHYjWhf3MAMZcmQbIs4kZudcAkb4URcveuC1SNZUk1Dx7qsnCvqbwXGO54Sboc3gZF P92qTMGijj0GCNaMLul8M3eEDCR2mNRp4aaJJKoVMo6ev8zUF+OsB8poWtfmQGwMpfgBz W9nrxGDIMNBmnVKO2u3GtsWGoSYR1/Ltu9U= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The EFI_FIMRWARE_VOLUME_HEADER is present at an offset in the NOR flash of Sbsa QEMU model. Use the right RegionBaseAddress so that the EFI firmware volume header can be found correctly. Signed-off-by: Tanmay Jagdale Tested-by: Graeme Gregory --- .../SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.c | 2 +- .../Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib.inf | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorF= lashLib.c b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFl= ashLib.c index e7bb626596..0946327cb5 100644 --- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .c +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .c @@ -23,7 +23,7 @@ NorFlashPlatformInitialization ( NOR_FLASH_DESCRIPTION mNorFlashDevice =3D { FixedPcdGet64(PcdFdBaseAddress), - FixedPcdGet64(PcdFdBaseAddress), + FixedPcdGet64(PcdFlashNvStorageVariableBase), FixedPcdGet32(PcdFdSize), QEMU_NOR_BLOCK_SIZE }; diff --git a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorF= lashLib.inf b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNor= FlashLib.inf index 82712c8901..f2ba41e1df 100644 --- a/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .inf +++ b/Silicon/Qemu/SbsaQemu/Library/SbsaQemuNorFlashLib/SbsaQemuNorFlashLib= .inf @@ -23,7 +23,9 @@ ArmPlatformPkg/ArmPlatformPkg.dec ArmPkg/ArmPkg.dec MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec =20 [FixedPcd] gArmTokenSpaceGuid.PcdFdBaseAddress gArmTokenSpaceGuid.PcdFdSize + gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableBase --=20 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61353): https://edk2.groups.io/g/devel/message/61353 Mute This Topic: https://groups.io/mt/74923728/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-