From nobody Tue May 7 22:58:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+60999+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60999+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1591749066; cv=none; d=zohomail.com; s=zohoarc; b=OBuSEMx7gpeuqmwewuFrryekp55ga4joM9CaX0fc1BVLtXqbpPp7Z4kx1MKWLugvyYmMlg0+HdU/rGyLw8j1jdO8bVnBMuDY+3MUkXDC5GLkjNX5ycqE1DGLi/+3t1DA+LVQpL5mStOAGSmQrSzVNM5uXqUHAcaqAeb2kLHT2fk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591749066; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=zKFyjstdSpEL9vlRcOflCMbI7u+Dur5GwCZPnf3qacA=; b=T8sW+nnxR1wHlb6j1E2jA0NxZLw8WWYBR7NMIiD7pu/5XTneZBLGHqUJKBXo0hjFWzQnsg37mEQQvzuVNs8CPOu3buHe48tx19bMNhpDdd4okcePs8dO5ZYkTioYYouN8qq5dqC6WsLnoeNUydyowPZP/TW794s23aVSJhqCSzQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60999+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1591749066007373.4639017737885; Tue, 9 Jun 2020 17:31:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id UiAEYY1788612xNjSquiT6zb; Tue, 09 Jun 2020 17:31:05 -0700 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.611.1591749064052388976 for ; Tue, 09 Jun 2020 17:31:04 -0700 IronPort-SDR: yrulpP+VMfka2OTNu4SWHW/ktVng6+1QN1Ksl6ND7pRZq1adWIac1inaSIGanmeLEsxw8uh2Cb RgjIa4cUslcQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 17:31:03 -0700 IronPort-SDR: TVb6e/ypZcbjM+6eYejExr7Dqeh41VekeQeI4lKtBEeKlx3anABkMNjQ5lXY7b1HZdAs2c2RgO DeDJM1YAHpVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,493,1583222400"; d="scan'208";a="379906095" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.255.74.121]) by fmsmga001.fm.intel.com with ESMTP; 09 Jun 2020 17:31:02 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Chasel Chiu , Sai Chaganty Subject: [edk2-devel] [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic bug Date: Tue, 9 Jun 2020 17:30:53 -0700 Message-Id: <20200610003053.3195-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: qVViQjcfgFpmryVwuGHdCY72x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1591749065; bh=xbjk4n7Dy3BcABX3E0jVlXpSwYPOneKFqjJrXwKZXms=; h=Cc:Date:From:Reply-To:Subject:To; b=xONeRPRqCjKPQaNVu8gGMaLyBLnsUQNHXvnGab3jn+T7bT28S/pryQe47KVzu5WI3/V Xio93tHcHKd6gyg18w6J0anErPjiYelQ9FaPvk8AQZLtIaIra42R42xy1RwUJ4m5R1l3/ SUCuKKbfKIyr6b5uC/ro7iNBXyge1CIYgqE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" (Cpptv & B_PCH_SPI_SFDPX_VSCCX_CPPTV) can only evaluate to two possible values, 0x0 or B_PCH_SPI_SFDPX_VSCCX_CPPTV (aka BIT31). The current comparison to 0x1 will always fail. Fixed the if statement to compare to B_PCH_SPI_SFDPX_VSCCX_CPPTV. Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Sai Chaganty Reviewed-by: Chasel Chiu Reviewed-by: Sai Chaganty --- .../KabylakeSiliconPkg/Hsti/Dxe/BootFirmwareMediaProtection.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/BootFirmwareMediaPro= tection.c b/Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/BootFirmwareMediaProt= ection.c index a255e7e514..467e133cd5 100644 --- a/Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/BootFirmwareMediaProtection= .c +++ b/Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/BootFirmwareMediaProtection= .c @@ -167,7 +167,7 @@ CheckBootFirmwareMediaProtection ( FreePool (HstiErrorString); } } else { - if ((Cpptv & B_PCH_SPI_SFDPX_VSCCX_CPPTV) =3D=3D 1) { + if ((Cpptv & B_PCH_SPI_SFDPX_VSCCX_CPPTV) =3D=3D B_PCH_SPI_SFDPX_VSCCX= _CPPTV) { =20 HstiErrorString =3D BuildHstiErrorString (HSTI_BYTE0_BOOT_FIRMWARE_M= EDIA_PROTECTION_ERROR_CODE_6 ,HSTI_SPI_FLASH_CONFIGURATION, HSTI_BYTE0_BOOT= _FIRMWARE_MEDIA_PROTECTION_ERROR_STRING_6); Status =3D HstiLibAppendErrorString ( --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60999): https://edk2.groups.io/g/devel/message/60999 Mute This Topic: https://groups.io/mt/74787555/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-