[edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers

Laszlo Ersek posted 3 patches 3 years, 9 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200603160627.3594-1-lersek@redhat.com
Maintainers.txt | 54 ++++++++++----------
1 file changed, 27 insertions(+), 27 deletions(-)
[edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers
Posted by Laszlo Ersek 3 years, 9 months ago
Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2778
Repo:   https://pagure.io/lersek/edk2.git
Branch: sort_maintainers

We originally meant to keep the subsystem (package) titles sorted, in
"Maintainers.txt".

However, as of 7191dd3c5990 ("ArmPkg/PlatformBootManagerLib: reject
'default' parity and stop bit count", 2020-06-03), we have some disorder
introduced.

This patch series restores lexicographical order between the subsystem
(package) headers.

The package / subsystem headers can be collected with the following
small script:

$ dos2unix < Maintainers.txt \
  | sed -n -e '/^EDK II Packages:$/,$p' \
  | tail -n +3 \
  | grep -E -v '^($|[LMRWTSFX]:)'

Where

- "dos2unix" strips CRs,

- "sed" removes the first part of the file that precedes the "EDK II
  Packages:" heading,

- "tail" removes that heading plus the underline on the next line,

- and "grep" removes the empty lines and the section entries.

What remains is the section headers.

Here's a comparison between the outputs of this script, before (that is,
at commit 7191dd3c5990) and after the series is applied:

> @@ -1,42 +1,42 @@
>  ArmPkg
>  ArmPlatformPkg
>  ArmVirtPkg
>  ArmVirtPkg: modules used on Xen
>  BaseTools
>  CryptoPkg
>  DynamicTablesPkg
>  EmbeddedPkg
>  EmulatorPkg
>  FatPkg
>  FmpDevicePkg
>  IntelFsp2Pkg
>  IntelFsp2WrapperPkg
>  MdeModulePkg
>  MdeModulePkg: ACPI modules
> -MdeModulePkg: ACPI S3 modules
> +MdeModulePkg: ACPI modules related to S3
>  MdeModulePkg: BDS modules
>  MdeModulePkg: Console and Graphics modules
>  MdeModulePkg: Core services (PEI, DXE and Runtime) modules
>  MdeModulePkg: Device and Peripheral modules
>  MdeModulePkg: Firmware Update modules
>  MdeModulePkg: HII and UI modules
>  MdeModulePkg: Management Mode (MM, SMM) modules
>  MdeModulePkg: Reset modules
>  MdeModulePkg: SMBIOS modules
>  MdeModulePkg: UEFI Variable modules
>  MdePkg
>  NetworkPkg
>  OvmfPkg
> -OvmfPkg: Xen-related modules
> -OvmfPkg: TCG- and TPM2-related modules
>  OvmfPkg: CSM modules
>  OvmfPkg: MptScsi and PVSCSI driver
> +OvmfPkg: TCG- and TPM2-related modules
> +OvmfPkg: Xen-related modules
>  PcAtChipsetPkg
>  SecurityPkg
>  ShellPkg
>  SignedCapsulePkg
>  SourceLevelDebugPkg
> +StandaloneMmPkg
>  UefiCpuPkg
>  UefiPayloadPkg
>  UnitTestFrameworkPkg
> -StandaloneMmPkg

Cc: Andrew Fish <afish@apple.com>
Cc: Anthony Perard <anthony.perard@citrix.com>
Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Julien Grall <julien@xen.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Cc: Liran Alon <liran.alon@oracle.com>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Cc: Stefan Berger <stefanb@linux.ibm.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>

Thanks,
Laszlo

Laszlo Ersek (3):
  Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"
  Maintainers.txt: restore order of OvmfPkg sections
  Maintainers.txt: move StandaloneMmPkg to the right spot

 Maintainers.txt | 54 ++++++++++----------
 1 file changed, 27 insertions(+), 27 deletions(-)

-- 
2.19.1.3.g30247aa5d201


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60681): https://edk2.groups.io/g/devel/message/60681
Mute This Topic: https://groups.io/mt/74652695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers
Posted by Philippe Mathieu-Daudé 3 years, 9 months ago
On 6/3/20 6:06 PM, Laszlo Ersek wrote:
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2778
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: sort_maintainers
> 
> We originally meant to keep the subsystem (package) titles sorted, in
> "Maintainers.txt".
> 
> However, as of 7191dd3c5990 ("ArmPkg/PlatformBootManagerLib: reject
> 'default' parity and stop bit count", 2020-06-03), we have some disorder
> introduced.
> 
> This patch series restores lexicographical order between the subsystem
> (package) headers.
> 
> The package / subsystem headers can be collected with the following
> small script:
> 
> $ dos2unix < Maintainers.txt \
>   | sed -n -e '/^EDK II Packages:$/,$p' \
>   | tail -n +3 \
>   | grep -E -v '^($|[LMRWTSFX]:)'
> 
> Where
> 
> - "dos2unix" strips CRs,
> 
> - "sed" removes the first part of the file that precedes the "EDK II
>   Packages:" heading,
> 
> - "tail" removes that heading plus the underline on the next line,
> 
> - and "grep" removes the empty lines and the section entries.
> 
> What remains is the section headers.
> 
> Here's a comparison between the outputs of this script, before (that is,
> at commit 7191dd3c5990) and after the series is applied:
> 
>> @@ -1,42 +1,42 @@
>>  ArmPkg
>>  ArmPlatformPkg
>>  ArmVirtPkg
>>  ArmVirtPkg: modules used on Xen
>>  BaseTools
>>  CryptoPkg
>>  DynamicTablesPkg
>>  EmbeddedPkg
>>  EmulatorPkg
>>  FatPkg
>>  FmpDevicePkg
>>  IntelFsp2Pkg
>>  IntelFsp2WrapperPkg
>>  MdeModulePkg
>>  MdeModulePkg: ACPI modules
>> -MdeModulePkg: ACPI S3 modules
>> +MdeModulePkg: ACPI modules related to S3
>>  MdeModulePkg: BDS modules
>>  MdeModulePkg: Console and Graphics modules
>>  MdeModulePkg: Core services (PEI, DXE and Runtime) modules
>>  MdeModulePkg: Device and Peripheral modules
>>  MdeModulePkg: Firmware Update modules
>>  MdeModulePkg: HII and UI modules
>>  MdeModulePkg: Management Mode (MM, SMM) modules
>>  MdeModulePkg: Reset modules
>>  MdeModulePkg: SMBIOS modules
>>  MdeModulePkg: UEFI Variable modules
>>  MdePkg
>>  NetworkPkg
>>  OvmfPkg
>> -OvmfPkg: Xen-related modules
>> -OvmfPkg: TCG- and TPM2-related modules
>>  OvmfPkg: CSM modules
>>  OvmfPkg: MptScsi and PVSCSI driver
>> +OvmfPkg: TCG- and TPM2-related modules
>> +OvmfPkg: Xen-related modules
>>  PcAtChipsetPkg
>>  SecurityPkg
>>  ShellPkg
>>  SignedCapsulePkg
>>  SourceLevelDebugPkg
>> +StandaloneMmPkg
>>  UefiCpuPkg
>>  UefiPayloadPkg
>>  UnitTestFrameworkPkg
>> -StandaloneMmPkg
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (3):
>   Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"
>   Maintainers.txt: restore order of OvmfPkg sections
>   Maintainers.txt: move StandaloneMmPkg to the right spot
> 
>  Maintainers.txt | 54 ++++++++++----------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 

FWIW series:
Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60686): https://edk2.groups.io/g/devel/message/60686
Mute This Topic: https://groups.io/mt/74652695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers
Posted by Leif Lindholm 3 years, 9 months ago
For the series:
Reviewed-by: Leif Lindholm <leif@nuviainc.com>

Thanks!

On Wed, Jun 03, 2020 at 18:06:24 +0200, Laszlo Ersek wrote:
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2778
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: sort_maintainers
> 
> We originally meant to keep the subsystem (package) titles sorted, in
> "Maintainers.txt".
> 
> However, as of 7191dd3c5990 ("ArmPkg/PlatformBootManagerLib: reject
> 'default' parity and stop bit count", 2020-06-03), we have some disorder
> introduced.
> 
> This patch series restores lexicographical order between the subsystem
> (package) headers.
> 
> The package / subsystem headers can be collected with the following
> small script:
> 
> $ dos2unix < Maintainers.txt \
>   | sed -n -e '/^EDK II Packages:$/,$p' \
>   | tail -n +3 \
>   | grep -E -v '^($|[LMRWTSFX]:)'
> 
> Where
> 
> - "dos2unix" strips CRs,
> 
> - "sed" removes the first part of the file that precedes the "EDK II
>   Packages:" heading,
> 
> - "tail" removes that heading plus the underline on the next line,
> 
> - and "grep" removes the empty lines and the section entries.
> 
> What remains is the section headers.
> 
> Here's a comparison between the outputs of this script, before (that is,
> at commit 7191dd3c5990) and after the series is applied:
> 
> > @@ -1,42 +1,42 @@
> >  ArmPkg
> >  ArmPlatformPkg
> >  ArmVirtPkg
> >  ArmVirtPkg: modules used on Xen
> >  BaseTools
> >  CryptoPkg
> >  DynamicTablesPkg
> >  EmbeddedPkg
> >  EmulatorPkg
> >  FatPkg
> >  FmpDevicePkg
> >  IntelFsp2Pkg
> >  IntelFsp2WrapperPkg
> >  MdeModulePkg
> >  MdeModulePkg: ACPI modules
> > -MdeModulePkg: ACPI S3 modules
> > +MdeModulePkg: ACPI modules related to S3
> >  MdeModulePkg: BDS modules
> >  MdeModulePkg: Console and Graphics modules
> >  MdeModulePkg: Core services (PEI, DXE and Runtime) modules
> >  MdeModulePkg: Device and Peripheral modules
> >  MdeModulePkg: Firmware Update modules
> >  MdeModulePkg: HII and UI modules
> >  MdeModulePkg: Management Mode (MM, SMM) modules
> >  MdeModulePkg: Reset modules
> >  MdeModulePkg: SMBIOS modules
> >  MdeModulePkg: UEFI Variable modules
> >  MdePkg
> >  NetworkPkg
> >  OvmfPkg
> > -OvmfPkg: Xen-related modules
> > -OvmfPkg: TCG- and TPM2-related modules
> >  OvmfPkg: CSM modules
> >  OvmfPkg: MptScsi and PVSCSI driver
> > +OvmfPkg: TCG- and TPM2-related modules
> > +OvmfPkg: Xen-related modules
> >  PcAtChipsetPkg
> >  SecurityPkg
> >  ShellPkg
> >  SignedCapsulePkg
> >  SourceLevelDebugPkg
> > +StandaloneMmPkg
> >  UefiCpuPkg
> >  UefiPayloadPkg
> >  UnitTestFrameworkPkg
> > -StandaloneMmPkg
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (3):
>   Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"
>   Maintainers.txt: restore order of OvmfPkg sections
>   Maintainers.txt: move StandaloneMmPkg to the right spot
> 
>  Maintainers.txt | 54 ++++++++++----------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 
> -- 
> 2.19.1.3.g30247aa5d201
> 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60687): https://edk2.groups.io/g/devel/message/60687
Mute This Topic: https://groups.io/mt/74652695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers
Posted by Laszlo Ersek 3 years, 9 months ago
On 06/03/20 18:06, Laszlo Ersek wrote:
> Ref:    https://bugzilla.tianocore.org/show_bug.cgi?id=2778
> Repo:   https://pagure.io/lersek/edk2.git
> Branch: sort_maintainers
> 
> We originally meant to keep the subsystem (package) titles sorted, in
> "Maintainers.txt".
> 
> However, as of 7191dd3c5990 ("ArmPkg/PlatformBootManagerLib: reject
> 'default' parity and stop bit count", 2020-06-03), we have some disorder
> introduced.
> 
> This patch series restores lexicographical order between the subsystem
> (package) headers.
> 
> The package / subsystem headers can be collected with the following
> small script:
> 
> $ dos2unix < Maintainers.txt \
>   | sed -n -e '/^EDK II Packages:$/,$p' \
>   | tail -n +3 \
>   | grep -E -v '^($|[LMRWTSFX]:)'
> 
> Where
> 
> - "dos2unix" strips CRs,
> 
> - "sed" removes the first part of the file that precedes the "EDK II
>   Packages:" heading,
> 
> - "tail" removes that heading plus the underline on the next line,
> 
> - and "grep" removes the empty lines and the section entries.
> 
> What remains is the section headers.
> 
> Here's a comparison between the outputs of this script, before (that is,
> at commit 7191dd3c5990) and after the series is applied:
> 
>> @@ -1,42 +1,42 @@
>>  ArmPkg
>>  ArmPlatformPkg
>>  ArmVirtPkg
>>  ArmVirtPkg: modules used on Xen
>>  BaseTools
>>  CryptoPkg
>>  DynamicTablesPkg
>>  EmbeddedPkg
>>  EmulatorPkg
>>  FatPkg
>>  FmpDevicePkg
>>  IntelFsp2Pkg
>>  IntelFsp2WrapperPkg
>>  MdeModulePkg
>>  MdeModulePkg: ACPI modules
>> -MdeModulePkg: ACPI S3 modules
>> +MdeModulePkg: ACPI modules related to S3
>>  MdeModulePkg: BDS modules
>>  MdeModulePkg: Console and Graphics modules
>>  MdeModulePkg: Core services (PEI, DXE and Runtime) modules
>>  MdeModulePkg: Device and Peripheral modules
>>  MdeModulePkg: Firmware Update modules
>>  MdeModulePkg: HII and UI modules
>>  MdeModulePkg: Management Mode (MM, SMM) modules
>>  MdeModulePkg: Reset modules
>>  MdeModulePkg: SMBIOS modules
>>  MdeModulePkg: UEFI Variable modules
>>  MdePkg
>>  NetworkPkg
>>  OvmfPkg
>> -OvmfPkg: Xen-related modules
>> -OvmfPkg: TCG- and TPM2-related modules
>>  OvmfPkg: CSM modules
>>  OvmfPkg: MptScsi and PVSCSI driver
>> +OvmfPkg: TCG- and TPM2-related modules
>> +OvmfPkg: Xen-related modules
>>  PcAtChipsetPkg
>>  SecurityPkg
>>  ShellPkg
>>  SignedCapsulePkg
>>  SourceLevelDebugPkg
>> +StandaloneMmPkg
>>  UefiCpuPkg
>>  UefiPayloadPkg
>>  UnitTestFrameworkPkg
>> -StandaloneMmPkg
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien@xen.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Liran Alon <liran.alon@oracle.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Cc: Nikita Leshenko <nikita.leshchenko@oracle.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
> 
> Thanks,
> Laszlo
> 
> Laszlo Ersek (3):
>   Maintainers.txt: retitle "MdeModulePkg: ACPI S3 modules"
>   Maintainers.txt: restore order of OvmfPkg sections
>   Maintainers.txt: move StandaloneMmPkg to the right spot
> 
>  Maintainers.txt | 54 ++++++++++----------
>  1 file changed, 27 insertions(+), 27 deletions(-)
> 

Merged as commit range 6ff7c838d092..6aa48ab791ec, via
<https://github.com/tianocore/edk2/pull/669>.

Thanks
Laszlo


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#60980): https://edk2.groups.io/g/devel/message/60980
Mute This Topic: https://groups.io/mt/74652695/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-