From nobody Mon Feb 9 23:16:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+60390+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60390+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1590657483; cv=none; d=zohomail.com; s=zohoarc; b=XnU90PrkXQeVx+MI3O9UT4kpdFmBq0lP1rGCx1NQ1/M8bvKkbJJ3NZFO5selVa/m8rxgdQJ0pyYKz6zFYJKL/eUiCoWwDi1bOgCybfzXD2b3K+CS5Z5jZjYxVw6DFb0kRZjz/A4Rp+Bv8loqJGAPU6DvOHI1NSytGI29oWQ2CYU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590657483; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=8EEQvsOi6eY1DCJ2325+Rzm8bSg5USeaLgA2+A6A7XM=; b=h2sANzQoah5DL8qhW4WSZwu/QXKQfG/4thVFIinM9HEGkEYUgrmaNsiQVoQLBCasixwgDUAZ4FmDy5mpE+dkfXp0/jYRZgCYLrXrUA2hhamuz4Q/Kg1wAdBRXpMeY2/04oV5WZILm/98jjTlIshysl4TyIjhym+RTv2rtURVNrE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+60390+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 159065748346460.74719372784887; Thu, 28 May 2020 02:18:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id kPHXYY1788612xOr8xBWMtKp; Thu, 28 May 2020 02:18:03 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.8400.1590657482609298337 for ; Thu, 28 May 2020 02:18:02 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3499FD6E; Thu, 28 May 2020 02:18:02 -0700 (PDT) X-Received: from e123331-lin.nice.arm.com (unknown [10.37.8.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5779B3F6C4; Thu, 28 May 2020 02:18:00 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: jon@solid-run.com, Ard Biesheuvel , Laszlo Ersek , Leif Lindholm , Ray Ni , Zhichao Gao Subject: [edk2-devel] [PATCH v2 3/5] MdeModulePkg/BootManagerUiLib: show inactive boot options Date: Thu, 28 May 2020 11:17:39 +0200 Message-Id: <20200528091741.14610-4-ard.biesheuvel@arm.com> In-Reply-To: <20200528091741.14610-1-ard.biesheuvel@arm.com> References: <20200528091741.14610-1-ard.biesheuvel@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@arm.com X-Gm-Message-State: Waih7yGc1gFKYTQ3qOskjWPSx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1590657483; bh=Rq/i0WnkhH7RoZac49TdvoCHTcwowkLa9TFUidOTlF0=; h=Cc:Date:From:Reply-To:Subject:To; b=q35yb7jFtV7siu7nkjE/nw+W0wS7YzPDlr5Z4QLfwAKb7kYyYTKey0IFxUFAKlgLDR5 TYMPjdqhTIL/XYz8Hk3OOO9W0E/eQtVLhMKETZG3t8kLyWcd+hFqYc18SCPmMP/B1GT3V Px/unbfEvrd/IK/sXpn4m1S+KGwySwKSi14= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" UEFI boot options may exist but have the LOAD_OPTION_ACTIVE flag cleared. This means that the boot option should not be selected by default, but it does not mean it should be omitted from the boot selection presented by the boot manager: for this purpose, another flag LOAD_OPTION_HIDDEN exists. Given that the latter flag exists solely for the purpose of omitting boot options from the boot selection menu, and LOAD_OPTION_XXX flags can be combined if desired, hiding inactive boot options as well is a mistake, and violates the intent of paragraph 3.1.3 of the UEFI specification (revision 2.8 errata A). Let's fix this by dropping the LOAD_OPTION_ACTIVE check from the code that populates the boot selection menu. Signed-off-by: Ard Biesheuvel Acked-by: Leif Lindholm Reviewed-by: Laszlo Ersek Reviewed-by: Zhichao Gao --- MdeModulePkg/Library/BootManagerUiLib/BootManager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Library/BootManagerUiLib/BootManager.c b/MdeModul= ePkg/Library/BootManagerUiLib/BootManager.c index 13b40e11b396..4b2c4c77a124 100644 --- a/MdeModulePkg/Library/BootManagerUiLib/BootManager.c +++ b/MdeModulePkg/Library/BootManagerUiLib/BootManager.c @@ -535,9 +535,9 @@ UpdateBootManager ( mKeyInput++; =20 // - // Don't display the hidden/inactive boot option + // Don't display hidden boot options, but retain inactive ones. // - if (((BootOption[Index].Attributes & LOAD_OPTION_HIDDEN) !=3D 0) || ((= BootOption[Index].Attributes & LOAD_OPTION_ACTIVE) =3D=3D 0)) { + if ((BootOption[Index].Attributes & LOAD_OPTION_HIDDEN) !=3D 0) { continue; } =20 --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60390): https://edk2.groups.io/g/devel/message/60390 Mute This Topic: https://groups.io/mt/74518313/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-