[edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

Nate DeSimone posted 5 patches 7 weeks ago

[edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

Posted by Nate DeSimone 7 weeks ago
"implemenations" should be "implementations"

Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
index 8283483ff8..5607997f4e 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
+++ b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
@@ -1,14 +1,11 @@
 /** @file
 
-  Copyright (c) 2004  - 2014, Intel Corporation. All rights reserved.<BR>
-                                                                                   

-  SPDX-License-Identifier: BSD-2-Clause-Patent
+  Copyright (c) 2004  - 2020, Intel Corporation. All rights reserved.<BR>
 
-                                                                                   

+  SPDX-License-Identifier: BSD-2-Clause-Patent
 
 Module Name:
 
-
   MonoStatusCode.c
 
 Abstract:
@@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR  mPpiListStatusCode = {
 };
 
 //
-// Function implemenations
+// Function implementations
 //
 
 /**
-- 
2.26.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59781): https://edk2.groups.io/g/devel/message/59781
Mute This Topic: https://groups.io/mt/74319999/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

Posted by Guomin Jiang 7 weeks ago
Add comment inline

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix
> spelling errors
> 
> "implemenations" should be "implementations"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> index 8283483ff8..5607997f4e 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> @@ -1,14 +1,11 @@
>  /** @file
> 
> -  Copyright (c) 2004  - 2014, Intel Corporation. All rights reserved.<BR>
> -
> 
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> +  Copyright (c) 2004  - 2020, Intel Corporation. All rights
> + reserved.<BR>
> 
> -
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  Module Name:
> 
> -
>    MonoStatusCode.c

I think that there are too many empty line between the Module Name: with MonoStatusCode.c

I suggest use format as below:
Module Name: MonoStatusCode.c
Or 
Module Name:

MonoStatusCode.c

Others change is good to me.

Reviewed-by: Guomin Jiang <guomin.jiang@intel.com>

> 
>  Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR  mPpiListStatusCode = {  };
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
> --
> 2.26.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59901): https://edk2.groups.io/g/devel/message/59901
Mute This Topic: https://groups.io/mt/74319999/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

Posted by Michael D Kinney 7 weeks ago
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On
> Behalf Of Nate DeSimone
> Sent: Monday, May 18, 2020 11:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5]
> Vlv2TbltDevicePkg: Fix spelling errors
> 
> "implemenations" should be "implementations"
> 
> Signed-off-by: Nate DeSimone
> <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> index 8283483ff8..5607997f4e 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoS
> tatusCode.c
> @@ -1,14 +1,11 @@
>  /** @file
> 
> -  Copyright (c) 2004  - 2014, Intel Corporation. All
> rights reserved.<BR>
> -
> 
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> +  Copyright (c) 2004  - 2020, Intel Corporation. All
> rights reserved.<BR>
> 
> -
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  Module Name:
> 
> -
>    MonoStatusCode.c
> 
>  Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR
> mPpiListStatusCode = {
>  };
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
> --
> 2.26.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59837): https://edk2.groups.io/g/devel/message/59837
Mute This Topic: https://groups.io/mt/74319999/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix spelling errors

Posted by Chiu, Chasel 7 weeks ago
Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Tuesday, May 19, 2020 2:18 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH 2/5] Vlv2TbltDevicePkg: Fix
> spelling errors
> 
> "implemenations" should be "implementations"
> 
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c    | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> index 8283483ff8..5607997f4e 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/MonoStatusCode/MonoStatusCode.c
> @@ -1,14 +1,11 @@
>  /** @file
> 
> -  Copyright (c) 2004  - 2014, Intel Corporation. All rights reserved.<BR>
> -
> 
> -  SPDX-License-Identifier: BSD-2-Clause-Patent
> +  Copyright (c) 2004  - 2020, Intel Corporation. All rights
> + reserved.<BR>
> 
> -
> 
> +  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  Module Name:
> 
> -
>    MonoStatusCode.c
> 
>  Abstract:
> @@ -35,7 +32,7 @@ EFI_PEI_PPI_DESCRIPTOR  mPpiListStatusCode = {  };
> 
>  //
> -// Function implemenations
> +// Function implementations
>  //
> 
>  /**
> --
> 2.26.0.windows.1
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59792): https://edk2.groups.io/g/devel/message/59792
Mute This Topic: https://groups.io/mt/74319999/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-