From nobody Sun May 5 02:02:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+59212+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59212+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1589233881; cv=none; d=zohomail.com; s=zohoarc; b=FrO4y49/jk15bs2tu1N77n09mxOhUliEb5ymW3kwrZs7f/EE8CyCvJiFsB6AaJ4GDw83pPD+4VXY0Q3OZk8FP/yT28FrDnIPXPeyWZU6frNAf8a9PJbMMKL0GfH7VCKLbvwgNMaEuJrCEiZ4Bm4uS8zxWHhfRDXjiLFoCkPg2yE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589233881; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=y6mCKTVqIpjncHIjGA1aBh2iEW170iT7blmx97VSOPA=; b=VmUQq/AJfSKWhOx1IGetPWwm7byf1JGFyZ2rozrtRi3DGD019UBCOgFv2G7FkSnZ/opquOSJuGGGrcAfeMtfaa6TkGV6+0jOzHDKJsfwqsddTuN6d1UfKV/cKDJiDXKJIsWW9Q3SBjgWosslS+9CC5Upl/zK2mGvIuGiG5S0oeU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59212+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1589233881326266.5904201484493; Mon, 11 May 2020 14:51:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0ZuiYY1788612xyyfYxj7eMb; Mon, 11 May 2020 14:51:21 -0700 X-Received: from atlmailgw1.ami.com (atlmailgw1.ami.com [63.147.10.40]) by mx.groups.io with SMTP id smtpd.web12.2744.1589233880372180480 for ; Mon, 11 May 2020 14:51:20 -0700 X-AuditID: ac1060b2-0f7ff700000018d4-53-5eb9c8d7e9c0 X-Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id 4A.61.06356.7D8C9BE5; Mon, 11 May 2020 17:51:19 -0400 (EDT) X-Received: from Oleksiy77.us.megatrends.com (172.16.97.158) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.468.0; Mon, 11 May 2020 17:50:42 -0400 From: "Oleksiy Yakovlev" To: CC: , , , , , Subject: [edk2-devel] [PATCH V3 1/5] MdePkg: Add new CPER Notification types Date: Mon, 11 May 2020 17:50:36 -0400 Message-ID: <20200511215040.31780-2-oleksiyy@ami.com> In-Reply-To: <20200511215040.31780-1-oleksiyy@ami.com> References: <20200511215040.31780-1-oleksiyy@ami.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRiBhgu71EzvjDJ5MkbNonzCbzeLqrV9M FvO+zWC1WHFvA7tFR8c/JgdWj+3fLzB6LN7zkimAKaqB0SYxLy+/JLEkVSEltTjZVimgKLMs MblSSSEzxVbJUEmhICcxOTU3Na/EVimxoCA1L0XJjksBA9gAlWXmKaTmJeenZOal2yp5Bvvr WliYWuoaKtmFZKQqZOal5RflJpZk5ucpJOfnlQBVp6YARRUSujkzZu7rYC+YKFKxZ/cflgbG SwJdjJwcEgImEtNXfGXrYuTiEBLYxSRxvnEWE4SzhVGioeERI0gVm4CmxIFjU8BsEQEpiSkH ZoIVMQtMZJTYumExG0hCWMAeKHEbrIhFQFXi0YILLCA2r4CpxMI3M9kg1mlITFtzlwnE5hQw kzj+/Sc7iC0EVLN3y3xGiHpBiZMzn4D1MgtISBx88YIZokZWou34c/YJjPyzkJTNQlK2gJFp FaNQYklObmJmTnq5oV5ibqZecn7uJkZIzG3awdhy0fwQIxMH4yFGCQ5mJRHelsydcUK8KYmV ValF+fFFpTmpxYcYnYAemMgsxQ0KQmCcxBsbGEiJwjiGJmYm5kbmhpYm5sbGSuK8k9euiRMS SAfGbXZqakFqEcwQJg5OqQZG4a9WD79XO+wV6/cVVr51e9tNwZ6KY74TYgoOc+09Yu5SYBDI wiV1mcOxq2a3jWxp1EbhxxNWuZ67zS5Q+v/I1EdLK26ILOLaY/3s4/5CZ42bvgtjtjV7TE7L 5RNIvlxl2dxWtU9qw4PPa8SsvWSjT/1Z4HTLyvfbJvEGCT7Pb34zVk6LOFmqxFKckWioxVxU nAgAXlgdZc4CAAA= Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,oleksiyy@ami.com X-Gm-Message-State: KLdhi1AEj5xaVWmlMQluMTQjx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1589233881; bh=gFiS4OJMcN9+OEpUN0gH9m5xnBo4NtB9tzRXb4AiF6Q=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=U0iqKwN1neueYS7K1+yfZrqg4VVE2dMJpmUIZ4bdF1vCp/pqjBjCLTJ+9oD3orCxw7F 0gRzzsI6AQYn8w4ioD20Obn6MmkXcXoup1dNejbYWYlj5k1GOuEl4JeStHWkf/yRjDnsE NyPdFucf3WSP3bqAkTTk6sdN02n6m0uQk+g= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/Cper.h | 15 +++++++++++++++ MdePkg/MdePkg.dec | 9 +++++++++ 2 files changed, 24 insertions(+) diff --git a/MdePkg/Include/Guid/Cper.h b/MdePkg/Include/Guid/Cper.h index 0cacd30..948f586 100644 --- a/MdePkg/Include/Guid/Cper.h +++ b/MdePkg/Include/Guid/Cper.h @@ -95,6 +95,18 @@ typedef struct { { \ 0x667DD791, 0xC6B3, 0x4c27, { 0x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xEB= , 0x41 } \ } +#define EFI_EVENT_NOTIFICATION_TYPE_DMAR_SEA \ + { \ + 0x9A78788A, 0xBBE8, 0x11E4, { 0x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x46= , 0xB0 } \ + } +#define EFI_EVENT_NOTIFICATION_TYPE_DMAR_SEI \ + { \ + 0x5C284C81, 0xB0AE, 0x4E87, { 0xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x43= , 0x23 } \ + } +#define EFI_EVENT_NOTIFICATION_TYPE_DMAR_PEI \ + { \ + 0x09A9D5AC, 0x5204, 0x4214, { 0x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2B= , 0xCD } \ + } ///@} =20 /// @@ -1207,6 +1219,9 @@ extern EFI_GUID gEfiEventNotificationTypeInitGuid; extern EFI_GUID gEfiEventNotificationTypeNmiGuid; extern EFI_GUID gEfiEventNotificationTypeBootGuid; extern EFI_GUID gEfiEventNotificationTypeDmarGuid; +extern EFI_GUID gEfiEventNotificationTypeSeaGuid; +extern EFI_GUID gEfiEventNotificationTypeSeiGuid; +extern EFI_GUID gEfiEventNotificationTypePeiGuid; =20 extern EFI_GUID gEfiProcessorGenericErrorSectionGuid; extern EFI_GUID gEfiProcessorSpecificErrorSectionGuid; diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 0b9c4bc..ecd7822 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -437,6 +437,15 @@ gEfiEventNotificationTypeDmarGuid =3D { 0x667DD791, 0xC6B3, 0x4c27, { 0= x8A, 0x6B, 0x0F, 0x8E, 0x72, 0x2D, 0xEB, 0x41 }} =20 ## Include/Guid/Cper.h + gEfiEventNotificationTypeSeaGuid =3D { 0x9A78788A, 0xBBE8, 0x11E4, { 0= x80, 0x9E, 0x67, 0x61, 0x1E, 0x5D, 0x46, 0xB0 }} + + ## Include/Guid/Cper.h + gEfiEventNotificationTypeSeiGuid =3D { 0x5C284C81, 0xB0AE, 0x4E87, { 0= xA3, 0x22, 0xB0, 0x4C, 0x85, 0x62, 0x43, 0x23 }} + + ## Include/Guid/Cper.h + gEfiEventNotificationTypePeiGuid =3D { 0x09A9D5AC, 0x5204, 0x4214, { 0= x96, 0xE5, 0x94, 0x99, 0x2E, 0x75, 0x2B, 0xCD }} + + ## Include/Guid/Cper.h gEfiProcessorGenericErrorSectionGuid =3D { 0x9876ccad, 0x47b4, 0x4bdb, = { 0xb6, 0x5e, 0x16, 0xf1, 0x93, 0xc4, 0xf3, 0xdb }} =20 ## Include/Guid/Cper.h --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59212): https://edk2.groups.io/g/devel/message/59212 Mute This Topic: https://groups.io/mt/74146777/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 02:02:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+59213+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59213+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1589233882; cv=none; d=zohomail.com; s=zohoarc; b=ems9FRQIqR8QcbTKp8+nrm8ZpKo+xUrz78MBprjnqOUmFmn8grTvVAhvpukMsbG5jdHDxh3Op30TUC1y4U/LBGeKF6fdAfz/GbYSK/fTGiOU8GTJpZKGExgEET7ArOtndOeKqmKovweN/XTrBf/LGRm8toMFkdn4mZ0Kqklc7ZE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589233882; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=LbPbbM1QsWXllqlimZ/wmaPpcRp/ubW57G7jtn+Owb4=; b=bgKGnJr3duqDOBFemPy0fu0GcOPThkP3GwakipeXyg7tODCNNzxOVCViqUmBO+cEVFiDQH1mUf1t4FGtTLVeM9YYGoqojnP+z6Bj+NpI8ZjsXMsyT16CORkSK5bZeBW0VKwYLkCRx1eD93Qb2BHEVYjwquv2H2GKeSNnK6bYAsI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59213+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1589233882211782.0708322181705; Mon, 11 May 2020 14:51:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id tSSPYY1788612xTG4LG8FRl4; Mon, 11 May 2020 14:51:21 -0700 X-Received: from atlmailgw2.ami.com (atlmailgw2.ami.com []) by mx.groups.io with SMTP id smtpd.web11.2588.1589233879512116435 for ; Mon, 11 May 2020 14:51:21 -0700 X-AuditID: ac10606f-049ff70000001b62-a3-5eb9c8d8bb32 X-Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id E0.90.07010.8D8C9BE5; Mon, 11 May 2020 17:51:20 -0400 (EDT) X-Received: from Oleksiy77.us.megatrends.com (172.16.97.158) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.468.0; Mon, 11 May 2020 17:50:43 -0400 From: "Oleksiy Yakovlev" To: CC: , , , , , Subject: [edk2-devel] [PATCH V3 2/5] MdePkg: Fix OUT parameters marked as IN OUT Date: Mon, 11 May 2020 17:50:37 -0400 Message-ID: <20200511215040.31780-3-oleksiyy@ami.com> In-Reply-To: <20200511215040.31780-1-oleksiyy@ami.com> References: <20200511215040.31780-1-oleksiyy@ami.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsWyRiBhgu6NEzvjDL59lrVonzCbzeLqrV9M FvO+zWC1WHFvA7tFR8c/JgdWj+3fLzB6LN7zkimAKaqB0SYxLy+/JLEkVSEltTjZVimgKLMs MblSSSEzxVbJUEmhICcxOTU3Na/EVimxoCA1L0XJjksBA9gAlWXmKaTmJeenZOal2yp5Bvvr WliYWuoaKtmFZKQqZOal5RflJpZk5ucpJOfnlQBVp6YARRUSujkz7l48xViwL6KiY2ddA2O7 bRcjJ4eEgInEzwv/mLoYuTiEBHYxSXzpXsAG4WxhlPg6bTUrSBWbgKbEgWNTGEFsEQEpiSkH ZoJ1MAtMZJTYumExG0hCWMBZ4v7rvcwgNouAqkTn6a3sIDavgKnE7/VvGCHWaUhMW3OXCcTm FDCTOP79J1iNEFDN3i3zGSHqBSVOznzCAmIzC0hIHHzxghmiRlai7fhz9gmM/LOQlM1CUraA kWkVo1BiSU5uYmZOermRXmJupl5yfu4mRkjE5e9g/PjR/BAjEwfjIUYJDmYlEd6WzJ1xQrwp iZVVqUX58UWlOanFhxidgB6YyCzFDQpBYJTEGxsYSInCOIYmZibmRuaGlibmxsZK4ryT1q6J ExJIB0ZtdmpqQWoRzBAmDk6pBkZBru9B60xMf9WmPJqj5t2tfeVVrtqFjIScBAWGLakfp6vs +Zk7X73DqT2yWf+FwU+PferPmP2tun3O89cUZTndmxm/7JDTtHbnJ6snzCxjzPlq9c3DRVwz ddb3jOMRLgcCs93uZXT6u1Y9E5nyS/uV+mPepIoKltOfWVu9tGzZVotfsYn1UGIpzkg01GIu Kk4EAFLyFqXNAgAA Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,oleksiyy@ami.com X-Gm-Message-State: ASVuRkmmReYsBVs2zDQfusSAx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1589233881; bh=J0I+ChQq8XD09H9UaSPzYDTxCXLDRXLGwJJm2VZPnzM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=haTkLXKEtRMAP6EP5S0v9JIIq/AdTWU3q7awBTQum/dHzV6FOrZTdQ1pCgT2bZ1KRNp 3b2VXs0DCeFad16LYuAmazX9FIXIMqzuMwrP47QVSW+wrnDvsw0W8PlnWnjr6MBwCYBqT MW8bT1iD/wVSTJ8vQ8RsJq2Q9BcxASzd3DY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some OUT parameters in the specification were mistakenly marked as IN OUT. "IN OUT" replaced with "OUT" in the following interfaces EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles EFI_SIMPLE_POINTER_PROTOCOL.GetState():State EFI_ABSOLUTE_POINTER_PROTOCOL.GetState():State EFI_EDID_OVERRIDE_PROTOCOL.GetEdid():EdidSize and Edid EFI_ATA_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath EFI_SD_MMC_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath EFI_EXT_SCSI_PASS_THRU_PROTOCOL.BuildDevicePath():DevicePath EFI_FIRMWARE_MANAGEMENT_PROTOCOL.GetImage():Image (UEFI 2.8 errata a, mantis 2035) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Protocol/AbsolutePointer.h | 2 +- MdePkg/Include/Protocol/AtaPassThru.h | 4 ++-- MdePkg/Include/Protocol/EdidOverride.h | 4 ++-- MdePkg/Include/Protocol/FirmwareManagement.h | 4 ++-- MdePkg/Include/Protocol/NvmExpressPassthru.h | 4 ++-- MdePkg/Include/Protocol/ScsiPassThruExt.h | 2 +- MdePkg/Include/Protocol/SdMmcPassThru.h | 4 ++-- MdePkg/Include/Protocol/SimplePointer.h | 2 +- MdePkg/Include/Uefi/UefiSpec.h | 8 ++++---- 9 files changed, 17 insertions(+), 17 deletions(-) diff --git a/MdePkg/Include/Protocol/AbsolutePointer.h b/MdePkg/Include/Pro= tocol/AbsolutePointer.h index 77d34ae..d59ac97 100644 --- a/MdePkg/Include/Protocol/AbsolutePointer.h +++ b/MdePkg/Include/Protocol/AbsolutePointer.h @@ -169,7 +169,7 @@ typedef EFI_STATUS (EFIAPI *EFI_ABSOLUTE_POINTER_GET_STATE)( IN EFI_ABSOLUTE_POINTER_PROTOCOL *This, - IN OUT EFI_ABSOLUTE_POINTER_STATE *State + OUT EFI_ABSOLUTE_POINTER_STATE *State ); =20 =20 diff --git a/MdePkg/Include/Protocol/AtaPassThru.h b/MdePkg/Include/Protoco= l/AtaPassThru.h index ce6f57f..888dff2 100644 --- a/MdePkg/Include/Protocol/AtaPassThru.h +++ b/MdePkg/Include/Protocol/AtaPassThru.h @@ -315,7 +315,7 @@ EFI_STATUS @param[in] PortMultiplierPort The port multiplier port number of th= e ATA device for which a device path node is to be allocated a= nd built. If there is no port multiplier, then specify 0xFFFF. - @param[in,out] DevicePath A pointer to a single device path nod= e that describes the ATA + @param[out] DevicePath A pointer to a single device path nod= e that describes the ATA device specified by Port and PortMult= iplierPort. This function is responsible for allocating the buf= fer DevicePath with the boot service AllocatePool(). It is th= e caller's responsibility @@ -334,7 +334,7 @@ EFI_STATUS IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, IN UINT16 PortMultiplierPort, - IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath ); =20 /** diff --git a/MdePkg/Include/Protocol/EdidOverride.h b/MdePkg/Include/Protoc= ol/EdidOverride.h index 9036f8b..709ee48 100644 --- a/MdePkg/Include/Protocol/EdidOverride.h +++ b/MdePkg/Include/Protocol/EdidOverride.h @@ -44,8 +44,8 @@ EFI_STATUS IN EFI_EDID_OVERRIDE_PROTOCOL *This, IN EFI_HANDLE *ChildHandle, OUT UINT32 *Attributes, - IN OUT UINTN *EdidSize, - IN OUT UINT8 **Edid + OUT UINTN *EdidSize, + OUT UINT8 **Edid ); =20 /// diff --git a/MdePkg/Include/Protocol/FirmwareManagement.h b/MdePkg/Include/= Protocol/FirmwareManagement.h index 297bb5f..b501261 100644 --- a/MdePkg/Include/Protocol/FirmwareManagement.h +++ b/MdePkg/Include/Protocol/FirmwareManagement.h @@ -345,7 +345,7 @@ EFI_STATUS @param[in] This A pointer to the EFI_FIRMWARE_MANAGEMENT_= PROTOCOL instance. @param[in] ImageIndex A unique number identifying the firmware = image(s) within the device. The number is between 1 and DescriptorCou= nt. - @param[in, out] Image Points to the buffer where the current im= age is copied to. + @param[out] Image Points to the buffer where the current im= age is copied to. @param[in, out] ImageSize On entry, points to the size of the buffe= r pointed to by Image, in bytes. On return, points to the length of the im= age, in bytes. =20 @@ -364,7 +364,7 @@ EFI_STATUS (EFIAPI *EFI_FIRMWARE_MANAGEMENT_PROTOCOL_GET_IMAGE)( IN EFI_FIRMWARE_MANAGEMENT_PROTOCOL *This, IN UINT8 ImageIndex, - IN OUT VOID *Image, + OUT VOID *Image, IN OUT UINTN *ImageSize ); =20 diff --git a/MdePkg/Include/Protocol/NvmExpressPassthru.h b/MdePkg/Include/= Protocol/NvmExpressPassthru.h index 7420924..870b9b5 100644 --- a/MdePkg/Include/Protocol/NvmExpressPassthru.h +++ b/MdePkg/Include/Protocol/NvmExpressPassthru.h @@ -214,7 +214,7 @@ EFI_STATUS @param[in] NamespaceId The NVM Express namespace ID for whi= ch a device path node is to be allocated and built. Caller must set = the NamespaceId to zero if the device path node will contain a valid= UUID. - @param[in,out] DevicePath A pointer to a single device path nod= e that describes the NVM Express + @param[out] DevicePath A pointer to a single device path nod= e that describes the NVM Express namespace specified by NamespaceId. T= his function is responsible for allocating the buffer DevicePath with= the boot service AllocatePool(). It is the caller's responsibility to = free DevicePath when the caller @@ -231,7 +231,7 @@ EFI_STATUS (EFIAPI *EFI_NVM_EXPRESS_PASS_THRU_BUILD_DEVICE_PATH)( IN EFI_NVM_EXPRESS_PASS_THRU_PROTOCOL *This, IN UINT32 NamespaceId, - IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath ); =20 /** diff --git a/MdePkg/Include/Protocol/ScsiPassThruExt.h b/MdePkg/Include/Pro= tocol/ScsiPassThruExt.h index c83da26..994fbba 100644 --- a/MdePkg/Include/Protocol/ScsiPassThruExt.h +++ b/MdePkg/Include/Protocol/ScsiPassThruExt.h @@ -259,7 +259,7 @@ EFI_STATUS IN EFI_EXT_SCSI_PASS_THRU_PROTOCOL *This, IN UINT8 *Target, IN UINT64 Lun, - IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath ); =20 /** diff --git a/MdePkg/Include/Protocol/SdMmcPassThru.h b/MdePkg/Include/Proto= col/SdMmcPassThru.h index 3db6a3e..ac5470b 100644 --- a/MdePkg/Include/Protocol/SdMmcPassThru.h +++ b/MdePkg/Include/Protocol/SdMmcPassThru.h @@ -164,7 +164,7 @@ EFI_STATUS @param[in] This A pointer to the EFI_SD_MMMC_PASS_THRU_PRO= TOCOL instance. @param[in] Slot Specifies the slot number of the SD card f= or which a device path node is to be allocated and built. - @param[in,out] DevicePath A pointer to a single device path node tha= t describes the SD + @param[out] DevicePath A pointer to a single device path node tha= t describes the SD card specified by Slot. This function is r= esponsible for allocating the buffer DevicePath with the = boot service AllocatePool(). It is the caller's respons= ibility to free @@ -182,7 +182,7 @@ EFI_STATUS (EFIAPI *EFI_SD_MMC_PASS_THRU_BUILD_DEVICE_PATH) ( IN EFI_SD_MMC_PASS_THRU_PROTOCOL *This, IN UINT8 Slot, - IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath + OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath ); =20 /** diff --git a/MdePkg/Include/Protocol/SimplePointer.h b/MdePkg/Include/Proto= col/SimplePointer.h index 2f5a940..c631414 100644 --- a/MdePkg/Include/Protocol/SimplePointer.h +++ b/MdePkg/Include/Protocol/SimplePointer.h @@ -109,7 +109,7 @@ typedef EFI_STATUS (EFIAPI *EFI_SIMPLE_POINTER_GET_STATE)( IN EFI_SIMPLE_POINTER_PROTOCOL *This, - IN OUT EFI_SIMPLE_POINTER_STATE *State + OUT EFI_SIMPLE_POINTER_STATE *State ); =20 /// diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h index 8ffaf97..455123f 100644 --- a/MdePkg/Include/Uefi/UefiSpec.h +++ b/MdePkg/Include/Uefi/UefiSpec.h @@ -211,7 +211,7 @@ EFI_STATUS On output, it is the size of the = buffer returned by the firmware if the buffer was large enough, or t= he size of the buffer needed to contain the map if the buffer was too sma= ll. - @param[in, out] MemoryMap A pointer to the buffer in which = firmware places the current memory + @param[out] MemoryMap A pointer to the buffer in which = firmware places the current memory map. @param[out] MapKey A pointer to the location in whic= h firmware returns the key for the current memory map. @@ -232,7 +232,7 @@ typedef EFI_STATUS (EFIAPI *EFI_GET_MEMORY_MAP)( IN OUT UINTN *MemoryMapSize, - IN OUT EFI_MEMORY_DESCRIPTOR *MemoryMap, + OUT EFI_MEMORY_DESCRIPTOR *MemoryMap, OUT UINTN *MapKey, OUT UINTN *DescriptorSize, OUT UINT32 *DescriptorVersion @@ -1556,7 +1556,7 @@ EFI_STATUS @param[in] Protocol Provides the protocol to search by. This parameter is only valid for a SearchT= ype of ByProtocol. @param[in] SearchKey Supplies the search key depending on the S= earchType. - @param[in, out] NoHandles The number of handles returned in Buffer. + @param[out] NoHandles The number of handles returned in Buffer. @param[out] Buffer A pointer to the buffer to return the requ= ested array of handles that support Protocol. =20 @@ -1574,7 +1574,7 @@ EFI_STATUS IN EFI_LOCATE_SEARCH_TYPE SearchType, IN EFI_GUID *Protocol, OPTIONAL IN VOID *SearchKey, OPTIONAL - IN OUT UINTN *NoHandles, + OUT UINTN *NoHandles, OUT EFI_HANDLE **Buffer ); =20 --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59213): https://edk2.groups.io/g/devel/message/59213 Mute This Topic: https://groups.io/mt/74146778/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 02:02:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+59214+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59214+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1589233882; cv=none; d=zohomail.com; s=zohoarc; b=Gm5KaKYtH8pX+DKg7yDh8zLX21/fuef20F689dsvt2POzapMyawKluPpC8MJMYY0hPqnXvGNDyvvQ5Ymf71RRaCL255ox/tfSxD0597PQO0o6FTdKe0oJCBjoPoRjd6yInIiXBqgRL93L+/Q0+yZjCwjRG+dYLXiD0FOoV9eqbM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589233882; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=/9sL/HFbvHVZtv0Q6QDPoQae7jUu7nmHdG5x4OlT1kU=; b=R5KIcWLADdnwLiAUfU0a0bwx/FEJqo1TcZEtmDCmoe9psHPna356mYDE9laWKssw8U4VL00nzVx+MJdX2G+p9rkSj/SE2Z5l5CgWiZuDEROFc8aOj9umyonWjj+1pgU54+2Nt3tgRjJik1AQTiYuBHU8QIWPr71v+S2OFaNA3Ls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59214+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 15892338828761008.7961598582062; Mon, 11 May 2020 14:51:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dPHuYY1788612xQIg18RXrzA; Mon, 11 May 2020 14:51:22 -0700 X-Received: from atlmailgw1.ami.com (atlmailgw1.ami.com []) by mx.groups.io with SMTP id smtpd.web12.2744.1589233880372180480 for ; Mon, 11 May 2020 14:51:22 -0700 X-AuditID: ac1060b2-0e1ff700000018d4-54-5eb9c8d929d4 X-Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id AA.61.06356.9D8C9BE5; Mon, 11 May 2020 17:51:21 -0400 (EDT) X-Received: from Oleksiy77.us.megatrends.com (172.16.97.158) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.468.0; Mon, 11 May 2020 17:50:44 -0400 From: "Oleksiy Yakovlev" To: CC: , , , , , Subject: [edk2-devel] [PATCH V3 3/5] MdePkg: Add EFI_RT_PROPERTIES_TABLE Date: Mon, 11 May 2020 17:50:38 -0400 Message-ID: <20200511215040.31780-4-oleksiyy@ami.com> In-Reply-To: <20200511215040.31780-1-oleksiyy@ami.com> References: <20200511215040.31780-1-oleksiyy@ami.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFIsWRmVeSWpSXmKPExsWyRiBhgu7NEzvjDN68UbJonzCbzeLqrV9M FvO+zWC1WHFvA7tFR8c/JgdWj+3fLzB6LN7zkimAKaqB0SYxLy+/JLEkVSEltTjZVimgKLMs MblSSSEzxVbJUEmhICcxOTU3Na/EVimxoCA1L0XJjksBA9gAlWXmKaTmJeenZOal2yp5Bvvr WliYWuoaKtmFZKQqZOal5RflJpZk5ucpJOfnlQBVp6YARRUSujkzXsydxFTQI1dx4u5HtgbG 6+JdjJwcEgImEq2HfzN1MXJxCAnsYpL4NuMpK0hCSGALo8SNW2YgNpuApsSBY1MYQWwRASmJ KQdmgjUwC0xklNi6YTEbSEJYwFpi/rv7TCA2i4CqxJ++9+wgNq+AqcTnBUcYIbZpSExbcxes hlPATOL495/sEMtMJfZumc8IUS8ocXLmExYQm1lAQuLgixfMEDWyEm3Hn7NPYOSfhaRsFpKy BYxMqxiFEktychMzc9LLDfUSczP1kvNzNzFCIm7TDsaWi+aHGJk4GA8xSnAwK4nwtmTujBPi TUmsrEotyo8vKs1JLT7E6AT0wERmKW5QCAKjJN7YwEBKFMYxNDEzMTcyN7Q0MTc2VhLnnbx2 TZyQQDowarNTUwtSi2CGMHFwSjUwFsysbEs/PC9Ep44n9a/lk/tXBZldlArF/95Zv1iue+t/ a4Z7IudeTlr2z/+wtc2h5zw+F1K/3RRZmW6znXnnv93PlCzP+iTPaDu3ycR+2eSMPt78b113 g49c29nEOFV6V7wuX3Pv4pRtcrtl7+7qinra9vrhxC25pT4nKxJYPzlyf0hl03CYpcRSnJFo qMVcVJwIAMzmsCzNAgAA Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,oleksiyy@ami.com X-Gm-Message-State: gU5d1lts8eoMYdFVlBSCTzjSx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1589233882; bh=BiVJooU2Q90jz3Ft+1szXMsYUtPjDiB4vFQBEN/pj2g=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=egGi6USy6WUSVf0YW/VvBIgQdN36nZFzRNZbLLaiQCHvEHyFtMXC0cXwzFNRP2MW6K0 ZZs5ndnK30/VlBnfrEjIVGbqDZNHlZa3rMHq+A9Gg3nTj9+sPsq55Qaf4LN70Ps6JCErm irDEPhkZX3rnl/khbyu4liKPxEFqQurdiz4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be published by a platform if it no longer supports all EFI runtime services once ExitBootServices() has been called by the OS. (UEFI 2.8 errata a, mantis 2049) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/RtPropertiesTable.h | 69 +++++++++++++++++++++++++++++= ++++ MdePkg/MdePkg.dec | 5 +++ 2 files changed, 74 insertions(+) create mode 100644 MdePkg/Include/Guid/RtPropertiesTable.h diff --git a/MdePkg/Include/Guid/RtPropertiesTable.h b/MdePkg/Include/Guid/= RtPropertiesTable.h new file mode 100644 index 0000000..1b07bf2 --- /dev/null +++ b/MdePkg/Include/Guid/RtPropertiesTable.h @@ -0,0 +1,69 @@ +/** @file +Guid & data structure for EFI_RT _PROPERTIES_TABLE, designed to be publish= ed by a +platform if it no longer supports all EFI runtime services once ExitBootS= ervices() +has been called by the OS. Introduced in UEFI 2.8a. + + +Copyright (c) 2020, American Megatrends International LLC. All rights rese= rved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#ifndef __RT _PROPERTIES_TABLE_GUID_H__ +#define __RT _PROPERTIES_TABLE_GUID_H__ + +// +// Table, defined here, should be published by a platform if it no longer = supports all EFI runtime +// services once ExitBootServices() has been called by the OS. Note that t= his is merely a hint +// to the OS, which it is free to ignore, and so the platform is still req= uired to provide callable +// implementations of unsupported runtime services that simply return EFI_= UNSUPPORTED. +// +#define EFI_RT_PROPERTIES_TABLE_GUID \ + { 0xeb66918a, 0x7eef, 0x402a, \ + { 0x84, 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} + + + + +#pragma pack(1) + +typedef struct { + /// + /// Version of the structure, must be 0x1. + /// + UINT16 Version; + + /// + /// Size in bytes of the entire EFI_RT_PROPERTIES_TABLE, must be 8. + /// + UINT16 Length; + + /// + /// Bitmask of which calls are or are not supported, where a bit set to = 1 indicates + /// that the call is supported, and 0 indicates that it is not. + /// + UINT32 RuntimeServicesSupported; +} EFI_RT_PROPERTIES_TABLE; + +#pragma pack() + +#define EFI_RT_PROPERTIES_TABLE_VERSION 0x1 + +#define EFI_RT_SUPPORTED_GET_TIME 0x0001 +#define EFI_RT_SUPPORTED_SET_TIME 0x0002 +#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME 0x0004 +#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME 0x0008 +#define EFI_RT_SUPPORTED_GET_VARIABLE 0x0010 +#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME 0x0020 +#define EFI_RT_SUPPORTED_SET_VARIABLE 0x0040 +#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP 0x0080 +#define EFI_RT_SUPPORTED_CONVERT_POINTER 0x0100 +#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT 0x0200 +#define EFI_RT_SUPPORTED_RESET_SYSTEM 0x0400 +#define EFI_RT_SUPPORTED_UPDATE_CAPSULE 0x0800 +#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES 0x1000 +#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO 0x2000 + +extern EFI_GUID gEfiRtPropertiesTableGuid; + +#endif diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index ecd7822..0dd20ad 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -654,6 +654,11 @@ ## Include/Guid/Btt.h gEfiBttAbstractionGuid =3D { 0x18633bfc, 0x1735, 0x4217, { 0x8a,= 0xc9, 0x17, 0x23, 0x92, 0x82, 0xd3, 0xf8 }} =20 + # GUIDs defined in UEFI2.8a + # + ## Include/Guid/RtPropertiesTable.h + gEfiRtPropertiesTableGuid =3D { 0xeb66918a, 0x7eef, 0x402a, { 0x84,= 0x2e, 0x93, 0x1d, 0x21, 0xc3, 0x8a, 0xe9 }} + # # GUID defined in PI1.0 # --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59214): https://edk2.groups.io/g/devel/message/59214 Mute This Topic: https://groups.io/mt/74146779/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 02:02:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+59215+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59215+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1589233883; cv=none; d=zohomail.com; s=zohoarc; b=R1hoepzGPj7xyJXKqtbPF4A/ziBFIDX1UUz6KgowXlXGRIp4LJpP2beGy9q9ccEOp179/7f3MEQOH2xxjHF2qc+VyMO8WIf5ca13zhv0j+KpwdEQBaigXFmizwiXRSGCTwBaDRnBZa42eNTphoYT33xytTwlnc9h3QqGn9KOdlY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589233883; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=KG0pSfPKfNqvBnjAGv4dWKzU50PQpzyycgh/lF5l/qw=; b=fD8OJtCXp1YIOMezihOPOJd+ArW0obLUlJMJg5cFeFC3PzFAykYAZmiZyVvGipFwMpoWmyto/BMgRc8cfDCrg4gPMkIGE2TxA+BT/STKQ57ozWmUv3Drnl0C/dlvp1NdRu8fMobZxNSOTOTA+iEoQswxwEOa6F4fF5gNjvA8afE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59215+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158923388386096.21657121394765; Mon, 11 May 2020 14:51:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7VlJYY1788612x5q6MHyUb2C; Mon, 11 May 2020 14:51:23 -0700 X-Received: from atlmailgw2.ami.com (atlmailgw2.ami.com []) by mx.groups.io with SMTP id smtpd.web11.2588.1589233879512116435 for ; Mon, 11 May 2020 14:51:23 -0700 X-AuditID: ac10606f-05fff70000001b62-a6-5eb9c8dab42c X-Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 61.90.07010.AD8C9BE5; Mon, 11 May 2020 17:51:22 -0400 (EDT) X-Received: from Oleksiy77.us.megatrends.com (172.16.97.158) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.468.0; Mon, 11 May 2020 17:50:45 -0400 From: "Oleksiy Yakovlev" To: CC: , , , , , Subject: [edk2-devel] [PATCH V3 4/5] MdePkg: Add FMP Capsule Image Header extension Date: Mon, 11 May 2020 17:50:39 -0400 Message-ID: <20200511215040.31780-5-oleksiyy@ami.com> In-Reply-To: <20200511215040.31780-1-oleksiyy@ami.com> References: <20200511215040.31780-1-oleksiyy@ami.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRiBhgu6tEzvjDDbfVbFonzCbzeLqrV9M FvO+zWC1WHFvA7tFR8c/JgdWj+3fLzB6LN7zkimAKaqB0SYxLy+/JLEkVSEltTjZVimgKLMs MblSSSEzxVbJUEmhICcxOTU3Na/EVimxoCA1L0XJjksBA9gAlWXmKaTmJeenZOal2yp5Bvvr WliYWuoaKtmFZKQqZOal5RflJpZk5ucpJOfnlQBVp6YARRUSujkzLm/ZyljwmLtifstTtgbG 35xdjJwcEgImEhO/97N1MXJxCAnsYpLomv6eFcLZwijxd+thJpAqNgFNiQPHpjCC2CICUhJT DsxkAiliFpjIKLF1w2I2kISwgJvElAf3WUBsFgFViRMTXoLFeQVMJaYcW8MMsU5DYtqau2BD OQXMJI5//8kOYgsB1ezdMp8Rol5Q4uTMJ2BzmAUkJA6+eMEMUSMr0Xb8OfsERv5ZSMpmISlb wMi0ilEosSQnNzEzJ73cSC8xN1MvOT93EyMk5vJ3MH78aH6IkYmD8RCjBAezkghvS+bOOCHe lMTKqtSi/Pii0pzU4kOMTkAPTGSW4gYFITBO4o0NDKREYRxDEzMTcyNzQ0sTc2NjJXHeSWvX xAkJpAPjNjs1tSC1CGYIEwenVANjWsSzvc08XOf22Kr98TsUHDKvP7fEsOAny9pPqtumFm66 2/Hs67X1H6O9ZU7pTPpp9a+dbc7h//7bUmP25OqZfGTybFmWMv21u5O+/tIHi++KBUnPYfsn yJDPP1VYOG/u3/aPYlO5eXI2tLjclFcu7hbr//DsiCbDG3ON1+tT7qzef7Jnsoi0EktxRqKh FnNRcSIAD9/9m84CAAA= Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,oleksiyy@ami.com X-Gm-Message-State: zz1Tk6CRvDMwhcRVHbwooryqx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1589233883; bh=xHof5eqcJ3/PR8+m05d6RaFfVDyxsled9k5q15qqBc0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=TP5TJE1eDzSNNntLUw6zxpiHLjC1CfGFJA3jbAUSLmF8eljrtaaJ5nQu7pXRGu3Mhdk f9LabqjGxnCKJ1Ub8Jgfj/cWOsYWFCcRz9DggQZASYEJBPB6jtUxFBcVkjAmZ6phbP4xi LvoMU+Yz7uSmOsDVWfbxvydnAKv/SVksEoY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/FmpCapsule.h | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/FmpCapsule.h b/MdePkg/Include/Guid/FmpCaps= ule.h index fb8c346..bd5cb77 100644 --- a/MdePkg/Include/Guid/FmpCapsule.h +++ b/MdePkg/Include/Guid/FmpCapsule.h @@ -79,13 +79,22 @@ typedef struct { /// therefore can be modified without changing the Auth data. /// UINT64 UpdateHardwareInstance; + + /// + /// A 64-bit bitmask that determines what sections are added to the payl= oad. + /// #define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001 + /// #define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002 + /// + UINT64 ImageCapsuleSupport; } EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER; =20 #pragma pack() =20 =20 #define EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER_INIT_VERSION 0x000000= 01 -#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x000000= 02 +#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER_INIT_VERSION 0x000000= 03 +#define CAPSULE_SUPPORT_AUTHENTICATION 0x0000000000000001 +#define CAPSULE_SUPPORT_DEPENDENCY 0x0000000000000002 =20 extern EFI_GUID gEfiFmpCapsuleGuid; =20 --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59215): https://edk2.groups.io/g/devel/message/59215 Mute This Topic: https://groups.io/mt/74146780/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 02:02:57 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+59216+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59216+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1589233884; cv=none; d=zohomail.com; s=zohoarc; b=Mw0hZVtsO+/VodxZNioWHs8faR4mGVRX5O8ZrKTGS96qfFQLCqk7ic4J4wvr+3bESDC/BJ7lDpRhj7K2l09fzW+BsySEEBntsKtftzWPXv0LwWj7rP1abiMKBXWqk7mcld0LLv8EL4nYYhy86BQLHudWD/CgDKcQ4+GSWtCJB3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1589233884; h=Content-Type:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=iKe8JDKBs6rs2FU/Or7VE3bZ20SajCV1fmCI8jlf6ys=; b=k1aTRoJqtsGmjFyup7DUuZKejOJLlpnIcZAcjDXWrDp2obNkrBho436R2BScHe3PSQ9FiLHYzo/ybzJr3U1BaAlOuhXMs4L4SCMoBP9suf+UPis16Z9mgcKqK944E19r4xRTbXlrURXLdPgDAcFGbF/kRRLkA0HRjq8OofhXrdc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+59216+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1589233884860939.068215715642; Mon, 11 May 2020 14:51:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id mVHMYY1788612x9F19cBLIMA; Mon, 11 May 2020 14:51:24 -0700 X-Received: from atlmailgw1.ami.com (atlmailgw1.ami.com []) by mx.groups.io with SMTP id smtpd.web12.2744.1589233880372180480 for ; Mon, 11 May 2020 14:51:24 -0700 X-AuditID: ac1060b2-0f7ff700000018d4-57-5eb9c8dbc0da X-Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id 0B.61.06356.BD8C9BE5; Mon, 11 May 2020 17:51:23 -0400 (EDT) X-Received: from Oleksiy77.us.megatrends.com (172.16.97.158) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server id 14.3.468.0; Mon, 11 May 2020 17:50:46 -0400 From: "Oleksiy Yakovlev" To: CC: , , , , , Subject: [edk2-devel] [PATCH V3 5/5] MdeModulePkg: Add FMP Capsule Image Header extension Date: Mon, 11 May 2020 17:50:40 -0400 Message-ID: <20200511215040.31780-6-oleksiyy@ami.com> In-Reply-To: <20200511215040.31780-1-oleksiyy@ami.com> References: <20200511215040.31780-1-oleksiyy@ami.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRiBhgu7tEzvjDD4v1rdonzCbzeLqrV9M FvO+zWC1WHFvA7tFR8c/JgdWj+3fLzB6LN7zkimAKaqB0SYxLy+/JLEkVSEltTjZVimgKLMs MblSSSEzxVbJUEmhICcxOTU3Na/EVimxoCA1L0XJjksBA9gAlWXmKaTmJeenZOal2yp5Bvvr WliYWuoaKtmFZKQqZOal5RflJpZk5ucpJOfnlQBVp6YARRUSujkzVu68x1zwgKti1ZunbA2M szm7GDk5JARMJE59+sHcxcjFISSwi0misfk9C4SzhVHi1MM3bCBVbAKaEgeOTWEEsUUEpCSm HJjJBFLELDCRUWLrhsVgRcICPhKbj+5jBrFZBFQlJl46yQ5i8wqYShyaOosFYp2GxLQ1d5lA bE4BM4nj33+C1QgB1ezdMp8Rol5Q4uTMJ2D1zAISEgdfvGCGqJGVaDv+nH0CI/8sJGWzkJQt YGRaxSiUWJKTm5iZk15uqJeYm6mXnJ+7iRESc5t2MLZcND/EyMTBeIhRgoNZSYS3JXNnnBBv SmJlVWpRfnxRaU5q8SFGJ6AHJjJLcYOCEBgn8cYGBlKiMI6hiZmJuZG5oaWJubGxkjjv5LVr 4oQE0oFxm52aWpBaBDOEiYNTqoGxqmjeQ3+HV3v3xP1wuHLv2Z2KaadK39R0O/wrvfLP6dA2 46fn9fQEj3W5CjW2vBe7d/VTi03iTn+N8EmJt9WD3ZTaKz/J6N1wsuHe5LNCxIxpZ5EB77K6 Y36rtgtGvi6//8P+o7WH8cV9RpJhf2ReznmU0mvlYPkrTNXE4a9Wnonoim+yF5mVWIozEg21 mIuKEwGgmYJ9zgIAAA== Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,oleksiyy@ami.com X-Gm-Message-State: HjgSUz2reb1lqFkAIpb7DPmjx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1589233884; bh=5+glX732tWq2PWtJw0M/rWkObMs4fs5sO25jYULA+A8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=cSr5ioWGeNtW9w7F1lAZ0dIq7+XY815XHXUB9OO8scwbDTcPJ8yj90SS6fo5o7Pzuzd a2L3YSf8eLTQlfZH6Fgs8AXshXE4in0sGihYLSBHhOQcn0a71F/BpIh1R9VtW3j4KLI/B +dEr14/4k3IXuPfnGJS0oN5c2IdytgQvgrI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeMod= ulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c index 5dda561..af80039 100644 --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c @@ -285,8 +285,10 @@ ValidateFmpCapsule ( DEBUG((DEBUG_ERROR, "ImageHeader->Version(0x%x) Unknown\n", ImageHea= der->Version)); return EFI_INVALID_PARAMETER; } - if (ImageHeader->Version < EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADE= R_INIT_VERSION) { + if (ImageHeader->Version =3D=3D 1) { FmpImageHeaderSize =3D OFFSET_OF(EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMA= GE_HEADER, UpdateHardwareInstance); + } else { + FmpImageHeaderSize =3D OFFSET_OF(EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMA= GE_HEADER, ImageCapsuleSupport); } if (FmpImageSize < FmpImageHeaderSize) { DEBUG((DEBUG_ERROR, "FmpImageSize(0x%lx) < FmpImageHeaderSize(0x%x)\= n", FmpImageSize, FmpImageHeaderSize)); --=20 2.9.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59216): https://edk2.groups.io/g/devel/message/59216 Mute This Topic: https://groups.io/mt/74146781/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-