[edk2-devel] [edk2-platforms][PATCH 0/2] RPi - add DT-only mode

Andrei Warkentin posted 2 patches 3 years, 10 months ago
Failed in applying to current master (apply log)
.../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |  21 ++-
.../Drivers/ConfigDxe/ConfigDxe.inf           |   2 +-
.../Drivers/ConfigDxe/ConfigDxeHii.uni        |   9 +-
.../Drivers/ConfigDxe/ConfigDxeHii.vfr        | 146 ++----------------
Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c  |   6 +-
.../RaspberryPi/Drivers/FdtDxe/FdtDxe.inf     |   2 +-
Platform/RaspberryPi/Include/ConfigVars.h     | 131 ++++++++++++++++
Platform/RaspberryPi/RPi3/RPi3.dsc            |   8 +-
Platform/RaspberryPi/RPi4/RPi4.dsc            |   8 +-
Platform/RaspberryPi/RaspberryPi.dec          |   2 +-
10 files changed, 180 insertions(+), 155 deletions(-)
create mode 100644 Platform/RaspberryPi/Include/ConfigVars.h
[edk2-devel] [edk2-platforms][PATCH 0/2] RPi - add DT-only mode
Posted by Andrei Warkentin 3 years, 10 months ago
Today the Pies can be booted in a way where only ACPI is exposed,
or both ACPI and DT are exposed.

This patch set adds one more mode - DT only, no ACPI. The target
audience is developers. When both are exposed, it's up to the OS
to decide which gets used, and that choice can differ between OSes.

Note: this does _not_ change defaults. Pi 3 still defaults to
ACPI + DT, while Pi 4 still defaults to ACPI only.

We don't really want to remove DT + ACPI mode - it is the default
on Pi 3, and removing it is bound to just annoy users - WoA and
NetBSD (voa UEFI) on Pi 3 only work with ACPI, while everything
else (Linux, FreeBSD) only work with DT. I'd make an analogy of
MPS and ACPI being exposed for the longest time ever together on
PCs.

Andrei Warkentin (2):
  RPi: move varstore structure defs to ConfigVars.h
  RPi: allow selecting DT-only mode

 .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |  21 ++-
 .../Drivers/ConfigDxe/ConfigDxe.inf           |   2 +-
 .../Drivers/ConfigDxe/ConfigDxeHii.uni        |   9 +-
 .../Drivers/ConfigDxe/ConfigDxeHii.vfr        | 146 ++----------------
 Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c  |   6 +-
 .../RaspberryPi/Drivers/FdtDxe/FdtDxe.inf     |   2 +-
 Platform/RaspberryPi/Include/ConfigVars.h     | 131 ++++++++++++++++
 Platform/RaspberryPi/RPi3/RPi3.dsc            |   8 +-
 Platform/RaspberryPi/RPi4/RPi4.dsc            |   8 +-
 Platform/RaspberryPi/RaspberryPi.dec          |   2 +-
 10 files changed, 180 insertions(+), 155 deletions(-)
 create mode 100644 Platform/RaspberryPi/Include/ConfigVars.h

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59010): https://edk2.groups.io/g/devel/message/59010
Mute This Topic: https://groups.io/mt/74124179/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] RPi - add DT-only mode
Posted by Ard Biesheuvel 3 years, 10 months ago
On 5/10/20 11:34 PM, Andrei Warkentin wrote:
> Today the Pies can be booted in a way where only ACPI is exposed,
> or both ACPI and DT are exposed.
> 
> This patch set adds one more mode - DT only, no ACPI. The target
> audience is developers. When both are exposed, it's up to the OS
> to decide which gets used, and that choice can differ between OSes.
> 
> Note: this does _not_ change defaults. Pi 3 still defaults to
> ACPI + DT, while Pi 4 still defaults to ACPI only.
> 
> We don't really want to remove DT + ACPI mode - it is the default
> on Pi 3, and removing it is bound to just annoy users - WoA and
> NetBSD (voa UEFI) on Pi 3 only work with ACPI, while everything
> else (Linux, FreeBSD) only work with DT. I'd make an analogy of
> MPS and ACPI being exposed for the longest time ever together on
> PCs.
> 
> Andrei Warkentin (2):
>    RPi: move varstore structure defs to ConfigVars.h
>    RPi: allow selecting DT-only mode
> 

Pushed as 51da3c318e3d..d492639638ee (with Pete's R-b and his remark 
addressed)

Thanks!


>   .../RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c |  21 ++-
>   .../Drivers/ConfigDxe/ConfigDxe.inf           |   2 +-
>   .../Drivers/ConfigDxe/ConfigDxeHii.uni        |   9 +-
>   .../Drivers/ConfigDxe/ConfigDxeHii.vfr        | 146 ++----------------
>   Platform/RaspberryPi/Drivers/FdtDxe/FdtDxe.c  |   6 +-
>   .../RaspberryPi/Drivers/FdtDxe/FdtDxe.inf     |   2 +-
>   Platform/RaspberryPi/Include/ConfigVars.h     | 131 ++++++++++++++++
>   Platform/RaspberryPi/RPi3/RPi3.dsc            |   8 +-
>   Platform/RaspberryPi/RPi4/RPi4.dsc            |   8 +-
>   Platform/RaspberryPi/RaspberryPi.dec          |   2 +-
>   10 files changed, 180 insertions(+), 155 deletions(-)
>   create mode 100644 Platform/RaspberryPi/Include/ConfigVars.h
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#59065): https://edk2.groups.io/g/devel/message/59065
Mute This Topic: https://groups.io/mt/74124179/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-