[edk2-devel] [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs

kettenis@xs4all.nl posted 1 patch 3 years, 10 months ago
Failed in applying to current master (apply log)
Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 --
1 file changed, 2 deletions(-)
[edk2-devel] [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs
Posted by kettenis@xs4all.nl 3 years, 10 months ago
From: Mark Kettenis <kettenis@xs4all.nl>

The SoftIron Overdrive 1000 does not have a BMC so don't advertise
the IPMI KCS interface.

Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
---
 Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
index 005ffad..5cf865d 100644
--- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
+++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
@@ -405,8 +405,6 @@ DEFINE NUM_CORES    = 4
   # map the stack as non-executable when entering the DXE phase
   gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
 
-  gAmdStyxTokenSpaceGuid.PcdEnableKcs|TRUE
-
 [PcdsPatchableInModule]
 # PCIe Configuration: x4x2x2 (=2 See Include/FDKGionb.h)
   gAmdModulePkgTokenSpaceGuid.PcdPcieCoreConfiguration|2
-- 
1.9.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58651): https://edk2.groups.io/g/devel/message/58651
Mute This Topic: https://groups.io/mt/74001807/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH] Platform/SoftIron/Overdrive1000Board: remove PcdEnableKcs
Posted by Ard Biesheuvel 3 years, 10 months ago
On 5/5/20 6:02 PM, kettenis@xs4all.nl wrote:
> From: Mark Kettenis <kettenis@xs4all.nl>
> 
> The SoftIron Overdrive 1000 does not have a BMC so don't advertise
> the IPMI KCS interface.
> 
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>

Thanks Mark

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

Pushed as 72d6a1e804cb..03fb86be4146

> ---
>   Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> index 005ffad..5cf865d 100644
> --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc
> @@ -405,8 +405,6 @@ DEFINE NUM_CORES    = 4
>     # map the stack as non-executable when entering the DXE phase
>     gEfiMdeModulePkgTokenSpaceGuid.PcdSetNxForStack|TRUE
>   
> -  gAmdStyxTokenSpaceGuid.PcdEnableKcs|TRUE
> -
>   [PcdsPatchableInModule]
>   # PCIe Configuration: x4x2x2 (=2 See Include/FDKGionb.h)
>     gAmdModulePkgTokenSpaceGuid.PcdPcieCoreConfiguration|2
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#58649): https://edk2.groups.io/g/devel/message/58649
Mute This Topic: https://groups.io/mt/74001807/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-