From nobody Sat May 4 04:02:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+58323+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58323+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1588184834; cv=none; d=zohomail.com; s=zohoarc; b=D+HeclwX733fJ+ZxtR+25deJA4yUh1X3p3Mg7Qt2nhgiW1hduhoL24UO+Q3o0m9Nbkl6V00739fDQTnwRV24zBpSJiP2fG/mikbbyeHpOh7yl2OayNRZx0TMokAjmtNk7CvjN0MNolymEZNfCkoyjgT42QFEXeQtSrClYn8iUQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588184834; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=IAG3kkx76sptbUOOYe7sahJaLaee/vVDL/DqPc68byg=; b=bWLGrFmwVDxpELH/xDcWetpYJz2XKRlscuneMYKf9W3AXF3czIRbeN+bh2VJfyKHNuDee1UW6akX+jJeSQisj4LeUxn35XMVkB+XqX6NPZ+iA7v23wGYynURfB4DncFODeBlYD331CYiHqnkg6kGtd9xgVx4Ybw4sXTFeut0FOg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58323+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1588184833938622.0224573793455; Wed, 29 Apr 2020 11:27:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id y0suYY1788612x2338mG0FqE; Wed, 29 Apr 2020 11:27:13 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.2472.1588184832786112726 for ; Wed, 29 Apr 2020 11:27:12 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7D08E1063; Wed, 29 Apr 2020 11:27:12 -0700 (PDT) X-Received: from e123331-lin.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB2393F73D; Wed, 29 Apr 2020 11:27:11 -0700 (PDT) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif@nuviainc.com, Ard Biesheuvel Subject: [edk2-devel] [PATCH] EmbeddedPkg: rename gEfiMmcHostProtocolGuid to gEdkiiMmcHostProtocolGuid Date: Wed, 29 Apr 2020 20:27:04 +0200 Message-Id: <20200429182704.8715-1-ard.biesheuvel@arm.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: <27952.devel.edk2.groups.io> Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@arm.com X-Gm-Message-State: Mb69jQGJb74QYEw1WhIY2As2x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1588184833; bh=Zr7B1Rz1K8Llr/ynCMXYTf9tqek0ZQeyvy/d5gpmEhU=; h=Cc:Date:From:Reply-To:Subject:To; b=H2zNjfIS/RH0I2U+smOLCBqE8F22lc4e7A3hgjlMY0oI5pxqnuEwX/8RK+b3lWlrrw1 8gXdnlBaYTTrrwH/WuEegkF67tAqu8bLxpEDFJfq6I24eRfA7iNtb2dj2DvIWWffNznoi b/bFZCKAm1e69xv8d8iX5tCB5SniS1yKavQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" In EDK2, identifiers carrying the EFI prefix are reserved for ones that are defined in the UEFI or PI specifications. For protocols that are part of the internal EDK2 implementation, we use EDKII instead. Since the MMC host protocol defined in EmbeddedPkg is not the one that the UEFI spec defines, and given the confusion around this, let's rename it to gEdkiiMmcHostProtocolGuid. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c | 2 +- ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf | 2 +- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c | 2 +- EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf | 2 +- EmbeddedPkg/EmbeddedPkg.dec | 2 +- EmbeddedPkg/Include/Protocol/MmcHost.h | 4 ++-- EmbeddedPkg/Universal/MmcDxe/Mmc.c | 10 +++++----- EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf | 2 +- 8 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c b/ArmPlatformPkg= /Drivers/PL180MciDxe/PL180Mci.c index 365f78b306fa..0c9e4b7ce15e 100644 --- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c +++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180Mci.c @@ -554,7 +554,7 @@ PL180MciDxeInitialize ( //Publish Component Name, BlockIO protocol interfaces Status =3D gBS->InstallMultipleProtocolInterfaces ( &Handle, - &gEfiMmcHostProtocolGuid, &gMciHost, + &gEdkiiMmcHostProtocolGuid, &gMciHost, NULL ); ASSERT_EFI_ERROR (Status); diff --git a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf b/ArmPlatfo= rmPkg/Drivers/PL180MciDxe/PL180MciDxe.inf index c70377bc7cfa..2c7272c87a59 100644 --- a/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf +++ b/ArmPlatformPkg/Drivers/PL180MciDxe/PL180MciDxe.inf @@ -36,7 +36,7 @@ [LibraryClasses] [Protocols] gEfiCpuArchProtocolGuid gEfiDevicePathProtocolGuid - gEfiMmcHostProtocolGuid + gEdkiiMmcHostProtocolGuid =20 [Pcd] gArmPlatformTokenSpaceGuid.PcdPL180SysMciRegAddress diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c b/EmbeddedPkg/Driver= s/DwEmmcDxe/DwEmmcDxe.c index 68c523a99f14..47b36e2e8656 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.c @@ -679,7 +679,7 @@ DwEmmcDxeInitialize ( //Publish Component Name, BlockIO protocol interfaces Status =3D gBS->InstallMultipleProtocolInterfaces ( &Handle, - &gEfiMmcHostProtocolGuid, &gMciHost, + &gEdkiiMmcHostProtocolGuid, &gMciHost, NULL ); ASSERT_EFI_ERROR (Status); diff --git a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf b/EmbeddedPkg/Driv= ers/DwEmmcDxe/DwEmmcDxe.inf index 21c372c5b200..f56e1beb0653 100644 --- a/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf +++ b/EmbeddedPkg/Drivers/DwEmmcDxe/DwEmmcDxe.inf @@ -37,7 +37,7 @@ [LibraryClasses] [Protocols] gEfiCpuArchProtocolGuid gEfiDevicePathProtocolGuid - gEfiMmcHostProtocolGuid + gEdkiiMmcHostProtocolGuid =20 [Pcd] gEmbeddedTokenSpaceGuid.PcdDwEmmcDxeBaseAddress diff --git a/EmbeddedPkg/EmbeddedPkg.dec b/EmbeddedPkg/EmbeddedPkg.dec index 69922802f473..20fed5441684 100644 --- a/EmbeddedPkg/EmbeddedPkg.dec +++ b/EmbeddedPkg/EmbeddedPkg.dec @@ -71,7 +71,7 @@ [Protocols.common] gEmbeddedExternalDeviceProtocolGuid =3D { 0x735F8C64, 0xD696, 0x44D0, { = 0xBD, 0xF2, 0x44, 0x7F, 0xD0, 0x5A, 0x54, 0x06 }} gEmbeddedGpioProtocolGuid =3D { 0x17a0a3d7, 0xc0a5, 0x4635, { = 0xbb, 0xd5, 0x07, 0x21, 0x87, 0xdf, 0xe2, 0xee }} gPeCoffLoaderProtocolGuid =3D { 0xB323179B, 0x97FB, 0x477E, { 0xB0, 0xF= E, 0xD8, 0x85, 0x91, 0xFA, 0x11, 0xAB } } - gEfiMmcHostProtocolGuid =3D { 0x3e591c00, 0x9e4a, 0x11df, {= 0x92, 0x44, 0x00, 0x02, 0xA5, 0xD5, 0xC5, 0x1B }} + gEdkiiMmcHostProtocolGuid =3D { 0x3e591c00, 0x9e4a, 0x11df, {= 0x92, 0x44, 0x00, 0x02, 0xA5, 0xD5, 0xC5, 0x1B }} gAndroidFastbootTransportProtocolGuid =3D { 0x74bd9fe0, 0x8902, 0x11e3, = {0xb9, 0xd3, 0xf7, 0x22, 0x38, 0xfc, 0x9a, 0x31}} gAndroidFastbootPlatformProtocolGuid =3D { 0x524685a0, 0x89a0, 0x11e3, = {0x9d, 0x4d, 0xbf, 0xa9, 0xf6, 0xa4, 0x03, 0x08}} gUsbDeviceProtocolGuid =3D { 0x021bd2ca, 0x51d2, 0x11e3, {0x8e, 0x56, 0= xb7, 0x54, 0x17, 0xc7, 0x0b, 0x44 }} diff --git a/EmbeddedPkg/Include/Protocol/MmcHost.h b/EmbeddedPkg/Include/P= rotocol/MmcHost.h index 9e070826805b..ef4aa2f65e75 100644 --- a/EmbeddedPkg/Include/Protocol/MmcHost.h +++ b/EmbeddedPkg/Include/Protocol/MmcHost.h @@ -13,7 +13,7 @@ /// /// Global ID for the MMC Host Protocol /// -#define EFI_MMC_HOST_PROTOCOL_GUID \ +#define EDKII_MMC_HOST_PROTOCOL_GUID \ { 0x3e591c00, 0x9e4a, 0x11df, {0x92, 0x44, 0x00, 0x02, 0xA5, 0xD5, 0xC5,= 0x1B } } =20 #define MMC_RESPONSE_TYPE_R1 0 @@ -178,7 +178,7 @@ struct _EFI_MMC_HOST_PROTOCOL { #define MMC_HOST_HAS_ISMULTIBLOCK(Host) (Host->Revision >=3D MMC_HOST_PROT= OCOL_REVISION && \ Host->IsMultiBlock !=3D NULL) =20 -extern EFI_GUID gEfiMmcHostProtocolGuid; +extern EFI_GUID gEdkiiMmcHostProtocolGuid; =20 #endif =20 diff --git a/EmbeddedPkg/Universal/MmcDxe/Mmc.c b/EmbeddedPkg/Universal/Mmc= Dxe/Mmc.c index c6170880debd..0088e27b9998 100644 --- a/EmbeddedPkg/Universal/MmcDxe/Mmc.c +++ b/EmbeddedPkg/Universal/MmcDxe/Mmc.c @@ -216,7 +216,7 @@ MmcDriverBindingSupported ( // Status =3D gBS->OpenProtocol ( Controller, - &gEfiMmcHostProtocolGuid, + &gEdkiiMmcHostProtocolGuid, (VOID **) &MmcHost, This->DriverBindingHandle, Controller, @@ -234,7 +234,7 @@ MmcDriverBindingSupported ( // gBS->CloseProtocol ( Controller, - &gEfiMmcHostProtocolGuid, + &gEdkiiMmcHostProtocolGuid, This->DriverBindingHandle, Controller ); @@ -275,7 +275,7 @@ MmcDriverBindingStart ( // Status =3D gBS->OpenProtocol ( Controller, - &gEfiMmcHostProtocolGuid, + &gEdkiiMmcHostProtocolGuid, (VOID **) &MmcHost, This->DriverBindingHandle, Controller, @@ -326,10 +326,10 @@ MmcDriverBindingStop ( MmcHostInstance =3D MMC_HOST_INSTANCE_FROM_LINK(CurrentLink); ASSERT(MmcHostInstance !=3D NULL); =20 - // Close gEfiMmcHostProtocolGuid + // Close gEdkiiMmcHostProtocolGuid Status =3D gBS->CloseProtocol ( Controller, - &gEfiMmcHostProtocolGuid, + &gEdkiiMmcHostProtocolGuid, This->DriverBindingHandle, Controller ); diff --git a/EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf b/EmbeddedPkg/Universa= l/MmcDxe/MmcDxe.inf index 67cdce6c5b4d..ea1410f839ee 100644 --- a/EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf +++ b/EmbeddedPkg/Universal/MmcDxe/MmcDxe.inf @@ -38,7 +38,7 @@ [Protocols] gEfiDiskIoProtocolGuid gEfiBlockIoProtocolGuid gEfiDevicePathProtocolGuid - gEfiMmcHostProtocolGuid + gEdkiiMmcHostProtocolGuid gEfiDriverDiagnostics2ProtocolGuid =20 [Depex] --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58323): https://edk2.groups.io/g/devel/message/58323 Mute This Topic: https://groups.io/mt/73359147/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-