From nobody Wed May 8 09:57:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+58317+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58317+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1588178181; cv=none; d=zohomail.com; s=zohoarc; b=NJ49NvgTWM3b1MmQXYptuu9kL1PrrEOoSaTaMQOxcENSyidJHV036j1uQB2ZQ7DIAyeGU3wqsZh3YZ/9+qk0zFMOLVnj5o/dxmhj3Zx0yrKOGHFu3nAAPBFx5pmCscgaMZXBJ5xqn+9vJHW3DJ4ESRgfGYmiXymxc+RDXcqsbSw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588178181; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=ckFIVdNFlS+LiP0XQzdsVI2XQKMi2D8vd0prSt5o+Yk=; b=kWSWHAYzJyRCCAUj/bWNoU0L2WCFkUZkgBkZ3CZgasua5Ouu3DJQKLTULy9NuuMNpHQf2GG3ZsZssmOUJRH+7NQDLw/vEYB4y8kt5jRFibzaenkkVd01ACJlgzEkxLdH4C4USQthdN3zyKJ2ZpWRO6qvuR5Zu9qGy2y+7QUWXaU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58317+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1588178181592552.4952510119439; Wed, 29 Apr 2020 09:36:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id H6MZYY1788612xpg9Lb8iP1I; Wed, 29 Apr 2020 09:36:21 -0700 X-Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.groups.io with SMTP id smtpd.web12.5280.1588178180488613141 for ; Wed, 29 Apr 2020 09:36:20 -0700 X-Received: by mail-wr1-f51.google.com with SMTP id k1so3341488wrx.4 for ; Wed, 29 Apr 2020 09:36:20 -0700 (PDT) X-Gm-Message-State: EBmQPrsuDMenNIUtFUXHIWGJx1787277AA= X-Google-Smtp-Source: APiQypL6GOV0Y7y/54K/9WCx+h+lacinTNeAQrurnRE0iYTcW/6GCQDl9A0tOt2tcyP5GglWlytRbg== X-Received: by 2002:a5d:420d:: with SMTP id n13mr43854815wrq.204.1588178178724; Wed, 29 Apr 2020 09:36:18 -0700 (PDT) X-Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id b12sm32690033wro.18.2020.04.29.09.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 09:36:18 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Bob Feng , Liming Gao Subject: [edk2-devel] [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py Date: Wed, 29 Apr 2020 17:36:14 +0100 Message-Id: <20200429163616.5951-2-leif@nuviainc.com> In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com> References: <20200429163616.5951-1-leif@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: <27952.devel.edk2.groups.io> Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1588178181; bh=a6n6K2N/gvVA7VNHIIQeAGWe1dTe9LxKBhtVnGqZiRY=; h=Cc:Date:From:Reply-To:Subject:To; b=JuFZgPLWMKwu93B0yTOQlrqUBCpAnyh4OXyo2hUKlz/DfSugWOAUx3QamDT8URt7zvQ 7p7k+i6BtWEzkEDsqARpG9GZQAZnT0LR9f1mrZNtmww1EkhBuoWrYxzGKt3Y6lz2G1XLe rP6YtXSsEipf5jemTx+SHGl+T9VtKjfYmIk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" GetMaintainer.py already extracts the value of any S: tags for sections, but it doesn't do anything with that information. Print a warning message, with the status, for each matching section with a status explicitly set to anything other than 'Supported' or 'Maintained'. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel Reviewed-by: Bob Feng --- BaseTools/Scripts/GetMaintainer.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMain= tainer.py index fbc63522db77..2ec550e86d36 100644 --- a/BaseTools/Scripts/GetMaintainer.py +++ b/BaseTools/Scripts/GetMaintainer.py @@ -77,8 +77,12 @@ def get_section_maintainers(path, section): matching the provided path in the provided section.""" maintainers =3D [] lists =3D [] + nowarn_status =3D ['Supported', 'Maintained'] =20 if path_in_section(path, section): + for status in section['status']: + if status not in nowarn_status: + print('WARNING: Maintained status for "%s" is \'%s\'!' % (= path, status)) for address in section['maintainer'], section['reviewer']: # Convert to list if necessary if isinstance(address, list): --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58317): https://edk2.groups.io/g/devel/message/58317 Mute This Topic: https://groups.io/mt/73356718/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 8 09:57:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+58318+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58318+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1588178182; cv=none; d=zohomail.com; s=zohoarc; b=D1e4DP1kRX+AmhrgMPG4WxSseDr+7zgIiElvcpDSMEo6Gx4DvbSXTp29fOXq9Wvl4fgsJ07iVv7+hulECOQIyFhVnwbiyEjQMm5s562agg3tsrqpOIOM7grSjbc3fX1vu9zO3zd8hjOrMCLournDbIc00a2hkvcLhL3dlCjsEL8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588178182; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=iw4j0EY2mPhK5PBKBc9gYhPPtom2uXda/FnMIqjL94o=; b=OAicekLD3ARbFkbWiRHbbXf9HH1lVz797Wr+meClYQ/qau3TOQ0LhHtkpsqLxrbTezDTZyflg7ejG9rdGCiHtZw8WX0yULpjtmlDfyFy3Ju0u1Vp+YIxPbMUBKt5UVefwvILBi/CTXJhP+AgeCjpvIIR7Tupr1o58DozFPyxDbI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58318+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1588178182265463.0582163954032; Wed, 29 Apr 2020 09:36:22 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id c93uYY1788612xJnQ2K3jAin; Wed, 29 Apr 2020 09:36:21 -0700 X-Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web11.5225.1588178181270286218 for ; Wed, 29 Apr 2020 09:36:21 -0700 X-Received: by mail-wr1-f67.google.com with SMTP id g13so3310696wrb.8 for ; Wed, 29 Apr 2020 09:36:21 -0700 (PDT) X-Gm-Message-State: 0P0q0Cp6dfHF5k04PGM33JXOx1787277AA= X-Google-Smtp-Source: APiQypLEqI+MWyjTxt5ep8i9B/hzjYjG01V2b2ie0wLaAtE161THMXKLEyogMtFps6NzrU3rfCRvjQ== X-Received: by 2002:a5d:6841:: with SMTP id o1mr40089292wrw.412.1588178179664; Wed, 29 Apr 2020 09:36:19 -0700 (PDT) X-Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id b12sm32690033wro.18.2020.04.29.09.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 09:36:19 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Andrew Fish , Ard Biesheuvel , Laszlo Ersek , Michael D Kinney Subject: [edk2-devel] [PATCH 2/3] Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete Date: Wed, 29 Apr 2020 17:36:15 +0100 Message-Id: <20200429163616.5951-3-leif@nuviainc.com> In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com> References: <20200429163616.5951-1-leif@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: <27952.devel.edk2.groups.io> Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1588178181; bh=VE1zhqMvoLAFIR6je0k6bSsR1Ue1vzgV4+aCakUG4Jw=; h=Cc:Date:From:Reply-To:Subject:To; b=ec8u6udrqUmWk2xtjgwxmGFz5Piq34Mv+w+v+Fb5Rn+daVoGNtOAI0hOzq4iZ4jMrxa 7ZRCRbVWqzg4Ap1UotW/Uxyz8IT6vU1XmWQkGtnkdJBQl/ied7GzDuv6Tbu7W6CcYp85a o5UYge2S9iz6rs6onf+U4zi8eKqKaGP8Fs8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The EmbeddedPkg MmcDxe duplicates definitions an functionality also available in MdeModulePkg. New platforms should not be making use of this, and old platforms should consider migrating - indicate this properly by creating a separate section in Maintainers.txt and marking it "Obsolete". Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Michael D Kinney Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek --- Maintainers.txt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 1733225722b6..4d62e0b334f3 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -172,10 +172,17 @@ M: Alexei Fedorov =20 EmbeddedPkg F: EmbeddedPkg/ +X: EmbeddedPkg/Include/Protocol/MmcHost.h +X: EmbeddedPkg/Universal/MmcDxe/ W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg M: Leif Lindholm M: Ard Biesheuvel =20 +EmbeddedPkg obsolete code +F: EmbeddedPkg/Include/Protocol/MmcHost.h +F: EmbeddedPkg/Universal/MmcDxe/ +S: Obsolete + EmulatorPkg F: EmulatorPkg/ W: https://github.com/tianocore/tianocore.github.io/wiki/EmulatorPkg --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58318): https://edk2.groups.io/g/devel/message/58318 Mute This Topic: https://groups.io/mt/73356719/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 8 09:57:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+58319+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58319+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1588178183; cv=none; d=zohomail.com; s=zohoarc; b=mn1wdV6pO66S1MULxaH8MlfWbE5FP7t6D1Rc6I2/gbUJRwbzRsXuXP9PCOdqFbL9Ds0LW4TpviLmvGbdwGbknlJh1kadHL84KeQj+BfqViDT35mt/bdvViCi8BpYpGuB4Vv0UHPbGj3Hb3Y8kWUi/Bds91Ik5Sn4POrA1rmVDFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588178183; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=MDPwtWl7TAIqfT7XOeXrBsAAs3tP31vOGKIi0I7KeDo=; b=gQgwu3Ewg8pPdeMg0m8+7XQEzxAobM6UyKpZ9gWpToMUfuYMNfWJoXbEn5fs8h9GYPK/2C4gucXrDmRHn6wM93pjKKlFQqxGf2yD0Qjl+KMS6FsnhPXEZk7zfMjcbFijtorz+VK4SlhfvjvlTU4244vCdbPtWpCUetL61QkJaw0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+58319+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1588178183484735.2860982272814; Wed, 29 Apr 2020 09:36:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id uD9kYY1788612xB1mbdT8CrH; Wed, 29 Apr 2020 09:36:23 -0700 X-Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by mx.groups.io with SMTP id smtpd.web10.5195.1588178182384310376 for ; Wed, 29 Apr 2020 09:36:22 -0700 X-Received: by mail-wr1-f65.google.com with SMTP id x17so3327652wrt.5 for ; Wed, 29 Apr 2020 09:36:22 -0700 (PDT) X-Gm-Message-State: uV2tCpR0GJ0B7KRXRMzCEY72x1787277AA= X-Google-Smtp-Source: APiQypLEJ6eJDlkrLK4gSFsdeZf5G+Fa+W8uSfjLO+8ZaXUnzWfzxF1z/eqLeohOhixTlu5M/T3fpA== X-Received: by 2002:a5d:4712:: with SMTP id y18mr41140036wrq.306.1588178180551; Wed, 29 Apr 2020 09:36:20 -0700 (PDT) X-Received: from vanye.hemma.eciton.net (cpc92302-cmbg19-2-0-cust304.5-4.cable.virginm.net. [82.1.209.49]) by smtp.gmail.com with ESMTPSA id b12sm32690033wro.18.2020.04.29.09.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Apr 2020 09:36:20 -0700 (PDT) From: "Leif Lindholm" To: devel@edk2.groups.io Cc: Andrew Fish , Ard Biesheuvel , Laszlo Ersek , Michael D Kinney Subject: [edk2-devel] [PATCH 3/3] Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete Date: Wed, 29 Apr 2020 17:36:16 +0100 Message-Id: <20200429163616.5951-4-leif@nuviainc.com> In-Reply-To: <20200429163616.5951-1-leif@nuviainc.com> References: <20200429163616.5951-1-leif@nuviainc.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: <27952.devel.edk2.groups.io> Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,leif@nuviainc.com Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1588178183; bh=6bmGOBATcZVNI1h1oFGWXvxJgv+6AVDO5sNR+GKUw+4=; h=Cc:Date:From:Reply-To:Subject:To; b=CpyzpB8JpnjmNkdZl7fZHdlX+MG9VUBqyXqQLCG7GYGtZXUYHJHPej2Ih3P0P8CAfZn mVBDGxsnJeD4V7I/Di7Qo3D6yrWeQpR2CzFy2r3AOBCaR1HF+rgtDX16r5D/uX/MVMD9l OIc9kvafufALtiXIkMM8fbKiL9i0LcUE88A= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" A bunch of legacy drivers (most not compliant with UEFI driver model) added for various ARM development platforms are still in EmbeddedPkg, which was arguably the only possible location for them before edk2-platforms was added. DwEmmcDxe, Isp1761UsbDxe, Lan9118Dxe, and Lan91xDxe all use a Pcd*BaseAddress mechanism making them *fundamentally* incompatible with the UEFI driver model, and preventing use of more than one device instance per system. SataSiI3132Dxe *looks* like a proper UEFI driver, but would need re-review with that in mind for moving to edk2-platforms. Mark these as Status: Obsolete in Maintainers.txt to at the very least indicate that they are not suitable references. Cc: Andrew Fish Cc: Ard Biesheuvel Cc: Laszlo Ersek Cc: Michael D Kinney Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel Reviewed-by: Laszlo Ersek --- Maintainers.txt | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 4d62e0b334f3..3415a0410b7b 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -172,6 +172,11 @@ M: Alexei Fedorov =20 EmbeddedPkg F: EmbeddedPkg/ +X: EmbeddedPkg/Drivers/DwEmmcDxe/ +X: EmbeddedPkg/Drivers/Isp1761UsbDxe/ +X: EmbeddedPkg/Drivers/Lan9118Dxe/ +X: EmbeddedPkg/Drivers/Lan91xDxe/ +X: EmbeddedPkg/Drivers/SataSiI3132Dxe/ X: EmbeddedPkg/Include/Protocol/MmcHost.h X: EmbeddedPkg/Universal/MmcDxe/ W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg @@ -179,6 +184,11 @@ M: Leif Lindholm M: Ard Biesheuvel =20 EmbeddedPkg obsolete code +F: EmbeddedPkg/Drivers/DwEmmcDxe/ +F: EmbeddedPkg/Drivers/Isp1761UsbDxe/ +F: EmbeddedPkg/Drivers/Lan9118Dxe/ +F: EmbeddedPkg/Drivers/Lan91xDxe/ +F: EmbeddedPkg/Drivers/SataSiI3132Dxe/ F: EmbeddedPkg/Include/Protocol/MmcHost.h F: EmbeddedPkg/Universal/MmcDxe/ S: Obsolete --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58319): https://edk2.groups.io/g/devel/message/58319 Mute This Topic: https://groups.io/mt/73356720/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-