From nobody Mon Feb 9 16:50:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57887+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57887+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587598163; cv=none; d=zohomail.com; s=zohoarc; b=Ok+oeXrEoPBvaK+sqOuWeS8PzPNBIDWwoPMKJFTaRiOwfPqf08vie+M6B9O06975pa9luG5umsmFaBBDMe2zbx4RN+ZS4sOm0RWkBdYbXtPHVnQUDDDAUfh4jE/djYzveAlKk7EH08ghuzxmdFajV9hQ4zvbg5EdUJKCNeed/zE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587598163; h=Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:Message-ID:Reply-To:References:Sender:Subject:To; bh=hzEXlMahJefcVUnkY75wkB1gZDyM4skm+xNRE3TB23A=; b=c9wl1HD2QkGRQZAP6wn8JMBEkF+qGMIgW+9resM/ROjTpnXIKjFB/Hcw1P2xL35RYaPfwu+P2/AK/0xFkK1Vo4I01ZFcjG6aMT+7TPXzNZI7NpRoMkMH0bQIQmuZgauOR0zDcBJ2GDp5HU0WaJS5ISAt2Qqx5t20G5GTn98U9is= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57887+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587598163173759.5126380404621; Wed, 22 Apr 2020 16:29:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8FpPYY1788612xKzxcvNy2gJ; Wed, 22 Apr 2020 16:29:22 -0700 X-Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.5379.1587598162302894222 for ; Wed, 22 Apr 2020 16:29:22 -0700 IronPort-SDR: uoWiG6AxXiBw+T3dOU33jDFKlmL2V1kjxaXGqbaJ8hxPe7Xz+gnfpeWDaw9Du+BCNbTiEKvjvj 6tEqUc8VcWhg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 16:29:20 -0700 IronPort-SDR: dqoSRIk/CKDD3WzgDUjKeBng04Wdf/L3wkGjC47wXpoM2xKY7V/ut0BK5mj7F2Xm8jFfSuQN2V MTYGRwVWascg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,304,1583222400"; d="scan'208";a="259238876" X-Received: from aedesimo-desk.amr.corp.intel.com ([10.7.159.171]) by orsmga006.jf.intel.com with ESMTP; 22 Apr 2020 16:29:20 -0700 From: "Ashley E Desimone" To: devel@edk2.groups.io Cc: Nate DeSimone , Puja Pandya , Erik Bjorge , Bret Barkelew , Prince Agyeman Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 3/3] EdkRepo: Update pull_latest_manifest_repo to use pull_single_manifest_repo Date: Wed, 22 Apr 2020 16:29:15 -0700 Message-Id: <20200422232915.18640-4-ashley.e.desimone@intel.com> In-Reply-To: <20200422232915.18640-1-ashley.e.desimone@intel.com> References: <20200422232915.18640-1-ashley.e.desimone@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashley.e.desimone@intel.com X-Gm-Message-State: 5cCIdwdSeo312ynVl1AKyOtGx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587598162; bh=z/eYqfMaRuUROELESlylWYWb/nUBrwf2Qs3RnjM0hHM=; h=Cc:Date:From:Reply-To:Subject:To; b=d3Fl4CGaFFPygf9VqrM2vkyvgdf2sTWic8hFaGaPOC0u6fKSfIHJgOr672l2eBsI2in 9nqGsUO9AeeevT4IQFYF44T0so0iWs5p2Okcn+ChJ2eXbFRGOqfzgg2Mm/RV6FGzQckoU AMwEAC5atbacxNcFNZ0TwSScEhboO2PWu8Y= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Updates the implementation for pull_latest_manifest_repo to call pull_single_manifest repo. Removes definitions of strings used by pull_latest_manifest_repo from common/humble.py and from the imports of common_repo_functions.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman Reviewed-by: Nate DeSimone --- edkrepo/common/common_repo_functions.py | 33 ++++-------------------------= ---- edkrepo/common/humble.py | 8 -------- 2 files changed, 4 insertions(+), 37 deletions(-) diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/commo= n_repo_functions.py index 0d39291..39b192c 100644 --- a/edkrepo/common/common_repo_functions.py +++ b/edkrepo/common/common_repo_functions.py @@ -46,12 +46,10 @@ from edkrepo.common.humble import COMMIT_TEMPLATE_NOT_F= OUND, COMMIT_TEMPLATE_CUS from edkrepo.common.humble import ADD_PRIMARY_REMOTE, REMOVE_PRIMARY_REMOTE from edkrepo.common.humble import FETCH_PRIMARY_REMOTE, MIRROR_PRIMARY_SHA= , TAG_AND_BRANCH_SPECIFIED from edkrepo.common.humble import MIRROR_BEHIND_PRIMARY_REPO, HOOK_NOT_FOU= ND_ERROR, SUBMODULE_FAILURE -from edkrepo.common.humble import MANIFEST_REPO_DIRTY, MANIFEST_REPO_MOVED= , CLONING_MANIFEST_REPO, SYNCING_MANIFEST_REPO from edkrepo.common.humble import INCLUDED_URL_LINE, INCLUDED_INSTEAD_OF_L= INE, INCLUDED_FILE_NAME from edkrepo.common.humble import ERROR_WRITING_INCLUDE, MULTIPLE_SOURCE_A= TTRIBUTES_SPECIFIED from edkrepo.common.humble import VERIFY_GLOBAL, VERIFY_ARCHIVED, VERIFY_P= ROJ, VERIFY_PROJ_FAIL -from edkrepo.common.humble import VERIFY_PROJ_NOT_IN_INDEX, VERIFY_GLOBAL_= FAIL, MANIFEST_REPO_NOT_CONFIG_BRANCH -from edkrepo.common.humble import MANIFEST_REPO_CHECKOUT_CONFIG_BRANCH +from edkrepo.common.humble import VERIFY_PROJ_NOT_IN_INDEX, VERIFY_GLOBAL_= FAIL from edkrepo.common.pathfix import get_actual_path from project_utils.sparse import BuildInfo, process_sparse_checkout from edkrepo.config.config_factory import get_workspace_path @@ -61,6 +59,7 @@ from edkrepo_manifest_parser.edk_manifest import CiIndexX= ml, ManifestXml from edkrepo.common.edkrepo_exception import EdkrepoNotFoundException, Edk= repoGitException, EdkrepoWarningException from edkrepo.common.edkrepo_exception import EdkrepoFoundMultipleException= , EdkrepoHookNotFoundException from edkrepo.common.edkrepo_exception import EdkrepoGitConfigSetupExceptio= n, EdkrepoManifestInvalidException +from edkrepo.common.workspace_maitenance.manifest_repos_maitenance import = pull_single_manifest_repo from edkrepo.common.ui_functions import init_color_console from edkrepo_manifest_parser import edk_manifest from edkrepo_manifest_parser.edk_manifest_validation import validate_manif= estrepo @@ -77,32 +76,8 @@ def pull_latest_manifest_repo(args, config, reset_hard= =3DFalse): branch =3D config['cfg_file'].manifest_repo_branch local_path =3D config['cfg_file'].manifest_repo_local_path init_color_console(False) - if not (os.path.isabs(local_path)): - #since only a relative path was specified it must be joined to the= Edkrepo Application Data Directory - local_path =3D os.path.join(get_edkrepo_global_data_directory(), l= ocal_path) - if not os.path.exists(local_path): - print (CLONING_MANIFEST_REPO.format(local_path, repo_url)) - repo =3D Repo.clone_from(repo_url, local_path, progress=3DGitProgr= essHandler(), branch=3Dbranch) - else: - repo =3D Repo(local_path) - if repo_url in repo.remotes['origin'].urls: - if repo.is_dirty(untracked_files=3DTrue) and not reset_hard: - raise EdkrepoWarningException(MANIFEST_REPO_DIRTY) - elif repo.is_dirty(untracked_files=3DTrue) and reset_hard: - repo.git.reset('--hard') - print (SYNCING_MANIFEST_REPO) - if repo.active_branch.name !=3D branch: - print(MANIFEST_REPO_NOT_CONFIG_BRANCH.format(repo.active_b= ranch.name)) - print(MANIFEST_REPO_CHECKOUT_CONFIG_BRANCH.format(branch)) - repo.git.checkout(branch) - repo.remotes.origin.pull() - else: - new_path =3D generate_name_for_obsolete_backup(local_path) - new_path =3D os.path.join(os.path.dirname(local_path), new_pat= h) - print(MANIFEST_REPO_MOVED.format(new_path)) - shutil.move(local_path, new_path) - print (CLONING_MANIFEST_REPO.format(local_path, repo_url)) - repo =3D Repo.clone_from(repo_url, local_path, progress=3DGitP= rogressHandler(), branch=3Dbranch) + pull_single_manifest_repo(repo_url, branch, local_path, reset_hard) + =20 def clone_repos(args, workspace_dir, repos_to_clone, project_client_side_h= ooks, config, skip_submodule, manifest): for repo_to_clone in repos_to_clone: diff --git a/edkrepo/common/humble.py b/edkrepo/common/humble.py index 64b9519..8ca38bb 100644 --- a/edkrepo/common/humble.py +++ b/edkrepo/common/humble.py @@ -34,14 +34,6 @@ MULTIPLE_SOURCE_ATTRIBUTES_SPECIFIED =3D 'BRANCH or TAG = name present with COMMIT I TAG_AND_BRANCH_SPECIFIED =3D 'BRANCH AND TAG name present in combination f= ield for {} repo. Using TAG.\n' CHECKING_CONNECTION =3D 'Checking connection to remote url: {}\n' =20 -# Informational messages and warnings for pull_latest_manifest_repo() -MANIFEST_REPO_DIRTY =3D 'Uncommited changes present in the global manifest= repository. Run edkrepo update-manifest-repo --hard to revert these change= s and sync the global manifest repository.\n' -MANIFEST_REPO_MOVED =3D '{}{}WARNING:{}{} The Global manifest repository h= as moved. Backing up previous global manifest repository to: {{}}{}\n'.form= at(Style.BRIGHT, Fore.RED, Style.RESET_ALL, Fore.RED, Style.RESET_ALL) -CLONING_MANIFEST_REPO =3D 'Cloning global manifest repository to: {} from:= {}\n' -SYNCING_MANIFEST_REPO =3D 'Syncing the global manifest repository.\n' -MANIFEST_REPO_NOT_CONFIG_BRANCH =3D 'The current active branch, {}, is not= the specified manifest repository branch' -MANIFEST_REPO_CHECKOUT_CONFIG_BRANCH =3D 'Checking out the specified manif= est repository branch, {}, prior to syncing' - #Error messages for sync_command.py SYNC_EXIT =3D 'Exiting without performing sync operations.' SYNC_UNCOMMITED_CHANGES =3D UNCOMMITED_CHANGES + SYNC_EXIT --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57887): https://edk2.groups.io/g/devel/message/57887 Mute This Topic: https://groups.io/mt/73209019/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-