From nobody Tue May 7 14:46:42 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57779+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57779+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587538557; cv=none; d=zohomail.com; s=zohoarc; b=hWPB1XuSIEKjbj0KfbMXDZicoyA9vOqOfmr+MFhQgmix9Dt4ewJ3mMfFhAcDTbt03gW0E5oyWiTUkvNf0VhOmXzAMTddowMN5PXVJ3KFRu15wM8d+B9mniqFTCrlJSP8LW+VY+Ps7f8PrEsTSi8zY8UTA9N91aDEiZeFozvCJpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587538557; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=lpJJv94PLVQVWYnNyQZRu51MY473LEDmYYnDbiwFk1o=; b=GpJ0lzy/7gZone+zAJB/crD+KXrk69050aNPAgKiIUuhHGHYt9FF1UIvPk6qMn5KrAQfjZXR0rJtm7mUUuVjS2hZDmtStxwgL7SYiL3+mYkOKwz+PrMBRjM6FPew3ag4F6AuXmCuFDOLF0roJp3VI9NmbVhhqqBr5E/UN4hdZkc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57779+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587538557471412.39178001673326; Tue, 21 Apr 2020 23:55:57 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7am4YY1788612xybz8SxUw6J; Tue, 21 Apr 2020 23:55:57 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.1671.1587538556254098038 for ; Tue, 21 Apr 2020 23:55:56 -0700 IronPort-SDR: zeVMn2p/Z4XW0zaQ/TLhC9y3ZYI6jzUdpzLnp4HNZPVtypX/HhJbZr7RcAWM12VOqZ5XPKcFHH /Bg1Y6ZbBC/w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2020 23:55:55 -0700 IronPort-SDR: eLZpAvFpdlXCGpgJdncgsGssG5FmS1dt58qOU+mPSblJiMMy+f4C6iTJZsiML6CUHMqtJPiUta ZPgrahVWqXKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,412,1580803200"; d="scan'208";a="255540778" X-Received: from shwdeopenpsi014.ccr.corp.intel.com ([10.239.9.4]) by orsmga003.jf.intel.com with ESMTP; 21 Apr 2020 23:55:53 -0700 From: "Wu, Hao A" To: devel@edk2.groups.io Cc: Hao A Wu , Eric Dong , Ray Ni , Laszlo Ersek Subject: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Add missing explicit PcdLib dependency Date: Wed, 22 Apr 2020 14:55:49 +0800 Message-Id: <20200422065549.10880-1-hao.a.wu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hao.a.wu@intel.com X-Gm-Message-State: E8fx64AD2qbNt6NS6NpUyhWZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587538557; bh=SPgO2Oa5H4g7PUBf/U3MgnRhOrPthi4L5wk3C21PCII=; h=Cc:Date:From:Reply-To:Subject:To; b=mbvyq7mVV2JoWT08u0D1/L/7CgJtJUqNdYaazB9sXgxCyg69F/XnlfFMQ6ZzJsRolfh 2tZLLY4OzR5/w8n0VP2rDWdg5BcdqirCjX7QMlzWu7wBATiITKCg2W2THuK/PHVrlwfJF NzFzI46Qph0FvJdguOpHK3gZwp2YJ62Wx9I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2632 Both PEI and DXE instances of the MpInitLib are using PcdLib APIs, but none of them list the dependency of the PcdLib in INF & header files. This commit will explicitly add such dependency in .H and .INF files. Test done: Library level build pass for VS2015x86 tool chain Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Hao A Wu Reviewed-by: Laszlo Ersek Reviewed-by: Ray Ni --- UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 1 + UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf | 1 + UefiCpuPkg/Library/MpInitLib/MpLib.h | 1 + 3 files changed, 3 insertions(+) diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/DxeMpInitLib.inf index a51a9ec1d2..9907f4157b 100644 --- a/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf @@ -51,6 +51,7 @@ [LibraryClasses] UefiBootServicesTableLib DebugAgentLib SynchronizationLib + PcdLib =20 [Protocols] gEfiTimerArchProtocolGuid ## SOMETIMES_CONSUMES diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf b/UefiCpuPkg/Lib= rary/MpInitLib/PeiMpInitLib.inf index d78d328b42..89ee9a79d8 100644 --- a/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf +++ b/UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf @@ -50,6 +50,7 @@ [LibraryClasses] UefiCpuLib SynchronizationLib PeiServicesLib + PcdLib =20 [Pcd] gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber ## CONS= UMES diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpIn= itLib/MpLib.h index 74e919dae0..a8ca03efb8 100755 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h @@ -31,6 +31,7 @@ #include #include #include +#include =20 #include =20 --=20 2.12.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57779): https://edk2.groups.io/g/devel/message/57779 Mute This Topic: https://groups.io/mt/73190361/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-