From nobody Sat Feb 7 05:01:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57515+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57515+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587137885; cv=none; d=zohomail.com; s=zohoarc; b=LZvveSbY1PyW+I2AOAXRc+OmBB43ekmj9mCW7vQTI7Vz+S/Xbgv09EM7YRu5W7r7xaPVbJmTllg7GlThNtSegE6darU1gKUwhxhm7Vqdeuj1YlSOqnIAB42twSlQMhrRbfaVR5lo4/yCsjn1axS0IUCd406yRM8zUqsWGaEVpdU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587137885; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=6Ch6EVD/6n9RPOdJ7jp6BD6OWX59XIaZzVIbgHL3XJQ=; b=fiG/wnGBaKI9/un9YywuUMwVKIy9r5DBcAVFo2uEa2yeA1PwjPS0dhKiqVCwibM8bGZB6Z+NIl/ERUNPYhllPnw5BErxLTBxgrZlwXpQA3X5UCVzSaifTIJpbB8duHURpHcQpfBu1LAteqv0MRgog0PrURSbLPMF9leTBiHEIt4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57515+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587137885140440.61823854846114; Fri, 17 Apr 2020 08:38:05 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rR7AYY1788612xZJm4C72Q9z; Fri, 17 Apr 2020 08:38:04 -0700 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web10.3689.1587137884069677684 for ; Fri, 17 Apr 2020 08:38:04 -0700 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-460-3iJg3JtyOdWs8_NZJc7dHg-1; Fri, 17 Apr 2020 11:38:01 -0400 X-MC-Unique: 3iJg3JtyOdWs8_NZJc7dHg-1 X-Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17EA08018B6; Fri, 17 Apr 2020 15:38:00 +0000 (UTC) X-Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-253.ams2.redhat.com [10.36.113.253]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1C1A6EF91; Fri, 17 Apr 2020 15:37:58 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Rebecca Cran Subject: [edk2-devel] [PATCH 2/6] OvmfPkg/ResetSystemLib: clean up library dependencies Date: Fri, 17 Apr 2020 17:37:47 +0200 Message-Id: <20200417153751.7110-3-lersek@redhat.com> In-Reply-To: <20200417153751.7110-1-lersek@redhat.com> References: <20200417153751.7110-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com X-Gm-Message-State: WbOL1BvnniCT88pgCw5bdGnDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587137884; bh=6Ch6EVD/6n9RPOdJ7jp6BD6OWX59XIaZzVIbgHL3XJQ=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=sZsbfO+y6Jj+fS8+7NLRI7ECQuvfP9LaAxchfyQlQERJlFXQOwZNFMDsSQ0JweeIARs MaMb60deYwANyBKVOC9cIkFtXNpAMN+VomZJtbzufkAjR3104rVXUbiypzmckI9/YSppr HUrpdnvvdajDocZw823x29fuPW+mH4jLho4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Annotate the #include directives with the interfaces that this lib instance needs from the included lib class headers. This will help us keep the #include set minimal, when we move code around later. While at it, synchronize the [LibraryClasses] section with the #include directives -- list BaseLib. Also #include the ResetSystemLib class header, which declares the interfaces that this lib instance implements. This forces us to spell out the "MdeModulePkg.dec" dependency too, under [Packages]. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Philippe Mathieu-Daud=C3=A9 Cc: Rebecca Cran Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2675 Signed-off-by: Laszlo Ersek Reviewed-by: Philippe Mathieu-Daude --- OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 2 ++ OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c | 15 ++++++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/Li= brary/ResetSystemLib/ResetSystemLib.inf index 063dc49f2453..af20f516c035 100644 --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf @@ -25,10 +25,12 @@ [Sources] ResetSystemLib.c =20 [Packages] + MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec OvmfPkg/OvmfPkg.dec =20 [LibraryClasses] + BaseLib DebugLib IoLib PciLib diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Libr= ary/ResetSystemLib/ResetSystemLib.c index b3abda80e75a..23816183a953 100644 --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c @@ -6,14 +6,15 @@ =20 **/ =20 -#include +#include // BIT1 =20 -#include -#include -#include -#include -#include -#include +#include // CpuDeadLoop() +#include // ASSERT() +#include // IoWrite8() +#include // PciRead16() +#include // ResetCold() +#include // MicroSecondDelay() +#include // OVMF_HOSTBRIDGE_DID =20 VOID AcpiPmControl ( --=20 2.19.1.3.g30247aa5d201 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57515): https://edk2.groups.io/g/devel/message/57515 Mute This Topic: https://groups.io/mt/73085500/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-