From nobody Tue Apr 30 03:26:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57455+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57455+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587022439; cv=none; d=zohomail.com; s=zohoarc; b=hgvLzfBBJg9ZOab+UCCUsMJ9L/mJ3uWrAE8LsDxFKUpHMfactaR9ne6WVYmtFu1+FRLj9F6AamidO2Tr6gfbW9o7bZtVY48E5/06AkTIErzzcaI1HKiRZovunuKDKtAYJwgDA4poybNu6cp/GBmeqp9LQem5rBOqwG6ufSuZBTU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587022439; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=zQbJmV/6WVOudSnmy5J1s3q079I2dPmfelgyKHdopQw=; b=kyCEauP+nd2ZK1zhGpfZnID4Id/Bybj3lGETxRqhhw4Uc21qbS0d8WmvbCHFErtYvA6XasUZ81MxzkiXk/s2FXR6kBkRlVeyo9gP4hQans6SGgMN4lF7HPhq/xEMjNHQb2lMmuKumrywE2BAyLzwj81S5MQNrH/K1H+k4olyuaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57455+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158702243922095.1507015475836; Thu, 16 Apr 2020 00:33:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CQUkYY1788612xm8RXvHpTaf; Thu, 16 Apr 2020 00:33:58 -0700 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2209.1587022437519145375 for ; Thu, 16 Apr 2020 00:33:58 -0700 IronPort-SDR: 6/1b3GiGrkCnmqUV+rdb90SS6CROlCVppw9l71gDutwqUKj7N0CGKAq89dZ0owe+UUkiD2ZZiR Enk8ltPeujZQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 00:33:57 -0700 IronPort-SDR: ggD/5/h/AMJVC+EfwULmFmTMFh3skqG6rNd8xOw0wF47vo4OI8kEVDXATpd+E1pWNQtt/Uwxf2 OLjG581/mm6w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="288803532" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2020 00:33:56 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Chao Zhang Subject: [edk2-devel] [PATCH v2 1/6] SecurityPkg/TPM: measure UEFI images without associated device paths again Date: Thu, 16 Apr 2020 15:33:49 +0800 Message-Id: <20200416073354.2232-2-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> References: <20200416073354.2232-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: KBLBu9u4xjcUS390qBb5vyQTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587022438; bh=peVqbOAWsQdQx5vsZ5zNagj0pCilKBq+0KSay7dw3YA=; h=Cc:Date:From:Reply-To:Subject:To; b=s+j1afx0NOBic4hNXwOYuxS/MrLUfplYYE2ma0+ST79bmo9Cs4YTIPclZVF6yPyjp2+ qEap9Vr5pTMzxXLhmUhenTCS5Pwz8JBKYkCIVd6J+V/sK06RyS1k07DE+fYo4aq2eP1DA 78EELfgdbrl16QHHaf4jC3HXdzULj2tSXPg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 DxeTpm2MeasureBootHandler() and DxeTpmMeasureBootHandler() functions may receive a FileBuffer argument that is not associated with any particular device path (e.g., because the UEFI image has not been loaded from any particular device path). Therefore rejecting (File=3D=3DNULL) at the top of the function is invalid. Fixes: 4b026f0d5af36faf3a3629a3ad49c51b5b3be12f Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Guomin Jiang Reviewed-by: Jian J Wang --- .../DxeTpm2MeasureBootLib.c | 20 +++++++++---------- .../DxeTpmMeasureBootLib.c | 20 +++++++++---------- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLi= b.c b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c index f0e95e5ec0..92eac71580 100644 --- a/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c +++ b/SecurityPkg/Library/DxeTpm2MeasureBootLib/DxeTpm2MeasureBootLib.c @@ -384,8 +384,6 @@ Finish: and other exception operations. The File parameter allows for possible = logging within the SAP of the driver. =20 - If File is NULL, then EFI_ACCESS_DENIED is returned. - If the file specified by File with an authentication status specified by AuthenticationStatus is safe for the DXE Core to use, then EFI_SUCCESS i= s returned. =20 @@ -398,6 +396,8 @@ Finish: might be possible to use it at a future time, then EFI_SECURITY_VIOLATIO= N is returned. =20 + If check image specified by FileBuffer and File is NULL meanwhile, retur= n EFI_ACCESS_DENIED. + @param[in] AuthenticationStatus This is the authentication status = returned from the securitymeasurement servi= ces for the input file. @@ -416,7 +416,7 @@ EFI_STATUS EFIAPI DxeTpm2MeasureBootHandler ( IN UINT32 AuthenticationStatus, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy @@ -435,13 +435,6 @@ DxeTpm2MeasureBootHandler ( EFI_PHYSICAL_ADDRESS FvAddress; UINT32 Index; =20 - // - // Check for invalid parameters. - // - if (File =3D=3D NULL) { - return EFI_ACCESS_DENIED; - } - Status =3D gBS->LocateProtocol (&gEfiTcg2ProtocolGuid, NULL, (VOID **) &= Tcg2Protocol); if (EFI_ERROR (Status)) { // @@ -615,6 +608,13 @@ DxeTpm2MeasureBootHandler ( // Status =3D PeCoffLoaderGetImageInfo (&ImageContext); if (EFI_ERROR (Status)) { + // + // Check for invalid parameters. + // + if (File =3D=3D NULL) { + Status =3D EFI_ACCESS_DENIED; + } + // // The information can't be got from the invalid PeImage // diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.= c b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c index d499371e7a..d990eb2ad3 100644 --- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c +++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c @@ -678,8 +678,6 @@ Finish: and other exception operations. The File parameter allows for possible = logging within the SAP of the driver. =20 - If File is NULL, then EFI_ACCESS_DENIED is returned. - If the file specified by File with an authentication status specified by AuthenticationStatus is safe for the DXE Core to use, then EFI_SUCCESS i= s returned. =20 @@ -692,6 +690,8 @@ Finish: might be possible to use it at a future time, then EFI_SECURITY_VIOLATIO= N is returned. =20 + If check image specified by FileBuffer and File is NULL meanwhile, retur= n EFI_ACCESS_DENIED. + @param[in] AuthenticationStatus This is the authentication status = returned from the securitymeasurement servi= ces for the input file. @@ -710,7 +710,7 @@ EFI_STATUS EFIAPI DxeTpmMeasureBootHandler ( IN UINT32 AuthenticationStatus, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy @@ -732,13 +732,6 @@ DxeTpmMeasureBootHandler ( EFI_PHYSICAL_ADDRESS FvAddress; UINT32 Index; =20 - // - // Check for invalid parameters. - // - if (File =3D=3D NULL) { - return EFI_ACCESS_DENIED; - } - Status =3D gBS->LocateProtocol (&gEfiTcgProtocolGuid, NULL, (VOID **) &T= cgProtocol); if (EFI_ERROR (Status)) { // @@ -912,6 +905,13 @@ DxeTpmMeasureBootHandler ( // Status =3D PeCoffLoaderGetImageInfo (&ImageContext); if (EFI_ERROR (Status)) { + // + // Check for invalid parameters. + // + if (File =3D=3D NULL) { + return EFI_ACCESS_DENIED; + } + // // The information can't be got from the invalid PeImage // --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57455): https://edk2.groups.io/g/devel/message/57455 Mute This Topic: https://groups.io/mt/73050532/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 03:26:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57456+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57456+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587022451; cv=none; d=zohomail.com; s=zohoarc; b=Y6k0mOeIetGt2Vw2Ho4wgMIwa564xxBefi0TH3YISxerebTKHRb1w8sCIGx3H2ZLEa7FkW4HJb67TegjwFfuP2s9dZX3zf8g9Jqn6TmhlAnfNKiST/1nKhdGKx+52MuFr2qTXTeojt0Qr4/DnAIkHrJP9XzSTi1n81XZytzFU68= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587022451; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=jHFeBdg1rxllOcZK6t2sBfav1ARZztdJ/QjwPyEJ5qE=; b=eqlRSeBzE3QNnFy+2/O/sk9ucWnJhMJMrdHjoCDRpRUAc5G6e2qxw+ZKoqemSUARjPyzE7Fas+bVpgU6R+k9njYVgNavU1JzV/4P3W0SfJzyz7AgE6ZEyZCy/9568POWNsUxGBzx17s/Ky8JSMn3g//Sdo4WOrALkGeh02v2QSg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57456+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158702245130886.12345458696825; Thu, 16 Apr 2020 00:34:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 5jeFYY1788612xtUrzSXbzzN; Thu, 16 Apr 2020 00:34:10 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.2211.1587022450060282729 for ; Thu, 16 Apr 2020 00:34:10 -0700 IronPort-SDR: /5B8OF4Yu5CBQWuEGeOYxaAbisK2Kq6mhP2OQcH2+nIXsN3ztX5IVtBJTNSJfrJwO8F09Lw2yd 3NueZxnkSFFg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 00:33:59 -0700 IronPort-SDR: RUXmoiPtbrt7Q1aEGbGbmOxKTiKR1BYZl5BWanRNSstPrHHo4RWjNWQNg+HqzGOv6nFNYETRyX seT/OtjG5MLA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="288803540" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2020 00:33:58 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Chao Zhang Subject: [edk2-devel] [PATCH v2 2/6] SecurityPkg/DxeImageAuth: Mark the File parameter as option Date: Thu, 16 Apr 2020 15:33:50 +0800 Message-Id: <20200416073354.2232-3-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> References: <20200416073354.2232-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: GBWcXnmPZzohIJ14MdFcBeuXx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587022450; bh=/C8eGtvrzcFvVCZwv2c61TZJpdvmPZHHZafjIdn+1hY=; h=Cc:Date:From:Reply-To:Subject:To; b=gQUYyPoyJqciTo+d7ErQShNaGoiqDcuDwrk/2UIn0s63/9sTscq/xjXwAbpW+c1Bc8+ kYW0UnfTrSrN8h+WwLIXzfLY166xgiWsCN+hsdnNg+HDt1g+YnuplbS/aU/Q5A/iCvueE 20pKdu466N0Fy99r9gxKAJp1JEEdaxL0uKU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 According to the File description, The File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Reviewed-by: Jian J Wang --- .../DxeImageAuthenticationStatusLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/DxeImageAuthenticationStatusLib/DxeImageAu= thenticationStatusLib.c b/SecurityPkg/Library/DxeImageAuthenticationStatusL= ib/DxeImageAuthenticationStatusLib.c index e4ddff21b5..ec77151c9c 100644 --- a/SecurityPkg/Library/DxeImageAuthenticationStatusLib/DxeImageAuthentic= ationStatusLib.c +++ b/SecurityPkg/Library/DxeImageAuthenticationStatusLib/DxeImageAuthentic= ationStatusLib.c @@ -32,7 +32,7 @@ EFI_STATUS EFIAPI DxeImageAuthenticationStatusHandler ( IN UINT32 AuthenticationStatus, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57456): https://edk2.groups.io/g/devel/message/57456 Mute This Topic: https://groups.io/mt/73050535/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 03:26:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57457+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57457+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587022451; cv=none; d=zohomail.com; s=zohoarc; b=XFXCopUDH6OzQmsQwLrrEvLrJVTsPf4dh0vDfGWCMZZymoqL/vkkXtAd6jHMJ1U5D6KxpEibMBti/Q7oL9Lnd2Nuer6qsrt2gYFuOLO2Fm2rM5sY/iwKx2GJJYMiQ1mz+fuzB3aA19nxo0Dab3tMTJyRzpHIleLoydlL9honX2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587022451; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=F5jSMahJ3oO5AHhGDFpklpsgthC5AEn3ihytYBTFzGQ=; b=WsY1++BEBgEhIACH8/0zFvTYV5BWolyN1zopBjnqAcXUa6hJ+2xtp9EM8L78yHNXuf6LADi8Zm09hcPjm2B8zd9xE7hCoNDht/EM+cGFR39AaA/Tobmyl8NuSPw+JgUnXunFvY8DnMPGM4EjzoIaTSibiQYzHwGIgdyjO2rCXQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57457+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587022451496509.06070067506664; Thu, 16 Apr 2020 00:34:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id j2SqYY1788612xpByy38gJ8C; Thu, 16 Apr 2020 00:34:10 -0700 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2211.1587022450060282729 for ; Thu, 16 Apr 2020 00:34:10 -0700 IronPort-SDR: mkrPsxwrqazmiNLQ61dCzsd9SytTvxwC6v+rPjocZqya7HzCEEmIRrz9EEDkuWACIoEqklduzo 9CKQlEDFdYJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 00:34:00 -0700 IronPort-SDR: Zz9nX+XT9Uc8NqcBtjK16U+/F1oEm6KVaUWNri0Xa1gwkeGjgga+2K9WfupOQTamsmj7uMA/YE MTUWtGhlAwFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="288803551" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2020 00:33:59 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Chao Zhang Subject: [edk2-devel] [PATCH v2 3/6] SecurityPkg/DxeImageVerificationLib: Mark the File parameter as OPTIONAL Date: Thu, 16 Apr 2020 15:33:51 +0800 Message-Id: <20200416073354.2232-4-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> References: <20200416073354.2232-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: en8gwQPpgBOyFrEYrDdM11xix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587022450; bh=xkTrRU2OfHGAGipPxWotttRak3R/FMTD8kK9bNuElRI=; h=Cc:Date:From:Reply-To:Subject:To; b=PkBoOkGPewbXKdBDKw+EPXDrSO3rZxWGzqzIKy2I6i/xbegSv7Fye+8US/5XOYvg0Yc doOLbnXOXyM+g6YPlGbd5ce0bi5PWNIKGWy6xlefLznfs7EBJSBJey9URBZvu5+5T8W7x qXXvmdJ2ZY8ra4LoQ2Wp9cL446iejMoB4KA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 According to the File description, the File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Reviewed-by: Jian J Wang --- .../Library/DxeImageVerificationLib/DxeImageVerificationLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificati= onLib.c b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationL= ib.c index b7fa8ea8c5..36b87e16d5 100644 --- a/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c +++ b/SecurityPkg/Library/DxeImageVerificationLib/DxeImageVerificationLib.c @@ -1630,7 +1630,7 @@ EFI_STATUS EFIAPI DxeImageVerificationHandler ( IN UINT32 AuthenticationStatus, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57457): https://edk2.groups.io/g/devel/message/57457 Mute This Topic: https://groups.io/mt/73050536/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 03:26:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57458+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57458+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587022451; cv=none; d=zohomail.com; s=zohoarc; b=n3BVLvPkZ4sGCzPSoBmiOeRlQ/s2vVe2KQH0YdW7cfS5iQvFQJH/Ag0Sk4ZUyRfAZebbwfkUkLnV5tXk3nESJTbFwKskS2VeP2wnQd03m1+1w2/EG1fkmYZqUGpu+y1t66dYmoO2x8pvoryK7VOT2HoTorbnZcxby3A0wvN4oks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587022451; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=An7meDR0yk3+XZkkKIKG6Ny5pMibyZZLUs5FrNkdxXU=; b=eEUaijS1/GWHdRl3sqF2Ak611nU1/frKzA3uMp3JAaWTTwUCX2bw0TvnwtJEvE75zTBO+MCA/2h5DhCECzJCgAuHCX2FKuC6XE3K0Z27O1TBFIhznc5NpwqzhEv7re9dK2mnN54A7HTnISloTnoR2evD4HfEzwwFbhd4dF7O9LI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57458+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587022451914858.3181120511668; Thu, 16 Apr 2020 00:34:11 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ffG3YY1788612xDD25NbctQH; Thu, 16 Apr 2020 00:34:11 -0700 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2211.1587022450060282729 for ; Thu, 16 Apr 2020 00:34:10 -0700 IronPort-SDR: nSba6SU2WhTWD+LXjfVHKYNbNIuU16FEyvggdLF2wf9Gt4rqa/nsErmqnYC+yYXvoWCvco7EX8 T7T3hx4MAflg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 00:34:03 -0700 IronPort-SDR: lJG1Y6AtzWeEz1Mb2rR2redkj/1ocLqEdBJn8VCSUBA/S9wl0AGV9kofwaUr5chLFfmPWqPtyM sd7kTvzuEkFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="288803641" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2020 00:34:01 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Dandan Bi , Liming Gao Subject: [edk2-devel] [PATCH v2 4/6] MdeModulePkg/SecurityManagementLib: Mark the File parameter as OPTIONAL Date: Thu, 16 Apr 2020 15:33:52 +0800 Message-Id: <20200416073354.2232-5-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> References: <20200416073354.2232-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: 3CiR8FvXCF4qLYTyFwCOiOFCx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587022451; bh=FKlLdGoj8Gjop4TZxhyf8KmVux5FcHOzYsAg7K3Z6Kw=; h=Cc:Date:From:Reply-To:Subject:To; b=wOaIM2VQS/eAn0DDiaVKrYVx9XHofKSPxwCM6BBY+G1NriC17PVXrW9pdTNsm50+smY CoopPnGzMkxl4A3vfi4lm4JZHvaGo2jL2AhqSuk03EjH5wfUH80lgcLsjLuwM25Teawh0 oCS8g6IRywDDEdyLhNdUPh6IfcOf5ZO0c9E= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 According to the File description, the File is optional and can be NULL. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Reviewed-by: Jian J Wang --- MdeModulePkg/Include/Library/SecurityManagementLib.h | 2 +- .../Library/DxeSecurityManagementLib/DxeSecurityManagementLib.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Include/Library/SecurityManagementLib.h b/MdeModu= lePkg/Include/Library/SecurityManagementLib.h index c6ef8c38b9..9bb29121af 100644 --- a/MdeModulePkg/Include/Library/SecurityManagementLib.h +++ b/MdeModulePkg/Include/Library/SecurityManagementLib.h @@ -261,7 +261,7 @@ EFIAPI ExecuteSecurity2Handlers ( IN UINT32 AuthenticationOperation, IN UINT32 AuthenticationStatus, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy diff --git a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManag= ementLib.c b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManag= ementLib.c index b541dbab3c..de1eb53183 100644 --- a/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLi= b.c +++ b/MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLi= b.c @@ -473,7 +473,7 @@ EFIAPI ExecuteSecurity2Handlers ( IN UINT32 AuthenticationOperation, IN UINT32 AuthenticationStatus, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57458): https://edk2.groups.io/g/devel/message/57458 Mute This Topic: https://groups.io/mt/73050537/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 03:26:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57459+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57459+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587022452; cv=none; d=zohomail.com; s=zohoarc; b=mn4NcBH4hNPfrw4WE4/d5GwqWTP0u+loVRtVyvHnBWmiQTBbqRt0YV/WOggk90pwfrQXJXw4QkHL404Mh7/y2GTbUgyyIMrO5su/2yfbztKUZjuCbU5NWxY54xnl/BYcPhW+fSheSrev/mKDX1qSt6vSI1UVx5Mo9OOdJm1hWpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587022452; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=lyy62o6hM6yWkvZfbnJaUq2RK0nK/+U4/emi2+lII1k=; b=aRPBYGwaIP4UPpE2R2vSHVEA5JejPdaF+wyk6Ixv0sRwY0SSrqOWt22sNEh/tH21OX5qidzRXiKN3zovJf3c/GXcuG8Rz2r6psT9ZQe7fOptLGZ6U2myN0DrIXSHIKzSpve48VU1u0BT1i5YguM60zHqr7EdUYzzLUzgznvDcDo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57459+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587022452014349.15912436141514; Thu, 16 Apr 2020 00:34:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 9eEmYY1788612xrKvesOj66k; Thu, 16 Apr 2020 00:34:11 -0700 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2211.1587022450060282729 for ; Thu, 16 Apr 2020 00:34:10 -0700 IronPort-SDR: E/3G17dpivM3wOv446nLOxqWUFcXBf38GWxjCzTA0f/tek3bvJxiVbTRcdUqJgoEpek2mghYnJ XsxqiEzRkUDA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 00:34:04 -0700 IronPort-SDR: t5+DExDub28ELpTPLcjxBSf/FfW7qIFgmLc4nDbqZxclacNgl+46bvwxC8YTw4RLlDWJDTbdLV Gii+tJ20mVEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="288803657" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2020 00:34:03 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Dandan Bi , Liming Gao Subject: [edk2-devel] [PATCH v2 5/6] MdeModulePkg/SecurityStubDxe: Mark the File parameter as OPTIONAL Date: Thu, 16 Apr 2020 15:33:53 +0800 Message-Id: <20200416073354.2232-6-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> References: <20200416073354.2232-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: TPEQTlFw5Z2ZR9qik1iDaQFEx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587022451; bh=1OuwlJ+1OPiZGveCwkxqbIMmNnj7gsz2KUb7nhQiRNM=; h=Cc:Date:From:Reply-To:Subject:To; b=LqQbPEKW4H8J2MOnaBmHNtpgb667W+kiQr/nyo1zv6pJT04mjGV9Q30TXyuXjKh+JxS BX6KHIOvawGcTKP+NLiV4Gmkk0iXW9ZY6hbz8RkSsxbcNB3cJ8ZMJds1cZYyhKWV6Nwy+ FIsOx/3vc+4jeb1VKNQOSeqAXNpmQPV13Pc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 According to the description, the File is optional and can be NULL Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Reviewed-by: Jian J Wang --- MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c b/MdeMod= ulePkg/Universal/SecurityStubDxe/SecurityStub.c index 3ed9527561..79f98b28e5 100644 --- a/MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c +++ b/MdeModulePkg/Universal/SecurityStubDxe/SecurityStub.c @@ -129,7 +129,7 @@ EFI_STATUS EFIAPI Security2StubAuthenticate ( IN CONST EFI_SECURITY2_ARCH_PROTOCOL *This, - IN CONST EFI_DEVICE_PATH_PROTOCOL *File, + IN CONST EFI_DEVICE_PATH_PROTOCOL *File, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57459): https://edk2.groups.io/g/devel/message/57459 Mute This Topic: https://groups.io/mt/73050538/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Apr 30 03:26:05 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57460+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57460+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1587022452; cv=none; d=zohomail.com; s=zohoarc; b=VcnLVG1SqXhI5bETkqKpIGlRwdUtsUT6TEnmv5sp+sLKpdufOY2GM/XWWjVo6ujmXKLxVGCtTUfKjneZCmtahKYXlVUvkLqkrSrdgN1gEG+R8x5vEu1nqslOBBlwB0NnARCefdXGVNvrKts94xurCgGb0L9AkJGGjOikgxCT1RQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587022452; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Ejn+myT+2eXRyQvohHPtmdexwcWn4DVuQLkksn/y/FU=; b=LGWu7OtAfQn+fJZpMtuBGaGL3Wo9/kwoZYQI57N9YI1LJ+tiC6S4wmAnDbDRXZ9mm3hA1PXQwH/vH9YoRMeViBdHqZAvxBuPszKKOox3tr1nU1/vdsmZeJ10eWJK+JEC1qadLV1wooyjgtL87XW/KfrcJ23s5oYC8SbTlNy1PiA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57460+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1587022452293850.3079480729167; Thu, 16 Apr 2020 00:34:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 8XLyYY1788612xowljCjIHx4; Thu, 16 Apr 2020 00:34:11 -0700 X-Received: from mga14.intel.com (mga14.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2211.1587022450060282729 for ; Thu, 16 Apr 2020 00:34:11 -0700 IronPort-SDR: J01MBLOU+dDNL7IUjTpdwubn8prxFCT3qZFsrosHUcxRRgxuqSUhZ3tU4kOVgtsrEf4TO5P6Ga 5FxJhbEPbNEw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 00:34:06 -0700 IronPort-SDR: fnifXK/3vLykt+ZhF7Lq7/syInYDzyEroQHeHIB0XywI7w/CZNnPqlYlmOi+gLMWbSaXCNArdf 6IApIZDzMt7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,390,1580803200"; d="scan'208";a="288803669" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga002.fm.intel.com with ESMTP; 16 Apr 2020 00:34:05 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v2 6/6] MdePkg/Security2: Mark the File parameter as OPTIONAL. Date: Thu, 16 Apr 2020 15:33:54 +0800 Message-Id: <20200416073354.2232-7-guomin.jiang@intel.com> In-Reply-To: <20200416073354.2232-1-guomin.jiang@intel.com> References: <20200416073354.2232-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: 1irgdMSssXo1KBw62UdkPD9Ex1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1587022451; bh=7doQcyYxnQ35qK+a+gwNugr/ryOZAIAWrvdiRCPl6KA=; h=Cc:Date:From:Reply-To:Subject:To; b=d/4MUwgVxNJnk6jkcfPh/5riC9IIAevg5qJOOqm2d0CbyDOboY8jIiLonVmtt4GjXRo P9pbmHPUEy5E66rSCCuWNpPBh1NWmtmI1UGG9kodDSBRLKZMXl/FHQ9EHFo1rlQrAa/Sd 9cfz3Yw9UAPlYhPVijdmXKaIVGO8WQNLz54= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2652 According to the description, the File is OPTIONAL and can be NULL. Signed-off-by: Guomin Jiang Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Jian J Wang --- MdePkg/Include/Protocol/Security2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Protocol/Security2.h b/MdePkg/Include/Protocol/= Security2.h index 2d85b4ba9f..6a63009956 100644 --- a/MdePkg/Include/Protocol/Security2.h +++ b/MdePkg/Include/Protocol/Security2.h @@ -80,7 +80,7 @@ typedef struct _EFI_SECURITY2_ARCH_PROTOCOL EFI_SECURI= TY2_ARCH_PROTOCOL; **/ typedef EFI_STATUS (EFIAPI *EFI_SECURITY2_FILE_AUTHENTICATION) ( IN CONST EFI_SECURITY2_ARCH_PROTOCOL *This, - IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath, + IN CONST EFI_DEVICE_PATH_PROTOCOL *DevicePath, OPTIONAL IN VOID *FileBuffer, IN UINTN FileSize, IN BOOLEAN BootPolicy --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57460): https://edk2.groups.io/g/devel/message/57460 Mute This Topic: https://groups.io/mt/73050539/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-