From nobody Tue May 21 08:43:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57183+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57183+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1586501647; cv=none; d=zohomail.com; s=zohoarc; b=aUnNX4cMiMQKsvJCS4iu8NgmD0NY+y11nkX779gjpl9Ip9/fP6oayloErFnhkIYGpDFio5hrtpAbj6CeqpH3y7Ue56y1Q/uchi5Z+j8s393KfZU8Be1t1jjqH5DGa0ToOIWfBXSeNnxpAvyhjKWJ/ykSnjuVIgmUx3Wy3x48Cto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586501647; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=Acd2JCr1lA86b4MD0f19Z4jFODTc9ErSFbMdesb/uFA=; b=mR7k7wWaDgrDh+bkWo1EN2ZZINFXXYKNPYrxARkzZ0ftk2+TLDph/Kec2JiqAgV+q48rWz8zSHjJmlWAz3qlheevrZVGGLfvHrwGYq/8qEYjpCEbxqNatp13hblsfrggbWxax3YBJvs0d8gkDNe+8NiRH7ostWcI7of0FZnUra8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57183+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158650164702667.49892652670178; Thu, 9 Apr 2020 23:54:07 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id NLa5YY1788612xXmGPjd7wLJ; Thu, 09 Apr 2020 23:54:06 -0700 X-Received: from mga17.intel.com (mga17.intel.com []) by mx.groups.io with SMTP id smtpd.web11.4523.1586501644904125037 for ; Thu, 09 Apr 2020 23:54:06 -0700 IronPort-SDR: Ps34UETgsfg6bIv1S7vusVT9jpM+9RO20aLftcnpCf4VHL5JHC3KsSJP29Tc1p7Mf8ZaQP4Xal 3hEvb2we3eiA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 23:54:06 -0700 IronPort-SDR: DkT1540kx9LbwZZlTi/5XLp1ThrX6Lnc/4hksQNXRU2hxH6F/+SuuFAyn+6wNoKrsT+YQk4ASS /dtJGXnfO6Ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="453423328" X-Received: from ydong10-desktop.ccr.corp.intel.com ([10.239.158.133]) by fmsmga006.fm.intel.com with ESMTP; 09 Apr 2020 23:54:03 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Star Zeng , Laszlo Ersek Subject: [edk2-devel] [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove Used parameter. Date: Fri, 10 Apr 2020 14:54:00 +0800 Message-Id: <20200410065401.966-2-eric.dong@intel.com> In-Reply-To: <20200410065401.966-1-eric.dong@intel.com> References: <20200410065401.966-1-eric.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,eric.dong@intel.com X-Gm-Message-State: uyfAF38qWCGi3ohRG2hU4jX0x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1586501646; bh=3nD/2xSjyPy26Ui/XJR0X+NbCz4Jn7cOGtCn3noJ8O4=; h=Cc:Date:From:Reply-To:Subject:To; b=o0SjrOnzvZ5TYc0jd05Awg7YbU8A3BRtXGyNP+05rDyPPD4puIFZlOgx01DJTSHyxeY 5eFTxdpvAhFzCtiLtwYahtOX2ujUb4xXs8WKpAZ2OkRfj14+nb3e/ElH/EZjP8IHveN7p tZyE5hj3nfI1auhEDldOZnoUoK8bUwaJC6Y= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2388 After patch "UefiCpuPkg/PiSmmCpuDxeSmm: Improve the performance of GetFreeToken()" which adds new parameter FirstFreeToken, it's not need to use Uses parameter. This patch used to remove this parameter. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Star Zeng Cc: Laszlo Ersek --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 10 +++++----- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 1 - 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxe= Smm/MpService.c index 93cac5e4fa..305bffa9bc 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -441,7 +441,6 @@ ResetTokens ( ProcToken =3D PROCEDURE_TOKEN_FROM_LINK (Link); =20 ProcToken->RunningApCount =3D 0; - ProcToken->Used =3D FALSE; =20 // // Check the spinlock status and release it if not released yet. @@ -1049,10 +1048,13 @@ IsTokenInUse ( } =20 Link =3D GetFirstNode (&gSmmCpuPrivate->TokenList); - while (!IsNull (&gSmmCpuPrivate->TokenList, Link)) { + // + // Only search used tokens. + // + while (Link !=3D gSmmCpuPrivate->FirstFreeToken) { ProcToken =3D PROCEDURE_TOKEN_FROM_LINK (Link); =20 - if (ProcToken->Used && ProcToken->SpinLock =3D=3D Token) { + if (ProcToken->SpinLock =3D=3D Token) { return TRUE; } =20 @@ -1104,7 +1106,6 @@ AllocateTokenBuffer ( =20 ProcTokens[Index].Signature =3D PROCEDURE_TOKEN_SIGNATURE; ProcTokens[Index].SpinLock =3D SpinLock; - ProcTokens[Index].Used =3D FALSE; ProcTokens[Index].RunningApCount =3D 0; =20 InsertTailList (&gSmmCpuPrivate->TokenList, &ProcTokens[Index].Link); @@ -1140,7 +1141,6 @@ GetFreeToken ( NewToken =3D PROCEDURE_TOKEN_FROM_LINK (gSmmCpuPrivate->FirstFreeToken); gSmmCpuPrivate->FirstFreeToken =3D GetNextNode (&gSmmCpuPrivate->TokenLi= st, gSmmCpuPrivate->FirstFreeToken); =20 - NewToken->Used =3D TRUE; NewToken->RunningApCount =3D RunningApsCount; AcquireSpinLock (NewToken->SpinLock); =20 diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h b/UefiCpuPkg/PiSmmC= puDxeSmm/PiSmmCpuDxeSmm.h index c9b3b739f3..7fb3a2d9e4 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h @@ -214,7 +214,6 @@ typedef struct { =20 SPIN_LOCK *SpinLock; volatile UINT32 RunningApCount; - BOOLEAN Used; } PROCEDURE_TOKEN; =20 #define PROCEDURE_TOKEN_FROM_LINK(a) CR (a, PROCEDURE_TOKEN, Link, PROCED= URE_TOKEN_SIGNATURE) --=20 2.23.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57183): https://edk2.groups.io/g/devel/message/57183 Mute This Topic: https://groups.io/mt/72915831/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 21 08:43:14 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+57184+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57184+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1586501648; cv=none; d=zohomail.com; s=zohoarc; b=oCKNw3p0dUsmqYur+eYpPsX0Bbp6l2Z0fK04NcKtFJweiEKRldacSIUJ0hL8UnmJtIp0yuDlZ6+VQllSuSw1RMurcpLDG8jAFSmO5hrsk46qtupFiEW4pHhKRbetv0HZrcY4uZ//VvhWGySUOJHZirBZ+LZryG00u+erS/CYY1U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586501648; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=9mbrirZ1X8dsC7K9b1GJYcCFAxzBa0yEQpyq42pUkzs=; b=T0D6g+zdE4Hvdc5XmInRiwnKMiW9hDepe+/+xDKnoFwWCudqH2vlUMbeJq3hZCnwcnh1FpFhL4sLsITxQNMZCLNSR0iK0nEZBa8BUrGtLnav1e70wdbbzNFrnyQJy8dB9iW6eNIL9io2rOA0dNC+7gSMmas8pSnjxauanmwFsLg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+57184+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1586501648250100.30343528074616; Thu, 9 Apr 2020 23:54:08 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AljKYY1788612xIoTRtKUnMa; Thu, 09 Apr 2020 23:54:07 -0700 X-Received: from mga17.intel.com (mga17.intel.com []) by mx.groups.io with SMTP id smtpd.web11.4523.1586501644904125037 for ; Thu, 09 Apr 2020 23:54:07 -0700 IronPort-SDR: nJ73lhXjc+DCY8MY35m3+uma8sXUXmEbiOp01wLEevD20lDZgpsTTCptQcJ9f3XR0qL3/tKmX6 AKTYfp6e6u0g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 23:54:07 -0700 IronPort-SDR: h4pyvtTLzk3KWXI1qDSHmRQk3QVXqrzJ6Vq1gGoP9/AilrMxKy6rHF1LfWpMxy/OS53BMg/Xlv F9NoLopXAiGQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,364,1580803200"; d="scan'208";a="453423346" X-Received: from ydong10-desktop.ccr.corp.intel.com ([10.239.158.133]) by fmsmga006.fm.intel.com with ESMTP; 09 Apr 2020 23:54:04 -0700 From: "Dong, Eric" To: devel@edk2.groups.io Cc: Ray Ni , Star Zeng , Laszlo Ersek Subject: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove useless code in ResetTokens. Date: Fri, 10 Apr 2020 14:54:01 +0800 Message-Id: <20200410065401.966-3-eric.dong@intel.com> In-Reply-To: <20200410065401.966-1-eric.dong@intel.com> References: <20200410065401.966-1-eric.dong@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,eric.dong@intel.com X-Gm-Message-State: ZC9aoiY1fFzB3ybUGzmHFSnAx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1586501647; bh=rtD6KXYY4tvXqDqiYz30qKJ7HfXPAnEYh6IrTmk83N0=; h=Cc:Date:From:Reply-To:Subject:To; b=Tx5GLsb+aHR1JFH2o+plZ9X7xv8ndk6J0fDbZaWi8wbAPBPPPagLAkYDtqWsuUluWIM 2B2wI94Gua/DKEFPnTXF5VScRyBT9h10/jNwA+t9puKJOo11FNQHURjUuwZSdWxyaZxaY 9X9IMdovhWBE2gjW1AYAoQW7TOwvzt3tKVg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2388 After remove Used parameter, below code in ResetTokens can also be removed: 1. The RunningApCount parameter will be reset in GetFreeToken. 2. The ReleaseSpinLock should be called in ReleaseToken function, Code in this function seems like a later fix if ReleaseToken not Release it. We should remove code here and fix the real issue if existed. Signed-off-by: Eric Dong Cc: Ray Ni Cc: Star Zeng Cc: Laszlo Ersek Reviewed-by: Ray Ni --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxe= Smm/MpService.c index 305bffa9bc..57e788c01b 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c @@ -433,26 +433,6 @@ ResetTokens ( VOID ) { - LIST_ENTRY *Link; - PROCEDURE_TOKEN *ProcToken; - - Link =3D GetFirstNode (&gSmmCpuPrivate->TokenList); - while (!IsNull (&gSmmCpuPrivate->TokenList, Link)) { - ProcToken =3D PROCEDURE_TOKEN_FROM_LINK (Link); - - ProcToken->RunningApCount =3D 0; - - // - // Check the spinlock status and release it if not released yet. - // - if (!AcquireSpinLockOrFail(ProcToken->SpinLock)) { - DEBUG((DEBUG_ERROR, "Risk::SpinLock still not released!")); - } - ReleaseSpinLock (ProcToken->SpinLock); - - Link =3D GetNextNode (&gSmmCpuPrivate->TokenList, Link); - } - // // Reset the FirstFreeToken to the beginning of token list upon exiting = SMI. // --=20 2.23.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#57184): https://edk2.groups.io/g/devel/message/57184 Mute This Topic: https://groups.io/mt/72915832/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-