From nobody Tue May 7 23:05:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56927+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56927+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1585887875; cv=none; d=zohomail.com; s=zohoarc; b=V4YpHlAMyH7iInuAPE2PI6lAiZ9JEchQ7Gim/fzqguI0k/E8f9L43PXXiWbjtWEeGfP9bAtkCs2KBGF7oqQUhTBiekw3KpbPxNhbqQFOkIYAzimk8zXJJ+sBARXS5s9V5T8nx2o58LpuubbkIgEkH4BtXEiDTr5CkbmdIkVvPGc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585887875; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=IG/ctbFnwLSkCQdi0mxPf/UhirQ4wsTSRtV4SgsWe1c=; b=nZfACOMkkU038uP58tTVkCqVY436E53HV+zyyED7k4eUUtCfDryANrFzd1dfLuGnlrF+AiiqYezkG9SjugPzZUO7/Etijg51pqpoz6dW2Kic4nlQBIJmHEKhVISnBFygPxy/EszQmw2gXgoNd5fT4HVgKPiWu/B3GKjt6OMkUfA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56927+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585887875353161.80908026510008; Thu, 2 Apr 2020 21:24:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id L5GOYY1788612xUyqSeG1aVt; Thu, 02 Apr 2020 21:24:35 -0700 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.4844.1585887874607629708 for ; Thu, 02 Apr 2020 21:24:34 -0700 IronPort-SDR: OZ4N0Px16L1tt9EIsY5/dBpIorf7cBCdjz7cEKVKQmaVTPbF9ObsgmzC2Qup/PRnD6fWSe4sZY w69zLG39Bk8A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2020 21:24:34 -0700 IronPort-SDR: rxMJhdqvg2DxS+AEUWChzU8Sf+f7v2JEvmxCvltwQTxwP6Aw1RKU8Pn8WBGkbgRblA8s10Dhgo 0hYXRLATMMbw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,338,1580803200"; d="scan'208";a="423397162" X-Received: from unknown (HELO guominji-MOBL.ccr.corp.intel.com) ([10.239.158.25]) by orsmga005.jf.intel.com with ESMTP; 02 Apr 2020 21:24:32 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jian J Wang , Hao A Wu , Eric Dong , Ray Ni Subject: [edk2-devel] [PATCH v2] MdeModulePkg/SmiHandlerProfileInfo: Overflowed Array Index Date: Fri, 3 Apr 2020 12:24:31 +0800 Message-Id: <20200403042431.1299-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: IbQ7mF1ZAEiU6BNhIMvUHOhEx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585887875; bh=gBlk6Oaers7BQBU/abSOi45j86AdNsCGNxwv0bZbYWw=; h=Cc:Date:From:Reply-To:Subject:To; b=gQM2M8m06XGc1mzSogcTJILJF5PwAZ4Ra5hM5hRDmCZUkdzllOcGDa/tizfnSQFR85r LwcA9TJpg8EznA8k/fURw78DDTp3FQyz5tddO9U8ao4CeatcfiNjc0rhnNQcHF68sT/JB iTWIEcSByISd7jpRJ6RsQeOCzkV2LYffYig= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2272 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2287 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2288 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2289 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2290 Index should be off-by one than size of array, so when check array, the max index should less than size of array. Cc: Jian J Wang Cc: Hao A Wu Cc: Eric Dong Cc: Ray Ni Signed-off-by: Guomin Jiang Reviewed-by: Jian J Wang --- .../SmiHandlerProfileInfo/SmiHandlerProfileInfo.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfi= leInfo.c b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfile= Info.c index 0f7163160b..4153074b7a 100644 --- a/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c +++ b/MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.c @@ -382,7 +382,7 @@ SxTypeToString ( IN EFI_SLEEP_TYPE Type ) { - if (Type >=3D 0 && Type <=3D ARRAY_SIZE(mSxTypeString)) { + if (Type >=3D 0 && Type < ARRAY_SIZE(mSxTypeString)) { return mSxTypeString[Type]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type); @@ -407,7 +407,7 @@ SxPhaseToString ( IN EFI_SLEEP_PHASE Phase ) { - if (Phase >=3D 0 && Phase <=3D ARRAY_SIZE(mSxPhaseString)) { + if (Phase >=3D 0 && Phase < ARRAY_SIZE(mSxPhaseString)) { return mSxPhaseString[Phase]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Phase); @@ -432,7 +432,7 @@ PowerButtonPhaseToString ( IN EFI_POWER_BUTTON_PHASE Phase ) { - if (Phase >=3D 0 && Phase <=3D ARRAY_SIZE(mPowerButtonPhaseString)) { + if (Phase >=3D 0 && Phase < ARRAY_SIZE(mPowerButtonPhaseString)) { return mPowerButtonPhaseString[Phase]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Phase); @@ -457,7 +457,7 @@ StandbyButtonPhaseToString ( IN EFI_STANDBY_BUTTON_PHASE Phase ) { - if (Phase >=3D 0 && Phase <=3D ARRAY_SIZE(mStandbyButtonPhaseString)) { + if (Phase >=3D 0 && Phase < ARRAY_SIZE(mStandbyButtonPhaseString)) { return mStandbyButtonPhaseString[Phase]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Phase); @@ -483,7 +483,7 @@ IoTrapTypeToString ( IN EFI_SMM_IO_TRAP_DISPATCH_TYPE Type ) { - if (Type >=3D 0 && Type <=3D ARRAY_SIZE(mIoTrapTypeString)) { + if (Type >=3D 0 && Type < ARRAY_SIZE(mIoTrapTypeString)) { return mIoTrapTypeString[Type]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type); @@ -508,7 +508,7 @@ UsbTypeToString ( IN EFI_USB_SMI_TYPE Type ) { - if (Type >=3D 0 && Type <=3D ARRAY_SIZE(mUsbTypeString)) { + if (Type >=3D 0 && Type < ARRAY_SIZE(mUsbTypeString)) { return mUsbTypeString[Type]; } else { AsciiSPrint (mNameString, sizeof(mNameString), "0x%x", Type); --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56927): https://edk2.groups.io/g/devel/message/56927 Mute This Topic: https://groups.io/mt/72742445/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-