From nobody Sat Apr 27 14:21:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56747+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56747+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1585652539; cv=none; d=zohomail.com; s=zohoarc; b=dpYM2pqUFG87FG4ilTVgXdDzkuao5MTKKqZSqsxmFKbbspVZ9luk8sRjbz+gb9i2ZYpHmJHJfBXRuusczV+yyJui5rWxZgpmop7fqpP16RQpwDKDlIOjfErcpyZNZDu6eAIUs1wL1C9nqZ3irWDFOjfOmg+LeaHXfTNT4OagIwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585652539; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=dkVYvnpPP4wue3b1NTvT8RBAsKJyqU4KdVzIZNtsZxY=; b=O5TcSFnRV4HBItVpRlxeLb2xtJ/JOu3CP/fR7bUCsm7yTzdwRvk8voiO+lFbQBQlKSAQN4KH2e0kc3eHxuxAkGOxRsekhXjAy0HaYichnoCz/5gg9yCBsFT8JjmJzvkrSNxv0FDz/Xuk6BTbsPiugmBRgffxTlAl6oNLoozAS1o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56747+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585652539117501.66945890380737; Tue, 31 Mar 2020 04:02:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id JhEsYY1788612xAEQJZVFcWQ; Tue, 31 Mar 2020 04:02:18 -0700 X-Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by mx.groups.io with SMTP id smtpd.web10.6668.1585652538297968163 for ; Tue, 31 Mar 2020 04:02:18 -0700 X-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02VAwsie189619; Tue, 31 Mar 2020 11:02:18 GMT X-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 303aqhfctv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Mar 2020 11:02:17 +0000 X-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02VB2H1l092418; Tue, 31 Mar 2020 11:02:17 GMT X-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 302g9x2bs4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 31 Mar 2020 11:02:17 +0000 X-Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02VB2Grd026182; Tue, 31 Mar 2020 11:02:16 GMT X-Received: from spark.ravello.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 31 Mar 2020 04:02:15 -0700 From: "Liran Alon" To: devel@edk2.groups.io, lersek@redhat.com Cc: sean.brogan@microsoft.com, nikita.leshchenko@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org, Liran Alon Subject: [edk2-devel] [PATCH] OvmfPkg/PvScsiDxe: Fix VS2019 build error because of implicit cast Date: Tue, 31 Mar 2020 14:04:52 +0300 Message-Id: <20200331110452.51992-1-liran.alon@oracle.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,liran.alon@oracle.com X-Gm-Message-State: uozrdbzBdj3H6ObW6THyYmLix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585652538; bh=TX5G8Dae8WL7JTJ7NIaG+gVVuj1IIXGNDSn/XG4qQqU=; h=Cc:Date:From:Reply-To:Subject:To; b=VrxNd6sqcBemKtqj4rsF5sj3DDba91Msl8fdL+5BPkAzfnVxbObIBldjG1i3himmQ0m RE5LNraIFFfpLWlifW6x1ptAcYD+XAnJgEODd/S0+omR5tQKBIiyVj5qi/5ALM+0H3W57 f6OWmCr6dnur6WN9CpC3i0yz7ob9WyccIAA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Sean reported that VS2019 build produce the following build error: INFO - PvScsi.c INFO - Generating code INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): error C2220: the following= warning is treated as an error INFO - d:\a\1\s\OvmfPkg\PvScsiDxe\PvScsi.c(459): warning C4244: '=3D': conv= ersion from 'const UINT16' to 'UINT8', possible loss of data This result from an implicit cast from PVSCSI Response->ScsiStatus (Which is UINT16) to Packet->TargetResponse (Which is UINT8). Fix this issue by adding an appropriate explicit cast and verify with assert that this truncation do not result in loss of data. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2651 Reported-by: Sean Brogan Signed-off-by: Liran Alon Reviewed-by: Laszlo Ersek --- OvmfPkg/PvScsiDxe/PvScsi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/PvScsiDxe/PvScsi.c b/OvmfPkg/PvScsiDxe/PvScsi.c index 0a66c98421a9..1ca50390c0e5 100644 --- a/OvmfPkg/PvScsiDxe/PvScsi.c +++ b/OvmfPkg/PvScsiDxe/PvScsi.c @@ -455,8 +455,12 @@ HandleResponse ( =20 // // Report target status + // (Strangely, PVSCSI interface defines Response->ScsiStatus as UINT16. + // But it should de-facto always have a value that fits UINT8. To avoid + // unexpected behavior, verify value is in UINT8 bounds before casting) // - Packet->TargetStatus =3D Response->ScsiStatus; + ASSERT (Response->ScsiStatus <=3D MAX_UINT8); + Packet->TargetStatus =3D (UINT8)Response->ScsiStatus; =20 // // Host adapter status and function return value depend on --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56747): https://edk2.groups.io/g/devel/message/56747 Mute This Topic: https://groups.io/mt/72673992/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-