From nobody Sat May 4 13:15:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56716+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56716+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1585626575; cv=none; d=zohomail.com; s=zohoarc; b=kjFRlZeF9LbGwd8H3QJ9vH2Mjrk1XvJrd2Ir/yGyH09ORAom8PJseT+uvPPtwAKF4vyalrd1ZxDx1lK3Igd1jX6w61OXjZEwKi6wqpwyyWDTBmu4ej/Fnfd2u+34IVHHsWzlPMVOpB28HHbLZF5OjaSaFxk8owBCrveNVOw106g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585626575; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=O+jdZyCalC8aC+bqR2BBNfqIvJSOnK5uF/wCpmAjHiE=; b=NiP9cZP7PbCJ6InwqszdDLAI5htyIVnKnw9xMLkDCzOdvY2o+PrVvijtvciMFQD7iKCHaU/Fs4FKPPXAxixaODyJamoejH9Ake4tgCCt+CkHCm/mjOLLEE/z5Psw0o0ryqNd36f5MuGwZmkzV4OTQd11Q2OQS5ydnTbOpo2L+c4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56716+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585626575770651.3054238430018; Mon, 30 Mar 2020 20:49:35 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id o0lbYY1788612xRSmqC2p136; Mon, 30 Mar 2020 20:49:35 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web12.2579.1585626574829899205 for ; Mon, 30 Mar 2020 20:49:34 -0700 IronPort-SDR: Y7HODZQ+Ve5xyhhd1k2Iq/VwUL4oFuoRt2L2nKM4XGrccddtWxkWsaA0Q0mkIkRSgv6dUu8R1N x9Upk1+AI7Cw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 20:49:34 -0700 IronPort-SDR: 0+7K4GxW+XtvRvYoZ8szQEQRheZ5xNerofZ5EUHne9n7eTorPdsmqjZ9xHibFSJpfo+rbrWKS2 fe5svf1FZTDA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,326,1580803200"; d="scan'208";a="450020862" X-Received: from unknown (HELO hengluo-dev.ccr.corp.intel.com) ([10.239.153.154]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2020 20:49:32 -0700 From: "Heng Luo" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao , Eric Dong , Ray Ni Subject: [edk2-devel] [Patch V2 1/3] Platform/Intel: Add all pathes of feature domains to package path Date: Tue, 31 Mar 2020 11:49:11 +0800 Message-Id: <20200331034913.1986-2-heng.luo@intel.com> In-Reply-To: <20200331034913.1986-1-heng.luo@intel.com> References: <20200331034913.1986-1-heng.luo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com X-Gm-Message-State: wXwiSuDCMazGyRWkbEMCg1LJx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585626575; bh=wPeLq44/JpITHYe4mMvknUJ0BOnEHexP1hiKcK1R7Ds=; h=Cc:Date:From:Reply-To:Subject:To; b=TLgi1UotWUX0CI4CUpGXLU8/4wYEedAqMwdu4R76KBymmgqGRWvlaBWId+WuD8dg1/d hkAfUXLMnxEnPPj4FmP8V4hTVnbzi7AiDqgZpJnZzyk+bM0/zGtWkkjcWxXvTXfq2RQIf rrdEuU3BdSaxipPhL4y2ijjkelAnxgP47+s= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 Add all pathes of feature domains to package path in build_bios.py. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo Reviewed-by: Eric Dong Reviewed-by: Liming Gao Reviewed-by: Ray Ni --- Notes: v2: - Skip adding folders that contains package contents to the PACKAGES_= PATH. [Ray Ni] Platform/Intel/build_bios.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index 1ef35aca0a..8f855f63eb 100644 --- a/Platform/Intel/build_bios.py +++ b/Platform/Intel/build_bios.py @@ -3,7 +3,7 @@ # Builds BIOS using configuration files and dynamically # imported functions from board directory # -# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
# SPDX-License-Identifier: BSD-2-Clause-Patent # =20 @@ -16,6 +16,7 @@ imported functions from board directory import os import re import sys +import glob import signal import shutil import argparse @@ -120,6 +121,13 @@ def pre_build(build_config, build_type=3D"DEBUG", sile= nt=3DFalse, toolchain=3DNone): config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_SILICON"] config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_SILICON_BI= N"] config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_FEATURES"] + # add all feature domains in WORKSPACE_FEATURES to package path + for filename in os.listdir(config["WORKSPACE_FEATURES"]): + filepath =3D os.path.join(config["WORKSPACE_FEATURES"], filename) + # feature domains folder does not contain dec file + if os.path.isdir(filepath) and \ + not glob.glob(os.path.join(filepath, "*.dec")): + config["PACKAGES_PATH"] +=3D os.pathsep + filepath config["PACKAGES_PATH"] +=3D os.pathsep + config["WORKSPACE_DRIVERS"] config["PACKAGES_PATH"] +=3D os.pathsep + \ os.path.join(config["WORKSPACE"], "FSP") --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56716): https://edk2.groups.io/g/devel/message/56716 Mute This Topic: https://groups.io/mt/72670486/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 13:15:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56717+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56717+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1585626578; cv=none; d=zohomail.com; s=zohoarc; b=OdNHNM8FxhrF6yE2MpK6rIUvxCgyKG47fmL0HC1bENKAHlu/v/RpiLtK8am5dSFXPUxRl+UMNUUIuZH/cKWQup9/TqsY8NGzTIXlnVlqg7Xgg4fiJ+TfVGGid2hPsV9QrGH9Vb2PzPBbbFvrdU7s9r64j8Z4TCRCms9StLWQ2Bg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585626578; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=7rWekuitJkse3esaMe/TWkjpRDKjArOGBEIH8yRQJaY=; b=E/KrgEWc5iZ4MD0naHi6/x+bvDrrwYH+ufv/ozLrjiVBVV4xNR/rp1akCvEKF9fHFirfKyfpexjourAgXcZ6OjkgTJSZX0weEaoeEQkktbIdH9J3II8ihnOTVyO+Ut9W+MnUIHRjsSp4jnGhfNt9WbRfRYn8UViyW2qH45KOZ0Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56717+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585626578261387.9718846019449; Mon, 30 Mar 2020 20:49:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id AtZQYY1788612xrIMGeSzLLL; Mon, 30 Mar 2020 20:49:37 -0700 X-Received: from mga07.intel.com (mga07.intel.com []) by mx.groups.io with SMTP id smtpd.web12.2579.1585626574829899205 for ; Mon, 30 Mar 2020 20:49:37 -0700 IronPort-SDR: y96gIQLTghLXxSg3/Z79rebsD+pvbfZEl8ADKb5TEJR1/WA+9vqfQx91+h5WTbixP9cyakiJRn 2V3EQlrwlN7Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 20:49:37 -0700 IronPort-SDR: 5aiENmOOoi45IcNsVb/YN7pQyCoDuFFHLblPUBc6hmukTUADcBx0OcZ/a8/fOIxU+3qDdMJMop pBte/lKugLhQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,326,1580803200"; d="scan'208";a="450020868" X-Received: from unknown (HELO hengluo-dev.ccr.corp.intel.com) ([10.239.153.154]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2020 20:49:35 -0700 From: "Heng Luo" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao , Eric Dong , Ray Ni Subject: [edk2-devel] [Patch V2 2/3] Features/Intel: Add LogoFeaturePkg to TemporaryBuildWorkaround Date: Tue, 31 Mar 2020 11:49:12 +0800 Message-Id: <20200331034913.1986-3-heng.luo@intel.com> In-Reply-To: <20200331034913.1986-1-heng.luo@intel.com> References: <20200331034913.1986-1-heng.luo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com X-Gm-Message-State: Mp0NqUmMnS8f10DITJ3gFCIsx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585626577; bh=UJcuH4hogx2/Jnv+rzCt9/Frb7Kp7VvZ1uiAVNYMvek=; h=Cc:Date:From:Reply-To:Subject:To; b=Xne4jxIFTSqKTU3MrT5ap6FjQqnGVEJ1ennRJv2xJrzPHYomm9z0rnFlnlUacxzRc4v z49AEM1hPPzJWQBaEoPHewm2z2G+J4OgoAzg1BbNjlop1EVzff5YJ2maJznhT63CafaCH daqBUanagqg8/4OiIFRMv4d2hSq3Jf8h8qI= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 Need to add LogoFeaturePkg to TemporaryBuildWorkaround because OpenBoard still includes TemporaryBuildWorkaround for building BIOS. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo Reviewed-by: Eric Dong Reviewed-by: Liming Gao --- Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildW= orkaround.dsc | 4 +++- Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryBuildW= orkaround.inf | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tem= poraryBuildWorkaround.dsc b/Features/Intel/AdvancedFeaturePkg/TemporaryBuil= dWorkaround/TemporaryBuildWorkaround.dsc index 227ae00908..c62f9ecc6e 100644 --- a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryB= uildWorkaround.dsc +++ b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryB= uildWorkaround.dsc @@ -13,7 +13,7 @@ # When the BaseTools update is complete, this file can entirely be removed # from this package. # -# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -49,6 +49,8 @@ gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable = |FALSE gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable = |FALSE gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable = |FALSE + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable = |FALSE + gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable = |FALSE !endif =20 # diff --git a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/Tem= poraryBuildWorkaround.inf b/Features/Intel/AdvancedFeaturePkg/TemporaryBuil= dWorkaround/TemporaryBuildWorkaround.inf index 74176d1989..00818fbe0a 100644 --- a/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryB= uildWorkaround.inf +++ b/Features/Intel/AdvancedFeaturePkg/TemporaryBuildWorkaround/TemporaryB= uildWorkaround.inf @@ -13,7 +13,7 @@ # When the BaseTools update is complete, this file can entirely be removed # from this package. # -# Copyright (c) 2019, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -40,6 +40,7 @@ PowerManagement/S3FeaturePkg/S3FeaturePkg.dec SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dec + UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec =20 [FeaturePcd] gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable @@ -49,6 +50,8 @@ gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnable + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable + gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable =20 [Sources] TemporaryBuildWorkaround.c --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56717): https://edk2.groups.io/g/devel/message/56717 Mute This Topic: https://groups.io/mt/72670488/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sat May 4 13:15:47 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56718+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56718+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1585626584; cv=none; d=zohomail.com; s=zohoarc; b=UvLK+xmpnpHy7MFT2Chhuh5TsW+xxCuhMZLe1GNcyGO2KfCYhra+NCegGYJCeLlB4Mz0P62zdIuHXupiq43yHzr79c53FFPzztxnATIyzsa/Sh2yQHukL3EbP3/BO6jxuJ8nEQxJTOyh9FOaxjKcIoXlbw95Clt2Fp4Gs5FQ28s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585626584; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=mmgavMbbfBg+99T2qNe8wj1dTDYxE8uIup3+1IgSWbI=; b=VL+j8jEqXNcOmS9l2JFhD6KIbIBOSXy3QFhOHD9X7v/Pf/lenwzauUEu8F/ULTwTAlStm/PD1qQQIvhpUriz7WhFTOzI+WsaCHeHsNSO5gqyWQRqnwKjIGETDjCmRw9gqsI15stY9G/hA/Yd+ytBSIVHOwWdQm1sutlC9H5+AXE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56718+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585626584052390.79063558544306; Mon, 30 Mar 2020 20:49:44 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 2aYyYY1788612xEFyEnQaqRp; Mon, 30 Mar 2020 20:49:43 -0700 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.2546.1585626583268406900 for ; Mon, 30 Mar 2020 20:49:43 -0700 IronPort-SDR: zbRGbFfTb+59R3D0kp0W/4oMoLi8ERWgeUIenjajPpDOG+Y6w8r2AdJkEp29ltJ1A2QEYCERQh XCeGEbWvtAtg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2020 20:49:42 -0700 IronPort-SDR: 047tTnbaRfGWTi9en6TeuJJx2p99YJz0vpmXLQchCufygLkZBOnNw8B7U4UbuXxZbDZbRzy7W0 4EsWZe+G0eNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,326,1580803200"; d="scan'208";a="450020908" X-Received: from unknown (HELO hengluo-dev.ccr.corp.intel.com) ([10.239.153.154]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2020 20:49:41 -0700 From: "Heng Luo" To: devel@edk2.groups.io Cc: Dandan Bi , Liming Gao , Eric Dong , Ray Ni Subject: [edk2-devel] [Patch V2 3/3] Features/Intel: Correct wrong codes and remove unnecessary codes Date: Tue, 31 Mar 2020 11:49:13 +0800 Message-Id: <20200331034913.1986-4-heng.luo@intel.com> In-Reply-To: <20200331034913.1986-1-heng.luo@intel.com> References: <20200331034913.1986-1-heng.luo@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,heng.luo@intel.com X-Gm-Message-State: leEI0ZVgSeLsASx9ndZbFatlx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585626583; bh=xSTd3K7AvoTuRMlftQ2Wvi685iy5jQZaIVLltzBUr0c=; h=Cc:Date:From:Reply-To:Subject:To; b=Bc4UAtYfKCwo4XoYYHQ4Lk1CmA5IkAtKtV15SM3/uvKno0OphVzY0YYqo2IA66ijc4T QhlMVQrVA9CWu94cQ7ZvBVipYust9XaV+uh9nPkbT5qvb/lmNRS2xCZ//AiXSel5i6WjU Fgu0NY/V7pgItr88pUjcT1S1qHs3/dmBV2Y= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2644 Correct wrong codes and remove unnecessary codes in LogoFeaturePkg. Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Ray Ni Signed-off-by: Heng Luo Reviewed-by: Eric Dong Reviewed-by: Liming Gao --- Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 9 --= ------- Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeatur= e.dsc b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc index fca0bfd540..d2dcdeb36a 100644 --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc @@ -25,15 +25,6 @@ !error "DXE_ARCH must be specified to build this feature!" !endif =20 -##########################################################################= ###### -# -# Packages Section - Make sure PCD can be directly used in a conditional s= tatement -# in a DSC which includes this DSC file. -# -##########################################################################= ###### -[Packages] - LogoFeaturePkg/LogoFeaturePkg.dec - ##########################################################################= ###### # # Library Class section - list of all Library Classes needed by this featu= re. diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory= .fdf b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf index 080c87223c..fead9f3b02 100644 --- a/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Include/PostMemory.fdf @@ -6,7 +6,7 @@ # SPDX-License-Identifier: BSD-2-Clause-Patent # ## -!if gSmbiosFeaturePkgTokenSpaceGuid.PcdJpgEnable =3D=3D TRUE +!if gLogoFeaturePkgTokenSpaceGuid.PcdJpgEnable =3D=3D TRUE INF LogoFeaturePkg/LogoDxe/JpegLogoDxe.inf !else INF LogoFeaturePkg/LogoDxe/LogoDxe.inf --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56718): https://edk2.groups.io/g/devel/message/56718 Mute This Topic: https://groups.io/mt/72670490/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-