From nobody Tue May 7 14:45:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56581+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 15855034860761000.5061040011798; Sun, 29 Mar 2020 10:38:06 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id qb6WYY1788612x092On6qnDv; Sun, 29 Mar 2020 10:38:05 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.44]) by mx.groups.io with SMTP id smtpd.web12.32352.1585503484874915048 for ; Sun, 29 Mar 2020 10:38:05 -0700 X-Received: from AM6PR02CA0031.eurprd02.prod.outlook.com (2603:10a6:20b:6e::44) by AM0PR08MB3796.eurprd08.prod.outlook.com (2603:10a6:208:100::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 17:38:01 +0000 X-Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::94) by AM6PR02CA0031.outlook.office365.com (2603:10a6:20b:6e::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 17:38:01 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56581+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 17:38:00 +0000 X-Received: ("Tessian outbound 8f06d475fc37:v48"); Sun, 29 Mar 2020 17:38:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7f4c4100174446ff X-CR-MTA-TID: 64aa7808 X-Received: from c4f4d59cd5cf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60290DF6-D8F2-49BF-89AF-59767B30EA43.1; Sun, 29 Mar 2020 17:37:53 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c4f4d59cd5cf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 17:37:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFRRyyj05Hb3JIJCmRYo8Vwpnrv/4nIrijOFar+5KDyxxGNRKw5HYazjpU52euy3X/kz7YLTVFemZslqLNTH5R30TlAlbgF7LC+mxDrYRTF93k2OkWPLoEZ5InE1VEYXWPtMHpZRwWF2bZTbr2OCdeCf94vZZyGvAPo1ewVE/Oe5oIsDHborSVq2S4UcKSzBM97uAYEuFczK6rLW8w5a+/KoBWw76TK3CI4loHEcgIFS+B9Vk7vd1ACikgWI9WCnNh9yN1ICc8xVUOVRaecakJg9OOmyGsBrHwHdOTh09Yony+5yCvgRbto+em3Wp8WyUw9MDBGuG1VqhTJg4FFWmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhHbA+K/sGLvt5xl9fx2IGUT0ygwanJUmfp7C1sFPNs=; b=A7kktgmp0LW6m3JlD9wEcV3EZ8tWRZMiWypxQWaqKNmWBWbx7w9/62JZDAtN6ULUjTbXdHxwv5FsfEHxU4YqCQrChDKZP3T4tIe8QVVCd14BnCxTwmD+OimxyJiIFfAKHBlQeAHKcD4+9RCU5DvKCWczrxKHyt56AY6oWwHNfHLXF7GnI6yYXGf2q4Evq48HSZSCb8vTIlYsyqo+89I8S0+pwvIPU2XPgCJL0MLSeEIu5OJmqc5iW3PG181BKrSLQGiwDmiVTvuEm9wtexiLzktcTmxV5JCVVuypbgQfQkJ4T47uFaAkD8qONwAM6j/JB6amwtYIwP7AfO4lGzcvOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR04CA0027.eurprd04.prod.outlook.com (2603:10a6:20b:92::40) by VI1PR08MB3888.eurprd08.prod.outlook.com (2603:10a6:803:b8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 17:37:52 +0000 X-Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::75) by AM6PR04CA0027.outlook.office365.com (2603:10a6:20b:92::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 17:37:52 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 17:37:52 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 17:37:50 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 17:37:50 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 17:37:49 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , Subject: [edk2-devel] [PATCH v1 1/2] DynamicTablesPkg: SRAT: Fix entry points Date: Sun, 29 Mar 2020 18:37:47 +0100 Message-ID: <20200329173748.7288-2-sami.mujawar@arm.com> In-Reply-To: <20200329173748.7288-1-sami.mujawar@arm.com> References: <20200329173748.7288-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(136003)(396003)(39850400004)(376002)(46966005)(8676002)(44832011)(47076004)(2616005)(426003)(8936002)(81166006)(81156014)(336012)(4326008)(2906002)(356004)(70206006)(70586007)(36756003)(316002)(478600001)(82740400003)(54906003)(5660300002)(7696005)(26005)(6916009)(186003)(1076003)(86362001);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8fb9b9e0-c6b1-4793-49cf-08d7d407ed68 X-MS-TrafficTypeDiagnostic: VI1PR08MB3888:|AM0PR08MB3796: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YzJ//8Cfb/zkuTtbu2NPY6WYRd3OXBoxs9Pl4zAyb2oVm3PgAqAzA2D60k82aXTC6Q15RA9uPEMdgbFSeHjkfaAXjKiCqZjnmziW5RWkaK3Qt93IotNv3GvzogJ73ookwp+y4/flPvZ/We3dziDJ03h4dTXU8lLNdd9AYe5TJ8dw5cSJQLJH3v4Y9nwNfSCwB2/eNOgy/DmwtpsQq8bNYyAkQIbEzt9ZCV3Jr2EyuEM8aDXRmZUluaacqb0kQbVERFHIpUHSTAAY3syCliiburclFZ5gbqT3kvCTpqRek+/fHKk2mgP6Ipqj8JnS3cH48tfuJzDSNYrkpxi5RQhbsxZmrL9aFUPq08j8+/Z6Go/UTJZMUBY9ogLQedow9IkLbrsoHxxisooeVBl1nIrZ9Cu5uoGETJTpb05+uLkVPVvQCokKf+uNP0YsPmFQOQCy8pV0Dr6+KFGo/Ho/krWOb8GPvQnzCrrtBMthYs8i6rVnoBSnW4w1S3HOTA/Pc0Yas4sCUADvbiHCZwp7rvji3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3888 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 29e6de44-4694-4c19-4d48-08d7d407e863 X-Microsoft-Antispam-Message-Info: Se0y9RmqPnPjrD7vatn/hz5eEaObD/94gFNCf3VUuK9M3REXRWB6jv11hN1B5NhNh8azq2tHcAw/Ls3ardh31ohav8Inikqz9oJYZMOkJOtprp521iphfoB0aTGLOEivTqYtp1LwPbV9UO9JAwNPKff1TD+EygxUwUXCb85Vka6JDyuzk35fWOFgblNMEAbovY9aKO84PejHL04XFW9DZUUYikyKBWibzMAThcpT2Hs7YtfxGk7esPdt5V3Gu+8wbkWYCE1cswpRoEHfEVb/Z9LCRSgqdUeHMX86QxgxdJItSHRSEBDnrZ8Dut0NLgWWBJLBpfgh4iwNDgriO1AaqREmrOGoMbFMgG7elWzen320rvBpCPAlhpP7XIyKKyOIMZTHolSDq1JziHOoxH4OXKVsvnpe425kczl+h0ly0MHYyDqXmE0t5a6ddmMG1sfN/3XyWuW/Y+WAzBxHTvLccsToeznWt2B1TvADyFUyMzhp7KInL1/UNzpKftXUmoSRANIDRcJRiSSjll2a10kDGg== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 17:38:00.8048 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8fb9b9e0-c6b1-4793-49cf-08d7d407ed68 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3796 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: UrTJE27thWJPqrsMvdCHpT2qx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585503485; bh=YZ4YPJ2dag5CN3g7Z2sSgqGpyH6bJqyfhEhGb2cpeQ4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=vKWqxlSONlWmtXF9Ns3oQZ4j5ju+5w1HSPAxOVLk5OEODB0y6bNnP4PXPjXUO0JoEu+ /Cyqij66Y1/zO6pUoUfMpAsYARiRhwJ38xU709x8NcqR8g0iKjMXSnSTqvKt9k5EqR3R0 nJzez5X3TsnzspFey3YBBLJRDS84dtcRke8= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" VS2017 reports 'warning C4028: formal parameter 2 different from declaration' for the library constructor and destructor interfaces for the SRAT Generator modules. Remove the CONST qualifier for the SystemTable pointer (the second parameter to the constructor/destructor/DXE Entry point) to make it compatible with the formal declaration. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 8 ++++-= --- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c index 5d56af66608d862e6eca81da812d719f110867d2..74cb7d92a5d8cddd3df8334f3ab= 55e6fa3e7267a 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c @@ -800,8 +800,8 @@ ACPI_TABLE_GENERATOR SratGenerator =3D { EFI_STATUS EFIAPI AcpiSratLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -823,8 +823,8 @@ AcpiSratLibConstructor ( EFI_STATUS EFIAPI AcpiSratLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56581): https://edk2.groups.io/g/devel/message/56581 Mute This Topic: https://groups.io/mt/72634737/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 7 14:45:49 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56580+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158550348520357.89753751610101; Sun, 29 Mar 2020 10:38:05 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 4fvjYY1788612xXaMZJ2AjNa; Sun, 29 Mar 2020 10:38:04 -0700 X-Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.54]) by mx.groups.io with SMTP id smtpd.web10.32258.1585503484137975557 for ; Sun, 29 Mar 2020 10:38:04 -0700 X-Received: from AM0PR06CA0002.eurprd06.prod.outlook.com (2603:10a6:208:ab::15) by AM0PR08MB2948.eurprd08.prod.outlook.com (2603:10a6:208:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 17:38:01 +0000 X-Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:ab:cafe::30) by AM0PR06CA0002.outlook.office365.com (2603:10a6:208:ab::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 17:38:01 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56580+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 17:38:01 +0000 X-Received: ("Tessian outbound fb361fb66447:v48"); Sun, 29 Mar 2020 17:38:00 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2479ea69fde19ac0 X-CR-MTA-TID: 64aa7808 X-Received: from 91026d27973c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA6FD261-22CC-4778-8C41-129FF6787077.1; Sun, 29 Mar 2020 17:37:55 +0000 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 91026d27973c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 17:37:55 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f3+dLtB1K9RJRY6DbzwAV14iwfkPXaUgeS3yNNcwnpH708/b4dZ50K+tuamkl1iLI92kZAbqRUE/PJJb2GufnHxuKsif5W9FchKoDfurd7ui2Wq4tBY/0TzWYMKTeMf/r5FWiqNvq0Bu1kHQFvOKBQyOGSx0e24Fmwczuz/pwEiJsT54r3sD7T3ViTDyBRyyeJPpI/9J6lezmUVmoZ02yNoN4vgFKHQLjW2s4KZh6+O8h1IVsjj6/K7llp1YxzEerlaqVz99lgXV96EbA9BzfyWSGwLnRfeY46f6M84Xs3x0KX8/2V/rsaQt08UjHdwOe2PUvMEKyd4cv3+tkxGv4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vrcZnodo9oeA5EkJovAfB66qSSz90n1c2CpgT3KnTxI=; b=GtOrEd4tRyU2gd6Lj4bKRxq8zw7I939k7AdEEnsNLEBj4HJGsd+cXUV9/zsxgdjQg/KSboskrXc7u3ZG7RQSY1k5dHjuQkwDL1qUp9a8yo+cj7x0aTkddFhN7OOkKQi+AStM7bb6Nu0nsN43ZoQb2GeYWsj5E5yPdoRBJ7RYaQ0mGt53Ky4uvOmJbqRjAp41FXETB4Gy6IxeJUEsx5FzoEUexxTsRnAJJUHzdTeyr88dYaKozvj8NYduPusRBQuJmdzlTVG2WMvDOpueIuREOpLHz5jeCckoEZavkb2FmIfrMl2rpOs0I4LPkTk8LC7inP/jgLEfKGjv9/Ui8BpUDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM6PR04CA0028.eurprd04.prod.outlook.com (2603:10a6:20b:92::41) by AM6PR08MB4469.eurprd08.prod.outlook.com (2603:10a6:20b:70::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 17:37:53 +0000 X-Received: from VE1EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:92:cafe::45) by AM6PR04CA0028.outlook.office365.com (2603:10a6:20b:92::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 17:37:53 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT054.mail.protection.outlook.com (10.152.19.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 17:37:53 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 17:37:50 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 17:37:50 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , Subject: [edk2-devel] [PATCH v1 2/2] DynamicTablesPkg: SRAT: Fix uninitialized memory usage Date: Sun, 29 Mar 2020 18:37:48 +0100 Message-ID: <20200329173748.7288-3-sami.mujawar@arm.com> In-Reply-To: <20200329173748.7288-1-sami.mujawar@arm.com> References: <20200329173748.7288-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(396003)(346002)(136003)(39850400004)(46966005)(7696005)(4326008)(186003)(336012)(2616005)(70586007)(44832011)(5660300002)(2906002)(8936002)(36756003)(426003)(1076003)(26005)(86362001)(82740400003)(47076004)(81166006)(8676002)(6916009)(356004)(81156014)(70206006)(478600001)(54906003)(316002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e2cba38-8261-40c4-b24c-08d7d407edb3 X-MS-TrafficTypeDiagnostic: AM6PR08MB4469:|AM0PR08MB2948: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: U8xXefg+rh9VkJM5oSYvuxHJAIhHK1e5wFgJPKZosiGzUcqp2jkaHUN9fT4L4mPCza/V9Rugnoy/qigIEE1Z6uZDtw/2HceSdJYB5mDIDFovomI+AM8eo8ccW0rF9/vqzJW8dxDsMBH6FNWZEh4Zo7E2SkUl7DB0285GmYuulyaHdOHP/Z4vFKgv2SBYiZntYNIJm3LY7+7uQ/AKB23h/qSt4FepoSNryFYmcs4OgEnpr8p8nZ+HXAcr2tSmJkiLWT644ZWO/fHZ5F5VlcCWu8g92a5JwhbyecTd4S3m+Z/++je5qnXVHOeWaWXghO5cMXh9rzmDuuh7QYCh4MtZTIqIgZz01I2l+x9886yNmRkQxwJ/q9kjwaXF8/0kS98/OT4/yPg86SINcJJaE844cNAQIjIHRFLCnv3ggE6Kh2Kiy5c2irWFjVGfW8k9nBniIx7jH19j4F2zTl+siuDTzhzPWUZOgN6c8+eyr9cxhbbdEnvzs4DCZwZ07pTShA6Z05k616VeC0nHf7kHpX3hxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4469 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: d19c47c5-8ee8-4b20-e7c9-08d7d407e903 X-Microsoft-Antispam-Message-Info: HGK/kf9I0mYRYoW7/FBtMuZ3utWtuGSJ69sm0R/hzhIBjZnQhumb2ohX2jxZZ7M5KOLG72DVB/e6ZboDoqzZ8tAFUlwhIl6zhJx98TCoWB+PyGCC6CH1zjFTTLFal7qlELVFU34rvnVIJHuYmJHKoX8bFdHsjTmbQQdHuASRCBnT/zvX2mNdHQWcifDxUAyZP5JL9lwaHYzGTuF3LhgT+nGnYi3xzW+kQU4JjnOt8IJn551p+EPDvkg63Do3u19IVpr3Il2pkxV4eF98te1kv+jInB+fyL8UOYNjSQEpQ+7mjUpwrXvcgCx6knJofD0uzMvm8pCRHATNByrU6tsIYcH6KCB7xsswiMN5ZNGzqaLkPvEpuFlH+u6zED0h141yH1Rrjbz7+4ZS3V1Pas9aaYjacaCjUdwe0Z5FRB42v9Ojej4YOdswe8sFxzTeyBZKHCxFpxI/G/zi6dG0GJ4iDiu6y3n+mrtCZEl/ytoRVe84MiqPlbcxSNsPze7oQqRYwup1PFiP6iFkK1J/kw9YyA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 17:38:01.3020 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e2cba38-8261-40c4-b24c-08d7d407edb3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2948 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: ZUt6FUA54nt0CXgvMxPyVTcxx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585503484; bh=93+xcBhz5utNJ0BfIwz4dXHdpGGkZSC8see5MBpdvGw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ogTFHhn8ke+APlT8MoW5wJov9w2UMCfxNkeDQ7mxk58aRlslBPYKwqVTG2sZvN/IrEr BzU9BbVBaCQj+T/fwMY2poCwBDsTy6EF0gFVbsbs4gmy3QTyEZQXA7NgxDNLXF9GXaG7M LAqtxoVo0wdTvK0DlrUGtAnGHkO+kIO426k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On enabling the /analyse option the VS2017 compiler reports: warning C6001: Using uninitialized memory. This warning is reported for the Status variable in AddGenericInitiatorAffinity() as it is not initialised to a default value. This condition is only valid if GenInitAffCount is equal to 0. Since GenInitAffCount is already checked in BuildSratTable() this condition can never happen. The value of the Status variable is returned in failure cases from appropriate locations in AddGenericInitiatorAffinity(). The only case where Status value is being used un-initialised is the return statement at the end of AddGenericInitiatorAffinity(). Therefore, to fix this issue EFI_SUCCESS can be safely returned instead of returning the Status variable at the end of the function. Signed-off-by: Sami Mujawar --- DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c index 74cb7d92a5d8cddd3df8334f3ab55e6fa3e7267a..620e2929ef2460b6bf318fa85f8= bca984608b955 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSratLibArm/SratGenerator.c @@ -413,7 +413,7 @@ AddGenericInitiatorAffinity ( GenInitAff++; GenInitAffInfo++; }// while - return Status; + return EFI_SUCCESS; } =20 /** Construct the SRAT ACPI table. --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56580): https://edk2.groups.io/g/devel/message/56580 Mute This Topic: https://groups.io/mt/72634736/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-