From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56562+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494852155255.15786661516893; Sun, 29 Mar 2020 08:14:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id X3UjYY1788612xmOyGus8XLf; Sun, 29 Mar 2020 08:14:11 -0700 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.53]) by mx.groups.io with SMTP id smtpd.web11.29109.1585494849175340686 for ; Sun, 29 Mar 2020 08:14:09 -0700 X-Received: from AM6PR10CA0075.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::16) by AM7PR08MB5480.eurprd08.prod.outlook.com (2603:10a6:20b:de::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:05 +0000 X-Received: from AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::be) by AM6PR10CA0075.outlook.office365.com (2603:10a6:209:8c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:05 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56562+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT058.mail.protection.outlook.com (10.152.17.48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: ("Tessian outbound 6835489d965f:v48"); Sun, 29 Mar 2020 15:14:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 15fe5b8463a5cc43 X-CR-MTA-TID: 64aa7808 X-Received: from d6890710da30.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DCC5E2A3-245E-461E-8673-446DF4528823.1; Sun, 29 Mar 2020 15:13:59 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d6890710da30.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:13:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=faju91s+ojAEIgIxVJ8OqEL9+oqozp5J5pFNDJMxSrnI/vtjOb7hC/gofvbvCPGsXOUC6SXcfaSaR+aFpd4SzYtz/CgptiYlWlZoX8ScYyE0jxzLh4flw9dQH6ML9otzwgl7q4XN58K3D841qRZC2mEsLh5deOEzwVE5k3C35afBFJTDo1koDLWdUwWoG4RnCwTTOo0jZAxc6LtbonRrl7Hi7XIMLQsaOgWoscEe7KvLKtXElMfF+pz2z2vnUHWr/VW49fd4BdeuB6J5Z4g5l+zHZpq7AmHP+sxawuBbGYtAlXEwFqDYMY22rjn1UqL4jzGTMIPlOgQFYHF87z0QGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CcNnRnzfokGSANO40K0HZWoUFh7LeWPQo2lFOFIxbaI=; b=k3bZiAPoG4+wCiwP4G9/pjLmhKhpmRCKtaG3TgDBixZfRx+16iKAbcUTLUJSXLK3vfp1bFtEPd6WkOrK+0jXigsKVbjPiCApB3AhiBg7+wu5mqbYUkp3XKMjTdrKdHU+gsAQ2b+iQhwvRezM5jsGx3ZbXpJE1pcfplE7cc4hIjFm7PGnt3FT0CgNMd6cGHBPU3LmJ6AVJvZ8xh5CjFq2+xVz6+f2nrhlPna6H6pZKWytZqyV645Wew6gLsE/FwZoWO/Mn8S7mklq5qRxHIXeZRaAK5KJT0otiz7WXeUCRwMYcfHxvWE9A9jceaYsEcfnjaaYp+N/0vzKb9wuxDZA8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM5PR0602CA0005.eurprd06.prod.outlook.com (2603:10a6:203:a3::15) by DBBPR08MB4904.eurprd08.prod.outlook.com (2603:10a6:10:f2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:13:57 +0000 X-Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::3b) by AM5PR0602CA0005.outlook.office365.com (2603:10a6:203:a3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:13:57 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:13:56 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:54 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:54 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 01/16] DynamicTablesPkg: Fix entry point param definition Date: Sun, 29 Mar 2020 16:13:38 +0100 Message-ID: <20200329151353.14096-2-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(39850400004)(396003)(376002)(136003)(46966005)(47076004)(86362001)(5660300002)(8676002)(1076003)(36756003)(8936002)(6666004)(966005)(356004)(316002)(70206006)(186003)(26005)(54906003)(82740400003)(2906002)(81166006)(30864003)(81156014)(478600001)(2616005)(70586007)(19627235002)(44832011)(4326008)(7696005)(426003)(336012)(6916009);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 661acc21-311a-4a0a-ba7d-08d7d3f3d203 X-MS-TrafficTypeDiagnostic: DBBPR08MB4904:|AM7PR08MB5480: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4941;OLM:4941; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TXVUtvByCRNLdg+D8XAsENyEhSKSiWoJ3MGggcW37XcChmvnoIrSKzb1wYzCgwJBFcKs8RvlwCgmnR/sem4ulrKSHb4fC5Vs0S2SmuAbWdlJMPrhKwGcFgnL9vP87TwUYrFKhN4Zvgl/I+0paqdt6xQO5EOVT2khav7CWoP5UsPYJF2KfbPTzCY2WgkSg/Xt52bteDkyDA5sglJQA7OqAHpNo1Zzt8q/EBbzdfr/mm/K41YD/A71kSAgplAZYM5trthPVa5pjRJqpnU7AMjJjofMZ6icIE18MXltWAc9zOezkcC0VVi7YjR2G2GSs3qMvzok8VloBWcu4LN5Vrw8TSsiSaNgZRznNp9AHyuKCONttedAmRcRk6GOIEhTcY0CLkIXA2HGp2WQK3y65WJWhGgArm1As67+TLOzRgrzkADFbO/5vQAsWRD1kpF9rdCZbaaGq/WQrfazLuMC7FWTsS8GQ3/Arn2PqB68L7sprCEjUMIrT3vvY1XM7Uxs/eXv+/WmRPydF5uYk/cfQYfWlVkiFeWwfLqGi6GxT2CqjneD/FzrOK+e+e/LGHQ1rleyM/TSLVHNCO8NDLfMN3vP6//IGnvIKKPu6DqK4mcQ+3c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4904 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: be9daf58-b072-47cb-ff8b-08d7d3f3cd2d X-Microsoft-Antispam-Message-Info: jaRe5LlpBdj7p6i28heYWRxxv7OiBzLkvIem8uAUB8DWQpP1DE9iQqLLMMtsZIPOFu4djwSZmoJnkhthWu5KG4K4VEeCFQ65E0ammiK6rQ/aN1NgOUZE6VVUrkqrZRVJGVvMIeTJHnAIyRg64oO9nCohYNlgpRDbQ7cmzVH1zUa6m9HxKRXnGJEHStEXZE70LPze1GMrAyJ+NE5XifJ/RPz8honwJFKkojm2PfqYOJsF6VQADMd+YysTK8xzTa+AbFBNHgP3Nt/wXrR8F5GsM+zs7Mzg6/voLYeBcBdHBXPwZhE8p/valVQvUdIq6/eAlXZFeP4UAAsWy9l+qbbn4o4EAv7EclQZZdySMZ7jmO5SeHbxTLMC8SUiNweLlKBRhquRKlDxdz7S89QZmj0VvdO4hCoFqsb1Ab7e4DbtJBXTdwxFPbgShRdYKWio2wv9Mqzv6rBbVhLCMaDQ61MUtkjPNpyJsjCWypg9oKaiLcuCKgekEwxekJ5PBYu/4gD+g1Ez9HL+ynIoh/yDN3DB584xHeIjk+XFTNgeIqr3HbrEFuGZ4SOMYH0e0O1ht4JbwFVbwSx0gNNmczxZujlzJOv3nB7NZStyCm0PX8aYoNI= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:04.9337 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 661acc21-311a-4a0a-ba7d-08d7d3f3d203 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5480 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: ITWdwkvTDQksI5Lz3uimvwB5x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494851; bh=noJlLZqps96dv+OJVC2870gwmGpKw+/s9R9f7bgv//M=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=TTUiE000NcDYzou8hQkSPlH5CcSlQypwKGAXV41ImwXnoD6RhWth/AZJhz9cfkmijht 3EKv4zVL5qrheIcZrAW+I3V7ugx0eYnHMF6BohZ/BlDiv+QeutSxVDhuytpPbvY3ekAsZ XJlFw1djkSIrP/275C/4Q3QFLIpsv9Z19Y0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" VS2017 reports 'warning C4028: formal parameter 2 different from declaration' for the library constructor and destructor interfaces for the Generator modules. VS2017 compiler also reports similar warnings for the DXE entry points. Remove the CONST qualifier for the SystemTable pointer (the second parameter to the constructor/destructor/DXE Entry point) to make it compatible with the formal declaration. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.c |= 6 +++--- DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.c |= 4 ++-- DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c |= 8 ++++---- DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c |= 8 ++++---- 11 files changed, 41 insertions(+), 41 deletions(-) diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.c b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.c index d87ea7809eae09cdb5ff06290cff8c2d7e7fa904..d1432348f05143bed8588cea54d= 7b9b6722b9b6d 100644 --- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.c +++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.c @@ -1,7 +1,7 @@ /** @file Dynamic Table Factory Dxe =20 - Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -60,8 +60,8 @@ EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL DynamicTableFactoryP= rotocol =3D { EFI_STATUS EFIAPI DynamicTableFactoryDxeInitialize ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableMa= nagerDxe.c b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableMa= nagerDxe.c index 39b75996d9922d2daf953bb28809aa285f7d214c..e27dcaf37470d811c4d6218d4f4= 0d2260f550c02 100644 --- a/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDx= e.c +++ b/DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDx= e.c @@ -655,8 +655,8 @@ ProcessAcpiTables ( EFI_STATUS EFIAPI DynamicTableManagerDxeInitialize ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index 0b45e15d2d1c2c1e35e801ca719d68d9ff88a65e..346ab5b22f5402bf87c385558f6= 8f080d1b454ed 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -418,8 +418,8 @@ ACPI_TABLE_GENERATOR Dbg2Generator =3D { EFI_STATUS EFIAPI AcpiDbg2LibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -442,8 +442,8 @@ AcpiDbg2LibConstructor ( EFI_STATUS EFIAPI AcpiDbg2LibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c index 1f05a04c7cab0ce3d1264e34d9d0ef252277d81e..b748c982b285a8f6c012c0e08fb= 95c9904f47730 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c @@ -648,8 +648,8 @@ ACPI_TABLE_GENERATOR FadtGenerator =3D { EFI_STATUS EFIAPI AcpiFadtLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -671,8 +671,8 @@ AcpiFadtLibConstructor ( EFI_STATUS EFIAPI AcpiFadtLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c index a30870806d7f223fde7311e3609cca92f47731cc..7e86c30649bd36ecebac75c7e3a= 86a0c25cd590b 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c @@ -738,8 +738,8 @@ ACPI_TABLE_GENERATOR GtdtGenerator =3D { EFI_STATUS EFIAPI AcpiGtdtLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -761,8 +761,8 @@ AcpiGtdtLibConstructor ( EFI_STATUS EFIAPI AcpiGtdtLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c index 05e360c899c7563aed04c071921865929524fdc4..f303e9f29cc700634d236c08505= cab91b9d62cb8 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c @@ -2040,8 +2040,8 @@ ACPI_IORT_GENERATOR IortGenerator =3D { EFI_STATUS EFIAPI AcpiIortLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -2063,8 +2063,8 @@ AcpiIortLibConstructor ( EFI_STATUS EFIAPI AcpiIortLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c index dc5238078376746847e7ae14258bbe35ca07ca2c..2651ca15414694c494678bcec65= 5fc882ee2cc0c 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c @@ -795,8 +795,8 @@ ACPI_TABLE_GENERATOR MadtGenerator =3D { EFI_STATUS EFIAPI AcpiMadtLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -818,8 +818,8 @@ AcpiMadtLibConstructor ( EFI_STATUS EFIAPI AcpiMadtLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c index d219e2f04ad6602b8157b048ae840a3094492680..1293ac8e43c8e0ed641b20ba425= 19172bc541b54 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c @@ -329,8 +329,8 @@ ACPI_TABLE_GENERATOR McfgGenerator =3D { EFI_STATUS EFIAPI AcpiMcfgLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -352,8 +352,8 @@ AcpiMcfgLibConstructor ( EFI_STATUS EFIAPI AcpiMcfgLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index c8713dec625cc18b0806659ffcdc3d9e70411e11..9e42eee9b75bb330833b0f56c98= 947563d9eb821 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -1492,8 +1492,8 @@ ACPI_PPTT_GENERATOR PpttGenerator =3D { EFI_STATUS EFIAPI AcpiPpttLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -1516,8 +1516,8 @@ AcpiPpttLibConstructor ( EFI_STATUS EFIAPI AcpiPpttLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c= b/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c index 544ea06f0bcb3442b78cf6409846f70ae5360664..2facfaa048115575829c9787084= 876efbe60834a 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiRawLibArm/RawGenerator.c @@ -109,8 +109,8 @@ ACPI_TABLE_GENERATOR RawGenerator =3D { EFI_STATUS EFIAPI AcpiRawLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -132,8 +132,8 @@ AcpiRawLibConstructor ( EFI_STATUS EFIAPI AcpiRawLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c index 7b70ba2c2c55a9a15a569680d1a57b359db4e73d..1404279f828d5c06bb7605cb2fe= 6d864ef7a080e 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c @@ -308,8 +308,8 @@ ACPI_TABLE_GENERATOR SpcrGenerator =3D { EFI_STATUS EFIAPI AcpiSpcrLibConstructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; @@ -331,8 +331,8 @@ AcpiSpcrLibConstructor ( EFI_STATUS EFIAPI AcpiSpcrLibDestructor ( - IN CONST EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE * CONST SystemTable + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE * SystemTable ) { EFI_STATUS Status; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56562): https://edk2.groups.io/g/devel/message/56562 Mute This Topic: https://groups.io/mt/72631534/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56563+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494852480693.0422570490009; Sun, 29 Mar 2020 08:14:12 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id la0eYY1788612xccspgsEFYD; Sun, 29 Mar 2020 08:14:12 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.71]) by mx.groups.io with SMTP id smtpd.web12.29104.1585494850425890988 for ; Sun, 29 Mar 2020 08:14:11 -0700 X-Received: from AM0PR06CA0105.eurprd06.prod.outlook.com (2603:10a6:208:fa::46) by DB8PR08MB3979.eurprd08.prod.outlook.com (2603:10a6:10:a5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:fa:cafe::a4) by AM0PR06CA0105.outlook.office365.com (2603:10a6:208:fa::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:04 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56563+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT017.mail.protection.outlook.com (10.152.16.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: ("Tessian outbound fb361fb66447:v48"); Sun, 29 Mar 2020 15:14:04 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6826ad6beb2279d0 X-CR-MTA-TID: 64aa7808 X-Received: from b84f3e69e83c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 45FA1BBD-9A5B-4529-A350-4ABF73332F27.1; Sun, 29 Mar 2020 15:13:58 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b84f3e69e83c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:13:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayXrhMzrIQYZS4v2fNY1nFCxOFoqJhf11mTAqHDMC+xkjebMHQF1vM11G1IaADLbsZIU6bC1ioscR03tPM02VeKaJ2MkgcampT1lv6Xgptpio/6WkM1KY2HYeq3bFFRz6UduQ2OjFSEIe7Vvws44lkCabhqwrBQCJ5f23Lle08zjsoahryByYIGhF/baPQHL5FWBor5YLm+xBRhTaF6fBWpGQ3KMujMxnqswDniXemGDINorIT6kvyNzDFO3uS70awPZWG6aI6zEI156je8MLFEl0jy7g5t2ioEmRhLrs03B7sCKxyV5nYYa8P1qgWLOvudF9lXum4yaAJTvcaPCKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OPyS54IP7Do/MiIbX0KsWI3pR3i3aUatHaptlr17HrU=; b=NWXfXRFCc8Gh8HaPBgCXdJQTaTnUyqr0YVg8gQKbDeYxOIOMUZ9gU7OcV0XGhOQqkcX5z9V4+YrTyBDLYJcYRapwHVyQWJysP5R7WjYsiyHipQfoKU17qcElbKlLh3AaeQG1VnEhA7t/wntpduBgYJFiZOamVHNN8Nz9tEaCgWTKMtkgJopiL9p354bSvdrwCwk9tzsxQKyxmaMe8QGopcWrh3+AenujkLZYWt3pVXRinOBv52YzPCphMteuwxpVQjPVSkHmMt8wS04QYAAFvIUM3ZyFvb7iIiajbnVvQ6tOeUQp5wY82WusM9Z8cQ/mNaB2vmq3gw0WCCbYFC3i1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB8P191CA0015.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::25) by DB8PR08MB4969.eurprd08.prod.outlook.com (2603:10a6:10:e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:13:57 +0000 X-Received: from DB5EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::43) by DB8P191CA0015.outlook.office365.com (2603:10a6:10:130::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Sun, 29 Mar 2020 15:13:57 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT039.mail.protection.outlook.com (10.152.21.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:13:57 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:56 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:13:56 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:55 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 02/16] DynamicTablesPkg: Fix missing local header warning Date: Sun, 29 Mar 2020 16:13:39 +0100 Message-ID: <20200329151353.14096-3-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(136003)(396003)(346002)(39850400004)(46966005)(70586007)(2616005)(47076004)(4326008)(6916009)(44832011)(336012)(7696005)(426003)(186003)(316002)(1076003)(26005)(8676002)(966005)(6666004)(356004)(8936002)(36756003)(70206006)(5660300002)(478600001)(86362001)(81156014)(2906002)(54906003)(81166006)(82740400003);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa25e0bc-8d91-45ec-9012-08d7d3f3d1a2 X-MS-TrafficTypeDiagnostic: DB8PR08MB4969:|DB8PR08MB3979: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:7219;OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: TJEZWiIv1fnP9JCm6N/kp7bvGVtta1AL1ZD9S/EMcq6oKkWXhigf/EFzZYwofkhGHJUnrBhjZZnxbgcwUxUFYHB2AsEfDz72KHMuEEds/j1K5oaltp6KpHSuh4bfU9z+5r3uAyi0P7XnzNdauZvRYOiytnx04C1grmcWuHl7gMBxudz+boSZ9N20Xte+IhgpXViUyK7+QE7UsZmhWtaBewtq3o3yMjDSkjtT1AEjGjb3du1wwLaf/hn7cOWHIAUI0iA0hjUqG8O+R9SZ/0LZJ9j+aXwxuoqPlvf6AEFFmhfMhRl2l53moxax4PJPsLeTT+uxGYRuLgCg8BwWhVaAbvuvX6rCvMvlqnu07CkJCRrCNw+UqS63woZ6XTAtydOaMMf/YjfgdPH/o1ol2neEhbGHI1uYk18giYTc/mrc1P7Pc+FWjhHmCQXG0ZuE7ChuFspKAijjJdxF2ciL5/rlZivy6eGfMkMcpy7CwouUz5SawkPyU6f+SqvYQdU6X3mau+mb0hgZZE1yM3DS9u+Ffrk96DanXaa86V3VT+tt2zekiFCGlbV0lbDbJZKDb9uGVSh4uQQKZ1app6nolBFs0/sXsmRVgB0uhuJRxmhhjj0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4969 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: f6ca1ad5-a313-4c7b-f029-08d7d3f3cd76 X-Microsoft-Antispam-Message-Info: sIzGn3WuYtfh+qmtPwfY5nCNabLZU5PM5o2cmvZk5OhVxWWOzSsWGuiJCNBKWnNzzwGZzlws1bAKDAP0ALIE8FCGHQJwYnSHaWimwLlEeR7vqbt2ivnQfRukiiX3XS/wu9iyeOfdHgwlFi5tP/08iy0gkRSYKXJyepUKdccM6oDgpWsWQ02UKD6NMqgpvkw1k0TJ1xD1lHj/sgSZJmhoGefSeVlbdv+X7dcrAtsxb4gr7uVUwB1RTXqa/voglS6bnmYG0698VsTdtiJFO+jsnIbV8aQxcjWdUnjGtQbxan94RjnV7jYEH+DAKdO33KIh7RFNj1eD9bg+bNIF/sQyUYQjkqqAYkAkhTHDLk93fuwo9T6UjMUg6S8kUREDyjEbHgdk+P85fZHnXlY09CGMc2zxYnlBCQoZlGAvu7uBi/2Sj7EO8/PgGLXJQiJMrdNVuoscuEtKaRJfPzn9RoBJDGq1tW9qVyga4vtR4yVvFhzPfP2eqIKoy0pkn4QyTs5KovYONYXaC4Jv5PQSHg5k6jdFVXA4y88/OY6AtKGKqwWxs7jMalgY53RtGeFRSX6FqR/r/hWYfcoP5jxymBf0JS4VTi5ohsm6docd+J8O5zM= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:04.3179 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa25e0bc-8d91-45ec-9012-08d7d3f3d1a2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3979 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: GdPVpEcrY9N8i8RFyAeH6VPMx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494852; bh=s0FpCMa0Yaw+KIsXhKsQ6vvaiwSlpN3xeNsgvI400hk=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=swxm8evHTl/D6Zr/BHAaiqj8RANaUdT38rsaMQ5fPPfX7NdYIjGbWtT46LIQZIMaMC7 Zp+bYflR1I9fI5tMHkU2XwL9ZRkONq1Cx8JJVzR0jh6+IFqPOxuVySuaS3l0GXMyUSzxu oguBnC7jKq7MrDszXy3NCSDqqUrGU01gfMY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The edk2 BaseTools report a warning if a local header file is not listed under the [Sources] section in the INF file. Add header files to the [Sources] section in the respective INF files to fix the warnings. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Ard Biesheuvel --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf= | 1 + DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf = | 3 ++- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf = | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFa= ctoryDxe.inf b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTable= FactoryDxe.inf index b47a690dd72702a2d7157cbb21249ba1d01d08cd..56b69591ac52ca3ba51250dc01a= 0846b22442ce9 100644 --- a/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.inf +++ b/DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDx= e.inf @@ -25,6 +25,7 @@ [Sources] DeviceTreeTableFactory/DeviceTreeTableFactory.c DynamicTableFactoryDxe.c SmbiosTableFactory/SmbiosTableFactory.c + DynamicTableFactory.h =20 [Packages] MdePkg/MdePkg.dec diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibAr= m.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf index 3bbd0e7818c6172f9178b12a3d0960e2d298bca1..2f987e3b6d339d4b5f342cb52b8= dc712cf4e585c 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/AcpiIortLibArm.inf @@ -1,7 +1,7 @@ ## @file # IORT Table Generator # -# Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. +# Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent ## @@ -18,6 +18,7 @@ [Defines] =20 [Sources] IortGenerator.c + IortGenerator.h =20 [Packages] MdePkg/MdePkg.dec diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibAr= m.inf b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf index 3cb13d7d8fd3df04f3e16cc6161d9736f7579a80..2c7d19513d6ceea29fd9f271f98= 3a6cf6d2c1046 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/AcpiPpttLibArm.inf @@ -18,6 +18,7 @@ [Defines] =20 [Sources] PpttGenerator.c + PpttGenerator.h =20 [Packages] EmbeddedPkg/EmbeddedPkg.dec --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56563): https://edk2.groups.io/g/devel/message/56563 Mute This Topic: https://groups.io/mt/72631536/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56564+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494853038733.9331947216782; Sun, 29 Mar 2020 08:14:13 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id y7IgYY1788612x25qS9c4bUW; Sun, 29 Mar 2020 08:14:12 -0700 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com (EUR05-VI1-obe.outbound.protection.outlook.com [40.107.21.80]) by mx.groups.io with SMTP id smtpd.web11.29111.1585494851841161575 for ; Sun, 29 Mar 2020 08:14:12 -0700 X-Received: from AM5PR0102CA0026.eurprd01.prod.exchangelabs.com (2603:10a6:206::39) by DB7PR08MB3835.eurprd08.prod.outlook.com (2603:10a6:10:75::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::b9) by AM5PR0102CA0026.outlook.office365.com (2603:10a6:206::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:09 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56564+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: ("Tessian outbound 66307db0259d:v48"); Sun, 29 Mar 2020 15:14:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 262805e9aa381fce X-CR-MTA-TID: 64aa7808 X-Received: from 97bedb122a07.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B1A1BC6F-9466-4D29-B25B-760A7079C3D0.1; Sun, 29 Mar 2020 15:14:03 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 97bedb122a07.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CKuXOoI78IC/hB0qO9h/TYQTZI7kQCtV2P/3K6EWj/AMPOAh2LX4/U41/R+B9OCY7lBkt8RF/ZO5tzcgGKEC0z2yODB8/2PBD7oXdv4IfqQ9A93qrLhVDL/qRnVS7oOTUIzR7aqWupsq6mUjc7vkkrIlYYPEkicqWs9CDfYzpN6RiFZpf3k/wwokg45XWp4ik25/E14PNcSSOXTc4TrvT8oWhqczG8a1GJdYP0aBbolk3E6cXVmIaQaTEBB8iTjBnssuXXPYBJUJVGevRBJ+Yf35L3f2XM9r1fdZvcLVFoclY7PXmvXDVFgjr+Bx3qgTmShuV9Z6/KCR0qfSaWF6NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0/1goE1Vp8kWWS4ogN9ljZ02wrCFeWLaVC9FDsqj3wc=; b=k2/zY2rUJSpVU4aqTWNJkRlaElhiVsmV+cmK3zoMYO/jZbb+CkLypQz+t2hkSb4S0dcGmqVylAQw+OFFqdiF5Zn9Ro/v3olPxfws9G4sHbhx4CP7JMwRybQdCwQp1/V90+SMVzTX6o3gW6Jbzt/vEST0U9KUTPN7RV4Mqm6/S/y/bu8KF70hp6WawvOrsPQCSa0ATuSUqnhmOtAxjn+sfpVEF2wZVGki0jo1zKuW6IOT8hdceOKJAXoTU+OtoqTUC/cR/PtRVon8mBu6I3e4rbpnsuFwaMj7WjIs5vknthT2UV521XM+utwkqUNlaIiVstFQM3ezvvFZv55LHTwI9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0004.eurprd09.prod.outlook.com (2603:10a6:200:9b::14) by AM5PR0802MB2515.eurprd08.prod.outlook.com (2603:10a6:203:9f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:13:59 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::da) by AM4PR0902CA0004.outlook.office365.com (2603:10a6:200:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:13:59 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:13:59 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:56 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:56 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 03/16] DynamicTablesPkg: Remove struct CM_ARM_CPU_INFO Date: Sun, 29 Mar 2020 16:13:40 +0100 Message-ID: <20200329151353.14096-4-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(136003)(346002)(396003)(39850400004)(46966005)(47076004)(2906002)(8676002)(36756003)(186003)(426003)(1076003)(316002)(4326008)(86362001)(6916009)(81156014)(81166006)(478600001)(7696005)(336012)(26005)(966005)(54906003)(70586007)(356004)(6666004)(5660300002)(44832011)(82740400003)(2616005)(8936002)(70206006);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7512d87f-3048-47eb-283a-08d7d3f3d453 X-MS-TrafficTypeDiagnostic: AM5PR0802MB2515:|DB7PR08MB3835: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1HAE3LG9LbTsln9X5asYJgTHRMHhO1BRdo2SrIH4F2TyY+GPUqPHDiXr4ob+d3/a7mGe62nZikFHU/w0XR/bF6j/54BzsqyI/q/pK3bBFVhFuQXdHlDOenjrdJVhX8gcIEvsm19to6Slw4h/8D6Ix/h/j9fni3Y1yreByPyocW8cdeb7/qAB89O1cYWGXJOAzzrbk6FioNmzT0pSP15YLe/CkFnCy7FRKDuE11gfhVMwdCqt0WqwhfBWshSsliP3w9StpMcfway1MTUBGCkl0om+VXPI5fACNblsbL9jneksKQxS4kcQ8JaUYix9G2Vp89qpJc2FC/4XbtvhmHGQt64X5OfyhckL1dwP1QUYTiMlOK8j5CcZy1JjOhP9Ox2isV3eqtZchbBdn1QCNPkIQ9s6tAX5nVVOsEzJyfZ4xPVSWPhFXfSgdJcRAoOlzilnR2jWcGqTJYzRhsbl9V7JV4UT5GmnQUsl0Uls5kCPo56PnmuGmkJB19ioc1o2myJcXZsHbwmyo+oYfnDH/+8ZIHxpflYM0KcImZ1gCbnnlEQ5sZTiwjfKI+yYTxl2VvlMEgYhOKvXJ5nBdoLApnhWgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2515 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 899c5a1c-c15d-4af0-2054-08d7d3f3cea5 X-Microsoft-Antispam-Message-Info: hCPZlK1+fw4LLsRkhh/YWvMbTfCAr92fMHsxE0ua4Toc6bszFLHSF6fPUlHAKmSYAM8k1xfJBcQdjJO0VP7SEORRLEkqTJKu9g89i3AIlpp+13wc6jhGUhEK4Cl6V8oZEhylG/ixYmmxPpzaB1EpjPERZtKedsnDqi2b/3BLQRUjCVIWmjWhNTMDjANulJDcWhEgQ+jR9FKbmhQicZ7Y8e6EW7lVSQoIxe+cFDA6QRjuV0bBei8xYAuCi1YJPn+lF1ed/FzB5oI2xhF9pVOaHP2x5GriTQuPTUaVkTW31hyrJfDDRfWcD7RDwRj9SLMZvdKg32sL+r57CTgoBbX2eKFfxLqo+4vDJxqxaQNx6nO+oGZX9L72yyFmzoADi7gc7at5MsWT9MmGDNRZ0n1k+M2he7YguEZjaZHObsHjzLudzQvhQRFL5JFOAXYmXebTP9heykKVtNklziO+Va3HWJ+t5yTtUYk46Q8KuYA8FMn7sstUmv97H1eFuFCGLazq/cqBw8R+DzLibVw4lzvqvHaHO5cJoEZjm6JGUkoUdz54F6dPuK4f3yep+YJ134h6zet/36khgzJ/l7UD3aoR3g== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:08.8377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7512d87f-3048-47eb-283a-08d7d3f3d453 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3835 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: xc72oSEbyTXIFuTCrQMTJxprx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494852; bh=wAfh3z5t0xrVfIFykClgw4ONxs88+Vsu5hWnTaegNis=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=B+x54tM+UiyRIvj9JfNlT9jUIIPL9lJ6/MGikI4ls/96ugdaan6i2OD2YNZJ1jC3mkJ c9hoScU/BYt0PqMwRZSEIaF8fk8lkl1EiU3TaP6eKPeLjfqHTjas0v0yDHUDBRZupAc8I qADZ+D5ON9ynK3nSYGG9/RDOWYFoRF+hclY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VS2017 compiler reports 'error C2016: C requires that a struct or union has at least one member' for the struct CM_ARM_CPU_INFO. Remove struct CM_ARM_CPU_INFO as this is not in use. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Ard Biesheuvel --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTables= Pkg/Include/ArmNameSpaceObjects.h index da70cba2037592f02c72c026dc32f90b67bec8db..2874938b663c33edf5bdaac9f41= 495f75abfc945 100644 --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h @@ -71,10 +71,6 @@ typedef struct CmArmBootArchInfo { UINT32 BootArchFlags; } CM_ARM_BOOT_ARCH_INFO; =20 -typedef struct CmArmCpuInfo { - // Reserved for use when SMBIOS tables are implemented -} CM_ARM_CPU_INFO; - /** A structure that describes the Power Management Profile Information for the Platform. =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56564): https://edk2.groups.io/g/devel/message/56564 Mute This Topic: https://groups.io/mt/72631537/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56567+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494855171531.937793171376; Sun, 29 Mar 2020 08:14:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id lXbaYY1788612xG5ex8mhAEq; Sun, 29 Mar 2020 08:14:14 -0700 X-Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.72]) by mx.groups.io with SMTP id smtpd.web11.29113.1585494853952128298 for ; Sun, 29 Mar 2020 08:14:14 -0700 X-Received: from AM7PR03CA0030.eurprd03.prod.outlook.com (2603:10a6:20b:130::40) by VI1PR0801MB2014.eurprd08.prod.outlook.com (2603:10a6:800:8d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18; Sun, 29 Mar 2020 15:14:11 +0000 X-Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::ec) by AM7PR03CA0030.outlook.office365.com (2603:10a6:20b:130::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:10 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56567+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:10 +0000 X-Received: ("Tessian outbound 6835489d965f:v48"); Sun, 29 Mar 2020 15:14:10 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: af293ba24d534263 X-CR-MTA-TID: 64aa7808 X-Received: from 4cd7d394ddb2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 30F7360F-F2EA-41DC-8B01-C787CFC88608.1; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4cd7d394ddb2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PYlM4UJXoWG9NhlaqRVnxwEFUGzJYAzyv5JcDb0SDBo3VjDhiNDJ4rs9QNWItnwfLq9c2bhz3Ff9BwjAAPZvgHqZgYEkt4TiaFhfxV5Ax+xO2erZDmVqUwgs8zhyHIZb9vv6dobxdcKct5CG6gA0tkE7dSw9eng0ngApXT42IFf/FQYd7rSN73SuEVDuUyNJD32Agbx8ZjaYGcMP4N5mzILH1qWI42sU6MX9wCQx7GGprFv+dox3WZAyDjcX7z81zP2Uk8xlJBGwvv8iSQYKkjfBVUHRd4qJyxDzq+ux0LuarUZHV3rAc54r1xZECVvMl/ESLdSzpsVH5t+I572YMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ut/fjAK5ubuVy98Qaei3Ud/B1VjCrNfZf1pLQoAP1Lk=; b=iUUS84zHVkIML59wnCvjV2eGUNZhmZf1Vdjb2n6vTG4pUR/oN2jyyjixBWxLnolrbDjEEU6buGeAQf8Vhhk/R5spu3ElbSyhQY256a4RmQYpzbmCjlkpWOV45Peb4sJhuFWXaePd/P+rcCFf467LebcfCF5oOsrxB0P8ZtacrswPIzhOVwvT0G90R+hkoXoY9BZq7oCljhvuYZJEg0uFVOPTwSZAz7Rspyf7KeKa2QMm6I3MWbT7Fguxv1hhI+mFF0f+U3XCuSVkQCYwqYurg0jZs+6BhSzxfuPL8ZLqMXcalUXFMi0XOcJHsu4Zvjweb6DozjXP2GQz2E0BFIALcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0004.eurprd09.prod.outlook.com (2603:10a6:200:9b::14) by AM5PR0801MB2033.eurprd08.prod.outlook.com (2603:10a6:203:4c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:03 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::6) by AM4PR0902CA0004.outlook.office365.com (2603:10a6:200:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:03 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:03 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:58 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:13:57 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:57 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 04/16] DynamicTablesPkg: Fix serial port subtype warning Date: Sun, 29 Mar 2020 16:13:41 +0100 Message-ID: <20200329151353.14096-5-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(396003)(39850400004)(136003)(346002)(376002)(46966005)(336012)(1076003)(7696005)(54906003)(6666004)(356004)(316002)(426003)(26005)(2906002)(44832011)(36756003)(186003)(2616005)(478600001)(8676002)(966005)(81166006)(8936002)(6916009)(5660300002)(82740400003)(70586007)(70206006)(81156014)(4326008)(86362001)(47076004);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d8d537a-0383-4cf9-0798-08d7d3f3d56f X-MS-TrafficTypeDiagnostic: AM5PR0801MB2033:|VI1PR0801MB2014: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ExQ4JkBc5b5wuz3jNW+1cTcMAIydeLp+bHyJAn+lYMitjUqiFthT20YNkFryXeutyrduhEQ8mM6NIpqjJVQyHroVMP/CSMtiMKmwVxZknDw9k6pLmWDWqdkr+nxqOslNdd8EM016tm0+81OXvv40/PLcHVSY19Z2qtUqm/6POv1ZN6Q85YRneJVAIca7Nad4BPGBij094kCC3IIyTE7H2HvHkbeEG5Xf6mYH4/ZZ80z2mRIo2skNXFiMPEfzzFsjj0TTrgpsDQauR3TUqttNB4Xek4r3an+/DuFsjt17s4PL0i3kI2IfgMH3pr10uhkQX+FjC+ZaLsLpLlAEzJyk0pcNhih/MR2w9dyrDaInDAJbCYvhAybr8zhPIXaxE/iHfoXXfHvO3vLjXo9ZVNYWtBaqYJ+k2i1fpfKxJiOr7Krc1dBMOqGdJGb/Cx7OC4smVDZ9hCQxMRLzY2m4mOVXyTve3BHlA2bIgVnLSZ2y9aJQ1KUT6VhnMXhIKYFTOvX3wxUgTZ2GfFq1fLsexvFsQsbd00Zkj8AOXmg04GOsayDq+N4NT9btyRjf1ntZaNWjNogXwD/1nqeQfQeg+wPS7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2033 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 21861cf6-af23-47ba-2288-08d7d3f3d140 X-Microsoft-Antispam-Message-Info: PVuEj+ct8F+4c/EQFR1qHfbWUDJ3BIyXHqnqLF+DxYAHa+mVmabjP3eh4xAslYnAUSyIqpDrRhoippNh9ZZ6wS1pEtbCjEQAze0c7noiDFlwGnFvWcXrcUemPAaLHuVKORefxZXa9R4Ka4w6vx+4tqFMAWvi9UtsBnQj2yRZ6qxhhCgQ601ar4S+JLo6bSYwGraNbN+ZZMYGnrNTaaf8KdfelE9pEOrnJcBlEsCLZvoo7qKu12TGUjQgqKYkCB+IK8gvrXdMucFVt3yv9MO+YAqUbTnZ7IJMrfxdKzEmjhFt9LB84K0iPIWHohw55I1oy1vX+crW49m/uOkl3LoTajOMyvzzfKhLl/+hxWIPjVf9GMVyza+uNToD1NfCOdHgXBCW/Dfbvh3xk9ZOpZZDJAODJRMr9bIyZjNBPSgmaC556A5hRY1FGHwCkKYkslV8AorpFyzF67I4C1y1FPknmFPVAWU8wGdSLn7kqxEPkyt0GGVikMEpez8EmJ6ZMLS2xd9HhzjyT2belYFlMhY2LWpyCHUcMDWgj84Dybo1yX3rw8WXF9EiwGUvBibXCkS/Awfurh9s2dS2QIySkxxRcQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:10.6510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8d537a-0383-4cf9-0798-08d7d3f3d56f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2014 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: lmaePDFOvNtSBf4ONwHlf4uOx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494854; bh=RsAGMjZKGBCYr0XGXx/y/UTIG8hI8NkxMoDqRgKRSaw=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=uWSqFvcUhdRI20lMb2/zd8I+PS8RFjx8ROAfyzWaBOvJlINKZgxQoBAxw94vk7oXCDU SwLk6mi63KEhpag4fUa6fQJ2wf4y5kW2yHyiE9M8MAucpqggXodO8LFA/ocOOddD9BdBR jD9wjtju4eMxpnTd0RPlZE15WYRkNLzSqHU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VS2017 compiler reports 'warning C4244: '=3D': conversion from 'UINT16' to 'UINT8', possible loss of data' for the SPCR InterfaceType field assignment. The SPCR InterfaceType field uses the same encoding as that of the DBG2 table Port Subtype field. However SPCR.InterfaceType is 8-bit while the Port Subtype field in DBG2 table is 16-bit. Since the Configuration Manager represents the Serial port information using the struct CM_ARM_SERIAL_PORT_INFO, the PortSubtype member in this struct is 16-bit. To fix the warning an explicit type case is added. A validation is also added to ensure that the Serial Port Subtype value provided by the Configuration Manager is within the 8-bit range (less than 256). Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Philippe Mathieu-Daude --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 15 ++++= ++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c index 1404279f828d5c06bb7605cb2fe6d864ef7a080e..4b2580da7df9b4472ae9bcc3df2= 138a9e13004d0 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c @@ -217,8 +217,21 @@ BuildSpcrTable ( goto error_handler; } =20 + // The SPCR InterfaceType uses the same encoding as that of the + // DBG2 table Port Subtype field. However InterfaceType is 8-bit + // while the Port Subtype field in the DBG2 table is 16-bit. + if ((SerialPortInfo->PortSubtype & 0xFF00) !=3D 0) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: SPCR: Invalid Port Sybtype (must be < 256). Status =3D %r\n", + Status + )); + goto error_handler; + } + // Update the serial port subtype - AcpiSpcr.InterfaceType =3D SerialPortInfo->PortSubtype; + AcpiSpcr.InterfaceType =3D (UINT8)SerialPortInfo->PortSubtype; =20 // Update the base address AcpiSpcr.BaseAddress.Address =3D SerialPortInfo->BaseAddress; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56567): https://edk2.groups.io/g/devel/message/56567 Mute This Topic: https://groups.io/mt/72631540/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56565+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494854477567.441736683908; Sun, 29 Mar 2020 08:14:14 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id lvLAYY1788612xJcHFvs4Zak; Sun, 29 Mar 2020 08:14:14 -0700 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.85]) by mx.groups.io with SMTP id smtpd.web12.29105.1585494852565137775 for ; Sun, 29 Mar 2020 08:14:13 -0700 X-Received: from AM7PR02CA0010.eurprd02.prod.outlook.com (2603:10a6:20b:100::20) by DB7PR08MB3353.eurprd08.prod.outlook.com (2603:10a6:5:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::47) by AM7PR02CA0010.outlook.office365.com (2603:10a6:20b:100::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:09 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56565+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: ("Tessian outbound 19f8d550f75c:v48"); Sun, 29 Mar 2020 15:14:08 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 7b59c68280bbcfbf X-CR-MTA-TID: 64aa7808 X-Received: from 5d2ee7a3c96e.3 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 95F71EE5-0B6F-487E-B423-FA49426F2EB8.1; Sun, 29 Mar 2020 15:14:03 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5d2ee7a3c96e.3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdnYCg/xXhiXYO1/SRSh34W9UBc/XkjPOtHZVe5ji4srojVRRPNUuQEE6fDkUzQnx7/sWXSV3DvYdOxlx/8dNsiPJUeFjkdPAqBnOlEGKkXcZYtF+z4c+3+brGqUNDllw/97OZVjssByFynw8BwMU09PIN8e+Fw4a+MTgiYE3aUS1Cy8T11grTKb3woeSH4F3rv33glH07VuBf4rWyU8OpV3rkyc7lmEgizi3ymrfwgRBKQKP461avDx44Epvlt1kZVItE9KY2EaBtFRrpkqIQ0RSn1RHQi31KmS0VUhc3fS2sfY5V+ipp1xwKv8LFxm1P2rHU59l9hS28fRLRim9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzTTtZa1XlR9rsEyZv/H3rASrIUytthlz2H3Dc+LRdg=; b=Pk76/zlzDvpqK6izFrlpRzVi88HwOmO3LZgQymWV43aLN3iCDpsupUgwS8IF0/5l7jlrxbvbwJkYaVly8t5HriqmilsrnvHLxRqWBTBbWwqN1KTy84Jke13dreE5jwLU0iK7dxqhjVSoIz+XyJKHowPGMWYbAs8+umJMg0S0Dl0xTytSyDL9b715awVLKVj7Iv+MVTXgsZD6DGyJoYaKjBBIi56WwHmPnH0QNIj29DBz6oU0B20aWxUtdICQVn41VMDFLfNz2cBdzM4i0uShMrxbuJJ/as8l2gMu+73jCzBAXLkZhcdvTJzIsdqdnCmNmKyjO8QQfKx/fhvK58e7RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0004.eurprd09.prod.outlook.com (2603:10a6:200:9b::14) by DB7PR08MB3082.eurprd08.prod.outlook.com (2603:10a6:5:1d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:00 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::6) by AM4PR0902CA0004.outlook.office365.com (2603:10a6:200:9b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:00 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:00 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:58 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:58 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 05/16] DynamicTablesPkg: Fix Proc node length assignment Date: Sun, 29 Mar 2020 16:13:42 +0100 Message-ID: <20200329151353.14096-6-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(136003)(39850400004)(376002)(396003)(346002)(46966005)(6666004)(44832011)(426003)(8676002)(82740400003)(36756003)(2906002)(316002)(336012)(5660300002)(81166006)(356004)(7696005)(54906003)(2616005)(1076003)(47076004)(86362001)(966005)(4326008)(186003)(478600001)(70206006)(70586007)(81156014)(26005)(8936002)(6916009);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9730dc0-11c1-4c49-70c4-08d7d3f3d470 X-MS-TrafficTypeDiagnostic: DB7PR08MB3082:|DB7PR08MB3353: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0bzUiglaFWURobdxVmwDaXWKmcwRqulQYMFZuUbLQfMYRhZoYjchxVufy0KUoYwBpicIYrnRblHztcbEGoXKGJRbyAXcGYHKgRkkEKVZyS6uttlnamem5smG9N2hsFpFws47bZSrbfE7Km0GJkdm0/fLnUKgSTdbAgn+SW0bzuMCBz0r+nu2W/zANR9cPAePPANdaTi+wROySgvxk5EPkj63W5/gIq2QMr19Uy3gHaeBf2HqxYynuZic3KPSrowl2ONelCjFuTDpfeNkP9QyhdMa7Mwp/KOOn7DSAsFUbdXKT/R3lsF8bKdn77tPnmhsaK7DVYXTqkq7xlU4GGwZ3G441aphPsgXeD9QsvuOpNA1Sk90S/lqeAZH4EVwxKFujsi46XAZpzEiLrpvgynxmFibOI179FGhLomerC9XIgw76s/21hdpZPoMbIKghZRkyf2J1y42FWlnvZoS0hgXEsUzOQvdzDqW2L0hOPA3LGxlCNF5aN77vBliRX4ECyyUmts3MMv6yrlAMLlRvrSmazcOTVJY+lKWfLVw0MBVOdTgFWd84NHj7qyk3ICdxiOAZ1L9nqgt/40Tf7HxNjEIRjElhoF1QMn4+CNcJF24JqI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3082 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 13a31d51-2b78-4aa9-7db6-08d7d3f3cf70 X-Microsoft-Antispam-Message-Info: 3a7PoBhSOEnGHGJt3yZnGmn+5Qrh3xH/4J262P5+UwxapJPgjS2fq2ktM4CPu1+kvFIgpt7ZikYLeszniK+uKoY3527nYi00YeaimsdNBo0qeKknraIq0XBWoMyxSVAL6ijS27+jGeMmHgJnynn0GJ3DlckNzA83MvRZNA+CoKyG6p9zu3BL85lr31nPd+BXEF6sTGllkFMFpD+8OCbG6xBg/0freKODzlWnN/flBmJbodTWIkX6RJqeXYITxiRwdv2VEdeqlHXm9FVaXgbnih6CLBr8sXSiHJCfEPrLaH78YgShl2kEpFGsLIYNBrg//xPk20OFBOSgt8P77AyoDg5YG5NP5VTXEcTM3j8XKeVLf3O9xgYMUi3BSFU7SzIR3nd9/zkdy9qlJ1doK48t09kN8QV72V6EJqBoZRfw2ErAiAxTokN+uAGGGse4H3jw/rP2r/VFQZyPDn2xlT5U04A42HojxWr76JLRM3qEy0uWb7lV4Q3In2rezcVycv+C8iuWvRZOphmTaKJyj98LeKcxDgmkf7sLfKZOzZyG2LE1IZQ/QVPpbqLYOZgPH2J39IYOhtHOO59RFdVn8SKxRycKLHa5VnyJubN76TnDCuw= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:09.0166 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9730dc0-11c1-4c49-70c4-08d7d3f3d470 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3353 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: xv0MZ4anB0gYTf0EMBOOsyrgx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494854; bh=SAPkPN4mlqxp2heBTdyhNkdZhHwR6znn+UyMox6sItA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=YqMAb+TkjVRc5PeUvCp3GDQPGXym811sw2gNtG1/63ihZ4cKvbGooXRNtvoGsHxKdvF gy54NZUnUMgJ5iX2jPpWhZm8FpeFoYiph9KL1rfGgj71mge9VnbvSF3MemLRmNPMJQSoo NGfH3iPiJsq7LCByKUp+KZEl/dZvWVM34HM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The length field for the Processor Hierarchy node structure is 8-bit wide while the number of private resource field is 32-bit wide. Therefore, the GetProcHierarchyNodeSize() returns the size as a 32-bit value. The VS2017 compiler reports 'warning C4244: '=3D': conversion from 'UINT32' to 'UINT8', possible loss of data' while assigning the length field of the Processor Hierarchy node structure. To fix this, a type cast is added. In addition, there is a check to ensure that the Processor Hierarchy node size does not exceed MAX_UINT8. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Ard Biesheuvel --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 7 ++++-= -- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index 9e42eee9b75bb330833b0f56c98947563d9eb821..40699ce113caa8530c89ac20562= cf5abda26b88e 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -504,6 +504,7 @@ AddProcHierarchyNodes ( =20 PPTT_NODE_INDEXER * ProcNodeIterator; UINT32 NodeCount; + UINT32 Length; =20 ASSERT ( (Generator !=3D NULL) && @@ -539,8 +540,8 @@ AddProcHierarchyNodes ( // imposed on the Processor Hierarchy node by the specification. // Note: The length field is 8 bit wide while the number of private // resource field is 32 bit wide. - if ((sizeof (EFI_ACPI_6_3_PPTT_STRUCTURE_PROCESSOR) + - (ProcInfoNode->NoOfPrivateResources * sizeof (UINT32))) > MAX_UINT= 8) { + Length =3D GetProcHierarchyNodeSize (ProcInfoNode); + if (Length > MAX_UINT8) { Status =3D EFI_INVALID_PARAMETER; DEBUG (( DEBUG_ERROR, @@ -556,7 +557,7 @@ AddProcHierarchyNodes ( =20 // Populate the node header ProcStruct->Type =3D EFI_ACPI_6_3_PPTT_TYPE_PROCESSOR; - ProcStruct->Length =3D GetProcHierarchyNodeSize (ProcInfoNode); + ProcStruct->Length =3D (UINT8)Length; ProcStruct->Reserved[0] =3D EFI_ACPI_RESERVED_BYTE; ProcStruct->Reserved[1] =3D EFI_ACPI_RESERVED_BYTE; =20 --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56565): https://edk2.groups.io/g/devel/message/56565 Mute This Topic: https://groups.io/mt/72631538/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56570+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494858391433.37560819847727; Sun, 29 Mar 2020 08:14:18 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id wDWKYY1788612xRktpNIOisF; Sun, 29 Mar 2020 08:14:18 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.57]) by mx.groups.io with SMTP id smtpd.web11.29116.1585494856789269627 for ; Sun, 29 Mar 2020 08:14:17 -0700 X-Received: from DB8PR09CA0032.eurprd09.prod.outlook.com (2603:10a6:10:a0::45) by VI1PR08MB4109.eurprd08.prod.outlook.com (2603:10a6:803:e7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: from DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::78) by DB8PR09CA0032.outlook.office365.com (2603:10a6:10:a0::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56570+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT007.mail.protection.outlook.com (10.152.20.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: ("Tessian outbound d6b3ed9fc62a:v48"); Sun, 29 Mar 2020 15:14:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8dd5044b1a2b5f5f X-CR-MTA-TID: 64aa7808 X-Received: from 49857e7ec042.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 77491EB1-21F8-4DED-BFC8-96ECDACEFF8D.1; Sun, 29 Mar 2020 15:14:05 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 49857e7ec042.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nIrtOZPdVvOF0pMs9KXOMQ+d5mLC6PhVks/iVZUilwMnow+FIoZYAobziTqKTQddRI6XkT5ogmTf4ZBFQJknY/MKT1GabAmYMzWqY0bzITAW3UzWapxmV6cbuLK1teWjw6m3BVb36mHqaJFRqTjXsZjve2nV0tCA63JMNRLqt28DpyppT5POv2lysFIFo3J6KI3LGPyvv67NlCALyN1AfOJjd5PWwrtqK6OtIt4IxHAky9OqVhH3Hv9zK7hH+YyiRp2ewlff8JM+hUklddW1lTHDxP8dQFHi9Y01m+OyKplgKp1aiizntT7F9ukGDUQjHE3LOH2XmTIsB2PAaqjcBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iRAF1ou5H39xV7D9Uxo8WrSN8G0xr9ZzcSf48v/Y41A=; b=jOf3fLwWoB6u+p1xwtMMmXoaYbk6GHz3+p8/jAvC8VlukmoN9ayjyZfZXaCDVZIL9f6rnt/kj2C3eLNrxIU5VUWSs5lKOj4pvKcdTgQPKNXEzaOhYN9OTK+t0tQqyiJeWAlcR3V8bg3x/FY+v5e67r7psrJe86ZOUBUm43ynwYFDi/WU7BrnXXM9Nr3rY13kmcQMYBOOGVxQLbJBGx+R5MjjpcmICV86uLZRdSBTJfxYWvqKHxrabihtBgL6Wo4dlcaCvmI5KdH/SHYRW1Z1ow6b7tAOsReG9Ve4VRCXyYuvlO/+GpaZKc2C/vqTMS3PG/N3KcWECUbbHBP9wCExEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0024.eurprd09.prod.outlook.com (2603:10a6:200:9b::34) by HE1PR0801MB1818.eurprd08.prod.outlook.com (2603:10a6:3:7b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::93) by AM4PR0902CA0024.outlook.office365.com (2603:10a6:200:9b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:04 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:59 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:58 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 06/16] DynamicTablesPkg: Fix GT Block length assignment Date: Sun, 29 Mar 2020 16:13:43 +0100 Message-ID: <20200329151353.14096-7-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(136003)(396003)(39850400004)(376002)(46966005)(44832011)(426003)(81156014)(336012)(316002)(186003)(54906003)(2616005)(26005)(81166006)(478600001)(7696005)(36756003)(82740400003)(6916009)(47076004)(86362001)(2906002)(966005)(4326008)(1076003)(5660300002)(356004)(6666004)(8676002)(8936002)(70586007)(70206006);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d04e20e3-b80f-4ccb-71bc-08d7d3f3d680 X-MS-TrafficTypeDiagnostic: HE1PR0801MB1818:|VI1PR08MB4109: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:608;OLM:608; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ZiO0haEaNJ9hVIEl18ZXTUZ4VMzREfZON4IptdJInt1SIu+6iZ/mQtp3E3T4bGFXp3cYAFAljv+SgaJ+98xxhdzJmU12uKXP7b1C8bSuNrq8jL+cYpznn941wpEaVYO8CoL030NgfH38Dq6dFzGe7YqGSi8D52Lmp44wCTpM5kDGc/gSfaCgKpubpbx7i1PBi0f/HhgC6EMCJRJKnpn4mu1Oegp21u+5zz4ZuWAchsKp2lFZJTGu0K1Pi6fT1zK9Jj+ETHFAZMNvZEUbjIHSEaU8EBh+AQ49efRwqBWbhLbeOoKVxoyYKT+9ctAr+P4N/eQmxVPjUGk1+hpkRcPo5PzTB+KBTK4FsLbWc6FjfZaUHAavcl2B+ZPG926oOMWJzl+E3v5xnaqBLiirnb6ZAP0YYrSvk4fEM+x1zCZJQtvFJmI6/9k+9yZ8rMc/OSa6ZEZ+H8TEyarzLU6MJdQRpmf5SeTX0oDuqlr3rCrgQScOVj2rbi1KGZS7YooW20fi9PvEkutcl9UWYZcusN6tIZpWDPnL0t5CkbGMAcFFtUVdH59iNJ9Xv5H1+W3N5OQBgIkzPMYI+o2PgZl/sES2RuGwiAgxOl/S0ynXvTGFIRo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1818 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 56c3bf09-8078-4c9a-7f1d-08d7d3f3d1bf X-Microsoft-Antispam-Message-Info: sIYN44oZn+v/Y/GWRg8H7qunqQsqvuT83+R4lMEtyiTx6wgkQpomMrhE8pOqfY8MY8eL6oXHLYsWjH+DulBcb39kFvxIL0Ymrh5qsFIxX9U2KOlqe1HZGo+FA2Cp7gwOuUMr+G13ODzZwimUJiqqX7dvNNFxLN3uF5wQXx4jps6Hx90lFhSMWroyXj7i/ek47WVBzk3bBRRroFnxzVOXoa1nods8P6hLrD3MirmQGKWbAIGSnqFkveKnrx6yygraVa6fn0r2SVvTk3qkoVugSDsNY4qfZFtSsjL7NP5c0KX522rgBvt0ewJxoIUBes8lyQgaCvNIdVHCA9+NVup+C8u7hNiuT3iFWWDWK87FoKY0Q2M1EPKxx59BPKKYmAE9eVF3UaQ2UP2pG2xi6y2DMF5I5e/UzPLlys3fs0Pa1fjehQTqbM/egK0NefYI1zBCArCrvUycpoQXUddxULuJi32cn4fODUkf/H9b18MUyXJU73DGd1GAHIJx2evVoi54C9DsAkpA/gbftBfwwCQY40EjCrPBQU60AiL9wHXBw3qPPq/QAm+UjqhxjR/HqzKHGGZUzmZqFz2r5498CPIXvfksnRoJyXRJ0wkR8uKKcZM= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:12.5410 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d04e20e3-b80f-4ccb-71bc-08d7d3f3d680 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4109 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: RyDnIRNC3f212BbXIkyD5PmOx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494858; bh=tH232SSiJN9BiW4OIcLouCRTvMDpJsBhyEuITGy/6Vg=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=AlWmBTCVgcXV0X1y2EajkTnmaNoijCsd+N+jeIM/T02kUiOc5Y53b4XG4oGYytllIKo lx4chAv1jkDTAW6uZ8KSzSsv+zUQILdKjg+QFUnxQxhjSk+FtVDPxvCvsgusuzqWZWwxR QntFbEhB4Yzy2NIpGpvPeP6znS/Tsr68tXc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VS2017 compiler reports 'warning C4267: '=3D': conversion from 'size_t' to 'UINT16', possible loss of data'. The sizeof() operator is used to calculate the size of the GT Block structure. The length field in the GT Block structure is 16-bit wide. Since the return type of sizeof() operator is size_t the VS2017 compiler reports the above warning. To fix the warning, an explicit type cast is added. An additional check is also performed to ensure that the calculated GT Block length does not exceed MAX_UINT16. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Philippe Mathieu-Daude --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 25 ++++= ++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c index 7e86c30649bd36ecebac75c7e3a86a0c25cd590b..0e996698887aefca8a7240fc27f= e3cb9324fd3e2 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c @@ -350,6 +350,7 @@ AddGTBlockList ( EFI_ACPI_6_3_GTDT_GT_BLOCK_TIMER_STRUCTURE * GtBlockFrame; CM_ARM_GTBLOCK_TIMER_FRAME_INFO * GTBlockTimerFrameList; UINT32 GTBlockTimerFrameCount; + UINTN Length; =20 ASSERT (Gtdt !=3D NULL); ASSERT (GTBlockInfo !=3D NULL); @@ -376,11 +377,27 @@ AddGTBlockList ( return Status; } =20 + Length =3D sizeof (EFI_ACPI_6_3_GTDT_GT_BLOCK_STRUCTURE) + + (sizeof (EFI_ACPI_6_3_GTDT_GT_BLOCK_TIMER_STRUCTURE) * + GTBlockInfo->GTBlockTimerFrameCount); + + // Check that the length of the GT block does not + // exceed MAX_UINT16 + if (Length > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: GTDT: Too many GT Frames. Count =3D %d. " \ + "Maximum supported GT Block size exceeded. " \ + "Status =3D %r\n", + GTBlockInfo->GTBlockTimerFrameCount, + Status + )); + return Status; + } + GTBlock->Type =3D EFI_ACPI_6_3_GTDT_GT_BLOCK; - GTBlock->Length =3D sizeof (EFI_ACPI_6_3_GTDT_GT_BLOCK_STRUCTURE) + - (sizeof (EFI_ACPI_6_3_GTDT_GT_BLOCK_TIMER_STRUCTUR= E) * - GTBlockInfo->GTBlockTimerFrameCount); - + GTBlock->Length =3D (UINT16)Length; GTBlock->Reserved =3D EFI_ACPI_RESERVED_BYTE; GTBlock->CntCtlBase =3D GTBlockInfo->GTBlockPhysicalAddress; GTBlock->GTBlockTimerCount =3D GTBlockInfo->GTBlockTimerFrameCount; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56570): https://edk2.groups.io/g/devel/message/56570 Mute This Topic: https://groups.io/mt/72631547/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56568+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158549485753373.4285603918745; Sun, 29 Mar 2020 08:14:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id RPnJYY1788612xjtOYOsAYu8; Sun, 29 Mar 2020 08:14:17 -0700 X-Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.42]) by mx.groups.io with SMTP id smtpd.web10.29263.1585494856191226575 for ; Sun, 29 Mar 2020 08:14:16 -0700 X-Received: from DB6PR0402CA0005.eurprd04.prod.outlook.com (2603:10a6:4:91::15) by AM6PR08MB4054.eurprd08.prod.outlook.com (2603:10a6:20b:a0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:13 +0000 X-Received: from DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::51) by DB6PR0402CA0005.outlook.office365.com (2603:10a6:4:91::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56568+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT006.mail.protection.outlook.com (10.152.20.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: ("Tessian outbound d6b3ed9fc62a:v48"); Sun, 29 Mar 2020 15:14:12 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1c7daf9495ffc327 X-CR-MTA-TID: 64aa7808 X-Received: from 959aed4abf9d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4D9FF3F2-3B01-4030-8705-9E6C57D1FD18.1; Sun, 29 Mar 2020 15:14:06 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 959aed4abf9d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VxHGwCj2clsn1kgB0vn2MxJOoDFADXY4TXtKqOM+CMWwxxDgkoPzdhiJ7Bn2LsEB7kD2ytTyg0F6hZrckCujcUhICQ0a1NTGx7XZJVmvwIqX6XtrDiGCSn/59v7YnUI+mmv9Lhl3HxvPWebOUdcAZmPSBjtlT1itGjpnvA6nsvT3HS3O77Jtl7WfrIQNI3UTOzYT0cLDrXkE32u3aY6ICTxLqKuzclalgwBKQwIqWMgqpveu0aZbZvtWDigg9JIVoF+4+3A2X/DMBW/QhFm3cxdZpfyZT/4CAr6bV/AsRz7VZS+/Kn2nQNi7BbqWJ3ssfnJTMBWAoSqKsB1NbbbhTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kegO/cTeaqMv8cEoOPhE/CfZmVdHYiYD9eGmkoCzi4=; b=k6lj7P5svpzxrsOON63nFcvqOu7OsCE1JsR7sOk4TdX6iPw0Fr+mC2Ebz1btceuDUrMjD+tt/FVqPd7AZdFAE/hUtcRlGGJZC9dgYX2mdcD1eZlthp6LLO1balJRH7ooYpfdDoJCNY+k9nZUrFGSBXcO/uTFTaDVEeZ5vNb8OvGx9xE3QERYDuRarHZntcZ6I1+hDioMUW/iaQUmbJroNjqZ0oEtt5PXQFE3MuT9QbEk76XentcUmFPOguue0Ezcp8DvVbhhmsWsk/esBPMrvDIesMhZUPkRbm3aGLQQGfJXojIJCvZnDAbK1OJr8isLWwMK3DHAxIuqpAusJVUd1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0015.eurprd09.prod.outlook.com (2603:10a6:200:9b::25) by AM0PR08MB4434.eurprd08.prod.outlook.com (2603:10a6:208:143::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:05 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::22) by AM4PR0902CA0015.outlook.office365.com (2603:10a6:200:9b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:05 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:05 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:13:59 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:13:59 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 07/16] DynamicTablesPkg: Fix Boot arch flag width Date: Sun, 29 Mar 2020 16:13:44 +0100 Message-ID: <20200329151353.14096-8-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(396003)(136003)(39850400004)(376002)(346002)(46966005)(478600001)(316002)(36756003)(1076003)(6916009)(7696005)(86362001)(966005)(5660300002)(54906003)(186003)(26005)(47076004)(8936002)(426003)(2616005)(82740400003)(8676002)(44832011)(6666004)(2906002)(356004)(70586007)(70206006)(81166006)(81156014)(336012)(4326008);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e28b14c5-c345-47ac-8ca0-08d7d3f3d6b1 X-MS-TrafficTypeDiagnostic: AM0PR08MB4434:|AM6PR08MB4054: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BG5O9aruh4p/boRgm+NhB2y76a0YxNOG1vY9uYzd5wWv93XZX01AjseCCGp17geUiQm/po8vKvHpHN1h8RSO98zOKtaHTrJgxulhbbiVXGMp/vMoxYuCLHI2khwOvtKAELGjtZhWRBAHH4bQhy0C/ypFja962/Tm1sR0S4ATMsoG1EA1sEuNDPVczByo46PRoTtIrNN/3fdGqp1Tta3mszbfcgKJnLcFCzGRuppfHsDPIA2vowus2fDSO7ldrBGpJkeVqo1sI15iLYmjMb9nq04C9TelA10rWVpyp3kDLk/MA/3P9B7GsNrV+iuUxFkrfUpyTPR9+7gsW/TmwiMAsrOk/JmaK/wUFM1pChhakUkLqW+wB116HPke1Gbm9nZhkByKUYpwQ9o064ke1zFCrlg4XKEn/jwTbDVrxBD0zbUClC85qcTQJOGRHCM7hER0sXWXlTsGuXUhTjC+O656/mraIrpDynoMxswEtWyMm5P7D4Rf6tUCrabsxhUgP/8zMpvczBXKMXQdeXzHxBdf3O+k1trjz85LyhVs5tuNDgGKqrclkho3C4e4Je9pZHz4ZTKt/roGX7A/1OQ3rBleQUkIADwbq5GT6AjmUpIKKas= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4434 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 219d3201-d1b4-40bd-e85e-08d7d3f3d24c X-Microsoft-Antispam-Message-Info: gyrq3gzS2Qlejqc3RnCm5gL4Oy+tS0WAbD4YYZmQQNlMkA1vUu0WnL6zpWaz922CpusD4GCXdqqxXHbYcM0FOxVem+Y8WG1SKKMd0CHltEEusF+DbFMjO+erCYYJx3EOYJYp/tCObvEJo3UnwAAf3eQ+mAt4YVuwoMcceWw/85OLxHuogSpQqByzDI3O+JmMrk/mc+DvWYibKa41Jcl42Q+9ufAYTEcqydU9i8Dc3nJVI6yNpuGCFz1IaYMkkcd4fb+YQXsmLmY1I5/9f0hjGBVGlciE1G7Dq2nck/5noyeUMu7i9CF6dkyVjJs4KbNDkb2kxPgAN44paAwBfbd4YJ7ITDUuKmL3K7qG2dqgNm8yuaVHUFX8nbo/4xCqPy7GZIiEB/kBHcWTo9Gr4z4cQOy+PrcUWSCyya3FfmVAYVehe7Yg7cAw9VVdvg+gsO8tMkPrIoaBhNkgHpUOhrDMNPYcvtsUXpBzh3rOpsu0qj348b0pvfSSmougaP9yjFXz4qEPvXJcbF+9GZqoRy7O85aXlqqVZ2BjssLeAzR1X8876gZV1Aku5G688sm6RVUgeLp+Wr6j4C0FKLS2imXoaJEl5a3CTRgMRprF9yZ7wow= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:12.8428 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e28b14c5-c345-47ac-8ca0-08d7d3f3d6b1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4054 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: y2Vlba98vfuYgSFejlLl4kOLx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494857; bh=ziM4PyHk7XT7EH6eK2bgWAnJIAlRtUZMqwbAYVd0hdU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=dMVPh45qduWN/AbMewYkmogWIGDEVo7z9NORVajOyXq/Uc3UbH7hpGGrujtgrTzhPUL ETeLEVxXad8/CoMb2WEQqdBgKE44jhEkLi+oZGvuGIvPIZa4pSLPuRs+KWlQrHF/8JorO +EBGvu1oN4vwO7FeKC4XktkGxQeNdB4rduU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ArmBootArch field of the FADT table is 16-bit wide. The VS2017 compiler reports 'warning C4244: '=3D': conversion from 'UINT32' to 'UINT16', possible loss of data' when assigning the CM_ARM_BOOT_ARCH_INFO.BootArchFlags value as the width of this field in CM_ARM_BOOT_ARCH_INFO is 32-bit wide. To fix this warning, update the CM_ARM_BOOT_ARCH_INFO struct to make the BootArchFlags field 16-bit wide. This also makes it compatible with the ACPI FADT specification. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h b/DynamicTables= Pkg/Include/ArmNameSpaceObjects.h index 2874938b663c33edf5bdaac9f41495f75abfc945..2f326960313c1d7658029205e5c= b09b89b0cdd88 100644 --- a/DynamicTablesPkg/Include/ArmNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/ArmNameSpaceObjects.h @@ -68,7 +68,7 @@ typedef struct CmArmBootArchInfo { /** This is the ARM_BOOT_ARCH flags field of the FADT Table described in the ACPI Table Specification. */ - UINT32 BootArchFlags; + UINT16 BootArchFlags; } CM_ARM_BOOT_ARCH_INFO; =20 /** A structure that describes the --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56568): https://edk2.groups.io/g/devel/message/56568 Mute This Topic: https://groups.io/mt/72631545/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56566+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494855015549.8260510461124; Sun, 29 Mar 2020 08:14:15 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0CVfYY1788612x6kPzdZCAi3; Sun, 29 Mar 2020 08:14:14 -0700 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.51]) by mx.groups.io with SMTP id smtpd.web10.29261.1585494853770829133 for ; Sun, 29 Mar 2020 08:14:14 -0700 X-Received: from AM0PR0202CA0004.eurprd02.prod.outlook.com (2603:10a6:208:1::17) by DB6PR0801MB1733.eurprd08.prod.outlook.com (2603:10a6:4:37::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:10 +0000 X-Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:1:cafe::f1) by AM0PR0202CA0004.outlook.office365.com (2603:10a6:208:1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:10 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56566+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:10 +0000 X-Received: ("Tessian outbound 19f8d550f75c:v48"); Sun, 29 Mar 2020 15:14:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 51f915a989c1b3ac X-CR-MTA-TID: 64aa7808 X-Received: from d980b44d2900.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8543C43A-CDF4-45DA-B67B-A00ACA027E43.1; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d980b44d2900.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e5ntAOid5OcZc9xZNy/vVxtkhrFeGYtFFtlEADmatrTj6Udx0Ictmn5rA/7rd8dcrixwLH/dXInu+XbxjDlq5Jc//4Uf5wtA7qxFV1AL4lO142qtSpXYPTBGNuH/rixVPd41Gfwy6daXPunhwTU73bDTDOsfik+j5rpdkA08/mdV/DPcoQo++Dpd7ulxPxrhaaxF0wF3e31KSyI5NYXuF/tOMveAdJ5un0GlerCCRo/3z7huBp97A687Deezhbx2SlF61HYMid2u6SEw5UF+0dh1+/lNs4NOu0fiaeK+9hiI7LFAwDsFRkaJ5MFVry/8+6xqfyP8DiKINeeXQWAkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3FIRZm5cQG3qDmSD7YXUyY7QBkuqls6qfL6Bti50F1I=; b=cAR/xH0XQTqVp4WNAKmkFkGXWex6poFd80y+6s5T/GeKXCT1JCtbBWo1aD2mXJAV1ypYrm0AteDOu8dbLCE5vIUMDHhUau+tDLOoE1VDSaJrLKbsuUtT8kwCo7ZF9chipK4WpOgbwLc/zYOGrAuQ8cHg7pyjhpIlMN6hQ2rM+t+LOyu9yamKwWdcU1R/RgDbNBE/KZz/nx6LVYxLRJQGqD7wofQRpMKTcmgueirWBKx1lnRkme9yk7Gvir00fq2e8sKaLsnhfJQdROA2XAHMj5bmRxSOyELSjSbj+7/9igM+8g/msxGq70ZVO0VFAyzqappxz4Gw/JQWAcBC1XFaGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from DB7PR03CA0087.eurprd03.prod.outlook.com (2603:10a6:10:72::28) by VI1PR0802MB2461.eurprd08.prod.outlook.com (2603:10a6:800:af::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:02 +0000 X-Received: from DB5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::3f) by DB7PR03CA0087.outlook.office365.com (2603:10a6:10:72::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:02 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by DB5EUR03FT031.mail.protection.outlook.com (10.152.20.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:02 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:01 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:14:00 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:00 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 08/16] DynamicTablesPkg: Fix ACPI table rev field width Date: Sun, 29 Mar 2020 16:13:45 +0100 Message-ID: <20200329151353.14096-9-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(376002)(396003)(39850400004)(136003)(46966005)(5660300002)(316002)(54906003)(478600001)(966005)(86362001)(82740400003)(6916009)(47076004)(2616005)(44832011)(336012)(186003)(70586007)(426003)(26005)(70206006)(1076003)(2906002)(8676002)(36756003)(356004)(6666004)(81166006)(81156014)(8936002)(4326008)(7696005);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00248ca2-3361-40d1-6828-08d7d3f3d522 X-MS-TrafficTypeDiagnostic: VI1PR0802MB2461:|DB6PR0801MB1733: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WyuXU3BJcZIopO0qLjmfKplblUp2ZJmH7I64FY+eedtruTC9MKX7LdNt5d2k+TB7eHqEtUaRuS748LlieFrqd6a88yAPj6FPFYUuIOQOVT+N1/oSVCSbejcBCainmiQNv2y14DxiIb3QyIAsNwKzoSYfl2COlf4atnRtngO0W+fPUSEmL1jddiLUVEwgwojK2dkE8FEyZ6diOblKY4HuYqeoKgcXUGOI8LXnSCxggouQ3JbKq8r+cmVs0xrGKcxXOK/WOPCAJ6tgDkDMxaHR4mkJF8pEUkY80+AV8kciizzDpVSFKvYSfGZjL9yhlQyUBR2vPkamGl/zKx5p94nO2DBPB2b0gaJ6qkr7VXbFwIe9BObL+cAdnf9COeZf/HnCE2qmhuBzKMLFj+pZnrrQfjMDlFqenn17+UCZKXBo2OFLISnZsfep0rufdOjMGpH1RLQ4+/IIi96P2GpVfKZlaOaqsrALLuRV+0e80kxRvv/n1fX7/p4u6JSmqWSfRmjhz4+cqnRXBTjTpoGLDwtch7eEIisjRBKehtBIjRhvtTOlWRpWkEoO9qSkgFkw4Bwqh2eSnDjdMh6OoEq3uzhG2l6jXtPFjmPRIMoQvvpjI24= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2461 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: a9f999f2-91e4-4780-13df-08d7d3f3d065 X-Microsoft-Antispam-Message-Info: xJtpQTJGuxxcSAWA/ATILnKSi+PpZ5VFGEUXoMoYDgbSWA7vDwW7kyRrKdfYO4nMBolLL7Z3ZmzHdtqqqQJx7E8QWpbrY+FqqLPhyBEn/MZ1nZxZ/nW7GzURdy6/F3KHeETmjVuGULIRN+MEfbHRjKPEwqPZzLPqZlOuOf+5L+TdL4aE0nVeUfOUZrDoegGU//t7IWYSiQiar9vCefKPPlYdvIBhWwL1vmoIm46O2lQayAaFJArCLDgGkXLPcy39Lax0xJbORUhFVgpR+YG7Lk0oXqgwkNMDfwslNYrCV6tq/cWYI/81tvZMBP6soBUJrgU8kHU0s6uCByIcof5cgQm3JygK7hJLSl0EWbAet5r89WydMkllgQt5BJccwnEqF/iMYj9TgzyIxdO3FP6f8XonymOfzim6xEvxPZXFPpcgLYYPF+d46+GNF84krX2OZ3nZIC2djHtMoHdp5Df0SJg1gDmxK13Zhgb1vI7e5hURVpkSTKK775kvhadZSSLhOJBd4PqvEPSViB5dZWckLYx5M/oauH7h/4WODekIVQ4i+nFhNjoTmfW85IJIT1v1s9QM3ey6IzivERbsqt5ZoncVcGPjCIOXMPiWrp0jBl8= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:10.1929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00248ca2-3361-40d1-6828-08d7d3f3d522 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1733 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: sAyHkAagb2KvhZ1lufMboGkZx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494854; bh=2wAuZpzBm0D+DgUcAzfYdxxar4DMRjw+4qRH+tqATOU=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=OfwnwpE3DXPGlYVeWB4Rd7vsbUphqr7U23HQXXZq8FofypNjlOQd2lm0WnOPoRZoESu 1YsNPkUhOj/YV3p6wnRibzUMCPiF92i+iqayOcsqqIwPtEPnrlIOFXkVoOgz8C0C/IVOR JWbbd/NUSegHOEe7qrpJw5RJFq8lg6IvSuE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VS2017 compiler reports 'warning C4244: '=3D': conversion from 'const UINT32' to 'UINT8', possible loss of data' when the ACPI table revision field is being updated. The width of the revision field in the EFI_ACPI_DESCRIPTION_HEADER struct is 8-bit wide. Therefore, to fix the above warning make the ACPI Table revision field usage 8-bit wide across Dynamic Tables Framework. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Ard Biesheuvel --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Include/AcpiTableGenerator.h | 4 ++-- DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/DynamicTablesPkg/Include/AcpiTableGenerator.h b/DynamicTablesP= kg/Include/AcpiTableGenerator.h index e46717e6e8442ec516ef79ea979bd29e070f6d0a..b55feb4e7507f0e4e1e0a64c3c4= b8068f17dad47 100644 --- a/DynamicTablesPkg/Include/AcpiTableGenerator.h +++ b/DynamicTablesPkg/Include/AcpiTableGenerator.h @@ -287,10 +287,10 @@ typedef struct AcpiTableGenerator { UINT32 AcpiTableSignature; =20 /// The ACPI table revision. - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; =20 /// The minimum supported ACPI table revision. - UINT32 MinAcpiTableRevision; + UINT8 MinAcpiTableRevision; =20 /// The ACPI table creator ID. UINT32 CreatorId; diff --git a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h b/DynamicT= ablesPkg/Include/StandardNameSpaceObjects.h index 21bb7de4044ffd6f97156f761e30fc1790f11c0c..0ba6b163691ea127ae7a7d57fb5= f9fdf84789338 100644 --- a/DynamicTablesPkg/Include/StandardNameSpaceObjects.h +++ b/DynamicTablesPkg/Include/StandardNameSpaceObjects.h @@ -79,7 +79,7 @@ typedef struct CmAStdObjAcpiTableInfo { UINT32 AcpiTableSignature; =20 /// The ACPI table revision - UINT32 AcpiTableRevision; + UINT8 AcpiTableRevision; =20 /// The ACPI Table Generator ID ACPI_TABLE_GENERATOR_ID TableGeneratorId; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56566): https://edk2.groups.io/g/devel/message/56566 Mute This Topic: https://groups.io/mt/72631539/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56569+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494857783994.4282361468703; Sun, 29 Mar 2020 08:14:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7Fg2YY1788612xXRNGQgoKNs; Sun, 29 Mar 2020 08:14:17 -0700 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com (EUR01-DB5-obe.outbound.protection.outlook.com [40.107.15.41]) by mx.groups.io with SMTP id smtpd.web12.29107.1585494856146029385 for ; Sun, 29 Mar 2020 08:14:16 -0700 X-Received: from DB8PR09CA0007.eurprd09.prod.outlook.com (2603:10a6:10:a0::20) by AM6PR08MB4659.eurprd08.prod.outlook.com (2603:10a6:20b:ca::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:14 +0000 X-Received: from DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:a0:cafe::62) by DB8PR09CA0007.outlook.office365.com (2603:10a6:10:a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Sun, 29 Mar 2020 15:14:14 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56569+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT027.mail.protection.outlook.com (10.152.20.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:14 +0000 X-Received: ("Tessian outbound e13acb17570e:v48"); Sun, 29 Mar 2020 15:14:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 0901abb6ec8963b9 X-CR-MTA-TID: 64aa7808 X-Received: from 687ddea41359.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 283C1816-FC9C-40EC-98EB-72A822901640.1; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 687ddea41359.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iCKuYHwKo/CvAFFnnZgrD4ZBbfyE1u6h7UJrIsk1YTcZTddgLekvVy+P0u7KIv+nEI3z7Bg3Im+8i+VPPQXm+zNpyTc7EARGRgIV7ZQOshCyhXwQZS/W/GIUpFW1BgwhMjUNxXYMhEKZCanKmQN8AnSd2DlrJUh3EqMSLywPfh9DbzOtkLRfpoARQPUmCKC0xtsHzuV9TPUR3UHXitOw7WhnzuiBZQFfj0hrPJV8q3QUtP7r06lDKQZofICCUId9d5UucBJNC2wOnpfi0WjpaOjvfdOJRvsDU997b4C0WfwkD/dKOXAmAp8eu24QsfernPfj2yZNFlNiSFRU//v6hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VEbVH+Bgw8gAhEdl4MumBrcv5nMPapQt/J1aDOOOze4=; b=FEIO1VVOQrZJDv+BMf9sdQaU682JvGv31EIgmwT6V26U94H9Uz6zIg7CSbyjhJ0kcRuNQmEC/W+JFO8UaHxo+pXJxIXIpMTokbyk94irbQ2Qy/CsZNuha/Net77Zb6Nt9tRk8fYKO1s1byDvf6INq5Vi4Hc8FroXqoadbHzlnbo8j0YclfJ7vFsQAd95gWl8Z9LSpzICaOM9FnU/6z20iG17PaXlUWo5CIa8xX9Nf4Kocd9R9tSoUoXmoYTGtKQiRrgiwk8EXArF4Gxl/FGfeGJxrpkKxp8YkywuoaxCsXwbfD/MDbdYtb7+9zwKevAI/nZwwQ4dOm1TMcFDRiSF5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0007.eurprd09.prod.outlook.com (2603:10a6:200:9b::17) by VI1PR08MB2640.eurprd08.prod.outlook.com (2603:10a6:802:1a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:06 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::8c) by AM4PR0902CA0007.outlook.office365.com (2603:10a6:200:9b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:06 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:06 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:01 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:01 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 09/16] DynamicTablesPkg: Fix unaligned pointers usage Date: Sun, 29 Mar 2020 16:13:46 +0100 Message-ID: <20200329151353.14096-10-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39850400004)(346002)(376002)(396003)(136003)(46966005)(5660300002)(316002)(54906003)(478600001)(966005)(86362001)(82740400003)(6916009)(47076004)(2616005)(44832011)(186003)(70586007)(336012)(26005)(426003)(70206006)(1076003)(2906002)(8676002)(36756003)(356004)(6666004)(81166006)(81156014)(8936002)(4326008)(7696005);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5a57c80-c2cf-441e-2326-08d7d3f3d771 X-MS-TrafficTypeDiagnostic: VI1PR08MB2640:|AM6PR08MB4659: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:4303;OLM:4303; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Cafc2CR74KJq9nzppHJjg5IlmwZ5p1JbTPuYNwHyC/Nww3ZuIs7jN3SlPBgi5C6J9z8IJ5qWLy+R29+/NSz07FI86ryNrSR2tLSitTE+WYJkIOrAYBMsxyUuk0KK0EZJH6Otk6PAa/wXxm2ZmuKd6UJSZCbJbP/h90ch1KyA0O3US44PCfQZgWltknteftAqOVOXk0jE7+Sgc5KNJLTkBxbOr9y/F+wpECQjBlcsL9vC35wAZyy5at9EKgDtINsvTiAcATadQ5NNr3sIwgaZVdcDYv/uFVVZoXNHeuMV1YtPOz08AO/ds6XlGUWFANMn26IJ4q9XCJ6NWnlo5pPz6VvqPKNOhIMPcFO6raGk319d7DH1rxsZPWU0lLfgTgVhoK5QSYAY+kpMrf10l3je43Zz15IOtBqfeYpnMWV2ZeJzxII+YQX5YvZuBMnQ5YvffOQR7aJO/UJOU2zMRzXPMd1ETzwxLmSauF4ExPXASb8lfAT76otYm47sykf/aNWVT4BR0XJ3D/kN5xBaR6x5mOASVXjj2t80mSXQ64rZfWRZMdL5WgOcGL2bGC2yjqdbtrjilAYe+1ZqNkxSOG6vlAOLA7AJfAZN2GMqLwSf2ac= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2640 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f3b600a-bbeb-42ce-41a7-08d7d3f3d30c X-Microsoft-Antispam-Message-Info: p4Yjd6EdyuuFk5zlzULiu6DIoQXichgUy5NuO7qxEtatc0JboqAhFW0AKvxJbpjVlX25vucMQO0rOag5viemaJF+4Vbe1fcnLjxsrwtDJ0Iz/zANG7krGeXYbIZH917/LeV1OCOh+2eWqxHC0OkWI7imAsmo5xuIQy8uPLPqUegHDEj4kdrvYYp+9ZppEq5T0bw4XsTYcMpezKYz/9iJnioJxjCeWyewVM+FX0EUOZoEwTVO+zM4il69rwgJzVzZ6vuojELcD0VDqAtGTvbgyT4AnSfr24CgIhxERb6TqvuvpsYmUM19jMi1Hs3yvmCGQ2zQXPJsSkRyA89m2PXY1hp56W2aoGRgHhnRoSc4FLQGZ91wgUFqX0fgcwYG9M5i0zGV2LZWuzXtdgALBbOaDVx7UjMG+BvOegtVwQusZ83Oq5DPphiPclTKjtYTlpoqUf/eCQXvwfYqCh/jj7DiV8M49waWyc8kyFbli5BtnLbQG9HXvbC+WXes76ebSxj8KYMTo3QAq0jI148vJngC+PX0hGSwzlfE8uDlwGvcUfNpYILfb2nA+XIsAivgcvQvMrqwHHY/aMJnYzYtC36cbveha6vZAmEQKor+7+1eeuc= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:14.1184 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5a57c80-c2cf-441e-2326-08d7d3f3d771 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4659 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: yKsqgEX3LKE4xnr4SwJOlYfzx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494857; bh=OEvOPrfzCxg4t/6H+zvccyw4kwZknFBP5b2A+QLhKv4=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=qsuE8/DlaJYTTA/jU9+EpFyrB7djwIgiPXyYUzrrHNG1LnfWl9S9SoCRCBx64j2Mn4v on5JxN90ob92xSuRCz2B04CujgVRlUy4ZIVKTL23fyLmRgxn1KLDRj+AF+ZjP7xZsSCZy PexVmfSN2FYf7UvwN8H+6yxlKsuCmYOy8HU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VS2017 compiler reports 'warning C4366: The result of the unary '&' operator may be unaligned' if an address of an unaligned structure member is passed as an argument to a function. Fix this warning by using local variables in place of unaligned structure members. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 24 ++++= +++++++++++----- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h | 13 ++++= +------ 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index 40699ce113caa8530c89ac20562cf5abda26b88e..82070403ac8757f54e839fd00eb= 4acb3292fc60c 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -1066,6 +1066,9 @@ BuildPpttTable ( EFI_STATUS Status; UINT32 TableSize; UINT32 ProcTopologyStructCount; + UINT32 ProcHierarchyNodeCount; + UINT32 CacheStructCount; + UINT32 IdStructCount; =20 UINT32 ProcHierarchyNodeOffset; UINT32 CacheStructOffset; @@ -1113,7 +1116,7 @@ BuildPpttTable ( CfgMgrProtocol, CM_NULL_TOKEN, &ProcHierarchyNodeList, - &Generator->ProcHierarchyNodeCount + &ProcHierarchyNodeCount ); if (EFI_ERROR (Status)) { DEBUG (( @@ -1124,7 +1127,8 @@ BuildPpttTable ( goto error_handler; } =20 - ProcTopologyStructCount =3D Generator->ProcHierarchyNodeCount; + ProcTopologyStructCount =3D ProcHierarchyNodeCount; + Generator->ProcHierarchyNodeCount =3D ProcHierarchyNodeCount; =20 // Get the cache info and update the processor topology structure count = with // Cache Type Structures (Type 1) @@ -1132,7 +1136,7 @@ BuildPpttTable ( CfgMgrProtocol, CM_NULL_TOKEN, &CacheStructList, - &Generator->CacheStructCount + &CacheStructCount ); if (EFI_ERROR (Status) && (Status !=3D EFI_NOT_FOUND)) { DEBUG (( @@ -1143,7 +1147,8 @@ BuildPpttTable ( goto error_handler; } =20 - ProcTopologyStructCount +=3D Generator->CacheStructCount; + ProcTopologyStructCount +=3D CacheStructCount; + Generator->CacheStructCount =3D CacheStructCount; =20 // Get the processor hierarchy node ID info and update the processor top= ology // structure count with ID Structures (Type 2) @@ -1151,7 +1156,7 @@ BuildPpttTable ( CfgMgrProtocol, CM_NULL_TOKEN, &IdStructList, - &Generator->IdStructCount + &IdStructCount ); if (EFI_ERROR (Status) && (Status !=3D EFI_NOT_FOUND)) { DEBUG (( @@ -1163,7 +1168,8 @@ BuildPpttTable ( goto error_handler; } =20 - ProcTopologyStructCount +=3D Generator->IdStructCount; + ProcTopologyStructCount +=3D IdStructCount; + Generator->IdStructCount =3D IdStructCount; =20 // Allocate Node Indexer array NodeIndexer =3D (PPTT_NODE_INDEXER*)AllocateZeroPool ( @@ -1475,6 +1481,12 @@ ACPI_PPTT_GENERATOR PpttGenerator =3D { =20 // Processor topology node count 0, + // Count of Processor Hierarchy Nodes + 0, + // Count of Cache Structures + 0, + // Count of Id Structures + 0, // Pointer to PPTT Node Indexer NULL }; diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .h b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h index 6a0fdd08e1533c57285f420555586314c70a5ed5..0a14da502d595e27d87262b1bac= 681318f1d9ced 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.h @@ -167,6 +167,12 @@ typedef struct AcpiPpttGenerator { ACPI_TABLE_GENERATOR Header; /// PPTT structure count UINT32 ProcTopologyStructCount; + /// Count of Processor Hierarchy Nodes + UINT32 ProcHierarchyNodeCount; + /// Count of Cache Structures + UINT32 CacheStructCount; + /// Count of Id Structures + UINT32 IdStructCount; /// List of indexed CM objects for PPTT generation PPTT_NODE_INDEXER * NodeIndexer; /// Pointer to the start of Processor Hierarchy nodes in @@ -176,13 +182,6 @@ typedef struct AcpiPpttGenerator { PPTT_NODE_INDEXER * CacheStructIndexedList; /// Pointer to the start of Id Structures in the Node Indexer array PPTT_NODE_INDEXER * IdStructIndexedList; - /// Count of Processor Hierarchy Nodes - UINT32 ProcHierarchyNodeCount; - /// Count of Cache Structures - UINT32 CacheStructCount; - /// Count of Id Structures - UINT32 IdStructCount; - } ACPI_PPTT_GENERATOR; =20 #pragma pack() --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56569): https://edk2.groups.io/g/devel/message/56569 Mute This Topic: https://groups.io/mt/72631546/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56572+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158549486084249.25462549270742; Sun, 29 Mar 2020 08:14:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id WRu0YY1788612xLxCZvPpXhx; Sun, 29 Mar 2020 08:14:20 -0700 X-Received: from EUR04-DB3-obe.outbound.protection.outlook.com (EUR04-DB3-obe.outbound.protection.outlook.com [40.107.6.71]) by mx.groups.io with SMTP id smtpd.web11.29118.1585494859678853175 for ; Sun, 29 Mar 2020 08:14:20 -0700 X-Received: from AM5PR0102CA0011.eurprd01.prod.exchangelabs.com (2603:10a6:206::24) by DB7PR08MB3563.eurprd08.prod.outlook.com (2603:10a6:10:4d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:16 +0000 X-Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:0:cafe::66) by AM5PR0102CA0011.outlook.office365.com (2603:10a6:206::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Sun, 29 Mar 2020 15:14:16 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56572+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:16 +0000 X-Received: ("Tessian outbound 66307db0259d:v48"); Sun, 29 Mar 2020 15:14:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 22592d0bc064360d X-CR-MTA-TID: 64aa7808 X-Received: from 088483b25b7e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 247C0890-8987-4601-BAFB-4A236620C99F.1; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 088483b25b7e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:08 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UDzK8uEkr7E4laopzt0MeEPteMLfkd58eXptUYo3WuypzuYN+tz/j4+/zi/2kFPMnCQSDnGx4p156d/z5LJA8/+f6XPuGO9r1Q0aNblu6u5Qc9csmS2ija3+ZJZ2/86zZG2bj+6X+VymxtNhQN1bcyiJIHgI5b1+wG7WzIA1tafz/oE+jm4F7m96M/KLx02FOo7/phJfXfaHTMA5ZWl+pPctn/Za/HwPvazZONOvQ5UoNn2RhaLfQmHa+183v8cGcovRfCo0byqxnKjWuVRGGlcjpZV5psLKM63WXRiAZ2jbAyZcV9Jo0olylAVal8e7QKcH9CKFBYtLECf0DowL9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cuqpqrGQYzresOgmd16U6ZSIqX/qs8kXbD8plncGg8=; b=ip9qTEMChMOrxeA/NzCjZXB9i407gqfzxP99VsAyaeuEf5rvfaMmJGCmuDS2HDF1hZ/127BkejMhsGy+aAdzmeV0VCxfBe0bKel+zY3qxUGu+SUBio3c9HJycjnyfFPyu6UomK8DjCnCaG9K8Siz8D+YrnipW+7rNJ7HtsjTdIl067N5ypz59siT9UH2KemrMTC4iuRgX7hZTOOcSd3N1+yaafoDja+BO1NGFfIQFhN9DM4GVa2Y2Y95meQd/4+h0zVrSullzXtz9VV/V7nUxx13OISNnTwLB6kK+MhrcBNghNRWSjOLx4mHzUNPYN3LZ3hX3e8im0+2egac+3grmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM4PR0902CA0015.eurprd09.prod.outlook.com (2603:10a6:200:9b::25) by AM6PR08MB3845.eurprd08.prod.outlook.com (2603:10a6:20b:85::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Sun, 29 Mar 2020 15:14:07 +0000 X-Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:200:9b:cafe::d0) by AM4PR0902CA0015.outlook.office365.com (2603:10a6:200:9b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:07 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:07 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:02 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:02 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 10/16] DynamicTablesPkg: Serial debug port initialisation Date: Sun, 29 Mar 2020 16:13:47 +0100 Message-ID: <20200329151353.14096-11-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(346002)(136003)(39850400004)(396003)(46966005)(81166006)(81156014)(8676002)(2616005)(70206006)(70586007)(47076004)(966005)(6916009)(478600001)(8936002)(5660300002)(2906002)(7696005)(54906003)(4326008)(44832011)(86362001)(186003)(336012)(36756003)(6666004)(356004)(26005)(82740400003)(426003)(1076003)(316002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f7fd07f6-cd24-43db-d756-08d7d3f3d8c4 X-MS-TrafficTypeDiagnostic: AM6PR08MB3845:|DB7PR08MB3563: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8273;OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: eUQA5WcmLw/0bIuAZxNm5JZdkpd0w2NERarIzmr9QTp2HoVGPKnBd0jMOBT21iZDsyErnk/54aVzz51eZbnN2rieJ/dg7rCrWnAp5rNX8U45dIMtjVD/zJU84Id8BiB50Z0OPHSD46MUOKk6rz2iVCVda1l3OCWFNYyUaG57fubJHIB6m4HAhJE6VqBIPFbnB8PjMJNC/EKp7IOPpw1Ml61+wfjMVamr/vqTqti4ryZ2dmPpcyWVfJVDD1meokxzWf3zftI/w8Xx0eOWmFtPncI5dQnx9qjy6cVvgcvlKztGgrkNMbgedAxSs87V8/m0Q+UTO7IhRRnqck3WLtnQlfYmxT+Yh0kfzfJVmAOJv+wV9kGbCm23yYsKNNhrmZ2JPOGsCOo8WcxPoRi27Q6hKN42sJQ5nAftWgaKG/q9yQSJFKCPk2qvlQedVG6tIiG6gEzNaEb41YDVBaeMF9WoAERPb/SSmYM2Sgw4ml43Ggaba2RYPQSEG8Zg+PXu1YI7us0jP4CK7kYmkWBOlEZwAlHdiKSuromghutLcrtZa9QUKgaLxI6OEcKzfyKQ1kBaO1fBM+a6mrNpp0/iIbK1hLYMeSYNJ11Tm8al56AAu1k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3845 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 6683e4cb-ad8c-4c67-7916-08d7d3f3d38b X-Microsoft-Antispam-Message-Info: Are8c8w5YNpCVWs7eZVWFm1GnjbO2V3mOA6Y0+Aym7ob59NuoxcMHrvTUK0DPqjNs9WlHgZvFlqB6quAKe153FNu6OS8MCA5TbR3cFjaCZM4bRMiVi9YF2lRQRugk+w5QnNmmegN5YxQU+cOB7ZhG6GWZR50cfB//KgXlDBENqtnrUGsM15OZI80oJK9UgOMlSPKEzTZqEEP7SLSyxHR97UWCLoT6X4S79giQkqoxLE9eN7GKYyMqBdREUHR3n5Sh3AWpPYAarl6ov+JE5t6aZVbUZW8LbIGHPOaAURnIiNZRWKNFfLnvEoc3Bhe3DJxNgKhu+qEIA4dC4HqK/HvlmUzesL1fO1MY67QZ1n0x9e82s2b5nhRfszPBSI21TBpFgJ0PnFDNqep0B29enTnayHbz+gzD8JT/l5q98djVwxM2T3cPntUAi+7pArUpbEwIeHrt0cTvEVyZs3g+3O3qvweNm+pMXyuoSzrWVzqA8K+xV1O35CSJpVnORo5b9BZwTeCwJwS5KHYdmAMWZTq5XmZOZV2t2dCc++VQF80ZUXrQs2BxPt7iZ4NcujsUT2mAV4V3SPiIxuy1eBzMS4PZSokTO6lRyLrjA5gBwxLhHo= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:16.2936 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f7fd07f6-cd24-43db-d756-08d7d3f3d8c4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3563 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: PpolblVEQXkCopJVYlZthVTOx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494860; bh=ibfmF1sBgrNPLljNtGumzVzCBYEb56ynZuBv56oQ3Xo=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=lwwgvhxC1otB5X9TKb2EfYD3uXXhk2CYbZ+LBebJNa04D5juRR8geprzfbn5pXuhFJl xRjBaOKHhRfuXh+qlk0gHIVy0bekiSG/fxrs+1WFeOvbtwYDAB5b9OQ1SlfUCuMIgZdyo 7V1QT/GPLfbYybyya52uLS4ZyfADNEynjoo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The ARM DCC serial port subtype is an option that is supported by the DBG2 generator. However, the serial port initialisation should only be done for PL011/SBSA compatible UARTs. Add check to conditionally initialise the serial port. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Philippe Mathieu-Daude --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 27 ++++= ++++++++-------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c index 346ab5b22f5402bf87c385558f68f080d1b454ed..51c843d25f75388104694855ce1= 33b3d61860196 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c @@ -175,7 +175,7 @@ GET_OBJECT_LIST ( CM_ARM_SERIAL_PORT_INFO ); =20 -/** Initialize the PL011 UART with the parameters obtained from +/** Initialize the PL011/SBSA UART with the parameters obtained from the Configuration Manager. =20 @param [in] SerialPortInfo Pointer to the Serial Port Information. @@ -353,15 +353,22 @@ BuildDbg2Table ( AcpiDbg2.Dbg2DeviceInfo[DBG_PORT_INDEX_PORT1].Dbg2Device.PortSubtype =3D SerialPortInfo->PortSubtype; =20 - // Initialize the serial port - Status =3D SetupDebugUart (SerialPortInfo); - if (EFI_ERROR (Status)) { - DEBUG (( - DEBUG_ERROR, - "ERROR: DBG2: Failed to configure debug serial port. Status =3D %r\n= ", - Status - )); - goto error_handler; + if ((SerialPortInfo->PortSubtype =3D=3D + EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART) || + (SerialPortInfo->PortSubtype =3D=3D + EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X) || + (SerialPortInfo->PortSubtype =3D=3D + EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART)) { + // Initialize the serial port + Status =3D SetupDebugUart (SerialPortInfo); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "ERROR: DBG2: Failed to configure debug serial port. Status =3D %r= \n", + Status + )); + goto error_handler; + } } =20 *Table =3D (EFI_ACPI_DESCRIPTION_HEADER*)&AcpiDbg2; --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56572): https://edk2.groups.io/g/devel/message/56572 Mute This Topic: https://groups.io/mt/72631549/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56571+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494860509828.2198050829841; Sun, 29 Mar 2020 08:14:20 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id PYg1YY1788612xmCLAPGZt2G; Sun, 29 Mar 2020 08:14:20 -0700 X-Received: from EUR02-AM5-obe.outbound.protection.outlook.com (EUR02-AM5-obe.outbound.protection.outlook.com [40.107.0.60]) by mx.groups.io with SMTP id smtpd.web10.29265.1585494859051360853 for ; Sun, 29 Mar 2020 08:14:19 -0700 X-Received: from AM7PR02CA0009.eurprd02.prod.outlook.com (2603:10a6:20b:100::19) by VI1PR0801MB1758.eurprd08.prod.outlook.com (2603:10a6:800:53::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:15 +0000 X-Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:100:cafe::42) by AM7PR02CA0009.outlook.office365.com (2603:10a6:20b:100::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Sun, 29 Mar 2020 15:14:15 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56571+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:15 +0000 X-Received: ("Tessian outbound 19f8d550f75c:v48"); Sun, 29 Mar 2020 15:14:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b516681592bacb13 X-CR-MTA-TID: 64aa7808 X-Received: from dc1e0481db73.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B9DA632-2E25-4ED1-AC58-3EB0207FF30F.1; Sun, 29 Mar 2020 15:14:10 +0000 X-Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dc1e0481db73.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V4Ib9VECAMcjVy7yIHqECuLvL2dnWF2RCS8gzPYTT2ZRezfgv3FXTy8xR96PUlxh/zHwHSaOnPDYr0ZHT8FkscDV1uClbk08mMkNvEbqLP3kKtUAR0HyKwYBXfQyP6BKNmsX4aNN0nOwcJA/4R5/Y/gCUlbv7qkxlI6yFEI4AGTczM20T4h/apPNlNxpruz9wOranAbe05IKyfzrNDp1+eU+KeHA/00SPW28jc4UEqWtE8zsgdkDhXEnLlMOfI3C77p3435hD4H9nqAUTXddsgyudpDhDBDRRVpaTJN6afe/wPWI2psCJPBt8Cj7jVWLsK1aqQ30j5pqGHq5awwadA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qH43ch7RU334KxupLx9JFiSAv768gjLjuVOQpLhAz3k=; b=cKVx8sLoDpvEa5swTF+YXyP0AepFOW9902uQQYaBOTcQtOcaJFFW0URPVfwNBkBLedotlBv2jE7+NmB5NCgimuOwGgcujjar7cdeP9aCFiUVOKNcEl8xrkH2MKJzbYbnHin7OlyjqbP3K8kSpD7rwz0Qk3bpp8EUZvdIqkO0Sp3xHCjU86ocamBH4T8D5RQM0C0NLdhSBgBUIa5BmKHbwlyjkjRcHE8bwG5skIy0guux5ow66TZHUSU5vY9tWSd7T2/cyFrlMzL4V9wJeUQD8NT1OjlucK11oS/ZNFoGDUybFtEXQvApmnQmMeIlhsthnM2vy2UK0gtSh8D8/X+DuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM0PR01CA0035.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::48) by AM0PR08MB5411.eurprd08.prod.outlook.com (2603:10a6:208:181::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:69:cafe::47) by AM0PR01CA0035.outlook.office365.com (2603:10a6:208:69::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:08 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:03 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 11/16] DynamicTablesPkg: Remove redundant frame count check Date: Sun, 29 Mar 2020 16:13:48 +0100 Message-ID: <20200329151353.14096-12-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(396003)(376002)(346002)(39850400004)(136003)(46966005)(86362001)(47076004)(44832011)(6916009)(8936002)(6666004)(356004)(82740400003)(7696005)(70586007)(8676002)(186003)(2906002)(1076003)(81156014)(426003)(336012)(81166006)(4326008)(70206006)(36756003)(54906003)(478600001)(966005)(316002)(2616005)(26005)(5660300002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f8385093-e95c-4f06-37f3-08d7d3f3d826 X-MS-TrafficTypeDiagnostic: AM0PR08MB5411:|VI1PR0801MB1758: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2043;OLM:2043; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3YTNmHZgvpvS7J5u6IN7e5Vad45m5i8mpKNkf48ZtVGAAtF5rAjnuRUDCw1/j4zymt2RK9mbpff2ecD3+Z6yPqrkhZdEPD9mib3fU7WZKKUZOIc64YWA97Zti8IN+wnfqLrDMLDbsVrTwFfHN0OojBW7T4TpmaNQ3X/eLWqqM9qFhluyuptqckxgzkV03u90ATE8P6KXzs34l2LLQKvabxQf+5cgOHaU8P9SHqe8+T5YXzq+pnmECcT0ascErDXR97AZXqGXeaThbd7V6+XLxaLNHzCLh8dsANuQ218/IvLQcWxRYNwp3mu+m9wcqzywAlPLKSnSVwoF1BaiWxnEXIcNdfxT8d9hX1z/IxC6t76prv86wEGRkS1t1D2NNQ/50ae3GH4g8pXhLxGx3j/eR/g+RARx1v3Dab3QquoMbRzLX03ACE+ayZgcgAyyrVvC/hS9eKJMkWIeqIPCp3kmcVwyhWqj6AqGNK0C7uV69iafqf8N3aSLqJ4tF0E4eKNYgtgj6YMXy95OUoF6992vE3vU2cvPJITeok1b8hZZ4RumZC193OtqwJCQ/lYFIJxkOybMoSJKMseiD7YXiKaIY5uXegSxFNpg2FUzHdirecw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5411 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e5f7a42-fd0b-44b9-9031-08d7d3f3d402 X-Microsoft-Antispam-Message-Info: uqHf7lRHIoOHFpId9kqWaDfc20k9x1VhKR8lwChL2yBRJ9B4/ixt9GuobgMv/ZHtmcAaZlehCdMyiBFNTs0X7fkrOglDJC7MD33cCACUwmDmoH7GZfc+yVLKJEb5oH1CvV5zpw+WWT4sXmi96+CGD6WlXyLOGS0S+d9s6nwOW+E9/rVos5C10tPWSzZDnw//lHVPJ5KcKtvNBqOgQgo8J+n/04LKi/sXZErY0rG0ioAUYql5MU1GydizrLIKVyqy5uJTYt9QF4ABQCqJJe30tfb4JpRUqsUExv9QrqHEoXaQmve/rA+RIFmGi+n5SCPEuH1MuYpq8sE5ZJVKIsOuRUZdt5g9SGhhGiZyZcMUnNeRsmmbM7qYq3HygXZZ7cXaT6069Cs1tK7AxPtniyb1ZFEGJ1Um+/AvPL1/L5oIQlqhfHFptmG9sr7uIif3dC6hUtwdb+vP2XQoPsKnbjgCgUzCMn/+0LVh5iDO2MVWpG7KBf5yzOWe0oSq+9bdGQ6faOJir/wN9T4sSzJUf57IkaIH2sjnUgOzLVid8NpfwxGB8pyh3Kt6GVBkw3D0VKMZPJhJFtM7n3PeDN5W2o5wompEPTbQ30r2JKRm6xEZ+ao= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:15.2491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8385093-e95c-4f06-37f3-08d7d3f3d826 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1758 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 9HaUi0a48XcwS3X0uHeLGtC2x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494860; bh=X7Ftfcnok35tCcdS8Z7ou33/uNP8xsPLHfow4kH4NUI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=AVK5CFzpKAuq+d4k9Qrly5PbuIybkqhIY/J64Vxzg1loxwYTVaWQaWANXN0AHRsvc77 kD6k9siaIP7fT111bC67FwBeZp3WP3uypQLonYTdcXDsvSm8eJHtHsYkSjTC6u+JY4j73 ksZZI6M997dKHbsbKWq8JP18m/j+AEHqPBM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Removing GT Block frame count check from AddGTBlockTimerFrames() as this is already validated in BuildGtdtTable(). Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 10 ----= ------ 1 file changed, 10 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c index 0e996698887aefca8a7240fc27fe3cb9324fd3e2..c109f2ac207311646e5a4ad3aa4= 65b1c2883e465 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c @@ -259,16 +259,6 @@ AddGTBlockTimerFrames ( ASSERT (GtBlockFrame !=3D NULL); ASSERT (GTBlockTimerFrameList !=3D NULL); =20 - if (GTBlockFrameCount > 8) { - DEBUG (( - DEBUG_ERROR, - "ERROR: GTDT: GT Block Frame Count %d is greater than 8\n", - GTBlockFrameCount - )); - ASSERT (GTBlockFrameCount <=3D 8); - return EFI_INVALID_PARAMETER; - } - IsFrameNumberDuplicated =3D FindDuplicateValue ( GTBlockTimerFrameList, GTBlockFrameCount, --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56571): https://edk2.groups.io/g/devel/message/56571 Mute This Topic: https://groups.io/mt/72631548/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56573+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494861841389.1859812772353; Sun, 29 Mar 2020 08:14:21 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id rGlxYY1788612xyoSOBKoFAF; Sun, 29 Mar 2020 08:14:21 -0700 X-Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.41]) by mx.groups.io with SMTP id smtpd.web10.29266.1585494860528977886 for ; Sun, 29 Mar 2020 08:14:21 -0700 X-Received: from AM5P194CA0010.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::20) by DB6PR0801MB2008.eurprd08.prod.outlook.com (2603:10a6:4:77::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:17 +0000 X-Received: from AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::da) by AM5P194CA0010.outlook.office365.com (2603:10a6:203:8f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:17 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56573+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT057.mail.protection.outlook.com (10.152.17.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:17 +0000 X-Received: ("Tessian outbound 6835489d965f:v48"); Sun, 29 Mar 2020 15:14:17 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9d46a402a96c79ca X-CR-MTA-TID: 64aa7808 X-Received: from d3731481aa9b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A9F0421-A0E2-493E-A8BB-324BF7C8115E.1; Sun, 29 Mar 2020 15:14:11 +0000 X-Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d3731481aa9b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HgGcHzazN3AllZ3gGj1Tn7KEuBNOYUHJTseoFxZORpBuwvHZJO4dQZSIm7QzhVYzw8z6BpKVrkSmbsycGL6tYFuaz/k6FXeVuQEs/r34ePbngwI4GzrfFSPxNWO0KdLytyLzekPSPCCi3mnGsIq9h8B/bgsGE0m5wBK+ZCp9NkpeoefUcXxuIjfrwFx4aAAV530+yctBAW/VscV+n1BS8d/LQVg3g9yIM+oYoj5HLfVdfPg4bkuXTloJhI9o+Vl0zSZnnU3ZRMWl5JSscOgHtnAaE+s6fwMKDwsuls2nvqil7fnvm39hKhCJoZUaTIdi105Ybm3bErB9xybcFLvOlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UY8CLvn/lw9n7chAFrrYBeDrbo9iCmbV8io9F/kgLD4=; b=UO7ojvgumUebfNQ/QyEffA6FnP3fHKlMBlQQ5pNdJhTkE3mcp0pc9hmq1sSVmhaQQb37l2OmpCSET0LUPlePgajCM601wouqYDx7+vemRZUkNz5hm1v0Zro+HLOz1uQm7Bss6x73nof8s4PmfGqxghv4ANPePLvCBIJXa/Vbbz/01TveDGIyRPK1YJfGxOxSYLguxz6E3atqnuH4z72C2bJzgzvoO64bwe3ExlcppjxQ1174hTuVwbYSillUr+pUl4eSKEyU1jKVzL4FjnCHo2fFCtj5Pke8HzphY1rdBmTtInitgu730azADtZhEBNQSDQC7a7mUoNH94oNM6jpvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM0PR01CA0020.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::33) by HE1PR0801MB1945.eurprd08.prod.outlook.com (2603:10a6:3:4f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:69:cafe::4) by AM0PR01CA0020.outlook.office365.com (2603:10a6:208:69::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:09 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:07 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:14:04 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:04 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 12/16] DynamicTablesPkg: Fix IORT node length assignment Date: Sun, 29 Mar 2020 16:13:49 +0100 Message-ID: <20200329151353.14096-13-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39850400004)(346002)(376002)(396003)(136003)(46966005)(5660300002)(316002)(54906003)(478600001)(966005)(86362001)(82740400003)(6916009)(47076004)(70586007)(2616005)(44832011)(186003)(336012)(26005)(426003)(70206006)(19627235002)(1076003)(2906002)(8676002)(36756003)(30864003)(356004)(6666004)(81166006)(81156014)(8936002)(4326008)(7696005);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f16b56d-1590-4cd9-6622-08d7d3f3d955 X-MS-TrafficTypeDiagnostic: HE1PR0801MB1945:|DB6PR0801MB2008: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:9508;OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8ABorV4fqIiOZI0w9EHCbqt+Y79v4ZL/o0+iLAHXm4mAiFLK1WRObDu/5yvH9/8+whWpI7QEDyLZuEqozooK56LRwtQU+g23UyjCNye9ju1QmuPvi00xQqFvWRHs/rqtSE0WXLgwLpuU1geHK48UBOkCMJkhX+chWU8kfcb7Wa0B3I8YFTXr92ZeRLIMCpEgyDo8SV3y/Px7PtsuG8e+6c/v4/SUQAryoTh37RjDDpVPBV2SiNY0qq8+qDM1h8Vh2DbPyMz/a4XxqzqUshBm7t7kmS00upgHpHIdx5rbM+yp19aOdqJsjtPzw/oOIOur2pGHFpaBJ7waEK2sq1rRr2QQa3y0ExOI89HKHsQL1VEZlmSWRPhPjHCVWb7ubMY5cxKOCfABIg4WZx8X3sC25V+YOSgIPMwjNsHF97lWfW25MwHqa01PhG1OgrzD1SrgKeY8ppgLNrretIeBMTiQLWOqp/fC75yUnO0iuCCrIzLcusWjXEzkhvFQkPkK6Dkr0yTo+lmUNGO8lAL46D6X0qeVLqieE++1fbuPNpuaDTwfFpgNy+O0arrXgeoTFvoiCFm/cR5qipYifJW7Ek2ZSDUT7aQHvMfy72WAHzXZOVg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1945 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 744c4fb8-e03c-4ef3-6b2c-08d7d3f3d492 X-Microsoft-Antispam-Message-Info: kJA9PTHhPS2As9kO3CrEc4YGfBU0TVt0ev/gBUcHWXOipaBAL//8UOH2u1hCsdimiFLUMCILKFGpwWjyw9MfTGfiQGCXoKC/1hF3u3EFaVn3oqYciYO8Rby9V9+ApzOwliPbuk+8suxX7sNz9VGOxVzO9gFQDj5xMv+RKG0wNp1ygFIus2W8/HpgJ6AlhrZVb6OsCngCe57hmTOD7g6OztMetZvxcS0fy7PA2Hi8G08f2bvzM3E7T/IMnNNa9mJMwp4JVd0xAswyh+S0Pm+JxF8mYttyEXOP4o4hplp94/fs1FcK5njZo5RYlwMocNefIM25+vWXQvb3Y1jvnNP6XHn+97JfwZoaIBQfTJQ9XGEqxAnuXr1U+d7dnTDJczMPjHdi/8OfikiOxITGJTlzL6mWNvg4gZEodOzokNqld4fGY6POcmWSuLf/zFUtdhOUxm/JLpmCNmK/7IWKJTz7tpQcqG6zUi8bI1lRx2obKAteZ4PKXcLKhjZunpQsqTlnBrhv3NL++A4EOa37s0rV4BzOYFpQxijNZy7mZeO033eeCGubd90LsbYTZ23U9GljBPUCxmVuQuLj8vzbZyBdw8ktTRxJpnB11WUlEbtzZZw= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:17.2200 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9f16b56d-1590-4cd9-6622-08d7d3f3d955 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2008 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: EVUhl4CqJ6O4My54x9ZtJIcWx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494861; bh=bwlVvegxgndzbsCJjelicOnZX2wfzcDyk8GpwyJyd84=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=aXrqvbuVLEo8HGRWy33RAbs3AknIhAFXVOJw4ro/5yv6BgHQMfw9GgWn3bNkPV2UahR Zl9SJdU5MIItVNikbd8RNIXXv046TTBz6Zn9HllIN+Tbke6S7b8TAeW41kYWuMHApxmXM SkZbwotjFIcPsiw/B8kKOi0B0jx2WtV0Cak= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The VS2017 compiler reports 'warning C4267: 'return': conversion from 'size_t' to 'UINT32', possible loss of data' for a number of functions that compute the IORT node length. Similarly, it reports warnings for IORT node length field assignments as the length field is 16-bit wide. This patch adds type casts at appropriate places and also implements validations to ensure that the max width of the respective fields is not exceeded. This patch also fixes a typo in one of the local variable names. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 352 +++= +++++++++++------ 1 file changed, 253 insertions(+), 99 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c index f303e9f29cc700634d236c08505cab91b9d62cb8..bd71220ca19679792de2bb6d88e= ed8d1913a7600 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c @@ -140,8 +140,8 @@ GetItsGroupNodeSize ( /* Size of ITS Group Node + Size of ITS Identifier array */ - return sizeof (EFI_ACPI_6_0_IO_REMAPPING_ITS_NODE) + - (Node->ItsIdCount * sizeof (UINT32)); + return (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_ITS_NODE) + + (Node->ItsIdCount * sizeof (UINT32))); } =20 /** Returns the total size required for the ITS Group nodes and @@ -160,7 +160,7 @@ GetItsGroupNodeSize ( @retval Total size of the ITS Group Nodes. **/ STATIC -UINT32 +UINT64 GetSizeofItsGroupNodes ( IN CONST UINT32 NodeStartOffset, IN CONST CM_ARM_ITS_GROUP_NODE * NodeList, @@ -168,7 +168,7 @@ GetSizeofItsGroupNodes ( IN OUT IORT_NODE_INDEXER ** CONST NodeIndexer ) { - UINT32 Size; + UINT64 Size; =20 ASSERT (NodeList !=3D NULL); =20 @@ -176,7 +176,7 @@ GetSizeofItsGroupNodes ( while (NodeCount-- !=3D 0) { (*NodeIndexer)->Token =3D NodeList->Token; (*NodeIndexer)->Object =3D (VOID*)NodeList; - (*NodeIndexer)->Offset =3D Size + NodeStartOffset; + (*NodeIndexer)->Offset =3D (UINT32)(Size + NodeStartOffset); DEBUG (( DEBUG_INFO, "IORT: Node Indexer =3D %p, Token =3D %p, Object =3D %p, Offset =3D = 0x%x\n", @@ -211,10 +211,10 @@ GetNamedComponentNodeSize ( Size of ID mapping array + Size of ASCII string + 'padding to 32-bit word aligned'. */ - return sizeof (EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE) + - (Node->IdMappingCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)) + - ALIGN_VALUE (AsciiStrSize (Node->ObjectName), 4); + return (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE) + + (Node->IdMappingCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)) + + ALIGN_VALUE (AsciiStrSize (Node->ObjectName), 4)); } =20 /** Returns the total size required for the Named Component nodes and @@ -233,7 +233,7 @@ GetNamedComponentNodeSize ( @retval Total size of the Named Component nodes. **/ STATIC -UINT32 +UINT64 GetSizeofNamedComponentNodes ( IN CONST UINT32 NodeStartOffset, IN CONST CM_ARM_NAMED_COMPONENT_NODE * NodeList, @@ -241,7 +241,7 @@ GetSizeofNamedComponentNodes ( IN OUT IORT_NODE_INDEXER ** CONST NodeIndexer ) { - UINT32 Size; + UINT64 Size; =20 ASSERT (NodeList !=3D NULL); =20 @@ -249,7 +249,7 @@ GetSizeofNamedComponentNodes ( while (NodeCount-- !=3D 0) { (*NodeIndexer)->Token =3D NodeList->Token; (*NodeIndexer)->Object =3D (VOID*)NodeList; - (*NodeIndexer)->Offset =3D Size + NodeStartOffset; + (*NodeIndexer)->Offset =3D (UINT32)(Size + NodeStartOffset); DEBUG (( DEBUG_INFO, "IORT: Node Indexer =3D %p, Token =3D %p, Object =3D %p, Offset =3D = 0x%x\n", @@ -284,9 +284,9 @@ GetRootComplexNodeSize ( /* Size of Root Complex node + Size of ID mapping array */ - return sizeof (EFI_ACPI_6_0_IO_REMAPPING_RC_NODE) + - (Node->IdMappingCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)); + return (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_RC_NODE) + + (Node->IdMappingCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE))); } =20 /** Returns the total size required for the Root Complex nodes and @@ -305,7 +305,7 @@ GetRootComplexNodeSize ( @retval Total size of the Root Complex nodes. **/ STATIC -UINT32 +UINT64 GetSizeofRootComplexNodes ( IN CONST UINT32 NodeStartOffset, IN CONST CM_ARM_ROOT_COMPLEX_NODE * NodeList, @@ -313,7 +313,7 @@ GetSizeofRootComplexNodes ( IN OUT IORT_NODE_INDEXER ** CONST NodeIndexer ) { - UINT32 Size; + UINT64 Size; =20 ASSERT (NodeList !=3D NULL); =20 @@ -321,7 +321,7 @@ GetSizeofRootComplexNodes ( while (NodeCount-- !=3D 0) { (*NodeIndexer)->Token =3D NodeList->Token; (*NodeIndexer)->Object =3D (VOID*)NodeList; - (*NodeIndexer)->Offset =3D Size + NodeStartOffset; + (*NodeIndexer)->Offset =3D (UINT32)(Size + NodeStartOffset); DEBUG (( DEBUG_INFO, "IORT: Node Indexer =3D %p, Token =3D %p, Object =3D %p, Offset =3D = 0x%x\n", @@ -358,13 +358,13 @@ GetSmmuV1V2NodeSize ( Size of context interrupt array + Size of PMU interrupt array */ - return sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU_NODE) + - (Node->IdMappingCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)) + - (Node->ContextInterruptCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT)) + - (Node->PmuInterruptCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT)); + return (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU_NODE) + + (Node->IdMappingCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)) + + (Node->ContextInterruptCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT)) + + (Node->PmuInterruptCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT))); } =20 /** Returns the total size required for the SMMUv1/SMMUv2 nodes and @@ -383,7 +383,7 @@ GetSmmuV1V2NodeSize ( @retval Total size of the SMMUv1/SMMUv2 nodes. **/ STATIC -UINT32 +UINT64 GetSizeofSmmuV1V2Nodes ( IN CONST UINT32 NodeStartOffset, IN CONST CM_ARM_SMMUV1_SMMUV2_NODE * NodeList, @@ -391,7 +391,7 @@ GetSizeofSmmuV1V2Nodes ( IN OUT IORT_NODE_INDEXER ** CONST NodeIndexer ) { - UINT32 Size; + UINT64 Size; =20 ASSERT (NodeList !=3D NULL); =20 @@ -399,7 +399,7 @@ GetSizeofSmmuV1V2Nodes ( while (NodeCount-- !=3D 0) { (*NodeIndexer)->Token =3D NodeList->Token; (*NodeIndexer)->Object =3D (VOID*)NodeList; - (*NodeIndexer)->Offset =3D Size + NodeStartOffset; + (*NodeIndexer)->Offset =3D (UINT32)(Size + NodeStartOffset); DEBUG (( DEBUG_INFO, "IORT: Node Indexer =3D %p, Token =3D %p, Object =3D %p, Offset =3D = 0x%x\n", @@ -433,9 +433,9 @@ GetSmmuV3NodeSize ( /* Size of SMMU v1/SMMU v2 node + Size of ID mapping array */ - return sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE) + - (Node->IdMappingCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)); + return (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE) + + (Node->IdMappingCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE))); } =20 /** Returns the total size required for the SMMUv3 nodes and @@ -454,7 +454,7 @@ GetSmmuV3NodeSize ( @retval Total size of the SMMUv3 nodes. **/ STATIC -UINT32 +UINT64 GetSizeofSmmuV3Nodes ( IN CONST UINT32 NodeStartOffset, IN CONST CM_ARM_SMMUV3_NODE * NodeList, @@ -462,7 +462,7 @@ GetSizeofSmmuV3Nodes ( IN OUT IORT_NODE_INDEXER ** CONST NodeIndexer ) { - UINT32 Size; + UINT64 Size; =20 ASSERT (NodeList !=3D NULL); =20 @@ -470,7 +470,7 @@ GetSizeofSmmuV3Nodes ( while (NodeCount-- !=3D 0) { (*NodeIndexer)->Token =3D NodeList->Token; (*NodeIndexer)->Object =3D (VOID*)NodeList; - (*NodeIndexer)->Offset =3D Size + NodeStartOffset; + (*NodeIndexer)->Offset =3D (UINT32)(Size + NodeStartOffset); DEBUG (( DEBUG_INFO, "IORT: Node Indexer =3D %p, Token =3D %p, Object =3D %p, Offset =3D = 0x%x\n", @@ -504,9 +504,9 @@ GetPmcgNodeSize ( /* Size of PMCG node + Size of ID mapping array */ - return sizeof (EFI_ACPI_6_0_IO_REMAPPING_PMCG_NODE) + - (Node->IdMappingCount * - sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE)); + return (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_PMCG_NODE) + + (Node->IdMappingCount * + sizeof (EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE))); } =20 /** Returns the total size required for the PMCG nodes and @@ -525,7 +525,7 @@ GetPmcgNodeSize ( @retval Total size of the PMCG nodes. **/ STATIC -UINT32 +UINT64 GetSizeofPmcgNodes ( IN CONST UINT32 NodeStartOffset, IN CONST CM_ARM_PMCG_NODE * NodeList, @@ -533,7 +533,7 @@ GetSizeofPmcgNodes ( IN OUT IORT_NODE_INDEXER ** CONST NodeIndexer ) { - UINT32 Size; + UINT64 Size; =20 ASSERT (NodeList !=3D NULL); =20 @@ -541,7 +541,7 @@ GetSizeofPmcgNodes ( while (NodeCount-- !=3D 0) { (*NodeIndexer)->Token =3D NodeList->Token; (*NodeIndexer)->Object =3D (VOID*)NodeList; - (*NodeIndexer)->Offset =3D Size + NodeStartOffset; + (*NodeIndexer)->Offset =3D (UINT32)(Size + NodeStartOffset); DEBUG (( DEBUG_INFO, "IORT: Node Indexer =3D %p, Token =3D %p, Object =3D %p, Offset =3D = 0x%x\n", @@ -735,6 +735,7 @@ AddItsGroupNodes ( CM_ARM_ITS_IDENTIFIER * ItsIdentifier; UINT32 ItsIdentifierCount; UINT32 IdIndex; + UINT64 NodeLength; =20 ASSERT (Iort !=3D NULL); =20 @@ -742,9 +743,22 @@ AddItsGroupNodes ( NodesStartOffset); =20 while (NodeCount-- !=3D 0) { + NodeLength =3D GetItsGroupNodeSize (NodeList); + if (NodeLength > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: ITS Id Array Node length 0x%lx > MAX_UINT16." + " Status =3D %r\n", + NodeLength, + Status + )); + return Status; + } + // Populate the node header ItsGroupNode->Node.Type =3D EFI_ACPI_IORT_TYPE_ITS_GROUP; - ItsGroupNode->Node.Length =3D GetItsGroupNodeSize (NodeList); + ItsGroupNode->Node.Length =3D (UINT16)NodeLength; ItsGroupNode->Node.Revision =3D 0; ItsGroupNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; ItsGroupNode->Node.NumIdMappings =3D 0; @@ -825,8 +839,9 @@ AddNamedComponentNodes ( EFI_STATUS Status; EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE * NcNode; EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE * IdMapArray; - UINT32 ObjectNameLenght; CHAR8 * ObjectName; + UINTN ObjectNameLength; + UINT64 NodeLength; =20 ASSERT (Iort !=3D NULL); =20 @@ -834,18 +849,30 @@ AddNamedComponentNodes ( NodesStartOffset); =20 while (NodeCount-- !=3D 0) { + NodeLength =3D GetNamedComponentNodeSize (NodeList); + if (NodeLength > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Named Component Node length 0x%lx > MAX_UINT16." + " Status =3D %r\n", + NodeLength, + Status + )); + return Status; + } + // Populate the node header NcNode->Node.Type =3D EFI_ACPI_IORT_TYPE_NAMED_COMP; - NcNode->Node.Length =3D - GetNamedComponentNodeSize (NodeList); + NcNode->Node.Length =3D (UINT16)NodeLength; NcNode->Node.Revision =3D 2; NcNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; NcNode->Node.NumIdMappings =3D NodeList->IdMappingCount; =20 - ObjectNameLenght =3D AsciiStrLen (NodeList->ObjectName) + 1; + ObjectNameLength =3D AsciiStrLen (NodeList->ObjectName) + 1; NcNode->Node.IdReference =3D - sizeof (EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE) + - (ALIGN_VALUE (ObjectNameLenght, 4)); + (UINT32)(sizeof (EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE) + + (ALIGN_VALUE (ObjectNameLength, 4))); =20 // Named Component specific data NcNode->Flags =3D NodeList->Flags; @@ -860,7 +887,7 @@ AddNamedComponentNodes ( sizeof (EFI_ACPI_6_0_IO_REMAPPING_NAMED_COMP_NODE)); Status =3D AsciiStrCpyS ( ObjectName, - ObjectNameLenght, + ObjectNameLength, NodeList->ObjectName ); if (EFI_ERROR (Status)) { @@ -936,6 +963,7 @@ AddRootComplexNodes ( EFI_STATUS Status; EFI_ACPI_6_0_IO_REMAPPING_RC_NODE * RcNode; EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE * IdMapArray; + UINT64 NodeLength; =20 ASSERT (Iort !=3D NULL); =20 @@ -943,9 +971,22 @@ AddRootComplexNodes ( NodesStartOffset); =20 while (NodeCount-- !=3D 0) { + NodeLength =3D GetRootComplexNodeSize (NodeList); + if (NodeLength > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Root Complex Node length 0x%lx > MAX_UINT16." + " Status =3D %r\n", + NodeLength, + Status + )); + return Status; + } + // Populate the node header RcNode->Node.Type =3D EFI_ACPI_IORT_TYPE_ROOT_COMPLEX; - RcNode->Node.Length =3D GetRootComplexNodeSize (NodeList); + RcNode->Node.Length =3D (UINT16)NodeLength; RcNode->Node.Revision =3D 1; RcNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; RcNode->Node.NumIdMappings =3D NodeList->IdMappingCount; @@ -1093,6 +1134,7 @@ AddSmmuV1V2Nodes ( =20 EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT * ContextInterruptArray; EFI_ACPI_6_0_IO_REMAPPING_SMMU_INT * PmuInterruptArray; + UINT64 NodeLength; =20 ASSERT (Iort !=3D NULL); =20 @@ -1100,9 +1142,21 @@ AddSmmuV1V2Nodes ( NodesStartOffset); =20 while (NodeCount-- !=3D 0) { + NodeLength =3D GetSmmuV1V2NodeSize (NodeList); + if (NodeLength > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: SMMU V1/V2 Node length 0x%lx > MAX_UINT16. Status = =3D %r\n", + NodeLength, + Status + )); + return Status; + } + // Populate the node header SmmuNode->Node.Type =3D EFI_ACPI_IORT_TYPE_SMMUv1v2; - SmmuNode->Node.Length =3D GetSmmuV1V2NodeSize (NodeList); + SmmuNode->Node.Length =3D (UINT16)NodeLength; SmmuNode->Node.Revision =3D 0; SmmuNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; SmmuNode->Node.NumIdMappings =3D NodeList->IdMappingCount; @@ -1239,6 +1293,7 @@ AddSmmuV3Nodes ( EFI_STATUS Status; EFI_ACPI_6_0_IO_REMAPPING_SMMU3_NODE * SmmuV3Node; EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE * IdMapArray; + UINT64 NodeLength; =20 ASSERT (Iort !=3D NULL); =20 @@ -1246,9 +1301,21 @@ AddSmmuV3Nodes ( NodesStartOffset); =20 while (NodeCount-- !=3D 0) { + NodeLength =3D GetSmmuV3NodeSize (NodeList); + if (NodeLength > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: SMMU V3 Node length 0x%lx > MAX_UINT16. Status =3D %= r\n", + NodeLength, + Status + )); + return Status; + } + // Populate the node header SmmuV3Node->Node.Type =3D EFI_ACPI_IORT_TYPE_SMMUv3; - SmmuV3Node->Node.Length =3D GetSmmuV3NodeSize (NodeList); + SmmuV3Node->Node.Length =3D (UINT16)NodeLength; SmmuV3Node->Node.Revision =3D 2; SmmuV3Node->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; SmmuV3Node->Node.NumIdMappings =3D NodeList->IdMappingCount; @@ -1344,6 +1411,7 @@ AddPmcgNodes ( EFI_ACPI_6_0_IO_REMAPPING_PMCG_NODE * PmcgNode; EFI_ACPI_6_0_IO_REMAPPING_ID_TABLE * IdMapArray; ACPI_IORT_GENERATOR * Generator; + UINT64 NodeLength; =20 ASSERT (Iort !=3D NULL); =20 @@ -1352,9 +1420,21 @@ AddPmcgNodes ( NodesStartOffset); =20 while (NodeCount-- !=3D 0) { + NodeLength =3D GetPmcgNodeSize (NodeList); + if (NodeLength > MAX_UINT16) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: PMCG Node length 0x%lx > MAX_UINT16. Status =3D %r\n= ", + NodeLength, + Status + )); + return Status; + } + // Populate the node header PmcgNode->Node.Type =3D EFI_ACPI_IORT_TYPE_PMCG; - PmcgNode->Node.Length =3D GetPmcgNodeSize (NodeList); + PmcgNode->Node.Length =3D (UINT16)NodeLength; PmcgNode->Node.Revision =3D 1; PmcgNode->Node.Reserved =3D EFI_ACPI_RESERVED_DWORD; PmcgNode->Node.NumIdMappings =3D NodeList->IdMappingCount; @@ -1448,9 +1528,11 @@ BuildIortTable ( ) { EFI_STATUS Status; - UINT32 TableSize; + + UINT64 TableSize; + UINT64 NodeSize; + UINT32 IortNodeCount; - UINT32 ItsGroupNodeCount; UINT32 NamedComponentNodeCount; UINT32 RootComplexNodeCount; @@ -1638,81 +1720,141 @@ BuildIortTable ( =20 // ITS Group Nodes if (ItsGroupNodeCount > 0) { - ItsGroupOffset =3D TableSize; + ItsGroupOffset =3D (UINT32)TableSize; // Size of ITS Group node list. - TableSize +=3D GetSizeofItsGroupNodes ( - ItsGroupOffset, - ItsGroupNodeList, - ItsGroupNodeCount, - &NodeIndexer - ); + NodeSize =3D GetSizeofItsGroupNodes ( + ItsGroupOffset, + ItsGroupNodeList, + ItsGroupNodeCount, + &NodeIndexer + ); + if (NodeSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Invalid Size of Group Nodes. Status =3D %r\n", + Status + )); + goto error_handler; + } + TableSize +=3D NodeSize; } =20 // Named Component Nodes if (NamedComponentNodeCount > 0) { - NamedComponentOffset =3D TableSize; + NamedComponentOffset =3D (UINT32)TableSize; // Size of Named Component node list. - TableSize +=3D GetSizeofNamedComponentNodes ( - NamedComponentOffset, - NamedComponentNodeList, - NamedComponentNodeCount, - &NodeIndexer - ); + NodeSize =3D GetSizeofNamedComponentNodes ( + NamedComponentOffset, + NamedComponentNodeList, + NamedComponentNodeCount, + &NodeIndexer + ); + if (NodeSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Invalid Size of Named Component Nodes. Status =3D %r= \n", + Status + )); + goto error_handler; + } + TableSize +=3D NodeSize; } =20 // Root Complex Nodes if (RootComplexNodeCount > 0) { - RootComplexOffset =3D TableSize; + RootComplexOffset =3D (UINT32)TableSize; // Size of Root Complex node list. - TableSize +=3D GetSizeofRootComplexNodes ( - RootComplexOffset, - RootComplexNodeList, - RootComplexNodeCount, - &NodeIndexer - ); + NodeSize =3D GetSizeofRootComplexNodes ( + RootComplexOffset, + RootComplexNodeList, + RootComplexNodeCount, + &NodeIndexer + ); + if (NodeSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Invalid Size of Root Complex Nodes. Status =3D %r\n", + Status + )); + goto error_handler; + } + TableSize +=3D NodeSize; } =20 // SMMUv1/SMMUv2 Nodes if (SmmuV1V2NodeCount > 0) { - SmmuV1V2Offset =3D TableSize; + SmmuV1V2Offset =3D (UINT32)TableSize; // Size of SMMUv1/SMMUv2 node list. - TableSize +=3D GetSizeofSmmuV1V2Nodes ( - SmmuV1V2Offset, - SmmuV1V2NodeList, - SmmuV1V2NodeCount, - &NodeIndexer - ); + NodeSize =3D GetSizeofSmmuV1V2Nodes ( + SmmuV1V2Offset, + SmmuV1V2NodeList, + SmmuV1V2NodeCount, + &NodeIndexer + ); + if (NodeSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Invalid Size of SMMUv1/v2 Nodes. Status =3D %r\n", + Status + )); + goto error_handler; + } + TableSize +=3D NodeSize; } =20 // SMMUv3 Nodes if (SmmuV3NodeCount > 0) { - SmmuV3Offset =3D TableSize; + SmmuV3Offset =3D (UINT32)TableSize; // Size of SMMUv3 node list. - TableSize +=3D GetSizeofSmmuV3Nodes ( - SmmuV3Offset, - SmmuV3NodeList, - SmmuV3NodeCount, - &NodeIndexer - ); + NodeSize =3D GetSizeofSmmuV3Nodes ( + SmmuV3Offset, + SmmuV3NodeList, + SmmuV3NodeCount, + &NodeIndexer + ); + if (NodeSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Invalid Size of SMMUv3 Nodes. Status =3D %r\n", + Status + )); + goto error_handler; + } + TableSize +=3D NodeSize; } =20 // PMCG Nodes if (PmcgNodeCount > 0) { - PmcgOffset =3D TableSize; + PmcgOffset =3D (UINT32)TableSize; // Size of PMCG node list. - TableSize +=3D GetSizeofPmcgNodes ( - PmcgOffset, - PmcgNodeList, - PmcgNodeCount, - &NodeIndexer - ); + NodeSize =3D GetSizeofPmcgNodes ( + PmcgOffset, + PmcgNodeList, + PmcgNodeCount, + &NodeIndexer + ); + if (NodeSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: Invalid Size of PMCG Nodes. Status =3D %r\n", + Status + )); + goto error_handler; + } + TableSize +=3D NodeSize; } =20 DEBUG (( DEBUG_INFO, "INFO: IORT:\n" \ " IortNodeCount =3D %d\n" \ - " TableSize =3D %d\n", + " TableSize =3D 0x%lx\n", IortNodeCount, TableSize )); @@ -1765,6 +1907,18 @@ BuildIortTable ( PmcgOffset )); =20 + if (TableSize > MAX_UINT32) { + Status =3D EFI_INVALID_PARAMETER; + DEBUG (( + DEBUG_ERROR, + "ERROR: IORT: IORT Table Size 0x%lx > MAX_UINT32," \ + " Status =3D %r\n", + TableSize, + Status + )); + goto error_handler; + } + // Allocate the Buffer for IORT table *Table =3D (EFI_ACPI_DESCRIPTION_HEADER*)AllocateZeroPool (TableSize); if (*Table =3D=3D NULL) { @@ -1783,7 +1937,7 @@ BuildIortTable ( =20 DEBUG (( DEBUG_INFO, - "IORT: Iort =3D 0x%p TableSize =3D 0x%x\n", + "IORT: Iort =3D 0x%p TableSize =3D 0x%lx\n", Iort, TableSize )); @@ -1793,7 +1947,7 @@ BuildIortTable ( This, &Iort->Header, AcpiTableInfo, - TableSize + (UINT32)TableSize ); if (EFI_ERROR (Status)) { DEBUG (( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56573): https://edk2.groups.io/g/devel/message/56573 Mute This Topic: https://groups.io/mt/72631550/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56576+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494865018268.85365455429314; Sun, 29 Mar 2020 08:14:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id dT08YY1788612xUzwMp6AIzk; Sun, 29 Mar 2020 08:14:24 -0700 X-Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.78]) by mx.groups.io with SMTP id smtpd.web12.29111.1585494863867586025 for ; Sun, 29 Mar 2020 08:14:24 -0700 X-Received: from AM6PR04CA0068.eurprd04.prod.outlook.com (2603:10a6:20b:f0::45) by VE1PR08MB4815.eurprd08.prod.outlook.com (2603:10a6:802:a3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:19 +0000 X-Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::8c) by AM6PR04CA0068.outlook.office365.com (2603:10a6:20b:f0::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:19 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56576+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:19 +0000 X-Received: ("Tessian outbound 66307db0259d:v48"); Sun, 29 Mar 2020 15:14:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: a482c9027290c7a2 X-CR-MTA-TID: 64aa7808 X-Received: from 371f161e133e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D12894A4-D79C-4CC0-8729-AAFF4D76CCDC.1; Sun, 29 Mar 2020 15:14:14 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 371f161e133e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQIiEpRqyiIOC6kljUhyZcEMTkV6RUbziv5/ZTwYdjUI/rXO0cIBaj4GUj3BE755UYF6BwLGHXHYnYHUN/jo1DaFcqZWsGQuNMBUXdx79m2ebmhqyzSjbX0yIfZV+bCHb/OmYLCKsdztB7JJZbZxfyUMceEER5ym5S5nuAoVETghhrYKth3anZ72HnIRfwgEFU9byVdPeCgFB45ValW78T73Z+cyeLDwt/vnB/hpL2IiJNvcr4WO5AD34l5gO5wz5XgCO1fhM/lmcwYksa5/6NPQA/b5aAqbWLQL6w6w/E5DOIoT44pc/r4OwU9hHbkv3Y10uf8R5hBDzmLZGaUirQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nz1UXdYT99yreTIS8HanM9LVNXPaMAasqg6/uYPCSbk=; b=CMubaA9+lrkgVxlmaX30xJdc24ILx0EzyQUDGejtM2k1BpV9zbPeJjPJtcsc1BYCcJphds18zRWykPRkf1Fliin6DVBXdkP7oMZPQEIfNWelUAxSLexP94Dl9PrwfwH2DFDS5nienDG+1NjY3aPEdizQZ6pP77cK3AxQuchmx7zcD375LRX6T5H2br23GvRHGO1kqF6agUgWTKo+UvgfWrkYWEw5cKHx1fljn7Xazh8BDw43zegFEJOyvAHbA87IuKsrzBoB09fuT6f0BOC1dTKpPUgO92nICGpfROH39KCySB0pDufXtoP/9TqkxpUh1/lZvQy7jCWCwEQLV/bppQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM0PR01CA0019.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::32) by HE1PR0802MB2186.eurprd08.prod.outlook.com (2603:10a6:3:c2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:11 +0000 X-Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:69:cafe::c7) by AM0PR01CA0019.outlook.office365.com (2603:10a6:208:69::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Sun, 29 Mar 2020 15:14:11 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:11 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:07 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:06 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 13/16] DynamicTablesPkg: IORT: Fix uninitialized memory usage Date: Sun, 29 Mar 2020 16:13:50 +0100 Message-ID: <20200329151353.14096-14-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(136003)(396003)(39850400004)(376002)(46966005)(186003)(47076004)(82740400003)(54906003)(316002)(70586007)(70206006)(26005)(4326008)(2616005)(356004)(6666004)(44832011)(336012)(1076003)(7696005)(426003)(8936002)(86362001)(478600001)(2906002)(5660300002)(81156014)(36756003)(8676002)(81166006)(966005)(6916009);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e923e5b7-1faf-42bc-b4b1-08d7d3f3da99 X-MS-TrafficTypeDiagnostic: HE1PR0802MB2186:|VE1PR08MB4815: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4+nc1UPGYkvKtSGkNXMfG5Tz2p1Nfq8phkflQE1jo1WYp4AK3tfBi9a2/XQ0Q8XR6wRlEtZASOLXpgBQ+6Fk2u/CZTnq1HyV6W4puQUc+9d853AbhSdHpbupj32w5ZUgKH0IBAC5dz40NWcpvr3IGpzV3b0U2eMUirGpXq1HElvzNie1bDVGgnGWRrUIxka1nDPJzmePdhYFi0gjZfSPjOjzIi7FuRoUDtEPJQD+HfGAnWAheK3O5AisXXy06/xWc/sREsV66XQ1LqvYMGhHcjPF3h6VCA/GMrb5U8gQUk6h6vDBshul0vEr/HnShIUGcsuTbkXSlfi5mCir/c/zfg78Mh6AQZrMp2Deus29waZMT410Uyd5nlk9/idh9rEQNht0GZj5kdIu9J+/vhqtNGOPJEKhrjUco8KY9VIlePd9xGwNXtovgfKRNFKWCZK0RV4X5A9SdTvdEWftLMqtCmdJeueT0V46iZUZEG5znqTZmBG5W0nKe2wj/QYAMuyjnIfuhfI+lot2laOBb4cuDviEloyXIC7oZLErUl8u1O3E4Q5pLM7z0Js66NwP6fEF34A0/9s9b3ulGFgOOa9wjJG19mPWVZ34CxMQqyopM7M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2186 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 98c49616-bba2-410a-284c-08d7d3f3d5ae X-Microsoft-Antispam-Message-Info: FUMFycB14WiyZB/wTwSRY01/hmlcTNoJmce2SaIG+AF0YubgAYJmphMueBX5iEYSsww397i0HKzHPJCH63JB0dw+daOyAZRX594eYCKvxbBbByp2fYH1UgRS4Wpuj41byXYuXfEDBgi1r868zOJdQbp+mp9MczoSJbfiPfclX0brcq0ZK8Uzam0fS/lEFHa5lfKltuDfDTbzgz2i8Hke2D8v/BfqzVYfFn9apzehCwdaTe5aPqoOzeJy82jIP7SptSTgame2RZb6x1hPUdRjR6smKS01LJkZoxHQqjT4VWJP7M8+3u9BUrMNm9JLYOrdQM9RGCRHptins2q5yEc27L8pSSfAKcl1Xpo8fV/k2bLORGB0IkvEhwDcnxySr2jj0OKU+nKxrXRmxGznwSsybnkavlyu9a54abLscVsFzQIVk+NGHYE0QSFlLOmzoH8ymeVTX0TDiumvqVspZJdFncG1vwZRe8HBoQd0I8Qt38NrEd/wnNLPhTZ9Qa0kTgvzT5EMZuZFRy8dyMlt1RrpdVC6tBGKDUZdFBUHhr0obuHOkfXclChuKYfX59jA/8TfjvePljSjLuNmoe80GWZuVuEgpUG7rqu2QtwQryatAL0= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:19.3584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e923e5b7-1faf-42bc-b4b1-08d7d3f3da99 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4815 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: lcFXYg8Td9NIC86WNIlvx84Vx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494864; bh=YEPAtUN+mn4iQYIIpygh6xiQvTkzAY5FsL7YWYxIsnE=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Ar6REQLOmefOuEFu1NWGXJFN0R8xTlubA23OYG8vRFlhn80b1xb8czKpdPSakgYa/bu A+AVMtWqvcSp7XjmJi+SlOJgosiA31i2XTbWnX1QERjDXrVmFX3FP6qxOgdSrqmvNLS53 Olbfojk3qkE9uXyY8uzlsJGFFe8nPQtJgps= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On enabling the /analyse option the VS2017 compiler reports: warning C6001: Using uninitialized memory. This warning is reported as some variables that were being logged were uninitialised. To fix this, moved the logging code after the variables being logged are initialised. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 96 ++++= ++++++---------- 1 file changed, 48 insertions(+), 48 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c index bd71220ca19679792de2bb6d88eed8d1913a7600..65d006c89e668c8b2b8a14326cd= df1b69979597f 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c @@ -1738,6 +1738,14 @@ BuildIortTable ( goto error_handler; } TableSize +=3D NodeSize; + + DEBUG (( + DEBUG_INFO, + " ItsGroupNodeCount =3D %d\n" \ + " ItsGroupOffset =3D %d\n", + ItsGroupNodeCount, + ItsGroupOffset + )); } =20 // Named Component Nodes @@ -1760,6 +1768,14 @@ BuildIortTable ( goto error_handler; } TableSize +=3D NodeSize; + + DEBUG (( + DEBUG_INFO, + " NamedComponentNodeCount =3D %d\n" \ + " NamedComponentOffset =3D %d\n", + NamedComponentNodeCount, + NamedComponentOffset + )); } =20 // Root Complex Nodes @@ -1782,6 +1798,14 @@ BuildIortTable ( goto error_handler; } TableSize +=3D NodeSize; + + DEBUG (( + DEBUG_INFO, + " RootComplexNodeCount =3D %d\n" \ + " RootComplexOffset =3D %d\n", + RootComplexNodeCount, + RootComplexOffset + )); } =20 // SMMUv1/SMMUv2 Nodes @@ -1804,6 +1828,14 @@ BuildIortTable ( goto error_handler; } TableSize +=3D NodeSize; + + DEBUG (( + DEBUG_INFO, + " SmmuV1V2NodeCount =3D %d\n" \ + " SmmuV1V2Offset =3D %d\n", + SmmuV1V2NodeCount, + SmmuV1V2Offset + )); } =20 // SMMUv3 Nodes @@ -1826,6 +1858,14 @@ BuildIortTable ( goto error_handler; } TableSize +=3D NodeSize; + + DEBUG (( + DEBUG_INFO, + " SmmuV3NodeCount =3D %d\n" \ + " SmmuV3Offset =3D %d\n", + SmmuV3NodeCount, + SmmuV3Offset + )); } =20 // PMCG Nodes @@ -1848,6 +1888,14 @@ BuildIortTable ( goto error_handler; } TableSize +=3D NodeSize; + + DEBUG (( + DEBUG_INFO, + " PmcgNodeCount =3D %d\n" \ + " PmcgOffset =3D %d\n", + PmcgNodeCount, + PmcgOffset + )); } =20 DEBUG (( @@ -1859,54 +1907,6 @@ BuildIortTable ( TableSize )); =20 - DEBUG (( - DEBUG_INFO, - " ItsGroupNodeCount =3D %d\n" \ - " ItsGroupOffset =3D %d\n", - ItsGroupNodeCount, - ItsGroupOffset - )); - - DEBUG (( - DEBUG_INFO, - " NamedComponentNodeCount =3D %d\n" \ - " NamedComponentOffset =3D %d\n", - NamedComponentNodeCount, - NamedComponentOffset - )); - - DEBUG (( - DEBUG_INFO, - " RootComplexNodeCount =3D %d\n" \ - " RootComplexOffset =3D %d\n", - RootComplexNodeCount, - RootComplexOffset - )); - - DEBUG (( - DEBUG_INFO, - " SmmuV1V2NodeCount =3D %d\n" \ - " SmmuV1V2Offset =3D %d\n", - SmmuV1V2NodeCount, - SmmuV1V2Offset - )); - - DEBUG (( - DEBUG_INFO, - " SmmuV3NodeCount =3D %d\n" \ - " SmmuV3Offset =3D %d\n", - SmmuV3NodeCount, - SmmuV3Offset - )); - - DEBUG (( - DEBUG_INFO, - " PmcgNodeCount =3D %d\n" \ - " PmcgOffset =3D %d\n", - PmcgNodeCount, - PmcgOffset - )); - if (TableSize > MAX_UINT32) { Status =3D EFI_INVALID_PARAMETER; DEBUG (( --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56576): https://edk2.groups.io/g/devel/message/56576 Mute This Topic: https://groups.io/mt/72631554/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56575+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494864013873.1890967871573; Sun, 29 Mar 2020 08:14:24 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id t3WhYY1788612xKEklckRIyo; Sun, 29 Mar 2020 08:14:23 -0700 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.55]) by mx.groups.io with SMTP id smtpd.web10.29270.1585494862735236514 for ; Sun, 29 Mar 2020 08:14:23 -0700 X-Received: from AM6PR04CA0069.eurprd04.prod.outlook.com (2603:10a6:20b:f0::46) by VE1PR08MB4863.eurprd08.prod.outlook.com (2603:10a6:802:ac::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18; Sun, 29 Mar 2020 15:14:19 +0000 X-Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:f0:cafe::65) by AM6PR04CA0069.outlook.office365.com (2603:10a6:20b:f0::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:19 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56575+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:19 +0000 X-Received: ("Tessian outbound 60d769d68364:v48"); Sun, 29 Mar 2020 15:14:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: cd96ed54a72baafc X-CR-MTA-TID: 64aa7808 X-Received: from bac14d3f59a9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A9A6C375-1C54-460B-A54F-BBC115D59CBE.1; Sun, 29 Mar 2020 15:14:13 +0000 X-Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bac14d3f59a9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bjTXqT1i7YQDjLgdAWxMG4uORBb846s6vmhJsaLv2GNhn+32tTKXJ20QnnOepCMQBoIU1u7C9hqdh5bYVX7bpKZm1WOTWckglH0AQA2F8Fcu9QVjdLXPKos7PxXo3FRmsiy7iFK2hDYpI0RSD2kw6BY6a8LIermNdX5wdWmLsYb94ycuGCyIh51hInxaIeM3mwR+YuiDiYeH3WwO/Vf+Wbplz7gUSBk4Mb4+sT7f4cYSHppp/KcPfW6DtydPOYxp5DLnSL8SSMSe5h02gxNpS4+6Vlng48w03ezlXbXlYq+TZQcnadujqVDaoL2a/5bXcD65C60hBMLTqgE+SCrPxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3Su/tqf9kOTHUzzA1yKLSETpHU0wfnOEIsjmbAhOUw=; b=it4gdQRSltHqQp1ihM4h0L5JOHFTashXkRTSHtBvvVWFUtQ5V0e65/rx+DxeIb1d8TbdmIh1sLaMXQOZJkTWFEEvQDVXDdQJRPqgwOt+rimf3z+LK6DadpUs7GVlp72dh/RUSIuPCp3LkQQ3bj7Y+31+V+K1rAyt+WbmNr4cXdadn6+GwonjqgomXBYLTF7+OrUPDqZ7/iLIZ0xaSqByFPIj/837hymyumSLMNwdte3rQgTwT6oxrSdyZ6jFBzjDSrs4Y5OTtXFwhTRgDJLG2ghpmtCufM6H8pbxvK7Qd9wBnfKi4QbbzHwIOpILV5vTeNkcJO9ci4Rwcj1bIRUWgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from VE1PR03CA0012.eurprd03.prod.outlook.com (2603:10a6:802:a0::24) by VI1PR08MB2992.eurprd08.prod.outlook.com (2603:10a6:803:44::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: from VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:802:a0:cafe::49) by VE1PR03CA0012.outlook.office365.com (2603:10a6:802:a0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT062.mail.protection.outlook.com (10.152.18.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:11 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:07 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 14/16] DynamicTablesPkg: PPTT: Fix uninitialized memory usage Date: Sun, 29 Mar 2020 16:13:51 +0100 Message-ID: <20200329151353.14096-15-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(346002)(376002)(136003)(396003)(39850400004)(46966005)(82740400003)(54906003)(4326008)(36756003)(26005)(316002)(6916009)(186003)(86362001)(47076004)(6666004)(356004)(1076003)(966005)(44832011)(2906002)(7696005)(336012)(5660300002)(70586007)(70206006)(8676002)(8936002)(478600001)(426003)(2616005)(81166006)(81156014);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e42a8d82-8d31-4990-a574-08d7d3f3da82 X-MS-TrafficTypeDiagnostic: VI1PR08MB2992:|VE1PR08MB4863: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:8882;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fyt1PdhBJRuP3wW2NUZqSHVRxOOVCsQcvm1++CYR7qZTkexl0TJPYgq86bmc90vT2GrlVSgIvPnBsZzq5jSknb/LPJ2hn4qE/1lBTGC4X0RNSglZuZvO3hhQSoThnzFukQVdamkqK9h77itPuNEIetEQ+i6gFt7Tov+qOdgi1wmjXHoE1zCGlAKwtwwxCDMDKRKoxC/bDlO0RaIcjC3+bWj+0iANlRZ/SRpIkJQdGRajFgRzUGbmUoJX/v20DKEKexD2wXg8hkX4dcnvHifbBB/Am9K2ts+1+/0D07jAV33RuHr0PkTQQpotcagd+t8P1V53AcNHAmtPcDqn0qRzug2P5TQH/oq2lcwz4cRBRusyadROpfWyDayT75L3ylHiGfBpv4eovnYiFfGdavsnmAZuf8TPV4YrQnK22OgZ2ssMBg8R6LRW4ASKaNnR5kyCYY7jqszjPQvXUfDtrY7yNGwsaKjn2aD1O3+3nKD6WVfsMq9N6ImM0mNx46o0I2HlA5YHPLdVrYXz7nl8MtJUCE6ZkhdVCd1xNUzCywsYYOZvyzaTQZbMntdZyvtN+afsUZg+kEHIfJU/zZC9uXa12g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2992 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 45e3ed06-f9fa-43a1-1507-08d7d3f3d620 X-Microsoft-Antispam-Message-Info: TIYlC+Bby7U37Jk3OmTXnaqGKvXe5WR4ckI9fDYC9/8bTRZbU17w5g3eEcG6fGfpH+sTwMDex26otA0GJ5tuKj2Vc3CFnOND/F5Yr6jvBoggU/+lvsK1d7qjHs/fg1kvP9Uo/oIyK/9viouEvmoBHT/MpOSXMXt25d61nq0zVLrci1yJz+7W3Nl+QUp8qWvsXEYgU8C2RRV86kJC961fFOFY7aplHWUp+fVL1n/x3HH0S+PjVZvPSBncTbJevlD33zjMnWAUEN4Zwv4qTlNb3qn1sCnDHqvGO2hbhfDPKwnY2XaxIwx6ZtMgmHDvovGs7JLDUwoVmSlHzf29derSx+R+NMgJ7sKgKOSwtw2cDNbtRGB6yLynIhbvi0Gm6R5ITkthLfHlAt+UZfIQAyJnm/oK/u7CeXt40PDIJNdAnLk7rO6+JgQyB1+keORZhGH9QT0NhPCMMOYTO1wiqWWMFG+XpehJERC5YMSC2+2Cks5siMCpobCP3hsr4b767HzS7IgFlawcUTGqGrId66W/DyvWjuWt5hw7HyjHyEK2/ReQ1hi30uM/HSLQFMtZE5neH6DPy4LU9PCuTMIUdYW9BA== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:19.1992 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e42a8d82-8d31-4990-a574-08d7d3f3da82 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4863 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: XQEunv4uezwD05EV8d9HGXMtx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494863; bh=APTDRHA2OQqYtrrl7M9M4w8UjjcXFsI4e47XUIACgj8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=gvH+mcrEPBatCxZOcsFzOPyhSEdYgu2J9P9XaCYXLEmaZjDgwWw24AeSEECmeuPkfcT X6Rdudtj04/OLcbjdCLvYcXITdZNpetnlGt88vHb9unsy6S0k+j9JwTmg0wsDY0WD38YV Xzy543EnBBaKdmhKONhIo9ZilnrZ0OkEiOc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On enabling the /analyse option the VS2017 compiler reports: warning C6001: Using uninitialized memory. This warning is reported as some variables that were being logged were uninitialised. To fix this, moved the logging code after the variables being logged are initialised. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 59 ++++= ++++++---------- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator= .c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c index 82070403ac8757f54e839fd00eb4acb3292fc60c..d70fc59e754e7d348965b8c3739= 822a9f1c4b7e6 100644 --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c @@ -1203,6 +1203,17 @@ BuildPpttTable ( Generator->ProcHierarchyNodeCount, &NodeIndexer ); + + DEBUG (( + DEBUG_INFO, + " ProcHierarchyNodeCount =3D %d\n" \ + " ProcHierarchyNodeOffset =3D 0x%x\n" \ + " ProcHierarchyNodeIndexedList =3D 0x%p\n", + Generator->ProcHierarchyNodeCount, + ProcHierarchyNodeOffset, + Generator->ProcHierarchyNodeIndexedList + )); + } =20 // Include the size of Cache Type Structures and index them @@ -1215,6 +1226,15 @@ BuildPpttTable ( Generator->CacheStructCount, &NodeIndexer ); + DEBUG (( + DEBUG_INFO, + " CacheStructCount =3D %d\n" \ + " CacheStructOffset =3D 0x%x\n" \ + " CacheStructIndexedList =3D 0x%p\n", + Generator->CacheStructCount, + CacheStructOffset, + Generator->CacheStructIndexedList + )); } =20 // Include the size of ID Type Structures and index them @@ -1227,6 +1247,15 @@ BuildPpttTable ( Generator->IdStructCount, &NodeIndexer ); + DEBUG (( + DEBUG_INFO, + " IdStructCount =3D %d\n" \ + " IdStructOffset =3D 0x%x\n" \ + " IdStructIndexedList =3D 0x%p\n", + Generator->IdStructCount, + IdStructOffset, + Generator->IdStructIndexedList + )); } =20 DEBUG (( @@ -1238,36 +1267,6 @@ BuildPpttTable ( TableSize )); =20 - DEBUG (( - DEBUG_INFO, - " ProcHierarchyNodeCount =3D %d\n" \ - " ProcHierarchyNodeOffset =3D 0x%x\n" \ - " ProcHierarchyNodeIndexedList =3D 0x%p\n", - Generator->ProcHierarchyNodeCount, - ProcHierarchyNodeOffset, - Generator->ProcHierarchyNodeIndexedList - )); - - DEBUG (( - DEBUG_INFO, - " CacheStructCount =3D %d\n" \ - " CacheStructOffset =3D 0x%x\n" \ - " CacheStructIndexedList =3D 0x%p\n", - Generator->CacheStructCount, - CacheStructOffset, - Generator->CacheStructIndexedList - )); - - DEBUG (( - DEBUG_INFO, - " IdStructCount =3D %d\n" \ - " IdStructOffset =3D 0x%x\n" \ - " IdStructIndexedList =3D 0x%p\n", - Generator->IdStructCount, - IdStructOffset, - Generator->IdStructIndexedList - )); - // Allocate the Buffer for the PPTT table *Table =3D (EFI_ACPI_DESCRIPTION_HEADER*)AllocateZeroPool (TableSize); if (*Table =3D=3D NULL) { --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56575): https://edk2.groups.io/g/devel/message/56575 Mute This Topic: https://groups.io/mt/72631553/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56574+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494863397555.6989370641943; Sun, 29 Mar 2020 08:14:23 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id QSFkYY1788612xCKB9ijzYYK; Sun, 29 Mar 2020 08:14:23 -0700 X-Received: from EUR03-VE1-obe.outbound.protection.outlook.com (EUR03-VE1-obe.outbound.protection.outlook.com [40.107.5.41]) by mx.groups.io with SMTP id smtpd.web12.29108.1585494861829181893 for ; Sun, 29 Mar 2020 08:14:22 -0700 X-Received: from AM0PR0102CA0048.eurprd01.prod.exchangelabs.com (2603:10a6:208::25) by AM0PR08MB5379.eurprd08.prod.outlook.com (2603:10a6:208:182::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:19 +0000 X-Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:0:cafe::f3) by AM0PR0102CA0048.outlook.office365.com (2603:10a6:208::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18 via Frontend Transport; Sun, 29 Mar 2020 15:14:19 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56574+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:19 +0000 X-Received: ("Tessian outbound 60d769d68364:v48"); Sun, 29 Mar 2020 15:14:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 22329de46beb881b X-CR-MTA-TID: 64aa7808 X-Received: from 551843b123ce.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 101165E7-0F0B-416C-8CDB-C54F914F6CFA.1; Sun, 29 Mar 2020 15:14:13 +0000 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 551843b123ce.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lXHseRKrCervJK7EuPRwIgFGHwb7wjgSz+R+NpFy2ZkPM7CQMfs+/bKeaz3hjhpYznDYpevfF1Wz+LKdr9liHMp8unr3PL1pywftczkW4H0595lFgF+JQyZu3whckrL3Z2CHkjPe2r3BpuhquEr7Tiym5LSA1MAvwF131Tx66dNgVxtAuEVamF/KRM0XU3xn3KDsca1LD2w/N4Xsc0imVrvN4guNkcLRv9fmMCW0zjMs3eb6BRUqjme4Ni50ZXmXLPuZOkqzcFN8/C7QLORsV6vzcNWvw1JBglB4ADkchNnrj659Yum8+98X5XCCnav2Yfa4go5m290brh7y+8a7+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MQ3qe1RltTZGHnRYp5QdZNdRqSIAjtlfVYWqvUEh/gU=; b=CCnZyB2AWDYEyr4pj4+5NFAP5rWdS0XzavBn2LV/KeBB8lBh7exhIFfGPRWd2Tjkc3+HGsoS316Wy9j35vTvf1NEPPNoWAS2c/h01kHK9/2Nvne6b25WJDaWdOf1FIzDCQ8ih/JSSAGBv937rX8E9QBrRWWU9GkmrfS10lLzzzYXeIqQBJ7gVtc2akmjrsUWs6PC+NW0qoH/C7H9oCGe6JICd429yJBQmjbk+eZeLsshpc6jHqXuBt9WnJVbe7CV2uqUswOu8JLM4xRv5nNK/EiXNAd2NUYdFbNBHAfjdoiaE+px4aouCYTPb2Cw41sINCR+EeqD00AB/VrimFtomg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM0PR01CA0035.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::48) by AM0PR08MB5411.eurprd08.prod.outlook.com (2603:10a6:208:181::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:69:cafe::47) by AM0PR01CA0035.outlook.office365.com (2603:10a6:208:69::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:11 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:08 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:08 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 15/16] DynamicTablesPkg: Remove erroneous use of EFIAPI Date: Sun, 29 Mar 2020 16:13:52 +0100 Message-ID: <20200329151353.14096-16-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(396003)(376002)(346002)(39850400004)(136003)(46966005)(86362001)(47076004)(44832011)(6916009)(8936002)(6666004)(356004)(82740400003)(7696005)(70586007)(8676002)(186003)(2906002)(1076003)(81156014)(426003)(336012)(81166006)(4326008)(70206006)(36756003)(54906003)(478600001)(966005)(316002)(2616005)(26005)(5660300002);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aff065bc-5236-4961-a9c7-08d7d3f3daa0 X-MS-TrafficTypeDiagnostic: AM0PR08MB5411:|AM0PR08MB5379: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6108;OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4uS4eEZY3SVbaFwdIkh3zYXbZ5eewNshVM8wjyVs2VumW0xpVhcRXQPwz3gGqiQEUVf9DyQNy3K53+vnsjJr275movJSlHGYW9XtWeQO/DMlZMtnhR51qVIn3rfi98jEkGWnF8841eq9CHTGmGEi5u03g9Cw0JOAcGKVfE82UO256wYfndh5n2Om1XQnmxMxtVTLVElmmdHDHA1sas6kHUeFys7yTskmcaj6jS7vwNH9GuKTUHcqJtiFKYK2UcLo2xi2Eg9VR7Ch1DloRr3ix/epQ8B2vxBz4YV+47VZ1xxd2jUPkiywDQ6ykwr0ThjX6SwuT0zenlv1xPHeyXNxXobfRZJQCnDVT/fZIXa/9H9ru1gWVlPNzrbiK/9KVbvrgpr5MJQRbHKkP70IBNv2gQRkHFgFvH2nsPXr7Mom923Q8oyVbm/0RdmI81jmtzSWLsYXyYz1IYLh1wAdnVUyaFjQQrJelDCGfJ6XKzUReeywbi4U+pwd3HM+F0Kg2HwAOsyO66EnaOfF/1GL/rmeg6DLJ09ryFFBFW0jUlQGAlTuwd0djZeycQiKPS5nMIx7wN82ZhC/5GssTu78ANgso2JudQPWlQVMRZzZnN557kM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5411 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: c5a8d4d9-02af-4059-3ba5-08d7d3f3d620 X-Microsoft-Antispam-Message-Info: TlODy1ANVDWJSZcrnAJq2LjwJ8h9gKxwCcZKLAikKD8VOxwnG2aaEeABt9+0sLiZ441mWyHLOfvBknZrvdkcj/ccJZs8LiwuNdIrCLMribbx9bmfNN/OcGMMW8oBCxGgdcFA1PwF6uEJ/QY9IOKcvgovPDI1vhBonCQP8+hNdLfX3hfuxnrH+H+K30BI5byGvxpxJxGo2IuDdtoNoGG1fElWLnZyPm+frpGtWHFKp/dM+EB0rEBbSPkWJnkkQ4386WQ0Asrh9OcdwddU6637qq9IzeyVry9a12uXXoTuokyABPS6i0wpvfCvfK7E1Ld40mlp4kvE5FEa5H3V0Xu7Rm8rdhFibmVo/fDeTtZA10zzrz4fLsLRVG6b8uO3XqM7ZxTskGXrcvswnKabYK5xA3S6JEQJPNxCLn+I5REFC+Y7YmiqRihHTzjHHqN2Ypqg99Gu2wIF4U314fHBua6Iu0P0+WaoekGTb84DypdhOmSv7gcpLaS6nx2RHTVA0MOQylkDB2r/Zg0piOSajjos1BbUf/Ar765Z/EvYn5ulo3yx59MhHi6AEeM+6YfN+i6hAfMoE3ktoJEC4Hs4FXp+embH9h7TWzDDKNS8iArXP/8= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:19.4086 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aff065bc-5236-4961-a9c7-08d7d3f3daa0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5379 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: 1qQnODOvh2w4ydgar4fEFRf5x1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494863; bh=TZuYapKxwOBdZQcXHFISGZU93s8vypxLyLFL0czx2SA=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=ttCvZG2vwPtp5999DQCC9PoB2S9q5BBtfSfsGQiu5TtvMDP6S9XyPrbQXDRnSkeEJGj B/xQ1Qpuvn2yzD5GjvKWPlDW0dibMIW8IEIFoyT49v9n6orkqMgOuBdrOetMBeBiD6Utj FK6KVBeNfCPWeycNXp+KkuMFxwnK/O+et2I= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The Dynamic Tables Factory protocol has an erroneous EFIAPI calling convention macro in the function pointer declaration. Remove the erroneous EFIAPI calling convention macro from the interface declarations. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov Reviewed-by: Philippe Mathieu-Daude --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h | 11 +----= ------ 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.= h b/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h index d07d0cac36dedb0568f6f604daa22429565aafd3..ff2331b060019976319fc2707f6= 5252130a5326c 100644 --- a/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h +++ b/DynamicTablesPkg/Include/Protocol/DynamicTableFactoryProtocol.h @@ -1,6 +1,6 @@ /** @file =20 - Copyright (c) 2017 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2017 - 2019, ARM Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -53,7 +53,6 @@ typedef struct DynamicTableFactoryInfo EDKII_DYNAMIC_TABL= E_FACTORY_INFO; **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_ACPI_TABLE_GENERATOR) ( IN CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL * CONST This, IN CONST ACPI_TABLE_GENERATOR_ID GeneratorId, @@ -73,7 +72,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_ACPI_TABLE_GENERATOR) ( IN CONST ACPI_TABLE_GENERATOR * CONST Generator ); @@ -89,7 +87,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_ACPI_TABLE_GENERATOR) ( IN CONST ACPI_TABLE_GENERATOR * CONST Generator ); @@ -109,7 +106,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_SMBIOS_TABLE_GENERATOR) ( IN CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL * CONST This, IN CONST SMBIOS_TABLE_GENERATOR_ID GeneratorId, @@ -129,7 +125,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_SMBIOS_TABLE_GENERATOR) ( IN CONST SMBIOS_TABLE_GENERATOR * CONST Generator ); @@ -145,7 +140,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_SMBIOS_TABLE_GENERATOR) ( IN CONST SMBIOS_TABLE_GENERATOR * CONST Generator ); @@ -165,7 +159,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_GET_DT_TABLE_GENERATOR) ( IN CONST EDKII_DYNAMIC_TABLE_FACTORY_PROTOCOL * CONST This, IN CONST DT_TABLE_GENERATOR_ID GeneratorId, @@ -185,7 +178,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_REGISTER_DT_TABLE_GENERATOR) ( IN CONST DT_TABLE_GENERATOR * CONST Generator ); @@ -204,7 +196,6 @@ EFIAPI **/ typedef EFI_STATUS -EFIAPI (EFIAPI * EDKII_DYNAMIC_TABLE_FACTORY_DEREGISTER_DT_TABLE_GENERATOR) ( IN CONST DT_TABLE_GENERATOR * CONST Generator ); --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56574): https://edk2.groups.io/g/devel/message/56574 Mute This Topic: https://groups.io/mt/72631552/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon May 6 14:32:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56577+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1585494865510242.5367439520004; Sun, 29 Mar 2020 08:14:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 6nadYY1788612xzV1pY18v1H; Sun, 29 Mar 2020 08:14:25 -0700 X-Received: from EUR01-HE1-obe.outbound.protection.outlook.com (EUR01-HE1-obe.outbound.protection.outlook.com [40.107.13.43]) by mx.groups.io with SMTP id smtpd.web12.29114.1585494864211890273 for ; Sun, 29 Mar 2020 08:14:24 -0700 X-Received: from DB6P191CA0021.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::31) by VE1PR08MB4976.eurprd08.prod.outlook.com (2603:10a6:803:105::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Sun, 29 Mar 2020 15:14:21 +0000 X-Received: from DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::6a) by DB6P191CA0021.outlook.office365.com (2603:10a6:6:28::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:21 +0000 Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56577+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT022.mail.protection.outlook.com (10.152.20.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:20 +0000 X-Received: ("Tessian outbound fb361fb66447:v48"); Sun, 29 Mar 2020 15:14:20 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 81890d3f0bb48d2e X-CR-MTA-TID: 64aa7808 X-Received: from 0018d0dd558b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EFDDCE52-A8A8-4941-8FD6-0E01246BD8CC.1; Sun, 29 Mar 2020 15:14:14 +0000 X-Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0018d0dd558b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Sun, 29 Mar 2020 15:14:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CZQBEWmMFdILLr9KDvsoEQSAvWacacLf6cKREhXz1VJCKwJrUxCi+b44FpJUGzZxav9FsYarbm0Ya8ZN0zP2Dsoab7WlVSGWJDSd4yjSEHCFRLXlVMFxlC+Ov9X3EpAbBVqnirZcOB5yLuAoeG8GR+f0hPGwtJIVSADY0rHgw2VIbS0dx7q/xCssZgeIju7/pv/IcjZ9RkJvTY15l6SSjKXYHpLFbiQgxZwieLT0GBOvWT7VDKR4ww9WPkeCESbCt2v3692dunxPG5ysWfrBaBo6k1E9kDZE6RnGyNzRdw2ZRPkH6vfk6IaJ+qusdKdibLAWTqsjwTLr23SLax93Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D28fOYwvpeUgu/Y0YVgQ9o54PeNws5hwPP4d2XFbnmI=; b=g1B5XTmr4ceVMUywOq8OKpk4TMbAo0o4xsK2iugW9qiLaupumPakJkJ9dnZfsWZWO4TBdnppfDQkAix4ALo6i/XDeXXE0D/gW/looX6rKg1F/E7VWTqRqlVRjW+XarI4KQ0i2ae9Nxe78RuIE0XsJZgBBO5UqX+hGE7y+fX64lBYt7h/Td3YlSyqqVEDbIyAw6R0wxh9UbMdDfnS7DVc5FiU3s62dLEylRzvt58+pUCab4GMlK7GmwAvpL9iJiPRhSMNLegdCrTwDIAVkXOaYRqES1pRFKqPONP8cirisymbzLds9zo+yCNrGP6LDKHp4m7Uqmi4Zmt66H03vjGjLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=bestguesspass action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AM0PR01CA0002.eurprd01.prod.exchangelabs.com (2603:10a6:208:69::15) by VI1PR08MB2815.eurprd08.prod.outlook.com (2603:10a6:802:19::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:69:cafe::4b) by AM0PR01CA0002.outlook.office365.com (2603:10a6:208:69::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 Authentication-Results-Original: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; X-Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.2856.17 via Frontend Transport; Sun, 29 Mar 2020 15:14:12 +0000 X-Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1779.2; Sun, 29 Mar 2020 15:14:09 +0000 X-Received: from E107187.Arm.com (10.57.20.21) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Sun, 29 Mar 2020 15:14:09 +0000 From: "Sami Mujawar" To: CC: Sami Mujawar , , , , , Subject: [edk2-devel] [PATCH v2 16/16] DynamicTablesPkg: Option for VS2017 static code analysis Date: Sun, 29 Mar 2020 16:13:53 +0100 Message-ID: <20200329151353.14096-17-sami.mujawar@arm.com> In-Reply-To: <20200329151353.14096-1-sami.mujawar@arm.com> References: <20200329151353.14096-1-sami.mujawar@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(39850400004)(136003)(396003)(346002)(376002)(46966005)(6666004)(81166006)(8676002)(356004)(8936002)(186003)(44832011)(426003)(6916009)(26005)(81156014)(4326008)(2616005)(36756003)(86362001)(47076004)(478600001)(336012)(70206006)(7696005)(316002)(70586007)(54906003)(4744005)(5660300002)(1076003)(966005)(2906002)(82740400003);DIR:OUT;SFP:1101; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09f00d26-8405-4777-a0c5-08d7d3f3db85 X-MS-TrafficTypeDiagnostic: VI1PR08MB2815:|VE1PR08MB4976: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:421;OLM:421; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +5E73VfZFcGXk+yZcvadjzBc0Yq8ZXGGfXEr0XGVxNMRJt/sqKVSryxJ+e80avqXzQGN/jyCkqXORZHJFIrD7hN9H96LlIDj/SXTHBHaC81SgLu0oaZ2o9Ws2ioySrr4Ed7ZNeN0xW8vKB/x2Tjga5onHRlO4wmh6j7dHPqQsYd3i4uGYV7CizVioyUaIBzp7/6twu/Ingdi1rr+oUCWme2Zc1n8N/dm2aZttcrOgHjMm9OxmvSIPlIbhS2xu7RR8fofPIai800NVJBtV3hwacJXVtabA2I6HRH95eEj2e+KiBwWErTD/emUbEmta4jZk5fd95hJOVQ9Ube/RWl4nv29n/3wj8lj32YK1O7elLUGb8KDrqifi6fj+EnY6wA8TD4PJRnveQQTP1WgIk4EC4YxP0Afvyoq3mJtssXT8RTgqLxzgA1thoxB0rWhX9Xl+fYM0DNnLkmqfwL3j4ctJyNhcJ6xD5GW9qEBQqid0pNpF19wYl7XBHE7ZVaCpeZ5WtUZif/dnMukW51t92oHO5Z62SWQSiXQ+ctNOa+/8L38JsXA1sZ4xzYzutojwFsnidxH2oBsuhsZIPcQJ0n5NZZ/6z1EPf9ZTZrmV9RwBcI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2815 Original-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=bestguesspass action=none header.from=arm.com; X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: bc61b04c-bf62-44b4-3ad9-08d7d3f3d688 X-Microsoft-Antispam-Message-Info: vZXToMv42KGiPFJzn/Fp6sbPSHhznkhsPqxTMJaH60JEHr8vvGUI2Hdq8xlRlkLFm24WVRq+dUaoHlUg4OQ/LCvrNndMYpyXTgfdFBwNvRyzNg2CU0zfbyunshYfVe2NzgEu7W49SgAeBeYUEvss9po/u/yGq/vVQTNlQ1S16FZrp/b4oFK331x8DYUWxeBGvvDFlYcW8ZcsojuIV9HufsvUMcoOkxeJDU2UDDGWEVPeJOiz7vPLxMbjd2rQgjlrc+yBGXWwvWjmJM9nbMlulXQNbDr10Xwv6V678Y7vvtgZizXqPjyGMv5mPYEem5ZJvH6ZoM6mLfnM9AsySkDH0sq+CT6nTrFHFLr6LX2ZXKEsUKSNfC7JzXy7smaVzhgXcU+8UOYE1g2U6InM4n+RTdkMDNSCtNe3/ZIL3vGAdmscpCPKdwTf+IoIutcWvadtunJccPmxI0JNEviTevQ/UuHCDoNnLKT4FdgDV3wkPXE3pCZRPMUGOPQlaVpzz2BMKhE8kbJx0+6bCFp4/M+Pq/Ze/cFb1tjc9pnYNvzDoil5duthyJlbDZNfqakMIbUjMGktkYAT9xL5asdeMczik/Aym7KsKbpyFKijJLuE0pk= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2020 15:14:20.9625 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09f00d26-8405-4777-a0c5-08d7d3f3db85 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4976 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,sami.mujawar@arm.com X-Gm-Message-State: TMFonQlRu8ELDM7sJRODfu6mx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585494865; bh=FEHeE0wcx4unEdIfRLEWDlnQr0EAlTiyI0lq3ay5LF8=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=PDlGy2pxx+7oeiMspnSPo/sb/loR8cCVh2PrvhT1BnEo/D2J/NbeAXsHNR307HXDr/F t+Rtp8DJQy6+VQaewqRpwJzTvZzBBtID8yJkhhlzSwxj09MJDLKcYaUQ99rFhcQpF+h/9 fxQhipjlx8tIsGQ7DxYfz9u7tJdnqMEB/SU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add build option STATIC_ANALYSIS to enable VS2017 static code analysis. Signed-off-by: Sami Mujawar Reviewed-by: Alexei Fedorov --- Notes: v2: Splitting patch series and re-submitting DynamicTablesPkg [SAMI] patches from https://edk2.groups.io/g/devel/message/46261 DynamicTablesPkg/DynamicTablesPkg.dsc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/Dynam= icTablesPkg.dsc index 19beaaf370f8633efa5e37c97f6665ae4505d4e7..02f04447fffa867c602c748279c= 041bd566a7fd6 100644 --- a/DynamicTablesPkg/DynamicTablesPkg.dsc +++ b/DynamicTablesPkg/DynamicTablesPkg.dsc @@ -40,3 +40,10 @@ [Components.common] =20 [BuildOptions] *_*_*_CC_FLAGS =3D -DDISABLE_NEW_DEPRECATED_INTERFACES + +!ifdef STATIC_ANALYSIS + # Check all rules + # Inhibit C6305: Potential mismatch between sizeof and countof quantitie= s. + *_VS2017_*_CC_FLAGS =3D /wd6305 /analyze +!endif + --=20 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56577): https://edk2.groups.io/g/devel/message/56577 Mute This Topic: https://groups.io/mt/72631555/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-