[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically

Nate DeSimone posted 1 patch 4 years ago
Failed in applying to current master (apply log)
edkrepo/commands/composite_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Posted by Nate DeSimone 4 years ago
Currently edkrepo --help shows a listing of commands
that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.

Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 edkrepo/commands/composite_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
         command_names = []
         for command in self._commands:
             command_names.append(command.get_metadata()['name'])
-        return command_names
+        return sorted(command_names)
--
2.25.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56507): https://edk2.groups.io/g/devel/message/56507
Mute This Topic: https://groups.io/mt/72597195/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Posted by Desimone, Ashley E 4 years ago
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Friday, March 27, 2020 1:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically

Currently edkrepo --help shows a listing of commands that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.

Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 edkrepo/commands/composite_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
         command_names = []
         for command in self._commands:
             command_names.append(command.get_metadata()['name'])
-        return command_names
+        return sorted(command_names)
--
2.25.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56518): https://edk2.groups.io/g/devel/message/56518
Mute This Topic: https://groups.io/mt/72597195/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Posted by Bjorge, Erik C 3 years, 12 months ago
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> 
Sent: Friday, March 27, 2020 1:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically

Currently edkrepo --help shows a listing of commands that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.

Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 edkrepo/commands/composite_command.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
         command_names = []
         for command in self._commands:
             command_names.append(command.get_metadata()['name'])
-        return command_names
+        return sorted(command_names)
--
2.25.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56798): https://edk2.groups.io/g/devel/message/56798
Mute This Topic: https://groups.io/mt/72597195/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-