From nobody Fri Apr 26 11:56:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56125+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56125+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1585014165; cv=none; d=zohomail.com; s=zohoarc; b=FG8FLhBks/asIgLBUa7p0+XyMGH/Svihh724LkmkvwP0S2j9pcfWgx9N0AmzGbt8Nf4xv9bhvMqLpdU6p+6TdhoKY/qu+4HgXDqRbMbhMarCugSOk9f8Z1HX0PGjZQB+IosGg3R5AQMbHSY9miUM7SgByJzoQ31lfKkU6D3w3s8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585014165; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=UQqwlZoSPfw0TGBWf9xohLxxHYY9XzHaMhiCbKeJi20=; b=WzhqbUf8ty5inje66M/Y6XvFclqSa9pi4uUuM0Oko/XH0YFdS2CRfTNvIpHnTCb+B6+jQyOiH0a6okaei1GgLBMzvnS9FAvInboyf+4aUq7l39SIJTQKla334sqOTmgw2WjSVSW0/Rdqgr5O93N9E+G4rNrU9f520RQXBAGBBQ8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56125+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158501416514875.64755152115231; Mon, 23 Mar 2020 18:42:45 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id CBCQYY1788612xC1jfikwRBe; Mon, 23 Mar 2020 18:42:44 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.4054.1585014164286193891 for ; Mon, 23 Mar 2020 18:42:44 -0700 IronPort-SDR: sgC4y02cRNvw60eVqejKBTMVcf/TjuD5Db1WlLdb/HqSDZJLQ2gdtUYoQw0RnzvBimCVa3UD8D rPddUz4E6zNA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2020 18:42:43 -0700 IronPort-SDR: LpwggZ6A59dss6is2DO5k4s2+xaiBxwusRRt+/smMuWJ39/9nraiAZ9sbzekiM/LW5sx1wg2XI OnYEAevFLtYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,298,1580803200"; d="scan'208";a="447712949" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga006.fm.intel.com with ESMTP; 23 Mar 2020 18:42:41 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH v4] MdePkg/UnitTestBaseLib: Add check for pointer BinData Date: Tue, 24 Mar 2020 09:42:41 +0800 Message-Id: <20200324014241.194-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: 86FFGDE0k4pVDjqE51YpBT4Lx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1585014164; bh=t3oJK2iCGOpNb6KZIahDFd3AQZQSn0db75R+M1tk0m4=; h=Cc:Date:From:Reply-To:Subject:To; b=W5k6QgTQQO3quqW+76ysLHFfKLvd1TGQmmEh/ALvKlL/JykiFm7PkuSJLPMeTJsManS gxrEuNeq/p0ALBHZQo9TMwkDlwH2ieueKN2MtKtYyI6u+L89olqrQ+wCl0yxLbd2xWcyF e8Hzo0vagNVEXYryIeAslY0fj6HDg2ciuSA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2531 AllocatePool may fail and BinData may be invalid, check it before use. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Guomin Jiang Reviewed-by: Bret Barkelew Reviewed-by: Michael D Kinney --- MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c b/MdePkg= /Test/UnitTest/Library/BaseLib/Base64UnitTest.c index 6f7c31cab4..8952f9da6c 100644 --- a/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c +++ b/MdePkg/Test/UnitTest/Library/BaseLib/Base64UnitTest.c @@ -252,9 +252,11 @@ RfcDecodeTest( BinSize =3D AsciiStrnLenS (binString, MAX_TEST_STRING_SIZE); =20 BinData =3D AllocatePool (BinSize); - Btc->BufferToFree =3D BinData; + UT_ASSERT_NOT_NULL(BinData); =20 + Btc->BufferToFree =3D BinData; ReturnSize =3D BinSize; + Status =3D Base64Decode (b64String, b64StringLen, BinData, &ReturnSize); =20 UT_ASSERT_STATUS_EQUAL (Status, Btc->ExpectedStatus); --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56125): https://edk2.groups.io/g/devel/message/56125 Mute This Topic: https://groups.io/mt/72508893/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-