From nobody Thu Apr 25 15:55:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56050+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56050+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584716306; cv=none; d=zohomail.com; s=zohoarc; b=bMMvAINCAdyneBYG4W0SgH5+35QaXAM9l4MboY8oDXdpjod1gn57KFEu7l3FQAbPdbH9W8VmXR4k1iIeoM4ty+7HDF0qDjwRIfz78W0kZYwOl2tUeCk78dID1LzfKDCWET3YiR0URZ1mt1u7Eepkjpk3THceHEGrxcU9fwvbUG0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584716306; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=I4ntc8WBfkm7a6dBxBstaSSDat1zpk01j0SH1Nz5w5g=; b=KKVqhM10Z6Nm6D1mVuYglc9E3IuCaLrtvOd4W80NECdKZHfGfdXQ1G0dJuCA74vpCub7PU6EmO5thNZbUqkGWnzvOX8dg7ltONSMA4WY8kX6VASxhd1fKg8KS8FhfvcBxKaGmeNUGeTSdlWgDjvPwGu1GWFgHQKi9MBDB6TMIIg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56050+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584716305951908.4766524084275; Fri, 20 Mar 2020 07:58:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 26sOYY1788612xqVyjWEO2n3; Fri, 20 Mar 2020 07:58:25 -0700 X-Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.6677.1584687347579807799 for ; Thu, 19 Mar 2020 23:55:47 -0700 IronPort-SDR: nqnaPOlcsbY6VCmHeN75adQFajb6nQN3W2rZZCH1yrH3Kbjm5/uKsXDaymqUmAXcyhlTU7QjkQ cderbrfoLY7g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 23:55:47 -0700 IronPort-SDR: g44Cqe+2Q2xVFggp5H6fmMOVkBgDmiIv/Zb62iRxsD9XLUF7rXYmfBRBxcc5NcyZGuCO/Vo1Nj 7Ui8M+aj3kmA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,283,1580803200"; d="scan'208";a="248790383" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by orsmga006.jf.intel.com with ESMTP; 19 Mar 2020 23:55:44 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Cc: Jordan Justen , Andrew Fish , Ray Ni Subject: [edk2-devel] [PATCH] EmulatorPkg/WinHost: Add EFI_BUFFER_TOO_SMALL for return status. Date: Fri, 20 Mar 2020 14:55:43 +0800 Message-Id: <20200320065543.602-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: lPz9HMwzaBC16ZBsUkNSRkDTx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584716305; bh=iANI7+XKCMFpCHwVEs4WfZHkjFlAefykM0XJo3PJi9w=; h=Cc:Date:From:Reply-To:Subject:To; b=MmkXIULpSdXl+HR9ZL7qUrMGGsSJ6r5vt3JBKFkLIJs0FL43UAOytYpdDfeQAqwVmRu bYZrk7qnH9mDoxOfhR7Lpc4LUCVHOjfJLJ03v/eF3gXk8UTitYNv7ttlsjg2GzJODsGRB 7TtKj7wCrOKAFchJCCD6BVjFrqZZr1HYru0= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2605 I think it is necessary that check the buffer size before ReadFile, it will inform the caller that they should provide more buffer. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Guomin Jiang --- EmulatorPkg/Win/Host/WinFileSystem.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/EmulatorPkg/Win/Host/WinFileSystem.c b/EmulatorPkg/Win/Host/Wi= nFileSystem.c index f6b06b1c92..6fb86db6b3 100644 --- a/EmulatorPkg/Win/Host/WinFileSystem.c +++ b/EmulatorPkg/Win/Host/WinFileSystem.c @@ -1159,6 +1159,12 @@ WinNtFileRead ( } } =20 + if (FileSize > *BufferSize) { + Status =3D EFI_BUFFER_TOO_SMALL; + *BufferSize =3D FileSize; + goto Done; + } + Status =3D ReadFile ( PrivateFile->LHandle, Buffer, --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56050): https://edk2.groups.io/g/devel/message/56050 Mute This Topic: https://groups.io/mt/72094663/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-