From nobody Thu Mar 28 21:24:52 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56082+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56082+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584933617; cv=none; d=zohomail.com; s=zohoarc; b=dRMD7gyImaiINTzMKevvoAgZABtbTN9VY2N/fDTgYJD499PHF1JhkIYHLhuHjc05OMqKjT0JG/75Dgf2wQ77tj2NeKt9ebfNjQtlYyR/Oe7qLU7xaC8i4e/YEa9XdAyTLTMVLzosOpBvFodfMCCLwYqa3GuUncUxbg51pVCjB4c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584933617; h=Content-Transfer-Encoding:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=2fmNNciPeUQNlVM20Cqa3z38scQZ8sxWic1EyWUgBcI=; b=jVNLWBMcxtgtTnJy7acJUjMi/f6IiS0TK/HTSBUdiCkDeOMon0tXGQBwGWBac5A8w33fsWKzmXUQAKCo1VBGo3nz/D7BG2BT3s2ctbEvwgOngJh8W5XMgRPEN5c53Jxjj/4vJiFrgZGY7ZOz3baNDdh8clOoWttomJRlic//LL0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56082+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584933617742716.7369316828374; Sun, 22 Mar 2020 20:20:17 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id wb1eYY1788612xxSnKQNn3aL; Sun, 22 Mar 2020 20:20:17 -0700 X-Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.14927.1584538428890160341 for ; Wed, 18 Mar 2020 06:33:49 -0700 IronPort-SDR: ejaMqYsf4e8jx0w9AXl/AHqFBq5Y3aVKg0xyZOsNbnkZyBOoWEeuBEP4RVquPKCyqPjpZ4fGtJ 1pfJRx6qnaeA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 06:33:46 -0700 IronPort-SDR: zCKMw0u+Dv/MzR2ICacIexBtlIHyzG+9lMqULLbztx0RIJ90KtJmJq8oPN3UHFuD+nJUJFqh1Q AvcEPTZMaaDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,567,1574150400"; d="scan'208";a="263383768" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.254.212.104]) by orsmga002.jf.intel.com with ESMTP; 18 Mar 2020 06:33:45 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platforms][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Date: Wed, 18 Mar 2020 21:33:43 +0800 Message-Id: <20200318133343.393-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: 7McbY0qQhELHOO0hbHfUJZfgx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584933617; bh=9gE5K3mvjSWewM4ErhiF2o/b9w7mXe32uVV9miemg0A=; h=Date:From:Reply-To:Subject:To; b=xJBSW19Kcv/cAnQ7BxplUb+Li5duEW90Zn8iCE86F0sf3V+RWF9rfaVrgSZB2WbJXe6 jhqZEYvmkXVxvEtbHa2M1vpy/+naJ+MO/8kWE8o4pd71iD/0tYkw1SOtiKaZvNMST6edw OUtDyfjZWkcgataPi/yZrBceDSoHrsT3Kuo= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang Reviewed-by: Bret Barkelew --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); =20 NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); + ASSERT(NewPciDevice !=3D NULL); =20 NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment =3D PciSegment; --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56082): https://edk2.groups.io/g/devel/message/56082 Mute This Topic: https://groups.io/mt/72484273/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-