From nobody Fri Apr 19 18:11:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56087+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56087+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584933776; cv=none; d=zohomail.com; s=zohoarc; b=VoDbtP/EXmGHF3wS5YAqu44b8bgROlkKoyvELzKLQKVn7zx3yXVRV2rNbDl6suwriGdeb99Rqe20GYdMYpVyyWztaTbv2JaecBRClUPhEkFwScFZcPe4yi7kHIfwGJ/rnU8GdTCX/lrNiofQrb8syWNHzDP0AjqHDA92zqhqs+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584933776; h=Content-Transfer-Encoding:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=pxu8qK3Nm/7aDAtwudX2YzY0N41/00l20WB35V92W6o=; b=BRIWXNQLoBi1cgALIGRddyOlluWZfMUiyPyNGHcexJPS5OFTuW8ogAccpTGuS5PaUlihZKevcZtzc/ytYpELC7+zAWkRLGFv8NwZtB8OwaephvK1mbSfzAAqXnbnElV/BvhzsPVzIA6iU/aDPhPCLIHtRKJ5ECowpKGu6sqSwjs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56087+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584933776994493.2487998578531; Sun, 22 Mar 2020 20:22:56 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id VgkPYY1788612xmxf9eSYJek; Sun, 22 Mar 2020 20:22:54 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.10609.1584520388065649027 for ; Wed, 18 Mar 2020 01:33:08 -0700 IronPort-SDR: tYetJoJ9u/iFhpP4XeMNNd7VfaG3H7MQujxPIwf9a9z/J8KVlXCuynFvcOSwfzniQSK9F4Bhap Qr3jMhjFuYcQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 01:33:07 -0700 IronPort-SDR: dE+unxQLjAsKB0gTMKxrXUr3MzWPahNJrcBl1VNfL/0yjTUoLdV6DuVPYkrs63WbL2NtC3w+HZ Y/S0CVTMpfrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="445791700" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga006.fm.intel.com with ESMTP; 18 Mar 2020 01:33:06 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Date: Wed, 18 Mar 2020 16:33:06 +0800 Message-Id: <20200318083306.1385-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: yJ3GLelWY1gJznWanZy5p7T5x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584933774; bh=UJvx9y+WhUELcCGWfq8hjgr1GsIQuJKUDJJK+F5nQjU=; h=Date:From:Reply-To:Subject:To; b=I8tjMLOezCIshZ/7L4gabsd1OrCZFjCgGLOH62H/Dd/273r1tgyxS46sFt+fKXbfv/Q yxcJeca8LMKPhbT/qPjGfpwjJZMcbU//A4eRrlS9QCIKYEPFDyWJM/3rim0+JRjaruor+ XYlQiPImiMAzmDUAoKZ2EcStBSOj7LqMd24= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); =20 NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); + ASSERT(NewPciDevice !=3D NULL); =20 NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment =3D PciSegment; --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56087): https://edk2.groups.io/g/devel/message/56087 Mute This Topic: https://groups.io/mt/72484312/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-