From nobody Sat Apr 20 02:15:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+56086+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56086+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584933774; cv=none; d=zohomail.com; s=zohoarc; b=EalbkwHvqRnXyye6I9j9YLlGXUMz7aQsB2TQRUpF9+IIQJGJ/3KSPTexD5oo2cbcVA6DjLplZxlUzhuVpAxa7ctFutpK4CACKNmFAxy9Pjk0zzUMoqxU0SreCpOmcYn+eKhL6FasF/x42oZ2JnzkouxTOXLP+fuAGa+ZV4pyQj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584933774; h=Content-Transfer-Encoding:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=XIHYc3H+snsEYElLYJ/ZuAO7ODikoOhfbFAQCtjKE1M=; b=N2vfVy+/T+JZpgNoZKJAwgNDr/VLCtgminSg+da2Xq21XBHnrnUdkJphgOxV8QUDuNNEPveCdqcetC2azo5nN9NMLmKP4WD5OGl+bLGiBJ7Cc7EEr1fGe09S94CfUfRIHMPY3O/QSqUGYUKwFaaGGk1Bw0YbNO9m1m4HDdeazO8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+56086+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584933774719511.79794348123664; Sun, 22 Mar 2020 20:22:54 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id fKwAYY1788612x1RochtqgdJ; Sun, 22 Mar 2020 20:22:54 -0700 X-Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.10474.1584519869635871846 for ; Wed, 18 Mar 2020 01:24:29 -0700 IronPort-SDR: pO0P2IaYoqI++uXwlCCe1tp3G9z3POe+7L+6f3Jr+IevPLUCc2+bMOW+nSt/2k7pgUrPsC+V1b Joh1VbmNOdgg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 01:24:29 -0700 IronPort-SDR: tQfDtAe1BFmgWQldd9XrJNUJreZnewgZzdcq7pTHZgSps6EaM63tBk+pxd3eEbvWctrla9NMlV WIuGThvmGtxA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="445788998" X-Received: from guominji-mobl.ccr.corp.intel.com ([10.238.5.173]) by fmsmga006.fm.intel.com with ESMTP; 18 Mar 2020 01:24:28 -0700 From: "Guomin Jiang" To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platform][PATCH] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Replace ASSERT_EFI_ERROR Date: Wed, 18 Mar 2020 16:24:27 +0800 Message-Id: <20200318082427.1295-1-guomin.jiang@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,guomin.jiang@intel.com X-Gm-Message-State: vRj9lVN4vtetITliZTDaXmsyx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584933774; bh=bbbKYOm6Yw3+okQOh/6wCQRGQ2cH4ksjGfNLX7PGGiY=; h=Date:From:Reply-To:Subject:To; b=KcKwtFiFStMiabXWsIfo7NXoC7jiQjfNXV1GiMJRQTFS1gyrtxvo9KxMf0ABtlWZGzV Dmk44MOQSbbvTRYxaSCUytE3ZCAhyyUX1Pd60Dk2LsFb9eI9xWpGPEcMUu8OgXAWlnQRv /KnfM3b9HmC82TXameg17XidAK9RQdZfskU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From: Guomin Jiang REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2589 According to code logic, it just judge the condition rather than the status, it should use the ASSERT rather than ASSERT_EFI_ERROR. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Guomin Jiang --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDev= iceSecurityDxe/IntelPciDeviceSecurityDxe.c b/Silicon/Intel/IntelSiliconPkg/= Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c index 29b6916f61..aa2bf14fa8 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecu= rityDxe/IntelPciDeviceSecurityDxe.c @@ -69,7 +69,7 @@ RecordPciDeviceInList( ASSERT_EFI_ERROR(Status); =20 NewPciDevice =3D AllocateZeroPool(sizeof(*NewPciDevice)); - ASSERT_EFI_ERROR(NewPciDevice !=3D NULL); + ASSERT(NewPciDevice !=3D NULL); =20 NewPciDevice->Signature =3D PCI_DEVICE_INSTANCE_SIGNATURE; NewPciDevice->PciSegment =3D PciSegment; --=20 2.25.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#56086): https://edk2.groups.io/g/devel/message/56086 Mute This Topic: https://groups.io/mt/72484312/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-