From nobody Sun Apr 28 19:06:22 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55951+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55951+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584511954; cv=none; d=zohomail.com; s=zohoarc; b=Fg33U5BBqiRT07zFdbKJjpAUaHfBIpCbSy/x8PYvaTC9N9GpeP1DmrZRcAbhSZSI5VOLWfd18MGl/rXf9NbIh1bA63QTHaE2pR/DGzK8M1EfKny8+eA/20pRl15baHkrOt2XD1bYHHLq9vq1SRZtMacsRHoOY3iB+7Cd1Ac2Qlw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584511954; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=otJk1ouFQUrnn29wyZwyIGEIAYsqjbxU8RYSByoxE+E=; b=ZLhhfaOu5C7kzrd85BjvHi3v2hRZrayI54iir37TA8Di2ZF0PzQHhHyabbHyo0g8ee0Swn64SzmjAMCXjASC6ARXTKk8mTlh1J4b4UIZiwBOhR0KR9qZCkipG40X1Rs/WvEvSQysdPn5mEOA42KoZkTS2F4VJ8rMMxC37GAeIIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55951+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584511954162693.5727956025968; Tue, 17 Mar 2020 23:12:34 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id 7BPjYY1788612xfHzRm1jyDB; Tue, 17 Mar 2020 23:12:33 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.9619.1584511953085378720 for ; Tue, 17 Mar 2020 23:12:33 -0700 IronPort-SDR: HAViRe/I8tuG39DsLu9z8mfYw44MRA2ckV50KACaOWToNhl4Ji7XKzXZ9H4Dt8Jw8INlWvyZz1 umeOn6kGzsWg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 23:12:32 -0700 IronPort-SDR: G8Mcwi2TCAJZGJSi8nvGvZLE9wlqbhCDMDcT4jZkI5WWgrefgSa7Fde9hAFUvSER9pszl43FoX 5Ic2gS49AVTA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,566,1574150400"; d="scan'208";a="391333731" X-Received: from shwdeopenpsi174.ccr.corp.intel.com ([10.239.157.39]) by orsmga004.jf.intel.com with ESMTP; 17 Mar 2020 23:12:30 -0700 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Kun Qin , Michael D Kinney , Liming Gao Subject: [edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Fix uninitialized pointer dereference Date: Wed, 18 Mar 2020 14:12:27 +0800 Message-Id: <20200318061227.12480-1-wei6.xu@intel.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com X-Gm-Message-State: keghP9vm0wDu8O6kB8WA05xkx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584511953; bh=E+7Rn+CmRI49wOG4up+L1bEwdr2ljtqowFUmfpp3ngo=; h=Cc:Date:From:Reply-To:Subject:To; b=caDQBQ4a1xezcwjfqecxX6rz/rBwRsJthlc5oYGpjqhb75f87dfjCClDDntD1Ubpjq1 52actrTDn7Ojy1vC+9pmrh5ipKLqU5k1YAIfighwi+q6hZzdIH2SL6sKsxYBfJfIj/M2C qBpomeMK3qqmewXQQ+ncgGgjWi2U82Hf+Hw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Kun Qin REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2602 Zero the allocated buffer in case GetImageInfo `continue` in the middle of a loop. This will cause unexpected GetImageInfo failure not clearing the corresponding entry and lead to GP faults when dereferencing this entry. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Wei6 Xu Reviewed-by: Guomin Jiang Reviewed-by: Michael D Kinney --- FmpDevicePkg/FmpDxe/Dependency.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDxe/Dependency.c b/FmpDevicePkg/FmpDxe/Depende= ncy.c index 8f97c42916..65c23989c6 100644 --- a/FmpDevicePkg/FmpDxe/Dependency.c +++ b/FmpDevicePkg/FmpDxe/Dependency.c @@ -550,11 +550,11 @@ EvaluateImageDependencies ( ); if (EFI_ERROR (Status)) { return EFI_ABORTED; } =20 - mFmpImageInfoBuf =3D AllocatePool (sizeof(EFI_FIRMWARE_IMAGE_DESCRIPTOR = *) * mNumberOfFmpInstance); + mFmpImageInfoBuf =3D AllocateZeroPool (sizeof(EFI_FIRMWARE_IMAGE_DESCRIP= TOR *) * mNumberOfFmpInstance); if (mFmpImageInfoBuf =3D=3D NULL) { return EFI_OUT_OF_RESOURCES; } =20 for (Index =3D 0; Index < mNumberOfFmpInstance; Index ++) { --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55951): https://edk2.groups.io/g/devel/message/55951 Mute This Topic: https://groups.io/mt/72043533/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-