From nobody Sun Feb 8 09:27:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55901+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55901+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1584379983; cv=none; d=zohomail.com; s=zohoarc; b=g9C/guahjdQSY4P/IwnhnCvUxu0UQOY12mxf4rADGiVbFxLHfMsSP9y7B4kyZajlW7lUUt0TsEyFUJJQfHeCkq6LCTkOGeWxU/EkdVULq/jQJsLET09QIRiSM6WlEmfn+CA1FH3w6VCv9nsX7PEwp0Ka13g0uUi/71T0GzvHpP8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584379983; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=UqljJWC47foG2HggRSMy4NLpn01ZbUbG3w+1EBhPByE=; b=XZQNxHwSjEWG8Ioyqjo7DXGwts/ESbaoDZwyYEesXORWdZodPiTu1nBOZ5IytMf0Oq/OF6teVKLo3FvXWR4Z4kFr2gjb+sKCBi7CwhEoJirKhSxGrWmiiMZJYxDW55h5iepAIy6emXQl5wwIa5vVMYFUjthjHm7R9BLyBaP3OmI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55901+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1584379983819831.319448511407; Mon, 16 Mar 2020 10:33:03 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id l9uiYY1788612xx2KrgpAu0X; Mon, 16 Mar 2020 10:33:03 -0700 X-Received: from mga02.intel.com (mga02.intel.com []) by mx.groups.io with SMTP id smtpd.web11.74233.1584379978542701702 for ; Mon, 16 Mar 2020 10:33:03 -0700 IronPort-SDR: r02Pou4poet6019HAyGtydsN6JTB3RUyxJOUVd70gD8alyh8vn5Y57epTK0/nvqRMORmfL6dbZ twgLIt0Yod+w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 10:33:02 -0700 IronPort-SDR: LcOpeJsLSFZNrkXdgMPOsWVCznlzEoqxVTKrxBn97vKlAcvAILSXcgQ0mbOlWKKCwHiz666tkk 2DVhizRGdDXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,561,1574150400"; d="scan'208";a="417229365" X-Received: from nldesimo-desk1.amr.corp.intel.com ([10.7.159.63]) by orsmga005.jf.intel.com with ESMTP; 16 Mar 2020 10:33:02 -0700 From: "Nate DeSimone" To: devel@edk2.groups.io Cc: Ashley DeSimone , Puja Pandya , Erik Bjorge , Bret Barkelew Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Uninstaller does not uninstall packages with '_' in their name. Date: Mon, 16 Mar 2020 10:32:47 -0700 Message-Id: <20200316173248.1678-2-nathaniel.l.desimone@intel.com> In-Reply-To: <20200316173248.1678-1-nathaniel.l.desimone@intel.com> References: <20200316173248.1678-1-nathaniel.l.desimone@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com X-Gm-Message-State: TH9gstGid5wJojq98yQ2VP05x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1584379983; bh=3s/MwAaC/lTVKUbEAgFlgK3SrSSw0EKZSnStU2umUDc=; h=Cc:Date:From:Reply-To:Subject:To; b=IfIN2C0NodDv1YvxW/a0WzKS9hB8lfFBIuecxJ/ALUyj6PkywOb5Q09OmKRwKPZqZ6+ kjIIYergMGuGospE2Y85fsM6fwNAkN89+U2vmT3I/4adZUPG2/KWqxH5lHnMdyLzJNZ+m VOHryE+U0EIriBGro0AfY8blP533/vpDRUw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" pip does not support '_' in package names and converts them to '-' after installing the wheel. In order to uninstall affected packages the '_' needs to be converted to a '-' when calculating the package name. Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone Reviewed-by: Ashley DeSimone --- edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs b/edkrepo_= installer/EdkRepoInstaller/InstallWorker.cs index 5a358f9..f9738fd 100644 --- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs +++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs @@ -550,10 +550,16 @@ namespace TianoCore.EdkRepoInstaller { if (VendorCustomizer.Instance.GetPythonWheelsToUninstall != =3D null) { - return VendorCustomizer.Instance.GetPythonWheelsToUnin= stall(); + // + // pip doesn't understand the difference between '_' a= nd '-' + // + return VendorCustomizer.Instance.GetPythonWheelsToUnin= stall().Select(p =3D> p.Replace('_', '-')); } } - return new string[] { InstallerStrings.EdkrepoPackageName }; + // + // pip doesn't understand the difference between '_' and '-' + // + return (new string[] { InstallerStrings.EdkrepoPackageName }).= Select(p =3D> p.Replace('_', '-')); } =20 public void PerformInstall(Action ReportComplete, Acti= on ReportProgress, Action AllowCancel, Func CancelPending) --=20 2.24.0.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55901): https://edk2.groups.io/g/devel/message/55901 Mute This Topic: https://groups.io/mt/72004232/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-