From nobody Mon Apr 29 06:10:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55690+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55690+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1583763698; cv=none; d=zohomail.com; s=zohoarc; b=R+eDgwR3jMsZeTlVAQ22msXjcLhjdfK64GaZF1MCQYLEyMdvIr0gb6mkB44YvhB/UGu9U+Hi2E2ovbln5KCJ9WZSmefab5tON5nwc8CpXVDz6c3h304hOKtGsquIyHtiDz07IIQP3c8hVZXIi5fYgqzyJ8lq4IT/5bsoBbxoWTo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583763698; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=aH3AwzeWNH/GAaiDbeWUNqQlrmuVfwW2E249hLthdhM=; b=RLNkCgSDBLJZmhJlRVEDz3UmdcCdB2gIIr52WDG4FiwZOt8mhIAzTiLyk8d2m4LZyjJcMcbdQKtw6doT1RFV5E4gEN0gXBFhWn98POoq89oCDnUHi0WRlQEZfwscE6XlnBWuRytge1bfb/W/AXxoBpKA96FRCCYO0hohnIKNgWk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55690+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158376369862098.12902044837085; Mon, 9 Mar 2020 07:21:38 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id iTl2YY1788612xR8M3G94nMI; Mon, 09 Mar 2020 07:21:37 -0700 X-Received: from mail-ed1-f65.google.com (mail-ed1-f65.google.com [209.85.208.65]) by mx.groups.io with SMTP id smtpd.web12.57039.1583763696826131520 for ; Mon, 09 Mar 2020 07:21:37 -0700 X-Received: by mail-ed1-f65.google.com with SMTP id a20so6272487edj.2 for ; Mon, 09 Mar 2020 07:21:36 -0700 (PDT) X-Gm-Message-State: EtlKu71zFqHG4qgjERlTthUlx1787277AA= X-Google-Smtp-Source: ADFU+vtd5i9L6aBuaDAZSGR+HBpuegkwMbSzEYj3O6YOeWvTtslfqDWFgjYGI+U1U7iawlVddQtV+g== X-Received: by 2002:a17:906:7ac9:: with SMTP id k9mr4477501ejo.44.1583763695085; Mon, 09 Mar 2020 07:21:35 -0700 (PDT) X-Received: from localhost.localdomain ([84.203.66.228]) by smtp.gmail.com with ESMTPSA id r23sm3901569edx.24.2020.03.09.07.21.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2020 07:21:34 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com, philmd@redhat.com, awarkentin@vmware.com Subject: [edk2-devel][PATCH 1/2] Platform/RPi/AcpiTables: Fix ASL compilation warnings Date: Mon, 9 Mar 2020 14:21:18 +0000 Message-Id: <20200309142119.7260-2-pete@akeo.ie> In-Reply-To: <20200309142119.7260-1-pete@akeo.ie> References: <20200309142119.7260-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1583763697; bh=cU6fPUzshBfHGzX656j/2sFQ99JjF/nW5E2leCkwgu0=; h=Cc:Date:From:Reply-To:Subject:To; b=UGHMOMxOQ4cR4HgJg1x1eRv5eDYp4nZlrkoIdDEL5fUn9yj8N9WD4qWqevmBTOpHgVA JI29NFmEoPLT+NuG5ln9Ty6561O5HEr5+HTjwf9oZziaRMZYUgSmQOhcneIXTp6CKSsSk Mc57HlMA0sumPCWhVxRo8tTNzECaL/fXnbg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Silence 2 warnings from pep.asl: * "Warning 3133 - Unknown reserved name (_GPI/_GCI/_GDI)" * "Warning 3150 - Empty Resource Template", which is caused by section "Name (_CRS, ResourceTemplate () {})" Remove "Offset(0)" in Xhci.asl, which produces the warning: "Unnecessary/redundant use of Offset operator". Signed-off-by: Pete Batard Reviewed-by: Ard Biesheuvel --- Platform/RaspberryPi/AcpiTables/AcpiTables.inf | 3 +++ Platform/RaspberryPi/AcpiTables/Xhci.asl | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Platform/RaspberryPi/AcpiTables/AcpiTables.inf b/Platform/Rasp= berryPi/AcpiTables/AcpiTables.inf index c95d75ed01bb..9ad5246d6bb6 100644 --- a/Platform/RaspberryPi/AcpiTables/AcpiTables.inf +++ b/Platform/RaspberryPi/AcpiTables/AcpiTables.inf @@ -56,3 +56,6 @@ [FixedPcd] gBcmNetTokenSpaceGuid.PcdBcmGenetRegistersAddress gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate gEmbeddedTokenSpaceGuid.PcdInterruptBaseAddress + +[BuildOptions] + GCC:*_*_*_ASL_FLAGS =3D -vw3133 -vw3150 diff --git a/Platform/RaspberryPi/AcpiTables/Xhci.asl b/Platform/RaspberryP= i/AcpiTables/Xhci.asl index 0083d1992936..bc3fea60f925 100644 --- a/Platform/RaspberryPi/AcpiTables/Xhci.asl +++ b/Platform/RaspberryPi/AcpiTables/Xhci.asl @@ -118,7 +118,6 @@ Device (SCB0) { Method (_INI, 0, Serialized) { OperationRegion (PCFG, SystemMemory, SANITIZED_PCIE_REG_BASE += PCIE_EXT_CFG_DATA, 0x1000) Field (PCFG, AnyAcc, NoLock, Preserve) { - Offset (0), VNID, 16, // Vendor ID DVID, 16, // Device ID CMND, 16, // Command register --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55690): https://edk2.groups.io/g/devel/message/55690 Mute This Topic: https://groups.io/mt/71835503/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Mon Apr 29 06:10:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55691+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55691+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1583763700; cv=none; d=zohomail.com; s=zohoarc; b=SFZZxm9ORkuowyqqC+RDINMuRC94YvBbnOmbJ6vdZoymE0W2qIXH1NDF2mnLaTV4HS4GZRJlhdgxLDZffRb/Dpc/d/nR7CelUsDirFCAe5uC70Sqh+KVXZyEiLRNaC3STVj5bopfXabL36Muky7JjsJI2XN4Dgd4PzT0ruf87io= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583763700; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=foa5gqC4S6LZcKrEuO9ugbmukDJnfjc/PjZYt8MHABQ=; b=XmNkW0zCmcbTyolOjOyMKnIdwfXIGDb9Y/D7dXkBCfEkL/YwwBT5+6jI/a58p5MBFAjZ8+DM6W61GlNm5dASud/HKfL3VExIBP/VkjKAswktdpYlxC3TPgKth3BXoVlBUoOX8PBaKFNC4dDgadfD7qOEzfWTN54uVw2fGz+fyps= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55691+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1583763700090241.62026212178841; Mon, 9 Mar 2020 07:21:40 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id UM24YY1788612xAxnsAkDuJ3; Mon, 09 Mar 2020 07:21:39 -0700 X-Received: from mail-ed1-f67.google.com (mail-ed1-f67.google.com [209.85.208.67]) by mx.groups.io with SMTP id smtpd.web12.57040.1583763698238007630 for ; Mon, 09 Mar 2020 07:21:38 -0700 X-Received: by mail-ed1-f67.google.com with SMTP id g19so12183295eds.11 for ; Mon, 09 Mar 2020 07:21:38 -0700 (PDT) X-Gm-Message-State: FxKrxpKqVnvdMI52smvqWxzYx1787277AA= X-Google-Smtp-Source: ADFU+vuO9bpuoDu3qy615odHUTU/Gx9LiIkODHVs5BjdPaOX5IQDW3NzjqUazqpCozpghxoJ5KNGnA== X-Received: by 2002:a17:906:53ce:: with SMTP id p14mr14883369ejo.212.1583763696388; Mon, 09 Mar 2020 07:21:36 -0700 (PDT) X-Received: from localhost.localdomain ([84.203.66.228]) by smtp.gmail.com with ESMTPSA id r23sm3901569edx.24.2020.03.09.07.21.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2020 07:21:35 -0700 (PDT) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com, philmd@redhat.com, awarkentin@vmware.com Subject: [edk2-devel][PATCH 2/2] Platform/RPi/ConfigDxe: Fix a compilation warning Date: Mon, 9 Mar 2020 14:21:19 +0000 Message-Id: <20200309142119.7260-3-pete@akeo.ie> In-Reply-To: <20200309142119.7260-1-pete@akeo.ie> References: <20200309142119.7260-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1583763699; bh=HWyZn0T13i0iuezRrEdGH4mir9IgBBqdKZnmJxAxpYc=; h=Cc:Date:From:Reply-To:Subject:To; b=blSiXk8Eld1M5dDh4aP3h4jlHfbC5zdK+E71O+X0v5J0ypiILsHQL7ojSezt8ROaocb Bxz7lOdGmZLS4v+yjzQUgatJrZsQdeDz8ro4GwWvkg/8CNluadUrr1DVbO7zqt7F9WZVn O84T9COTpWc9tpHjwYs313OaS+GlZzHZi8k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" This fixes "WARNING: default value re-defined with different value" being produced when trying to set default values for the Scaled VModes in ConfigDxeHii.vfr. This warning is generated regardless of what the default value is being set to and since we don't actually care about setting a default value, as long as the PCD is properly set, we choose to simply remove the default. We also ensure that all the PCDs are set to the expected default value. Signed-off-by: Pete Batard Reviewed-by: Ard Biesheuvel --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 ------ Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- Platform/RaspberryPi/RaspberryPi.dec | 2 +- 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr b/Plat= form/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr index 2a15e0f5096e..10c9e646f621 100644 --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr @@ -365,42 +365,36 @@ formset prompt =3D STRING_TOKEN(STR_DISPLAY_VMODES_640_PROMPT), help =3D STRING_TOKEN(STR_DISPLAY_VMODES_640_HELP), flags =3D CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG | RESE= T_REQUIRED, - default =3D TRUE, endcheckbox; =20 checkbox varid =3D DisplayEnableScaledVModes.v800, prompt =3D STRING_TOKEN(STR_DISPLAY_VMODES_800_PROMPT), help =3D STRING_TOKEN(STR_DISPLAY_VMODES_800_HELP), flags =3D CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG | RESE= T_REQUIRED, - default =3D TRUE, endcheckbox; =20 checkbox varid =3D DisplayEnableScaledVModes.v1024, prompt =3D STRING_TOKEN(STR_DISPLAY_VMODES_1024_PROMPT), help =3D STRING_TOKEN(STR_DISPLAY_VMODES_1024_HELP), flags =3D CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG | RESE= T_REQUIRED, - default =3D TRUE, endcheckbox; =20 checkbox varid =3D DisplayEnableScaledVModes.v720p, prompt =3D STRING_TOKEN(STR_DISPLAY_VMODES_720_PROMPT), help =3D STRING_TOKEN(STR_DISPLAY_VMODES_720_HELP), flags =3D CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG | RESE= T_REQUIRED, - default =3D TRUE, endcheckbox; =20 checkbox varid =3D DisplayEnableScaledVModes.v1080p, prompt =3D STRING_TOKEN(STR_DISPLAY_VMODES_1080_PROMPT), help =3D STRING_TOKEN(STR_DISPLAY_VMODES_1080_HELP), flags =3D CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG | RESE= T_REQUIRED, - default =3D TRUE, endcheckbox; =20 checkbox varid =3D DisplayEnableScaledVModes.Physical, prompt =3D STRING_TOKEN(STR_DISPLAY_VMODES_REAL_PROMPT), help =3D STRING_TOKEN(STR_DISPLAY_VMODES_REAL_HELP), flags =3D CHECKBOX_DEFAULT | CHECKBOX_DEFAULT_MFG | RESE= T_REQUIRED, - default =3D TRUE, endcheckbox; =20 oneof varid =3D DisplayEnableSShot.Enable, diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3= /RPi3.dsc index 91d5738afbc6..8266a92f3958 100644 --- a/Platform/RaspberryPi/RPi3/RPi3.dsc +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc @@ -436,7 +436,7 @@ [PcdsDynamicHii.common.DEFAULT] # # Display-related. # - gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableS= caledVModes"|gConfigDxeFormSetGuid|0x0|0xff + gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableS= caledVModes"|gConfigDxeFormSetGuid|0x0|0x3f gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|g= ConfigDxeFormSetGuid|0x0|1 =20 # diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4= /RPi4.dsc index 2e98c3e16b91..85b5f024ef1b 100644 --- a/Platform/RaspberryPi/RPi4/RPi4.dsc +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc @@ -475,7 +475,7 @@ [PcdsDynamicHii.common.DEFAULT] # # Display-related. # - gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableS= caledVModes"|gConfigDxeFormSetGuid|0x0|0xff + gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|L"DisplayEnableS= caledVModes"|gConfigDxeFormSetGuid|0x0|0x3f gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|L"DisplayEnableSShot"|g= ConfigDxeFormSetGuid|0x0|1 =20 # diff --git a/Platform/RaspberryPi/RaspberryPi.dec b/Platform/RaspberryPi/Ra= spberryPi.dec index 1355cdee0534..10e0ef95a749 100644 --- a/Platform/RaspberryPi/RaspberryPi.dec +++ b/Platform/RaspberryPi/RaspberryPi.dec @@ -56,7 +56,7 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, Pc= dsDynamicEx] gRaspberryPiTokenSpaceGuid.PcdDebugEnableJTAG|0|UINT32|0x00000014 gRaspberryPiTokenSpaceGuid.PcdDebugShowUEFIExit|0|UINT32|0x00000015 gRaspberryPiTokenSpaceGuid.PcdCustomCpuClock|0|UINT32|0x00000016 - gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|0|UINT8|0x000000= 17 + gRaspberryPiTokenSpaceGuid.PcdDisplayEnableScaledVModes|0x3F|UINT8|0x000= 00017 gRaspberryPiTokenSpaceGuid.PcdDisplayEnableSShot|0|UINT32|0x00000018 gRaspberryPiTokenSpaceGuid.PcdOptDeviceTree|1|UINT32|0x0000001B gRaspberryPiTokenSpaceGuid.PcdRamMoreThan3GB|0|UINT32|0x00000019 --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55691): https://edk2.groups.io/g/devel/message/55691 Mute This Topic: https://groups.io/mt/71835504/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-