[edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings

Pete Batard posted 2 patches 4 years ago
Failed in applying to current master (apply log)
Platform/RaspberryPi/AcpiTables/AcpiTables.inf          | 3 +++
Platform/RaspberryPi/AcpiTables/Xhci.asl                | 1 -
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 ------
Platform/RaspberryPi/RPi3/RPi3.dsc                      | 2 +-
Platform/RaspberryPi/RPi4/RPi4.dsc                      | 2 +-
Platform/RaspberryPi/RaspberryPi.dec                    | 2 +-
6 files changed, 6 insertions(+), 10 deletions(-)
[edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings
Posted by Pete Batard 4 years ago
This addresses the following warnings, that are generated during
compilation of the RPi firmware:

------------------------------------------------------------------

/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    165:       })
Warning  3150 -                                                            Empty Resource Template (END_TAG only) ^

/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    173:       Name (_GPI, Buffer()
Warning  3133 -                                                                                      Unknown reserved name ^  (_GPI)

/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    189:       Name (_GCI, Buffer()
Warning  3133 -                                                                                      Unknown reserved name ^  (_GCI)

/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    218:       Name (_GDI, Buffer()
Warning  3133 -                                                                                      Unknown reserved name ^  (_GDI)

/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    354:                     Offset (0),
Remark   2158 -                                                                            Unnecessary/redundant use of Offset operator ^

------------------------------------------------------------------

VfrCompile...
/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(240): WARNING: default
        : default value re-defined with different value

VfrCompile...
/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(246): WARNING: default
        : default value re-defined with different value

VfrCompile...
/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(252): WARNING: default
        : default value re-defined with different value

VfrCompile...
/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(258): WARNING: default
        : default value re-defined with different value

VfrCompile...
/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(264): WARNING: default
        : default value re-defined with different value

VfrCompile...
/usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(270): WARNING: default
        : default value re-defined with different value

------------------------------------------------------------------

Pete Batard (2):
  Platform/RPi/AcpiTables: Fix ASL compilation warnings
  Platform/RPi/ConfigDxe: Fix a compilation warning

 Platform/RaspberryPi/AcpiTables/AcpiTables.inf          | 3 +++
 Platform/RaspberryPi/AcpiTables/Xhci.asl                | 1 -
 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 ------
 Platform/RaspberryPi/RPi3/RPi3.dsc                      | 2 +-
 Platform/RaspberryPi/RPi4/RPi4.dsc                      | 2 +-
 Platform/RaspberryPi/RaspberryPi.dec                    | 2 +-
 6 files changed, 6 insertions(+), 10 deletions(-)

-- 
2.21.0.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#55689): https://edk2.groups.io/g/devel/message/55689
Mute This Topic: https://groups.io/mt/71835502/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel][PATCH 0/2] Platform/RPi: Fix compilation warnings
Posted by Ard Biesheuvel 4 years ago
On Mon, 9 Mar 2020 at 15:21, Pete Batard <pete@akeo.ie> wrote:
>
> This addresses the following warnings, that are generated during
> compilation of the RPi firmware:
>

Thanks Pete

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 3daa70143953..79c06cfaeaee


> ------------------------------------------------------------------
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    165:       })
> Warning  3150 -                                                            Empty Resource Template (END_TAG only) ^
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    173:       Name (_GPI, Buffer()
> Warning  3133 -                                                                                      Unknown reserved name ^  (_GPI)
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    189:       Name (_GCI, Buffer()
> Warning  3133 -                                                                                      Unknown reserved name ^  (_GCI)
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    218:       Name (_GDI, Buffer()
> Warning  3133 -                                                                                      Unknown reserved name ^  (_GDI)
>
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/AcpiTables/AcpiTables/OUTPUT/./Dsdt.iiii    354:                     Offset (0),
> Remark   2158 -                                                                            Unnecessary/redundant use of Offset operator ^
>
> ------------------------------------------------------------------
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(240): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(246): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(252): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(258): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(264): WARNING: default
>         : default value re-defined with different value
>
> VfrCompile...
> /usr/src/Build/RPi4/DEBUG_GCC5/AARCH64/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe/OUTPUT/ConfigDxeHii.i(270): WARNING: default
>         : default value re-defined with different value
>
> ------------------------------------------------------------------
>
> Pete Batard (2):
>   Platform/RPi/AcpiTables: Fix ASL compilation warnings
>   Platform/RPi/ConfigDxe: Fix a compilation warning
>
>  Platform/RaspberryPi/AcpiTables/AcpiTables.inf          | 3 +++
>  Platform/RaspberryPi/AcpiTables/Xhci.asl                | 1 -
>  Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 ------
>  Platform/RaspberryPi/RPi3/RPi3.dsc                      | 2 +-
>  Platform/RaspberryPi/RPi4/RPi4.dsc                      | 2 +-
>  Platform/RaspberryPi/RaspberryPi.dec                    | 2 +-
>  6 files changed, 6 insertions(+), 10 deletions(-)
>
> --
> 2.21.0.windows.1
>

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#56264): https://edk2.groups.io/g/devel/message/56264
Mute This Topic: https://groups.io/mt/71835502/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-