ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 27 ++++++++++++++++++-- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 26 +++++++++++++++++-- OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ 4 files changed, 52 insertions(+), 4 deletions(-)
Repo: https://pagure.io/lersek/edk2.git Branch: timeout_var In the PlatformBootManagerLib instances, set the Timeout global variable to the same value as PcdPlatformBootTimeOut. This way the "setvar" command in the UEFI shell, and the "efibootmgr" command in a Linux guest, can report the front page timeout that was requested on the QEMU command line (see GetFrontPageTimeoutFromQemu() in "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). A DEBUG_VERBOSE message is logged on success too, for our QE team's sake. Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Jordan Justen <jordan.l.justen@intel.com> Cc: Leif Lindholm <leif@nuviainc.com> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> Thanks Laszlo Laszlo Ersek (2): OvmfPkg/PlatformBootManagerLib: sync Timeout with PcdPlatformBootTimeOut ArmVirtPkg/PlatformBootManagerLib: sync Timeout with PcdPlatformBootTimeOut ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 27 ++++++++++++++++++-- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 26 +++++++++++++++++-- OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ 4 files changed, 52 insertions(+), 4 deletions(-) -- 2.19.1.3.g30247aa5d201 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55379): https://edk2.groups.io/g/devel/message/55379 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek <lersek@redhat.com> wrote: > > Repo: https://pagure.io/lersek/edk2.git > Branch: timeout_var > > In the PlatformBootManagerLib instances, set the Timeout global variable > to the same value as PcdPlatformBootTimeOut. This way the "setvar" > command in the UEFI shell, and the "efibootmgr" command in a Linux > guest, can report the front page timeout that was requested on the QEMU > command line (see GetFrontPageTimeoutFromQemu() in > "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). > > A DEBUG_VERBOSE message is logged on success too, for our QE team's > sake. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > > Thanks > Laszlo > > Laszlo Ersek (2): > OvmfPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > ArmVirtPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > Provided that the use of the bare 'sizeof <identifier>' doesn't throw up any build errors with Clang (I seem to remember a report from Mike Kinney about this?) Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 27 ++++++++++++++++++-- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 26 +++++++++++++++++-- > OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ > 4 files changed, 52 insertions(+), 4 deletions(-) > > -- > 2.19.1.3.g30247aa5d201 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55396): https://edk2.groups.io/g/devel/message/55396 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 03/04/20 10:54, Ard Biesheuvel wrote: > On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek <lersek@redhat.com> wrote: >> >> Repo: https://pagure.io/lersek/edk2.git >> Branch: timeout_var >> >> In the PlatformBootManagerLib instances, set the Timeout global variable >> to the same value as PcdPlatformBootTimeOut. This way the "setvar" >> command in the UEFI shell, and the "efibootmgr" command in a Linux >> guest, can report the front page timeout that was requested on the QEMU >> command line (see GetFrontPageTimeoutFromQemu() in >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). >> >> A DEBUG_VERBOSE message is logged on success too, for our QE team's >> sake. >> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Cc: Jordan Justen <jordan.l.justen@intel.com> >> Cc: Leif Lindholm <leif@nuviainc.com> >> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> >> >> Thanks >> Laszlo >> >> Laszlo Ersek (2): >> OvmfPkg/PlatformBootManagerLib: sync Timeout with >> PcdPlatformBootTimeOut >> ArmVirtPkg/PlatformBootManagerLib: sync Timeout with >> PcdPlatformBootTimeOut >> > > Provided that the use of the bare 'sizeof <identifier>' doesn't throw > up any build errors with Clang (I seem to remember a report from Mike > Kinney about this?) > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> I use the "sizeof" operator exclusively without parens if the operand is not a type name, at least in packages that I co-maintain. I don't recall any particular build failures (even from the edk2 CI). Thanks! Laszlo > >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 27 ++++++++++++++++++-- >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + >> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 26 +++++++++++++++++-- >> OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ >> 4 files changed, 52 insertions(+), 4 deletions(-) >> >> -- >> 2.19.1.3.g30247aa5d201 >> > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55417): https://edk2.groups.io/g/devel/message/55417 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On Wed, 4 Mar 2020 at 15:51, Laszlo Ersek <lersek@redhat.com> wrote: > > On 03/04/20 10:54, Ard Biesheuvel wrote: > > On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek <lersek@redhat.com> wrote: > >> > >> Repo: https://pagure.io/lersek/edk2.git > >> Branch: timeout_var > >> > >> In the PlatformBootManagerLib instances, set the Timeout global variable > >> to the same value as PcdPlatformBootTimeOut. This way the "setvar" > >> command in the UEFI shell, and the "efibootmgr" command in a Linux > >> guest, can report the front page timeout that was requested on the QEMU > >> command line (see GetFrontPageTimeoutFromQemu() in > >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). > >> > >> A DEBUG_VERBOSE message is logged on success too, for our QE team's > >> sake. > >> > >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > >> Cc: Jordan Justen <jordan.l.justen@intel.com> > >> Cc: Leif Lindholm <leif@nuviainc.com> > >> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > >> > >> Thanks > >> Laszlo > >> > >> Laszlo Ersek (2): > >> OvmfPkg/PlatformBootManagerLib: sync Timeout with > >> PcdPlatformBootTimeOut > >> ArmVirtPkg/PlatformBootManagerLib: sync Timeout with > >> PcdPlatformBootTimeOut > >> > > > > Provided that the use of the bare 'sizeof <identifier>' doesn't throw > > up any build errors with Clang (I seem to remember a report from Mike > > Kinney about this?) > > > > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > I use the "sizeof" operator exclusively without parens if the operand is > not a type name, at least in packages that I co-maintain. I don't recall > any particular build failures (even from the edk2 CI). > OK fine. I don't remember the exact details, and I kind of like this notation as well, so ... :-) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55418): https://edk2.groups.io/g/devel/message/55418 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 3/4/20 10:44 AM, Laszlo Ersek wrote: > Repo: https://pagure.io/lersek/edk2.git > Branch: timeout_var > > In the PlatformBootManagerLib instances, set the Timeout global variable > to the same value as PcdPlatformBootTimeOut. This way the "setvar" > command in the UEFI shell, and the "efibootmgr" command in a Linux > guest, can report the front page timeout that was requested on the QEMU > command line (see GetFrontPageTimeoutFromQemu() in > "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). > > A DEBUG_VERBOSE message is logged on success too, for our QE team's > sake. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > > Thanks > Laszlo > > Laszlo Ersek (2): > OvmfPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > ArmVirtPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 27 ++++++++++++++++++-- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 26 +++++++++++++++++-- > OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ > 4 files changed, 52 insertions(+), 4 deletions(-) > Series: Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55419): https://edk2.groups.io/g/devel/message/55419 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 03/04/20 16:50, Philippe Mathieu-Daudé wrote: > On 3/4/20 10:44 AM, Laszlo Ersek wrote: >> Repo: https://pagure.io/lersek/edk2.git >> Branch: timeout_var >> >> In the PlatformBootManagerLib instances, set the Timeout global variable >> to the same value as PcdPlatformBootTimeOut. This way the "setvar" >> command in the UEFI shell, and the "efibootmgr" command in a Linux >> guest, can report the front page timeout that was requested on the QEMU >> command line (see GetFrontPageTimeoutFromQemu() in >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). >> >> A DEBUG_VERBOSE message is logged on success too, for our QE team's >> sake. >> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Cc: Jordan Justen <jordan.l.justen@intel.com> >> Cc: Leif Lindholm <leif@nuviainc.com> >> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> >> >> Thanks >> Laszlo >> >> Laszlo Ersek (2): >> OvmfPkg/PlatformBootManagerLib: sync Timeout with >> PcdPlatformBootTimeOut >> ArmVirtPkg/PlatformBootManagerLib: sync Timeout with >> PcdPlatformBootTimeOut >> >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> | 27 ++++++++++++++++++-- >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> | 1 + >> OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c >> | 26 +++++++++++++++++-- >> OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> | 2 ++ >> 4 files changed, 52 insertions(+), 4 deletions(-) >> > > Series: > Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com> > Thank you! I plan to push this tomorrow, with your R-b, and Ard's. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55429): https://edk2.groups.io/g/devel/message/55429 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
On 03/04/20 10:44, Laszlo Ersek wrote: > Repo: https://pagure.io/lersek/edk2.git > Branch: timeout_var > > In the PlatformBootManagerLib instances, set the Timeout global variable > to the same value as PcdPlatformBootTimeOut. This way the "setvar" > command in the UEFI shell, and the "efibootmgr" command in a Linux > guest, can report the front page timeout that was requested on the QEMU > command line (see GetFrontPageTimeoutFromQemu() in > "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c"). > > A DEBUG_VERBOSE message is logged on success too, for our QE team's > sake. > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Jordan Justen <jordan.l.justen@intel.com> > Cc: Leif Lindholm <leif@nuviainc.com> > Cc: Philippe Mathieu-Daudé <philmd@redhat.com> > > Thanks > Laszlo > > Laszlo Ersek (2): > OvmfPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > ArmVirtPkg/PlatformBootManagerLib: sync Timeout with > PcdPlatformBootTimeOut > > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 27 ++++++++++++++++++-- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 26 +++++++++++++++++-- > OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ > 4 files changed, 52 insertions(+), 4 deletions(-) > Merged as commit range 3b9cd714542a..7288ff4095cf, via <https://github.com/tianocore/edk2/pull/422>. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55486): https://edk2.groups.io/g/devel/message/55486 Mute This Topic: https://groups.io/mt/71722702/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=-=-=-=-=-=-=-=-=-=-=-
© 2016 - 2024 Red Hat, Inc.