From nobody Sun May 5 19:25:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55165+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1583145230514126.35792518625465; Mon, 2 Mar 2020 02:33:50 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id VsJCYY1788612xYHXa5NMDVV; Mon, 02 Mar 2020 02:33:49 -0800 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.12386.1583145228879747385 for ; Mon, 02 Mar 2020 02:33:49 -0800 X-Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022ANggE002564; Mon, 2 Mar 2020 10:33:48 GMT X-Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2ygxxb0v1p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 10:33:48 +0000 X-Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 43AD2A9; Mon, 2 Mar 2020 10:33:47 +0000 (UTC) X-Received: from G4W9335.americas.hpqcorp.net (16.208.33.85) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:38 +0000 X-Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G4W9335.americas.hpqcorp.net (16.208.33.85) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:17 +0000 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Mar 2020 10:33:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I6fBLTr+I83xbr6/HYwvHko9IzzL8VWHXT2Eyw1g9qz7GHadfJWze/rnIm4Yek/9yW8XWOSrAAEDIZAkP+0yxlnZyyApPeF2OLCRUUuQgB4Uir3oR0xv0/5DlvWEniQ6ASbWvKJFIbg34TIXPIfyUI5xwY502cEr/rpfT4Zp3Raya74G8EMzg7ImO4dEefQFKCVXQ3xbvjkEajw+1075aijJe8Y48eLwN54cQ8OZfrz4AIoG+W2IPxsBYwLRnE6skXqEBNPamWbA69xa9UeY2SRG5R8nwB4Q8MhGeZnwZJ7wPs4vRSGtP1/+t3dbDz1PlNJvkrXeGliRaG+Yp30fDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=De8v6jDFytgkn+g/lThrPP3GXUtiYyel/tin9WD9Trg=; b=a5deneD/MBS9LAmnOtqAkdh2+Fra0OB+t3sTcPjhx2PxOwD6h2die5VuPB4iNeZ8vXXVgv4t0bEnsYVbh0jxsku56l+Fyb36FgMdZMJSLdYtnhXrvTM8n7f1sKM4ctyIXfxYkFxy48Fs83z+Yo7GBLu9xmgG34E5M42B3x0citchok+3+8xf+p1h6OTsCWw4rPkYJbh2++ljit8RAGfyq8H29rTq6OOA+LYp3fIftEfu4fYvUdNztIPWdBI2/78cxTUalOsz7WQNtKm8yujEnhOJmnXZGW0yY1qi8y31ZUSml/lKYlKIvfquHXpOnCGLlTZBi0IJoAeRvnHxFcKGgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) by TU4PR8401MB1248.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 10:32:56 +0000 X-Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae]) by TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae%5]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 10:32:56 +0000 From: "Daniel Schaefer" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Eric Dong , Ray Ni , Hao A Wu , Dandan Bi , Liming Gao Subject: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: Restrict libraries using SMM to x86 Date: Mon, 2 Mar 2020 11:32:36 +0100 Message-ID: <20200302103238.25726-2-daniel.schaefer@hpe.com> In-Reply-To: <20200302103238.25726-1-daniel.schaefer@hpe.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) To TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from x360-nix.fritz.box (84.58.209.92) by FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15 via Frontend Transport; Mon, 2 Mar 2020 10:32:54 +0000 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 54eb5d71-7ce5-4b71-110a-08d7be95128a X-MS-TrafficTypeDiagnostic: TU4PR8401MB1248: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1051; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55165+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: Ka9n8hZhbVXva4Gb+nRKqCnaOIPtvyg6QwMYp8zTE5E/wuaHXmD5BfYLUrj4YXjNT53EJ4KHRgYYm2dKIrEOfE0iboDc5HmhiTA/Pb9IE+svCbfMXxx2mU0z2dWufiBKhcIm1gTXOfpn7wojcW+R4ZLK4+JNenHBsIMJE+QYLYOOeendxJWT/shrdsWTr6Ei9QJ02yrTGumpijFx6WEyJMSSRYj7lokCkAGl3jKbaHnfI7s3Dl2KyirFCUfGsDlGnXtWEAlcr/CDDOi7e3xBdgdLoDPLBSNbTIfDMDpP5UBSGBAXvFsCBZlKQRLsi5DHLnecbGjOQKcKQozR0jBQMYPgNVvFCr8h/8kXg0cokyn0cJElLJ79fyODq4beC4wH2f6H1TYgOiRD+xP9rZa+gbyuNArhunAoMEtqxpa6jZ0MV15f3bNzQH2d918RQMxjFP/cgXp4Loll35bMRpfOpPWr4Nw3E7/WCOGve7HUAZgxraP8GkxZzjp7NeoG375rlJuIzI5WAA6dY6UDWIN8FA== X-MS-Exchange-AntiSpam-MessageData: f4rfHaLGDSLQh1s0D+H9BBEdSCqnC9v7l2xbjq5CYp59/UGtbfRonsEwasdiJ+7bBxNwkNK/8mzfWLnQU1DBmRacSKd2PFTWQBGhR2KIZ3Hn7iNm9SyMNe4kvnYEK2crWlzs764bQJAg7muLIcXprg== X-MS-Exchange-CrossTenant-Network-Message-Id: 54eb5d71-7ce5-4b71-110a-08d7be95128a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 10:32:56.8576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P8nnbp6v8Xunr2AplCByQCi1WMlsjsUxgAJteK5EOF2QaCv+ohPyQyDbSF8SLb28F1votMxppboBE0G5xBBglA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1248 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: TwlOPZgkk48L188Fzcnulu3yx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1583145229; bh=JqLObauzTkW7BdZF4HXmP7PMdkg2jfEpQiuV11ITnpY=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=BGiW8QfbSyGks1B1GAdo1nzRPbUuUj7yx8yUSwB2PDSCW5RcaWvWitq5p2ngdEHDJHC xEhF8P5ZcuMQSYbPJRVzh5NP2ku/8wXZU3xgt/dUbf+PHQNI8nhlCqHY26o5IJA4aV9uU jVVKao0PWqZa3t4b60iCLRtmnt4qW7ZtU5M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The modules: MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerfo= rmanceDxe.inf seem like they are independent of SMM but they actually do requires SMM's LockBoxLib. Ideally they would be rewritten to not require SMM on non x86. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2549 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Eric Dong Cc: Ray Ni Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- Notes: v2: - Fix IA86 -> IA32 [Mike] MdeModulePkg/MdeModulePkg.dsc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index f7dbb27ce25d..5a20722a4270 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -109,6 +109,8 @@ [LibraryClasses.common.PEIM] HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExt= ractGuidedSectionLib.inf + +[LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf =20 [LibraryClasses.common.DXE_CORE] @@ -228,7 +230,6 @@ [Components] MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/IncompatiblePciDevi= ceSupportDxe.inf MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf MdeModulePkg/Bus/Pci/SdMmcPciHcPei/SdMmcPciHcPei.inf MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcBlockIoPei.inf @@ -251,7 +252,6 @@ [Components] MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf - MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf @@ -395,7 +395,6 @@ [Components] LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf } - MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsRes= ourceTableDxe.inf MdeModulePkg/Universal/SectionExtractionDxe/SectionExtractionDxe.inf { @@ -447,6 +446,8 @@ [Components.IA32, Components.X64, Components.ARM, Compo= nents.AARCH64] [Components.IA32, Components.X64] MdeModulePkg/Universal/DebugSupportDxe/DebugSupportDxe.inf MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf + MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf + MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { @@ -478,6 +479,7 @@ [Components.IA32, Components.X64] MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaArchCustomDecompressLib= .inf MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.= inf + MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerf= ormanceSmm.inf @@ -487,6 +489,7 @@ [Components.IA32, Components.X64] MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferD= xe.inf MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf =20 + [Components.X64] MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf =20 --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55165): https://edk2.groups.io/g/devel/message/55165 Mute This Topic: https://groups.io/mt/71671275/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 19:25:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55163+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1583145201424393.5635876101543; Mon, 2 Mar 2020 02:33:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id U59MYY1788612xhHQDzTExhU; Mon, 02 Mar 2020 02:33:20 -0800 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web12.12214.1583145199661878048 for ; Mon, 02 Mar 2020 02:33:19 -0800 X-Received: from pps.filterd (m0134424.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022ARMje030641; Mon, 2 Mar 2020 10:33:19 GMT X-Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2ygy0vrwwr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 10:33:18 +0000 X-Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id 49FB388; Mon, 2 Mar 2020 10:33:18 +0000 (UTC) X-Received: from G4W9336.americas.hpqcorp.net (16.208.33.86) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:18 +0000 X-Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G4W9336.americas.hpqcorp.net (16.208.33.86) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:17 +0000 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Mar 2020 10:33:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Atg0zEuFgHbENVEENZfd7O1IOJxo9UgFFENlUKzVxPpOAeEysbZRE2+XJndO4K50HbAk90OM+fzttpYEshZkQjKBaJJZkjqVa/LxASIZvVK5Ocd+HIT3bkj7rc+ETW2hbMDYmKU1G0t5XGNobhtVFCZZULZ4hSOYFda469JdK82gBw+R9jBZBc2642eKw0GT1uxa7F2uBBLKCQY3HCAc+DTlYXI+6P3xCI0J+WN5JF6bydxdgKU73e8jHrAOvJFpEh2W1SpXiKTxl0T2TKuth8Bf/iL6cdEEz0+ID+vCi3i8F1ysNgon2HvJsQW6prDgP/0Bui1BXEPuwIyrbbDkgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzII3FsO1Kj0aOwXxVIkvnyLF2qBqVrQlXidHb/PiLk=; b=E+drqXSrk7Uz8bfWnypMj6XcOlmU2ZUkrEVi3RUm96OnseWx1qUfGkKZ4XeC8vcAN6xf+1quoQf2sh04+GoQ3/Rx5IiElMZ3Q2tzlTPDT38HtZBdr1oDcLtXjbkABgJtI4Ny5HF1479Y5yyGq+rAoU3aWDaUHbz9Z4a8mfnmV1IDnUs7x6pNdiAE0bD+nB0yoW5JC2QSxXhgEA/SVBNDV+gQWs/Tshc628QC7kYiFemsHS7MuOZYzae1+orAPzXmq42Eiq3XhcsBxazg+caaBm2Uh71dHPWFwFmJN8fdd3qKFMKQlfR2SW0U1rncUP/aKJO53k9plw9jq5/wIpQetg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) by TU4PR8401MB1248.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 10:32:59 +0000 X-Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae]) by TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae%5]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 10:32:58 +0000 From: "Daniel Schaefer" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Dandan Bi , "Liming Gao" Subject: [edk2-devel] [PATCH v2 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Date: Mon, 2 Mar 2020 11:32:37 +0100 Message-ID: <20200302103238.25726-3-daniel.schaefer@hpe.com> In-Reply-To: <20200302103238.25726-1-daniel.schaefer@hpe.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) To TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from x360-nix.fritz.box (84.58.209.92) by FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15 via Frontend Transport; Mon, 2 Mar 2020 10:32:57 +0000 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: d5d8f894-1b0c-48a2-07db-08d7be9513a1 X-MS-TrafficTypeDiagnostic: TU4PR8401MB1248: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55163+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: OVaUcYA42v4XXW//VjTWVVVcgvHaPq5vS2GDhg/Flqpfqy7uz/PlRcKuZtCNDlYiOcXvH11lwm9paDPVyYoe3XONd+ywZnsCb5xA41DTUZVdeYnkDNF0m0rgvD/rd7telCaK/O8FkWNRx+O2Iak453GHtR06HDwt3bsiqneF+dTTrUYPvi31E1GMmIdtzHeEGDFtE2mu1jDf+C/L7SQD1FFcOQlU7EXggvGbJtBvkL5/8ecXqiQMbTlP8defXuA2ze6i/javjPpNlizdVpoDel4abeuXJkPGtYz5fDUqvfHZkgf1O87GPMwnrCr8D7Rlc818HPXWSbfE73HlFIkBpj+Gr38zL89iaw3d8Vy9gmRrobP8QQBtCS+pK+BlMhAkHxbO7a5S8r8x5ZVfHRVhCgi01TeNSZ/k3mSUX/hAgzDjYsuDR7+inpH2gD9suOSbEeCv8tuvDv0YX3LvZux3hctqK57n3D9PWSQkErKKwJsst8VXe1kKagj/DfZIhUoBx5JH9OXW+J+DNLOC4h4q4A== X-MS-Exchange-AntiSpam-MessageData: SgXXiCguFfdxxzi/bS1nQ5TZ4wzviQtpAFhuy86/tfxONVaVijGk4lUWECr5K4cR+Ia4ZXi5cDoU0oaXrbTMcWvqtrjYWjbNnJeaPG43A5le43fEoiaa2IDH4eJ8not0ihVxcWizC2H/bWrmb6RCOQ== X-MS-Exchange-CrossTenant-Network-Message-Id: d5d8f894-1b0c-48a2-07db-08d7be9513a1 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 10:32:58.8228 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 51BtVtTFkYseSWNnXQOU0DvJyT9hiIny6RYxr90zqOpWKai0H0W+fZGgUXo1oDU0GBJRGBXnvgKERs29sPDapA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1248 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: 61znNZdvmJbRD8SGqekMJcVvx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1583145200; bh=5uKdLT7tymlYNTcf+FyGthvBffXINWYLsQsQ9qiRNt0=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Yct3HFIGDzgOya5B7K4xavQ1u0wX8//QSfY1p2a93c8VQSuPp5k6dR0oZwDSpS28L2N WTLirXh3h+zG/1JSJZSzLYkjC2ngsZk2vwgw+0Pt3vNlasEpPCB1arexmqxUth5s9L6Ts JWz/HahPfufrBSmEV3u1NMIig+wSA2pdntU= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Otherwise the PCD isn't defined on other architectures. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2548 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..59645c860148 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -879,6 +879,9 @@ [PcdsFeatureFlag] [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|B= OOLEAN|0x0001003a =20 +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] + gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE|BOOLEAN|0= x0001003b + [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] ## Indicates if DxeIpl should switch to long mode to enter DXE phase. # It is assumed that 64-bit DxeCore is built in firmware if it is true;= otherwise 32-bit DxeCore --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55163): https://edk2.groups.io/g/devel/message/55163 Mute This Topic: https://groups.io/mt/71671269/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 5 19:25:33 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55164+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1583145201534747.6102980274449; Mon, 2 Mar 2020 02:33:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id a7azYY1788612xaMdLnEr9cV; Mon, 02 Mar 2020 02:33:20 -0800 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.12379.1583145200030689468 for ; Mon, 02 Mar 2020 02:33:20 -0800 X-Received: from pps.filterd (m0150242.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 022AWKjC007530; Mon, 2 Mar 2020 10:33:19 GMT X-Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0a-002e3701.pphosted.com with ESMTP id 2yg1ve05j5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 02 Mar 2020 10:33:19 +0000 X-Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3427.houston.hpe.com (Postfix) with ESMTPS id A9A5272; Mon, 2 Mar 2020 10:33:18 +0000 (UTC) X-Received: from G9W8672.americas.hpqcorp.net (16.220.49.31) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:18 +0000 X-Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G9W8672.americas.hpqcorp.net (16.220.49.31) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 2 Mar 2020 10:33:18 +0000 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (15.241.52.10) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 2 Mar 2020 10:33:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UijHh4kYkkybt0jmNtPjW7IgpSOUHW/PtMq0obF8cJyrfJP3WHH7KZyGnS2mv/nh/i7BRCYe7nDPy73UP8rGLcgCQioAmUhK7SNIPf6YYD241IqNGFpCZR8nH/V8xXfh+E5Co8twk95jdHChvE5HDvNPWumCYt2wf4En/l62PyrdYu2I4c4H4aDl6E8qAQSE+EcttV+/FbRcBAtBwrLfqHbsmjO+rlrduOD4FhUsVniA4h8Od9whQo8W3qV2ssCDdmtUQp5fqk2laMaAp498SejApewBO+G7biXU78yf+PiPASvQjXSNo+FrbM51jyD+glgB0/4Qw0Qg52clTO3M2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e2pdHMtQYCdkInKco+68LpyKYYKQVvQMWPj9rn5sdZM=; b=Dhee3FyLiyKkGgx1AkgKVMxjh51LFLVx8I1kem4gyQy/OlPFEMntTmDlVk+W8WgoA7btPm7vXtmMG0a72xvy83vEl/hIDXH8nHNMKOCxJlu+V+F+3iU1+oLgzkNhM5659utGRyT5Hw4XL3b+LlUuXjy3931MqcepX394rGcF7KjdVrx3/BS496LGGbnTugdDP9eqE5ebLFPSS396qIaXqn8g5yyEK9EsC4ZZ0fL2JfBgj/t7IlA7sr/3g4UuwMyU7CYpG7vVC5FN9HqKeWehc865O1twIqiHw6LmTlqNlW+0QxUYfKY8tZ3TsmhoLAgKGfHhdAGVX6ooe7lZzXJIiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) by TU4PR8401MB1248.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7715::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.18; Mon, 2 Mar 2020 10:33:01 +0000 X-Received: from TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae]) by TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM ([fe80::a138:305f:61e2:16ae%5]) with mapi id 15.20.2772.019; Mon, 2 Mar 2020 10:33:00 +0000 From: "Daniel Schaefer" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Dandan Bi , Eric Dong Subject: [edk2-devel] [PATCH v2 3/3] MdeModulePkg: Use CopyMem instead of GUID assignment Date: Mon, 2 Mar 2020 11:32:38 +0100 Message-ID: <20200302103238.25726-4-daniel.schaefer@hpe.com> In-Reply-To: <20200302103238.25726-1-daniel.schaefer@hpe.com> References: <20200302103238.25726-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) To TU4PR8401MB0909.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7710::14) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from x360-nix.fritz.box (84.58.209.92) by FR2P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15 via Frontend Transport; Mon, 2 Mar 2020 10:32:59 +0000 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 495a85e0-331e-4a30-3a81-08d7be9514d2 X-MS-TrafficTypeDiagnostic: TU4PR8401MB1248: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:393; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55164+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: nTxo4BdPU/6pNv2u745ju7e3cQGhJPfH0iZrFyKoG2NMWw5IEHa2caWT8kARuoJi9p5CoCbluZ0MTUuUkUhSWR+rqkseXFvahPdJfx3SmGz0y523HV34snD4dNJ4R/RdPa+zGPvAW6wpxhsFM6eKZlD1lORRv6Iuzq77Y0OIG/ufU5mr2nCibvGfLUI7PYKYi8VbaVrjHewL1vOaZbtNhDsNx1mbntoLKEgRqO8HRIN15LBiusutAbNDF2KSNCqRHTQcyHos0HDxpmYKaKomJdifHUkTovWnHqmGqgCOHyHEvxTNVvY2EGNx9C8bOZR/6yvrFuasFHD7mH0dzqPRWKw+Zm18NftcyGbeWHn7qQpVMQbIj2i3oaeHk5GP0ZH/UmloBiOeWKgU76aw/P4xSemLsrnPaEtHYSHs7NHW1HY06I4LTk07xd0Fbtf/oHZ2uESL8FDjfJLVOm84nB8wM+GvyxVvthNQrRYnNKTypwVcW5fUCPITuI5B+QIMzNCUPQykIwaH+EWkTnC7PzWkOA== X-MS-Exchange-AntiSpam-MessageData: xZ7e9pkNcefooTqH4xfXCPfKiHLn9vbQZDGBW0pLFn6+l11X5SPijkjNaEult2ZvYJ1LofcN1/YJhBuPVDIygFZiVquMA5yoM4FPOjjF6xt1HS4X2NjRjocoXaOJ79lKuiN5uGYXVyzoO419tD1GPw== X-MS-Exchange-CrossTenant-Network-Message-Id: 495a85e0-331e-4a30-3a81-08d7be9514d2 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2020 10:33:00.8149 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UcpCY2LpVVR5FsfgjYOVXsOXPMnQrx0XLZ1wTgzJ+yCOKFLlNWkWv06pAUkCjI+9rdALpy7KjQ3wWqgec4UaSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TU4PR8401MB1248 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: LGQGRFbINQHUJWqWwkxqo6Mkx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1583145200; bh=ou+j9BzpzKUTIyE17otHGfuGcfwFr/IMz9uo4GQqnxM=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=SI5zr5dh4wNl9NBFo14NrovVCxsqU0Ln7llArDdVmo+iYkHghbxtENW6+lAQ09n9FJO aZU0MOpy3w72oqf6JbxyKyrv2jJTwxtjJE7kaEhD4S65RL4jcTpAkbFUk1bKGQvN19K8g Yb917G+Rc+xDW2jwcPAeS4NwUUmAdLE51kE= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" GCC translates a simple assignment to memcpy, which EDKII doesn't provide. See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.html REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2547 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Dandan Bi Cc: Eric Dong Reviewed-by: Dandan Bi --- Notes: v2: - Use CopyMem instead of CopyGuid [Dandan] MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c b/MdeM= odulePkg/Library/DeviceManagerUiLib/DeviceManager.c index 5cc527679a78..0540e6fa8a44 100644 --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c @@ -619,7 +619,7 @@ CreateDeviceManagerForm( TokenHelp =3D HiiSetString (HiiHandle, 0, String, NULL); FreePool (String); =20 - FormSetGuid =3D ((EFI_IFR_FORM_SET *)Ptr)->Guid; + CopyMem (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid, sizeof (= EFI_GUID)); =20 // // Network device process --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55164): https://edk2.groups.io/g/devel/message/55164 Mute This Topic: https://groups.io/mt/71671270/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-