From nobody Sun Feb 8 22:00:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55064+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55064+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1582886353; cv=none; d=zohomail.com; s=zohoarc; b=A+WUqwNPr/larqP5CQ4gTGrqcfN98yX4CgoqiXyuZGshcdXOcAq3vbX4MH0hkwuJt+IiP6INIcCA7FnVXjz2y3D9eVQpjNrJ9bBJCNiRaLfocO6C8OTIxoXvnH79pNpnzjuheFOSkpO+U2GSYNPn9wPs5RMtg96UOk6nNZGiKU4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582886353; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=YRKY6lWEKkLO4JVXXEDGx4gl0/pAJo2WUX0lfEzvUVQ=; b=HyxabTS7/HpEIUvkdDIOK/XsRd1XpdKyIx7/64nKFi7ospQuIrdjkTTeQkJ0FDE6z2PoG2MClbQ61AjwEh+ignOtLO8L+zV5VL79OYTINQX7zHRwL3+Gz/XeluxmJpbj+kkb0+JzAyHFbrDvEl5KgFCK1g0YXv12oSeu9ew8B2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55064+1787277+3901457@groups.io Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582886353125308.52924484142886; Fri, 28 Feb 2020 02:39:13 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id LUF8YY1788612xvi6yUhNAUR; Fri, 28 Feb 2020 02:39:12 -0800 X-Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web12.12399.1582886350506768789 for ; Fri, 28 Feb 2020 02:39:11 -0800 X-Received: by mail-wm1-f65.google.com with SMTP id c84so2610900wme.4 for ; Fri, 28 Feb 2020 02:39:10 -0800 (PST) X-Gm-Message-State: vqjd6l9flF1F8k3X6o3eDNIgx1787277AA= X-Google-Smtp-Source: APXvYqyH2p/ZuvZhMwudi9118SXVMIysf0RflgmS2DFdmkTz0QVZgA5Ui8bF5ae3KAtvZsNpnaZ56w== X-Received: by 2002:a1c:208a:: with SMTP id g132mr3958823wmg.143.1582886348768; Fri, 28 Feb 2020 02:39:08 -0800 (PST) X-Received: from localhost.localdomain ([84.203.56.244]) by smtp.gmail.com with ESMTPSA id s8sm12341061wrt.57.2020.02.28.02.39.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Feb 2020 02:39:08 -0800 (PST) From: "Pete Batard" To: devel@edk2.groups.io Cc: ard.biesheuvel@linaro.org, leif@nuviainc.com, philmd@redhat.com Subject: [edk2-devel] [edk2-platforms][PATCH 01/15] Platform/RPi: Move DW USB base address to Silicon Date: Fri, 28 Feb 2020 10:38:41 +0000 Message-Id: <20200228103855.11352-2-pete@akeo.ie> In-Reply-To: <20200228103855.11352-1-pete@akeo.ie> References: <20200228103855.11352-1-pete@akeo.ie> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pete@akeo.ie Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582886352; bh=GbYG62v0CERgqYrr6VGLUYFr8TuCtnhLFRTTb0r/ISg=; h=Cc:Date:From:Reply-To:Subject:To; b=JV4hNog81G+fsrI0AT83k5xkCYGnBIXsTQHWHCaP17J24SQwmq0ZgFduEpMbIanQ0nR Q6bihFSuZU5MtaIkYJ3Ia+7P56lUCLntIDQ3bL3yj/PeG69BwEDttdB63YWXZtVwbnceQ fnBuyliOkH45kWUQEQFDowsSM2lw8fA7RVM= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The official BCM2835 ARM Peripherals guide lists the DW USB controller as standard SoC device. Treat is as such by adding its base address to Silicon. Signed-off-by: Pete Batard Reviewed-by: Philippe Mathieu-Daude --- Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.c | 3 ++- Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h | 6 +----- Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h | 5 +++++ 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.c b/Pla= tform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.c index 37ebf503fd60..4f6f60b1eb5f 100644 --- a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.c +++ b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.c @@ -7,6 +7,7 @@ * **/ =20 +#include #include "DwUsbHostDxe.h" #include "DwcHw.h" =20 @@ -1548,7 +1549,7 @@ CreateDwUsbHc ( DwHc->DwUsbOtgHc.ClearRootHubPortFeature =3D DwHcClearRootHubPort= Feature; DwHc->DwUsbOtgHc.MajorRevision =3D 0x02; DwHc->DwUsbOtgHc.MinorRevision =3D 0x00; - DwHc->DwUsbBase =3D DW2_USB_BASE_ADDRESS; + DwHc->DwUsbBase =3D BCM2836_USB_BASE_ADD= RESS; =20 Pages =3D EFI_SIZE_TO_PAGES (DWC2_STATUS_BUF_SIZE); DwHc->StatusBuffer =3D AllocatePages (Pages); diff --git a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h b/Platform/R= aspberryPi/Drivers/DwUsbHostDxe/DwcHw.h index ddbf69a1d608..12fbde9ff6f2 100644 --- a/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h +++ b/Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h @@ -10,11 +10,7 @@ #ifndef __DWCHW_H__ #define __DWCHW_H__ =20 -#define DW2_USB_OFFSET 0x00980000 -#define DW2_USB_BASE_ADDRESS (FixedPcdGet64 (PcdBcm283xRegister= sAddress) \ - + DW2_USB_OFFSET) - -#define HSOTG_REG(x) (x) +#define HSOTG_REG(x) (x) =20 #define HCCHAR(_ch) HSOTG_REG(0x0500 + 0x20 * (_ch)) #define HCSPLT(_ch) HSOTG_REG(0x0504 + 0x20 * (_ch)) diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h b/= Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h index 7ba4877337a8..cee5fb6a4e15 100644 --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836.h @@ -70,6 +70,11 @@ #define BCM2836_INTC_TIMER_CONTROL_OFFSET 0x00000040 #define BCM2836_INTC_TIMER_PENDING_OFFSET 0x00000060 =20 +/* usb constants */ +#define BCM2836_USB_OFFSET 0x00980000 +#define BCM2836_USB_BASE_ADDRESS (BCM2836_SOC_R= EGISTERS + BCM2836_USB_OFFSET) +#define BCM2836_USB_LENGTH 0x00010000 + /* uart constants */ #define BCM2836_PL011_UART_OFFSET 0x00201000 #define BCM2836_PL011_UART_BASE_ADDRESS (BCM2836_SOC_R= EGISTERS + BCM2836_PL011_UART_OFFSET) --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55064): https://edk2.groups.io/g/devel/message/55064 Mute This Topic: https://groups.io/mt/71605839/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-