From nobody Sat May 4 13:30:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+55003+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55003+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1582813538; cv=none; d=zohomail.com; s=zohoarc; b=LVul0zwYZgZr5Sfgt6u1zkNiQt9RbBeA+6FTmWVNUzGYwOat+BUwvKb3m7MNF22H5515hnPImBAP2hAl+AmS5HuPBY2s47MNljemIpBy6LnxWQ/L8CcpfrX6mwbnRQ8vER5GhTbNyORYPh0Ec7aDABGS9oYKkeHD7H7/vYysTTc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582813538; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=UzlnKV7K67ng/rPnZl9TpWqMlAoykFtfU8YARt65T6o=; b=QDxcomSVI56LBLyCv12ihp21APj3aYmxSLENkZq95SgI8ISKQy1ULPbmkD3xa5DA61rPyWmZQ2nHw6d/Ls7sFjDuC1/wqYUGMbKIs+0qxGj54cK0NZ982ppAsqXKG4EahJqqPhvakTSRvcsuPnyO9x+0TTcOn4cSVX/ZnLKdXMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+55003+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582813538720892.8904372736098; Thu, 27 Feb 2020 06:25:38 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id sg9MYY1788612xIsZzjRBeZj; Thu, 27 Feb 2020 06:25:37 -0800 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.4626.1582813537368438565 for ; Thu, 27 Feb 2020 06:25:37 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 06:25:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,492,1574150400"; d="scan'208";a="350693603" X-Received: from shwdepsi1121.ccr.corp.intel.com ([10.239.158.66]) by fmsmga001.fm.intel.com with ESMTP; 27 Feb 2020 06:25:35 -0800 From: "Bob Feng" To: devel@edk2.groups.io Cc: Andrew Fish , Laszlo Ersek , Leif Lindholm , Michael D Kinney , Pierre Gondois Subject: [edk2-devel] [Patch] BaseTools: Remove invalid leading space before !INCLUDE in Makefile Date: Thu, 27 Feb 2020 22:25:24 +0800 Message-Id: <20200227142524.24504-1-bob.c.feng@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,bob.c.feng@intel.com X-Gm-Message-State: AYwzfGS6bzAoswvSANLMlN0gx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582813537; bh=y1HJf+Tmajf0qp6eGTxIOAD11ZS8+4tHCTuFnLKGT5I=; h=Cc:Date:From:Reply-To:Subject:To; b=h6QNLm3XQ72MjK6AAHq1mFWgC8OXP6OK5I0NvgBH75xSM2dATE4J074J4I96Cfi9igf SWRTOT1d0JInxUCiAjhRtEzAP5z7nuWgrwNvrDbSg8/kOwrsx/tamvCmmSb524dk2fRtO AjgB2K3u3QFIhy/3PleeLUWFcZxr2ueTawg= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2563 This patch is to fix a incremental build regression bug which happen when using nmake. That's introduced by 818283de3f6d. If there is white space before !INCLUDE instruction, nmake will not process it. Source code's dependent header files are listed in ${deps_file} file, if it's not included successfully, nmake will not detect the change of those header file. This patch has been verified in Windows with VS2015 and Linux with GCC5. The header file add/modify/delete can trig the incremental build with this = fix. There is no impact on the clean build. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Cc: Pierre Gondois Signed-off-by: Bob Feng Acked-by: Laszlo Ersek Reviewed-by: Liming Gao Tested-by: Liming Gao