[edk2-devel] [PATCH 0/3] ArmPkg/ArmLib: ASSERT() on misuse of set/way ops

Ard Biesheuvel posted 3 patches 4 years, 1 month ago
Failed in applying to current master (apply log)
ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 16 ++++++++++++----
ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c       | 17 +++++++++++++----
ArmPkg/Library/ArmLib/ArmBaseLib.inf       |  6 +++---
ArmPkg/Library/ArmLib/ArmLib.c             |  2 --
4 files changed, 28 insertions(+), 13 deletions(-)
[edk2-devel] [PATCH 0/3] ArmPkg/ArmLib: ASSERT() on misuse of set/way ops
Posted by Ard Biesheuvel 4 years, 1 month ago
Talking to Leif on IRC, we decided that deprecating cache maintenance
by set/way, as I proposed in the series I just sent out [0] may be too
strict, especially considering that some v7 based uniprocessor platforms
such as BeagleBoard may actually need it to clean any junk from the caches
before turning them on.

So instead, ensure that this use cache remains supported, but discourage/
prevent misuse by ASSERT()ing that they are only used with the MMU off.

[0] https://edk2.groups.io/g/devel/topic/patch_0_6_armpkg_eradicate/71562844

Ard Biesheuvel (3):
  ArmPkg/ArmLib: clean up library includes
  ArmPkg/ArmLib: remove bogus protocol declaration
  ArmPkg/ArmLib: ASSERT on set/way cache ops being used with MMU on

 ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 16 ++++++++++++----
 ArmPkg/Library/ArmLib/Arm/ArmV7Lib.c       | 17 +++++++++++++----
 ArmPkg/Library/ArmLib/ArmBaseLib.inf       |  6 +++---
 ArmPkg/Library/ArmLib/ArmLib.c             |  2 --
 4 files changed, 28 insertions(+), 13 deletions(-)

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#54881): https://edk2.groups.io/g/devel/message/54881
Mute This Topic: https://groups.io/mt/71564918/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-