From nobody Tue Nov 26 08:38:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54730+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582390851707672.7820793306364; Sat, 22 Feb 2020 09:00:51 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id Ppb5YY1788612xe5WkdE5jZH; Sat, 22 Feb 2020 09:00:51 -0800 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.78.1582390850189747380 for ; Sat, 22 Feb 2020 09:00:50 -0800 X-Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01MGw2hk005153; Sat, 22 Feb 2020 17:00:50 GMT X-Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0b-002e3701.pphosted.com with ESMTP id 2yasp6be48-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 22 Feb 2020 17:00:49 +0000 X-Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id E86F16B; Sat, 22 Feb 2020 17:00:48 +0000 (UTC) X-Received: from G4W9335.americas.hpqcorp.net (16.208.33.85) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 22 Feb 2020 16:59:57 +0000 X-Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G4W9335.americas.hpqcorp.net (2002:10d0:2155::10d0:2155) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 22 Feb 2020 16:59:57 +0000 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 22 Feb 2020 16:59:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CnYDgY7t0vYpFmfkOBiP6zT+Wyv057lUW8cEWxhX8/arZJ4icyUzDxBb+FBonFf0dATgsentH3a8wEZmp2I7hIbbv+OcGxdHIPQljT4HWLceSZ/BHJNWmrDrxO92xEQPWIcXN4JNXIYRpkCyC0Pn+z9QF8ds+UfEwhErMsJ3L0g1Zz/cLURmaTEcs963TYo0AUM/gi4bksk/m/eu3kHkYue/4URMx06HmapXuR0QHE9BVbFKcjGCmkhALGj0xfHiQjKp+ywcoCDTjVupWSnve1tjIltqe9JrYMRFnB/hd6OEaJoMmsHqxqMv8idKQMMvA6y3ySvU2eyMiqQN5/sZFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FCUKmB8EHwI4G2IsbzsA6sw52eVTFyUlxO8WCXDn4mI=; b=hC2mAmtpi8G9H5rmY+rQ3ZPfJrKzdKyGiN4bUE0lbZ/yA12a9o92sGrFKDGkou9uEaY4mo/z2lNNfu5Ka8ht8xfDEtC+6Zvpi7Ym9qWyu9Q1ZfzUC9MiSmpVuphioMfGZYZsGQXe5w++xPbeKYjnRbkr+5Wh20Dr4ZynxXCLlw6SgnFaB8+gGo7BrMKLjVzZwqyyk3NjYuRWVe/4h0p2ZB7K14UCLYw404S+6ZzWZ4Ua0Tz11ETWmLOyN2Qx6qsPQRg/rYz1a8MlkxYgr+m+45LDoxZqAdPXxwPdCkYJHKFETbmBd/9aSXPjunidwUD+eTGnVn91t/WqWjgWV7Wqdw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::13) by DF4PR8401MB0764.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Sat, 22 Feb 2020 16:59:53 +0000 X-Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b801:ced5:4070:1d8a]) by DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b801:ced5:4070:1d8a%2]) with mapi id 15.20.2750.021; Sat, 22 Feb 2020 16:59:53 +0000 From: "Schaefer, Daniel Helmut (DualStudy)" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Eric Dong , Ray Ni , Hao A Wu , Dandan Bi , Liming Gao Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Restrict libraries using SMM to x86 Date: Sat, 22 Feb 2020 17:59:16 +0100 Message-ID: <20200222165918.20834-2-daniel.schaefer@hpe.com> In-Reply-To: <20200222165918.20834-1-daniel.schaefer@hpe.com> References: <20200222165918.20834-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) To DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::13) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from x360-nix.fritz.box (84.58.209.92) by ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18 via Frontend Transport; Sat, 22 Feb 2020 16:59:51 +0000 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: bc43550f-d1ba-4456-0f56-08d7b7b8a30a X-MS-TrafficTypeDiagnostic: DF4PR8401MB0764: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1051; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54730+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: wTW2TX3HGyD17SWNaRNhcQ5tw8S/1sfFteEUmp2LUoLEPY96AAjMTN16wEkelKAuzwjdbLk/2OWT0d4TcsNL8MCFq56STI+vMON53Ks2DLfLR/NFQNIf1wAkDK439eMbCD1kSjzdmRZjXx1F5yo0VFUJXEskeqoIZIn6WbBsZaKM9v/86Iw5iWHSDeORLM58Nw2vaIrZ8aa184Nsr8PRFGWimkWuFWvkqT203fgUufS5DAKyQzTNJEg2H/7+f/Reu68w8T0lOytzBJqoQKtxEn780wkCrNjb9lK7K6QhZdZnu1bomzsPlhOpvmaKikq5FV0j+ikmZ6YNJtiaZh1Sz95+rDYauUiaCW+Ot2Es2BvAiu3QTztoVpmd8STj95AZSJMWH18jsgtvkmE+67fsUs/Tweu5VeYGGPQNvRk4yAwdwA2CC6DMEdeXt4OYxgwizrzZTi5UvbW/UPQUhXWlxCG0RPuw/0nkhQkHej+gsQJ7bJU3tXPxsNAyHK83WykckcyHHJ6oznKZgrew1cjQVQ== X-MS-Exchange-AntiSpam-MessageData: 6d1SnIsZ03Ah7Qw5Gz97eRqPOoIVLZkAcAGq8hc4Z6OZrEoPVglFFHfSlscy7P6CkXl6BfNlUfjERwiNXCHH2NOqjuZ1ZQWQlSZMhk1/tFGa+aYircT2tcx9AINe1b2jYib4NMXImRgFLKrAuE+Fcg== X-MS-Exchange-CrossTenant-Network-Message-Id: bc43550f-d1ba-4456-0f56-08d7b7b8a30a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2020 16:59:53.5044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NsDopv4L11yWbpaFy6Q5yvuedNq2dUy6kESnFE2o89/fdUKo4rIiRHq4DdvxYijASl6gliwu1E8Rm+PIzuXW3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0764 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: x2YVHupmlspKkANHDH0eI4Cgx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582390851; bh=t5txurwFsNXR2SJ4aD8pja+JzuTfqUiKMPYeqvxsGQs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=Zo0HMYdQSmFd7KG+4juLwhpWet2F0W9IFwN5CRhpH8TpKKTEughJGJH7ytLiMkLYNAS vnZIusNdV3zN9WrKRhfEthnSHZtS3Ppr1anDut6HnT/WWEqmlfQD9n/CsTODW8YRQCkzN IVBYYPFW5UtiXVJVIhrMGf5+UhPcgASoCx4= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" The modules: MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerfo= rmanceDxe.inf seem like they are independent of SMM but they actually do requires SMM's LockBoxLib. Ideally they would be rewritten to not require SMM on non x86. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2549 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Eric Dong Cc: Ray Ni Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dsc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index f7dbb27ce25d..fc8c3976cca5 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -109,6 +109,8 @@ [LibraryClasses.common.PEIM] HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExt= ractGuidedSectionLib.inf + +[LibraryClasses.IA86.PEIM, LibraryClasses.X64.PEIM] LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf =20 [LibraryClasses.common.DXE_CORE] @@ -228,7 +230,6 @@ [Components] MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf MdeModulePkg/Bus/Pci/IncompatiblePciDeviceSupportDxe/IncompatiblePciDevi= ceSupportDxe.inf MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressDxe.inf - MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf MdeModulePkg/Bus/Pci/SdMmcPciHcPei/SdMmcPciHcPei.inf MdeModulePkg/Bus/Sd/EmmcBlockIoPei/EmmcBlockIoPei.inf @@ -251,7 +252,6 @@ [Components] MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf - MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf MdeModulePkg/Bus/Scsi/ScsiBusDxe/ScsiBusDxe.inf MdeModulePkg/Bus/Scsi/ScsiDiskDxe/ScsiDiskDxe.inf MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf @@ -395,7 +395,6 @@ [Components] LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf } - MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsRes= ourceTableDxe.inf MdeModulePkg/Universal/SectionExtractionDxe/SectionExtractionDxe.inf { @@ -447,6 +446,8 @@ [Components.IA32, Components.X64, Components.ARM, Compo= nents.AARCH64] [Components.IA32, Components.X64] MdeModulePkg/Universal/DebugSupportDxe/DebugSupportDxe.inf MdeModulePkg/Application/SmiHandlerProfileInfo/SmiHandlerProfileInfo.inf + MdeModulePkg/Bus/Ata/AhciPei/AhciPei.inf + MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.inf MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { @@ -478,6 +479,7 @@ [Components.IA32, Components.X64] MdeModulePkg/Library/SmmSmiHandlerProfileLib/SmmSmiHandlerProfileLib.inf MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaArchCustomDecompressLib= .inf MdeModulePkg/Universal/Acpi/BootScriptExecutorDxe/BootScriptExecutorDxe.= inf + MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/FirmwarePerf= ormanceDxe.inf MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveStateDxe.inf MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.inf MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableSmm/FirmwarePerf= ormanceSmm.inf @@ -487,6 +489,7 @@ [Components.IA32, Components.X64] MdeModulePkg/Universal/SmmCommunicationBufferDxe/SmmCommunicationBufferD= xe.inf MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf =20 + [Components.X64] MdeModulePkg/Universal/CapsulePei/CapsuleX64.inf =20 --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54730): https://edk2.groups.io/g/devel/message/54730 Mute This Topic: https://groups.io/mt/71474828/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Nov 26 08:38:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54729+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582390831667617.7707940180737; Sat, 22 Feb 2020 09:00:31 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TwrNYY1788612xchMZoR0so5; Sat, 22 Feb 2020 09:00:31 -0800 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web11.80.1582390830789845808 for ; Sat, 22 Feb 2020 09:00:30 -0800 X-Received: from pps.filterd (m0134421.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01MH0UrS015322; Sat, 22 Feb 2020 17:00:30 GMT X-Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) by mx0b-002e3701.pphosted.com with ESMTP id 2yb2rd182b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 22 Feb 2020 17:00:30 +0000 X-Received: from G2W6311.americas.hpqcorp.net (g2w6311.austin.hp.com [16.197.64.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2352.austin.hpe.com (Postfix) with ESMTPS id 4209585; Sat, 22 Feb 2020 16:59:58 +0000 (UTC) X-Received: from G4W9336.americas.hpqcorp.net (16.208.33.86) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 22 Feb 2020 16:59:58 +0000 X-Received: from G9W9210.americas.hpqcorp.net (2002:10dc:429b::10dc:429b) by G4W9336.americas.hpqcorp.net (2002:10d0:2156::10d0:2156) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 22 Feb 2020 16:59:57 +0000 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G9W9210.americas.hpqcorp.net (16.220.66.155) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 22 Feb 2020 16:59:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jvbQkE36xKwINTtwQR7CJ7hzRdoeHrG1Lj4hWhFL7SpRyc5mqzaKYwTwdcfWFypXym+JTwDBbcERuYNHp0gt8OSGf+tLxf882UNdcCQHJqVBZJfHxcsyKmX8CDbEvNdqvRtFPVX5m0ampR3tGRStOMZ78PCSKV7LemWI8OSedAGGHdvl7zfl1QAOWQ8CCCLPovSn7/fGEIzSOqMX39JD7UWGY4/+SfaoEFqwxJDwRpZ+gJlE4l2cKrQaZhRAitsTvwTKIYO/fucNhSbJEyhvJ+Etv8nocbwwkGJWuwPhjtnlHCjNix/35EGE4EksroFGs8f5JUL8W3+XuZ/iLZoG7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fzII3FsO1Kj0aOwXxVIkvnyLF2qBqVrQlXidHb/PiLk=; b=V6S2RYMyqpnmOnjPgpegMVlIiB1tzA5XXlB2rw4FLSQN1E1kwN0jo1R/0uarb+bXs1BJnoEXujon0Cw+m2EB46R0jNHNuOuJowb9d7a9mQUMMmk9a1yzzWk7G+WBTs9dv0vmKlxRtKmWOhofEkg01WXxKuvc2eZMOs4SsxwL/4vfNcZtWXYyK1vIGp7yQsJhYEvETpLkuRYkuL3f+276FXSzpwx3oHJKJVjG6ERVDygSBxrAGfq6P7ofRUy9iv57HfyxnHNjGHiEKaPYceW00LSgR6NfcaNBFLxHRPipXMXY6iGBnoXnbomHbIMijlmiVg+hK/YTyfz/3g8mdiux6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::13) by DF4PR8401MB0764.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Sat, 22 Feb 2020 16:59:55 +0000 X-Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b801:ced5:4070:1d8a]) by DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b801:ced5:4070:1d8a%2]) with mapi id 15.20.2750.021; Sat, 22 Feb 2020 16:59:55 +0000 From: "Schaefer, Daniel Helmut (DualStudy)" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Dandan Bi , "Liming Gao" Subject: [edk2-devel] [PATCH 2/3] MdeModulePkg: Set PcdDxeIplSwitchToLongMode false on non-x86 Date: Sat, 22 Feb 2020 17:59:17 +0100 Message-ID: <20200222165918.20834-3-daniel.schaefer@hpe.com> In-Reply-To: <20200222165918.20834-1-daniel.schaefer@hpe.com> References: <20200222165918.20834-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) To DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::13) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from x360-nix.fritz.box (84.58.209.92) by ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18 via Frontend Transport; Sat, 22 Feb 2020 16:59:53 +0000 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b5ef5218-5ebb-49f7-3113-08d7b7b8a40d X-MS-TrafficTypeDiagnostic: DF4PR8401MB0764: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54729+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: Be/SaBLLMD0olOfPTfUgZatdsUqV8lzNAA3gE8x/Fectc7+RH2zz1XJYRuhcH0OL/1CWELs3FzDFhn6IQ99MP6DVPARdqbdJe3GBQoOPA0gpN0j6zHD5N1Kb3LAbpL4SdpPWqtHVBMORedsNqNleQJPOSl7/TOjih3qyzsFLCJ5noPlh4H+kIPi2kLcB52THY7/KTeK4aLfvBeCLInrMeodpDL0tm7/eK6Ta0L2seMiVMJ3JGxJ013yMw3v5H3CPrxRg/tPip36KVX6ZgVsPVJA/YGh+LsTE97GsWqBo7EahOj6j8u28O+6LdBJ0DaRUXROwcN/KNV0lSTnItL+qb0PA2BDMO0hBHpRMc6lTf8IyiHU3E1AhYfAu1nPWC7hdQXbIWJDP4HMosLsC7HvC5pPjl14cf8OpcPjXnGzvREi34XBvBe+AqK6d8mUlGKv3pa1y77YlpkUsKTzUpRx3qLCem8/35//BgMAfDnYiJxkUBxgwBYR7VCz++kXA5Atas3eYcNAdhDzJRC/P063BWQ== X-MS-Exchange-AntiSpam-MessageData: cZ5/heIzfYUyXzKFLTXoHeblg9ORSEzYq+K2dQ3suqdwjkgv3MZkSP9oaN1FJeRnT019TsipgmOGc52umK4LX9HsadOmbPWJ3iRV+UYIHjVAPAb4Q5Zl6pQ+1zHgFg6Fx9WRmFP/AJlvs1x6eKcBxg== X-MS-Exchange-CrossTenant-Network-Message-Id: b5ef5218-5ebb-49f7-3113-08d7b7b8a40d X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2020 16:59:55.3456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rSOsZocLg5aZTTpA/4e9og03mfUYwb80R9j3Yy6LxKf/pIMQxTQZbM6BhvRixtigavZYcbKLy6zync0H53cyWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0764 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: 6e0yDbdyOpeRAmsXy3OuCdrkx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582390831; bh=dj4S6qatRsCIiN9ruTwTbN8U/NfaA1Rn7ME3tkwX2xs=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=oJxr0etRMC2LJUavK8mHhf8ZWViDeT1om+NOD1gd3C39w1WCIVh3fiWlh+kq/MdCSLC POZIhhbFQjfhIIFlCIhPEgjNZaYmcXmkNeiMCquCPchWy/SSVbFBRIoNM97URP7XZcjpB w4r+TfLdn4Qpslx483XV3NgJ7NA2QleKfYY= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Otherwise the PCD isn't defined on other architectures. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2548 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Dandan Bi Cc: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec index 91a3c608231c..59645c860148 100644 --- a/MdeModulePkg/MdeModulePkg.dec +++ b/MdeModulePkg/MdeModulePkg.dec @@ -879,6 +879,9 @@ [PcdsFeatureFlag] [PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|B= OOLEAN|0x0001003a =20 +[PcdsFeatureFlag.EBC, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] + gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE|BOOLEAN|0= x0001003b + [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] ## Indicates if DxeIpl should switch to long mode to enter DXE phase. # It is assumed that 64-bit DxeCore is built in firmware if it is true;= otherwise 32-bit DxeCore --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54729): https://edk2.groups.io/g/devel/message/54729 Mute This Topic: https://groups.io/mt/71474813/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue Nov 26 08:38:45 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54731+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=hpe.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582390852084541.5869735813388; Sat, 22 Feb 2020 09:00:52 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id HzYaYY1788612xkTLnwDDktb; Sat, 22 Feb 2020 09:00:51 -0800 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web12.83.1582390850169356723 for ; Sat, 22 Feb 2020 09:00:50 -0800 X-Received: from pps.filterd (m0150241.ppops.net [127.0.0.1]) by mx0a-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01MGvwvi017164; Sat, 22 Feb 2020 17:00:50 GMT X-Received: from g4t3426.houston.hpe.com (g4t3426.houston.hpe.com [15.241.140.75]) by mx0a-002e3701.pphosted.com with ESMTP id 2yatumu57s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 22 Feb 2020 17:00:49 +0000 X-Received: from G1W8106.americas.hpqcorp.net (g1w8106.austin.hp.com [16.193.72.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3426.houston.hpe.com (Postfix) with ESMTPS id 1241E6C; Sat, 22 Feb 2020 17:00:49 +0000 (UTC) X-Received: from G9W8675.americas.hpqcorp.net (16.220.49.22) by G1W8106.americas.hpqcorp.net (16.193.72.61) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 22 Feb 2020 16:59:59 +0000 X-Received: from G2W6311.americas.hpqcorp.net (16.197.64.53) by G9W8675.americas.hpqcorp.net (16.220.49.22) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Sat, 22 Feb 2020 16:59:59 +0000 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G2W6311.americas.hpqcorp.net (16.197.64.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Sat, 22 Feb 2020 16:59:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YCwvuoxihoFe5Xlk+j8jZj6Tv2cOO/nNboNM2Scj1Okcz5gupYUsblDn9ha2gI+81VnoA3J6oZkUTdV3ClrnfkibLU2Bc9cFS+T3ssy+B101HVXxsoX1RexPgGF0gU6fdz6t014ry5ZWakYV32l3KG7NlFuy2Y0vHBoE9LXqr7L/L2e42bQp0Y1YPXYPKMaDwnFO6E0wySne+GRyHPZr2oFiWDUcpeNYuNHkTNehTTIP0lA0CrafImltFS/ggsy9nmYgCn3v0cCR5hwtf5b7IEI51erhpuYgbgUW/oMnZ+xLno2xQBgZqetXxv3TmoS8+XwnH5+CuKbzX+w3/H6vXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AS7KT+W9STlf4M95a7ggCdZLy1w1zFq+IDyiF/hbRtg=; b=S4MXxOWY1u1VOxFhUowjDXwPZZ4KTWPiIytXb6UwXa5sYCQJQpqQpCKv+MWrOr3vWUmhOg4EUu8Xl1U9Xatknd1nUck3PN6heC2zHTNQ2ybo5QqJBYhksK/QyaWjkzi/LDr4qoGWazjELtLCzlTg/NEpMkPzq4fQvNhc/Ne7OImaKGLOeD6OSX/sum2SjtkIW7qqal0xWTlbRkfZez+FnNX5L2aHTvcbTjAaQnjUIoL/iyZAyh6v7yW1qe2ejKlcOzluRHx2BsUJNxMMXbz3cpkTw1BWHo4iTeyuKg/Nzt6JfOMxuKAm/CjJTLTGiSVK83sLhwdQhtG2QdXLfwW1+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none X-Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::13) by DF4PR8401MB0764.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.21; Sat, 22 Feb 2020 16:59:57 +0000 X-Received: from DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b801:ced5:4070:1d8a]) by DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM ([fe80::b801:ced5:4070:1d8a%2]) with mapi id 15.20.2750.021; Sat, 22 Feb 2020 16:59:57 +0000 From: "Schaefer, Daniel Helmut (DualStudy)" To: CC: Abner Chang , Gilbert Chen , Leif Lindholm , Dandan Bi , Eric Dong Subject: [edk2-devel] [PATCH 3/3] MdeModulePkg: Use CopyGuid instead of GUID assignment Date: Sat, 22 Feb 2020 17:59:18 +0100 Message-ID: <20200222165918.20834-4-daniel.schaefer@hpe.com> In-Reply-To: <20200222165918.20834-1-daniel.schaefer@hpe.com> References: <20200222165918.20834-1-daniel.schaefer@hpe.com> X-ClientProxiedBy: ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) To DF4PR8401MB0777.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7609::13) X-MS-Exchange-MessageSentRepresentingType: 1 X-Received: from x360-nix.fritz.box (84.58.209.92) by ZR0P278CA0032.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:1c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.18 via Frontend Transport; Sat, 22 Feb 2020 16:59:55 +0000 X-Originating-IP: [84.58.209.92] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 1be156fe-2543-43ce-92fd-08d7b7b8a528 X-MS-TrafficTypeDiagnostic: DF4PR8401MB0764: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:361; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54731+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: hpe.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: ltqrBdFj4x7+SHGHUGXND6pA2d5racHD8iTPOUmqp7n5Qp5qtCB21qj28QZW5noruVpphBYSNUSX+Lj7sPaAU0fqHMQ+EtNT4RALiiCUAv8E5ZcvtKyLYvwP/1ZENR45/5phV01P8LSzfP08NxPH6aINGuuzElz39b2nghhhCLCRgIQcgw5+rOjjLXYrwagCeymPhFrV2Xmr0DcPRiTHiJ4RhzA8WBA+TahxDrPl3iPEIoFuzYyzmIvvfnEWLwXxYyFX4Ub1zHnkgI3zSCgIySyEpmYtNMx/Na4PizXjhhzokeM6KYdEdLddbUEIzB7D5QvSa3Su9TqAhDWd+Jf6UjBlghyV36YjWae6Dj65YRHB9dSa99UMn4smLihnvvDXJiV+7PAzPYRn5i5yMKx3pKCdzlBwkYrLp0Tx7bCV1k39RiNR9HBWece10kbjRI1w+CVTlVMJIhdOvle8hYu6qzCedOm4rxYZ9zz7lQVioWkZsRpAe1QphOYePSV0usRCa+Xi3WIgtb5JjpsBcPty/g== X-MS-Exchange-AntiSpam-MessageData: KPlmQZluxAOvQOJvFSThY2I5j+52NqIw40Fbur5Z5do9vNneHjKDk1T7zseHktMVya/dQtJHYUn+1SWSJngpREuFnokL52YcccA312UdSZKgr2A3e8Ow9WQwDvfChL7WPGf/bn8SIDOuMddu9kKXBg== X-MS-Exchange-CrossTenant-Network-Message-Id: 1be156fe-2543-43ce-92fd-08d7b7b8a528 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2020 16:59:57.2078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TccDr8a/ljqchRqQ7NwZdi1yAi/3KsPoW43t/EZRJVOJ5JxfXcJyJszD3Kd1q3PiMCiotsnOhDcjCHCGXejjuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0764 X-OriginatorOrg: hpe.com X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,daniel.schaefer@hpe.com X-Gm-Message-State: gHH72WFrtSuoujoJ71SHncdpx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582390851; bh=XcpVm7hPdqz9Aop5EG2CoT74KthI2WrJiWzsXImnFls=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=BWYzt46gj6IzXWvinupZaAZR9UaqkaYwBP2zLCGc46xRpjXw160UM1xXDxPup6EJxJH c88bbEOR+sdTOffkaTBAP7iGjAWCeFAogbOv6Wbe2az5nTPIdG97gTbXk5Wn0PL6eBuAU AT+zuKteESlGMWZkbD2eAwtVtaIlXnfHcmc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" GCC translates a simple assignment to memcpy, which EDKII doesn't provide. See: https://www.mail-archive.com/edk2-devel@lists.01.org/msg11928.html REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2547 Signed-off-by: Daniel Schaefer Cc: Abner Chang Cc: Gilbert Chen Cc: Leif Lindholm Cc: Dandan Bi Cc: Eric Dong --- MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c b/MdeM= odulePkg/Library/DeviceManagerUiLib/DeviceManager.c index 5cc527679a78..d36648aaa04a 100644 --- a/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c +++ b/MdeModulePkg/Library/DeviceManagerUiLib/DeviceManager.c @@ -619,7 +619,7 @@ CreateDeviceManagerForm( TokenHelp =3D HiiSetString (HiiHandle, 0, String, NULL); FreePool (String); =20 - FormSetGuid =3D ((EFI_IFR_FORM_SET *)Ptr)->Guid; + CopyGuid (&FormSetGuid, &((EFI_IFR_FORM_SET *) Ptr)->Guid); =20 // // Network device process --=20 2.25.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54731): https://edk2.groups.io/g/devel/message/54731 Mute This Topic: https://groups.io/mt/71474829/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-