From nobody Tue Nov 26 08:41:17 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54696+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54696+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=hpe.com ARC-Seal: i=1; a=rsa-sha256; t=1582250241; cv=none; d=zohomail.com; s=zohoarc; b=aynuclbhcL1pP6OwaN/6bp4NV4BW8WUfeP2AqDO1fSYAEdS+4jA+rEZbhLdaMA3hXneKA6iekJ8E3J3DHjkQIRksnV0GQgN5LibxbE9CapCrGt3P6h1KR7bkGEKk9j/FMqGKyP0ePsVV3L691oAWRWcGlX6fagO3qeoaBxgt9tw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582250241; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=XhxvuvUOLznO/xhoGx3/WBI7toapv7R9LRCGISefAU0=; b=PPMI6Uo7KwYprAh2cUcvZEXztuFzOhyBVn+VkNgsis11Zq2NA8iZSNrpcrv9T7agHDyN0TIHDJkDmvjnuJZ/bEY6J0WfwBiMg0QTU2UNToAbU+QumN8fiqCGw1oAEkN7dgqZRJV6stIqigL35mS1GVxNAcrxj1OIFGH739bQPcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54696+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582250241648507.7550208011585; Thu, 20 Feb 2020 17:57:21 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id BaOvYY1788612xrUghQYgq9n; Thu, 20 Feb 2020 17:57:21 -0800 X-Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.3041.1582250239686521753 for ; Thu, 20 Feb 2020 17:57:20 -0800 X-Received: from pps.filterd (m0150244.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01L1ltZt031884; Fri, 21 Feb 2020 01:57:18 GMT X-Received: from g4t3427.houston.hpe.com (g4t3427.houston.hpe.com [15.241.140.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2y9th45jgp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Feb 2020 01:57:18 +0000 X-Received: from g9t2301.houston.hpecorp.net (g9t2301.houston.hpecorp.net [16.220.97.129]) by g4t3427.houston.hpe.com (Postfix) with ESMTP id 24DB15C; Fri, 21 Feb 2020 01:57:18 +0000 (UTC) X-Received: from WANGNICK4.asiapacific.hpqcorp.net (wangnick4.asiapacific.hpqcorp.net [10.43.41.3]) by g9t2301.houston.hpecorp.net (Postfix) with ESMTP id A4A034B; Fri, 21 Feb 2020 01:57:16 +0000 (UTC) From: "Nickle Wang" To: devel@edk2.groups.io, nickle.wang@hpe.com Cc: dandan.bi@intel.com Subject: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Date: Fri, 21 Feb 2020 09:56:45 +0800 Message-Id: <20200221015644.10444-1-nickle.wang@hpe.com> MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nickle.wang@hpe.com X-Gm-Message-State: w13EKZ5KoL9lWNjrJcIliIhpx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582250241; bh=JDcts2ZgdsxXy0cvU52A7oFFPK6JfXS1Mvr9BaOJreY=; h=Cc:Date:From:Reply-To:Subject:To; b=aCGUiKA0X0SjEdpnFuJBCqJHcdPZhn5WaJKTSoRDmc3vZ0Ydd2Pvf0qmeClyaakszJs g/5JZ7pm8M5g9/+xwe0J7Ne4bkOd50TWNv5edu0p7Wgk1P6Q/WGhW89lOS7BAqxTTYPBd SNr25aHns3BgHRQROruIwRo/9RpzuVrpwgc= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes exception when FormSetGuid is NULL. Signed-off-by: Nickle Wang Reviewed-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/= Universal/SetupBrowserDxe/Setup.c index 288f1c3197..82067b541c 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -2,6 +2,7 @@ Entry and initialization module for the browser. =20 Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
+(C) Copyright 2020 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -5844,7 +5845,7 @@ GetIfrBinaryData ( // // Try to compare against formset GUID // - if (IsZeroGuid (FormSetGuid) || + if (IsZeroGuid (ComparingGuid) || CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + sizeof= (EFI_IFR_OP_HEADER)))) { break; } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54696): https://edk2.groups.io/g/devel/message/54696 Mute This Topic: https://groups.io/mt/71442938/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-