From nobody Mon Apr 29 11:38:28 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54640+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54640+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=hpe.com ARC-Seal: i=1; a=rsa-sha256; t=1582122221; cv=none; d=zohomail.com; s=zohoarc; b=A3eOx2fzh/PR1SAoC9taf3lR9Oc6V1AadolBTppdY2mf0fXoYViHs/0LoJ4hQyjbxWG3jB0D//sEhJDWb0wij5w+3xVQoJM3c3lFGA+PYArkD3AMhJiJASr9JclcdYpLb261GN7Xv7mrzSqi7f4+wbWvV8q4K7bMp1SULPcr5bQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582122221; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=3t1ZYzTHOCoblMoltwi/ozqM55bEElNdVLP6JWnNtuk=; b=I94S1Yzjq+m84DlQ4GAPyvm6sB2UvHtp0xpsAmZUqcXLJX287DJTzhLEZouOJJiak6lbewny/hDexqRCaUT1oSeIfQp7wM/RVz6m60gdDJNPBHpwM94IEZ8diAwGIg46x2sxfMTVH9P6/3cKymgePoI6TaMXJBuhzbcsdb0kFo0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54640+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1582122221825669.6835323184231; Wed, 19 Feb 2020 06:23:41 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id kYuxYY1788612xxyBpZ0joFt; Wed, 19 Feb 2020 06:23:41 -0800 X-Received: from mx0a-002e3701.pphosted.com (mx0a-002e3701.pphosted.com [148.163.147.86]) by mx.groups.io with SMTP id smtpd.web10.12668.1582122220440694706 for ; Wed, 19 Feb 2020 06:23:40 -0800 X-Received: from pps.filterd (m0134420.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 01JENeT4010584; Wed, 19 Feb 2020 14:23:40 GMT X-Received: from g9t5009.houston.hpe.com (g9t5009.houston.hpe.com [15.241.48.73]) by mx0b-002e3701.pphosted.com with ESMTP id 2y8ub7n8gg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Feb 2020 14:23:40 +0000 X-Received: from g9t2301.houston.hpecorp.net (g9t2301.houston.hpecorp.net [16.220.97.129]) by g9t5009.houston.hpe.com (Postfix) with ESMTP id F22216B; Wed, 19 Feb 2020 14:23:01 +0000 (UTC) X-Received: from WANGNICK4.asiapacific.hpqcorp.net (unknown [16.168.160.55]) by g9t2301.houston.hpecorp.net (Postfix) with ESMTP id CE7AD4A; Wed, 19 Feb 2020 14:22:59 +0000 (UTC) From: "Nickle Wang" To: devel@edk2.groups.io, nickle.wang@hpe.com Cc: dandan.bi@intel.com Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Date: Wed, 19 Feb 2020 22:22:40 +0800 Message-Id: <20200219142240.10448-1-nickle.wang@hpe.com> MIME-Version: 1.0 X-HPE-SCL: -1 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nickle.wang@hpe.com X-Gm-Message-State: Dxy2jkPKzqnTGFnXhGopyTCVx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582122221; bh=xOSUBFilrTKufXpyepCgVPxTiyduNdvf/yB1FkmPP2Y=; h=Cc:Date:From:Reply-To:Subject:To; b=kSRJ6nO5RXa7u38n+K+CpHOsdtSe2Hzf49T8AGC+mrTq/0hwGRUwYDXrDZdKdpERygp qzo66mBis6Ho3asuxKrIZ/hB5ivy0jbPr5AmDDtfWkKqlzr55+bUktGcJjH92WGYVLXg3 +bMiXm0g4ZR2PstLpW0jRkdGOndrXZy6cCw= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" From the function description of GetIfrBinaryData(), FormSetGuid can be NUL= L. However, FormSetGuid is passed to IsZeroGuid(). This causes exception wh= en FormSetGuid is NULL. Signed-off-by: Nickle Wang Reviewed-by: Dandan Bi --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c b/MdeModulePkg/= Universal/SetupBrowserDxe/Setup.c index 288f1c3197..82067b541c 100644 --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c @@ -2,6 +2,7 @@ Entry and initialization module for the browser. =20 Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
+(C) Copyright 2020 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -5844,7 +5845,7 @@ GetIfrBinaryData ( // // Try to compare against formset GUID // - if (IsZeroGuid (FormSetGuid) || + if (IsZeroGuid (ComparingGuid) || CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + sizeof= (EFI_IFR_OP_HEADER)))) { break; } --=20 2.20.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54640): https://edk2.groups.io/g/devel/message/54640 Mute This Topic: https://groups.io/mt/71396770/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-