From nobody Thu Apr 25 20:40:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54157+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54157+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1581360216634492.780158234027; Mon, 10 Feb 2020 10:43:36 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id YJQ1YY1788612xLclaXAy4UZ; Mon, 10 Feb 2020 10:43:35 -0800 X-Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.2477.1581360215031095219 for ; Mon, 10 Feb 2020 10:43:35 -0800 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2020 10:43:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,425,1574150400"; d="scan'208";a="380189427" X-Received: from mdkinney-mobl2.amr.corp.intel.com ([10.254.12.129]) by orsmga004.jf.intel.com with ESMTP; 10 Feb 2020 10:43:34 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Sean Brogan , Bret Barkelew Subject: [edk2-devel] [Patch] UnitTestFrameworkPkg/UnitTestLib: Fix XCODE parenthesis issues Date: Mon, 10 Feb 2020 10:43:32 -0800 Message-Id: <20200210184332.30716-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com X-Gm-Message-State: n7puanGgSxsV8MMKejCYWTtDx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1581360215; bh=kfn9OIAnNpN9C9ePf6TqAtSUA8kVV5HHIJveKMsMQRk=; h=Cc:Date:From:Reply-To:Subject:To; b=iiteETQWh1tavLDRoXkAGPr76WkO4T8F62p4FLelH8zARhJWR1/2By5rxgIJD9wktcB 7RTUdNZMd5/B16g6DfaNMGd3uuLGxDaKl2pbYzUhPJrCvsEfZbGEPqOtKmp3O4uvbKAgD 7QmleAUeNFg2SfKW85OcdsXriTwW/od+q7k= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" https://bugzilla.tianocore.org/show_bug.cgi?id=3D2512 Remove extra sets of parenthesis that generate warnings on XCODE5 builds. Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D Kinney Reviewed-by: Bret Barkelew --- UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c | 6 +++--- UnitTestFrameworkPkg/Library/UnitTestLib/Log.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c b/UnitTestFr= ameworkPkg/Library/UnitTestLib/Assert.c index dd85b84b08..c327ba88f1 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Assert.c @@ -247,7 +247,7 @@ UnitTestAssertEqual ( IN CONST CHAR8 *DescriptionB ) { - if ((ValueA !=3D ValueB)) { + if (ValueA !=3D ValueB) { UnitTestLogFailure ( FAILURETYPE_ASSERTEQUAL, "%a::%d Value %a !=3D %a (%d !=3D %d)!\n", @@ -365,7 +365,7 @@ UnitTestAssertNotEqual ( IN CONST CHAR8 *DescriptionB ) { - if ((ValueA =3D=3D ValueB)) { + if (ValueA =3D=3D ValueB) { UnitTestLogFailure ( FAILURETYPE_ASSERTNOTEQUAL, "%a::%d Value %a =3D=3D %a (%d =3D=3D %d)!\n", @@ -420,7 +420,7 @@ UnitTestAssertStatusEqual ( IN CONST CHAR8 *Description ) { - if ((Status !=3D Expected)) { + if (Status !=3D Expected) { UnitTestLogFailure ( FAILURETYPE_ASSERTSTATUSEQUAL, "%a::%d Status '%a' is %r, should be %r!\n", diff --git a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c b/UnitTestFrame= workPkg/Library/UnitTestLib/Log.c index 78df086a28..ac4e229b40 100644 --- a/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c +++ b/UnitTestFrameworkPkg/Library/UnitTestLib/Log.c @@ -136,7 +136,7 @@ UnitTestLogInit ( return; } =20 - if((Buffer !=3D NULL) && (BufferSize > 0) && ((BufferSize <=3D UNIT_TEST= _MAX_LOG_BUFFER))) { + if((Buffer !=3D NULL) && (BufferSize > 0) && (BufferSize <=3D UNIT_TEST_= MAX_LOG_BUFFER)) { CopyMem (Test->Log, Buffer, BufferSize); } } --=20 2.21.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54157): https://edk2.groups.io/g/devel/message/54157 Mute This Topic: https://groups.io/mt/71145488/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-