From nobody Sun May 19 02:06:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53742+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53742+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1580856573020770.2308148591253; Tue, 4 Feb 2020 14:49:33 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id lKYDYY1788612x89jZJ3ukEL; Tue, 04 Feb 2020 14:49:32 -0800 X-Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web09.1502.1580856571748531987 for ; Tue, 04 Feb 2020 14:49:31 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-56-tAXjPLj7OkWLbnLzBI7glA-1; Tue, 04 Feb 2020 17:49:28 -0500 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDEB7A0CBF; Tue, 4 Feb 2020 22:49:27 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-152.brq.redhat.com [10.40.204.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B49B7FB79; Tue, 4 Feb 2020 22:49:25 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bob Feng , Liming Gao Subject: [edk2-devel] [PATCH 1/3] BaseTools/Scripts/PatchCheck.py: Do not use mailmap Date: Tue, 4 Feb 2020 23:49:14 +0100 Message-Id: <20200204224916.11320-2-philmd@redhat.com> In-Reply-To: <20200204224916.11320-1-philmd@redhat.com> References: <20200204224916.11320-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: tAXjPLj7OkWLbnLzBI7glA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: Xd8OI7RY4TUdGKbn4bf8DVkbx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1580856572; bh=EjMJ7A+xbt1Z+ihADEQb23mEWZa1IDY21G2s18aIxw8=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=aeysNPLzT9bZXkS/rrKWgQTZ8J1rT0v6oSze/HqYf0T13Y6ijrNhr1lzZhvHhaeiIkV +bCdCEbsyc3ejuKGJDtxPzkpEPYqX+NZ8wRQTuavM7G42alikhAOKRBllBeBP1p4w1Pj5 qyUXlQ+TMtKXdXCkp3hf0T+FaXkCxN58gLI= X-ZohoMail-DKIM: pass (identity @groups.io) From: Philippe Mathieu-Daud=C3=A9 We check the author/committer name/email are properly displayed since commits 8ffa47fb3ab..c0328cf3803. However if PatchCheck.py uses the mailmap, it will check sanitized names/emails. Use the --no-use-mailmap option so PatchCheck.py will check unsanitized input. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Bob Feng Reviewed-by: Laszlo Ersek --- BaseTools/Scripts/PatchCheck.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 6823cc69bb9f..07881abaf64e 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -643,11 +643,13 @@ class CheckGitCommits: =20 def read_patch_from_git(self, commit): # Run git to get the commit patch - return self.run_git('show', '--pretty=3Demail', '--no-textconv', c= ommit) + return self.run_git('show', '--pretty=3Demail', '--no-textconv', + '--no-use-mailmap', commit) =20 def read_committer_email_address_from_git(self, commit): # Run git to get the committer email - return self.run_git('show', '--pretty=3D%cn <%ce>', '--no-patch', = commit) + return self.run_git('show', '--pretty=3D%cn <%ce>', '--no-patch', + '--no-use-mailmap', commit) =20 def run_git(self, *args): cmd =3D [ 'git' ] --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53742): https://edk2.groups.io/g/devel/message/53742 Mute This Topic: https://groups.io/mt/70984701/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 02:06:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53745+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53745+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1580856579994505.42620032971104; Tue, 4 Feb 2020 14:49:39 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id q2j6YY1788612xxJBLMtj83D; Tue, 04 Feb 2020 14:49:39 -0800 X-Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web09.1505.1580856579050040799 for ; Tue, 04 Feb 2020 14:49:39 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-hegVuM0oPHiauR0L7s7RRg-1; Tue, 04 Feb 2020 17:49:31 -0500 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9BD19A0CC1; Tue, 4 Feb 2020 22:49:30 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-152.brq.redhat.com [10.40.204.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB6AF7FB79; Tue, 4 Feb 2020 22:49:28 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bob Feng , Liming Gao Subject: [edk2-devel] [PATCH 2/3] BaseTools/Scripts/PatchCheck.py: Detect emails rewritten by Groups.Io Date: Tue, 4 Feb 2020 23:49:15 +0100 Message-Id: <20200204224916.11320-3-philmd@redhat.com> In-Reply-To: <20200204224916.11320-1-philmd@redhat.com> References: <20200204224916.11320-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: hegVuM0oPHiauR0L7s7RRg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: CpE3d4UYAsav4au33xlzzGbYx1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1580856579; bh=fjD0czG9/5j7U1hh5DMUEsEIw3fVoOVCpQUvzNV2ljY=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=roPbjWxw44gjt6VofxoLSsSmqWWnQ5ro/AIOg1iUcM94G9Ql715XvfNvtLZSMTdQQGT w2gohfXoyWbpa54ztzRgQnn7Alk4GaeZEL34i3M8JomQfVoRIHWNETMPBlCToDP8y00Su pFJtBdiaISG022YoghsQ88WI5S4B3lY7aOc= X-ZohoMail-DKIM: pass (identity @groups.io) From: Philippe Mathieu-Daud=C3=A9 Due to strict DMARC / DKIM / SPF rules, Groups.Io sometimes rewrite the author email. See for example commit df851da3ceff5b6bcf5e12616. Add a check to detect these rewrites with PatchCheck.py. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Bob Feng Reviewed-by: Laszlo Ersek --- BaseTools/Scripts/PatchCheck.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCheck= .py index 07881abaf64e..13da6967785d 100755 --- a/BaseTools/Scripts/PatchCheck.py +++ b/BaseTools/Scripts/PatchCheck.py @@ -79,6 +79,10 @@ class EmailAddressCheck: self.error("The email address cannot contain a space: " + mo.group(3)) =20 + if ' via Groups.Io' in name and mo.group(3).endswith('@groups.io'): + self.error("Email rewritten by lists DMARC / DKIM / SPF: " + + email) + class CommitMessageCheck: """Checks the contents of a git commit message.""" =20 --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53745): https://edk2.groups.io/g/devel/message/53745 Mute This Topic: https://groups.io/mt/70984707/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Sun May 19 02:06:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53744+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53744+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1580856577433407.2163401938037; Tue, 4 Feb 2020 14:49:37 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FEykYY1788612xYXdVLA3MA8; Tue, 04 Feb 2020 14:49:37 -0800 X-Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web11.1472.1580856576484930115 for ; Tue, 04 Feb 2020 14:49:36 -0800 X-Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-299-dU8shoanNZa5QK-rnU6QfA-1; Tue, 04 Feb 2020 17:49:33 -0500 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73FAC108442A; Tue, 4 Feb 2020 22:49:32 +0000 (UTC) X-Received: from x1w.redhat.com (ovpn-204-152.brq.redhat.com [10.40.204.152]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 070707FB79; Tue, 4 Feb 2020 22:49:30 +0000 (UTC) From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= To: devel@edk2.groups.io Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bob Feng , Liming Gao Subject: [edk2-devel] [PATCH 3/3] BaseTools/Scripts: Add log.mailmap to SetupGit.py Date: Tue, 4 Feb 2020 23:49:16 +0100 Message-Id: <20200204224916.11320-4-philmd@redhat.com> In-Reply-To: <20200204224916.11320-1-philmd@redhat.com> References: <20200204224916.11320-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: dU8shoanNZa5QK-rnU6QfA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,philmd@redhat.com X-Gm-Message-State: Wf0Ia6GHRbOtqw1bBu6jaDS3x1787277AA= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1580856577; bh=Z3IPyvMDosqxdLxhtX8ZVYhFe61bfF+2Sy/dTHFD/As=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=frMKKwdQGduVJLcKvgKBwTXe0KgwtdhDk7jJC1S5+UVinhSAoOqLtGSmri0l0ppR5hg xHZt05CjrPytwkrH+nQQGGG+v/RLsGM6ANuvddqRGdAKhoExB1RBcafDG74s2ix0512mw nJIgGaJ/GRYfkCBjCaW9eX2wOHgjkm70MS4= X-ZohoMail-DKIM: pass (identity @groups.io) From: Philippe Mathieu-Daud=C3=A9 We added .mailmap to the repository in commit 4a1aeca3bd02d04e01c2d to display commit mistakes fixed. Use this option by default in our git setup. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Bob Feng Reviewed-by: Laszlo Ersek --- BaseTools/Scripts/SetupGit.py | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py index 514f1c4d42d4..e320ba2f887e 100644 --- a/BaseTools/Scripts/SetupGit.py +++ b/BaseTools/Scripts/SetupGit.py @@ -74,6 +74,7 @@ OPTIONS =3D [ {'section': 'format', 'option': 'coverLetter', 'value': Tru= e}, {'section': 'format', 'option': 'numbered', 'value': Tru= e}, {'section': 'format', 'option': 'signoff', 'value': Fal= se}, + {'section': 'log', 'option': 'mailmap', 'value': Tru= e}, {'section': 'notes', 'option': 'rewriteRef', 'value': 're= fs/notes/commits'}, {'section': 'sendemail', 'option': 'chainreplyto', 'value': Fal= se}, {'section': 'sendemail', 'option': 'thread', 'value': Tru= e}, --=20 2.21.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53744): https://edk2.groups.io/g/devel/message/53744 Mute This Topic: https://groups.io/mt/70984705/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-