From nobody Sat May 4 20:34:44 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53358+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53358+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1579259818; cv=none; d=zohomail.com; s=zohoarc; b=EWfK63vrnByX/lAT0yqFYbFOqqaVTwhtNR/m2nkb3uePOM1U1bSrDsw6Oi38BQ5bLys4qkCqaGhsChqlJKPfWWUe8xVT3DgZ69xWvc3ul5TMi9EnT+gdupQZBKeb6QrLiSbvXQ0LfrMuICneP/dGNDYBc6PZu/RDZfcFTmuUi2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1579259818; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=Aprm56D5TY0lkI5+xko/ZBDwxd3IWgWoMcbOQJK7xvM=; b=e/q2axM9vFCgfOiNSZ7TzWzH5E89hAo+PJPxQaEbU9C6V61eAnkXWyrgB8v7vzqFHFLIdDhnf7Wj6EU8AuZq/9dlvtm+jmySp7HeZa1iVbBR/qwgX/3TVJQYN2E0sbto3RFuVAwpfLGriPsH0/mjmc07EAv2YIJ6G4RoSu/mmYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53358+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1579259818138993.3979383295152; Fri, 17 Jan 2020 03:16:58 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id eHdSYY1788612x8LVQb4qQhF; Fri, 17 Jan 2020 03:16:57 -0800 X-Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web10.5161.1579259816495095406 for ; Fri, 17 Jan 2020 03:16:57 -0800 X-Received: by mail-wr1-f67.google.com with SMTP id d16so22320095wre.10 for ; Fri, 17 Jan 2020 03:16:56 -0800 (PST) X-Gm-Message-State: 8zDHmVYxyI8AqIV8uWxvx9Nyx1787277AA= X-Google-Smtp-Source: APXvYqzhtX1z3zA0oLyYSMCQr7aKSdK3xzRpy3rlu2iMoZUHpi+itDBjf7CxDfpgjOvB1ovchyOAsA== X-Received: by 2002:adf:e6c6:: with SMTP id y6mr2480503wrm.284.1579259814813; Fri, 17 Jan 2020 03:16:54 -0800 (PST) X-Received: from dogfood.home ([2a01:cb1d:112:6f00:d1a2:6463:e9f:6fd0]) by smtp.gmail.com with ESMTPSA id p5sm31957259wrt.79.2020.01.17.03.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 03:16:54 -0800 (PST) From: "Ard Biesheuvel" To: devel@edk2.groups.io Cc: leif.lindholm@linaro.org, Ard Biesheuvel Subject: [edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer/NetsecDxe: ignore DMA coherency at binding time Date: Fri, 17 Jan 2020 12:16:51 +0100 Message-Id: <20200117111651.10740-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ard.biesheuvel@linaro.org Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1579259817; bh=as9EJH6PbGnq46fNCyIkWiwWZ96o9boaREbn0kKB8aQ=; h=Cc:Date:From:Reply-To:Subject:To; b=eM25MJOAF113NeNl8VvHZTsGj/6WoJFfi+m+f04vrY9iSpErgr2iIZBXQg+DJJIRwXO d4H26ImomyfutRf04adoUiaNxgA+HlXL0JSdEvv2Iwb0k22BLuIYelGLdJWUVFi/uXZB4 8CFaL5S6pTjPruv6OzA1V0CRFNYaxQuq88M= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" Whether the Netsec driver is built to support coherent or non-coherent DMA is decided by the DmaLib library class resolution that is provided by the platform description, and there are various other places where the platform needs to be consistent with this (ACPI tables, device tree, platform driver, etc) Since the driver has no way to figure out which flavor of DmaLib it was built against, there is no point in limiting it to one flavor only, and we can drop the DmaType check at binding time entirely. This fixes an issue introduced by commit 88c7874481b856578662b775 ("Silicon/SynQuacer/PlatformDxe: set NETSEC DMA as coherent"), which incorrectly stated that the driver does not look at the DmaType flag in the first place. Signed-off-by: Ard Biesheuvel Reviewed-by: Leif Lindholm --- Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBindin= g.c b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c index 9820585e0dd5..392d1b474f5e 100644 --- a/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c +++ b/Silicon/Socionext/SynQuacer/Drivers/Net/NetsecDxe/DriverBinding.c @@ -52,8 +52,7 @@ NetsecDriverBindingSupported ( return Status; } =20 - if (CompareGuid (Dev->Type, &gNetsecNonDiscoverableDeviceGuid) && - Dev->DmaType =3D=3D NonDiscoverableDeviceDmaTypeNonCoherent) { + if (CompareGuid (Dev->Type, &gNetsecNonDiscoverableDeviceGuid)) { Status =3D EFI_SUCCESS; } else { Status =3D EFI_UNSUPPORTED; --=20 2.20.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53358): https://edk2.groups.io/g/devel/message/53358 Mute This Topic: https://groups.io/mt/69840917/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-