[edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib

Wang, Jian J posted 2 patches 4 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/edk2 tags/patchew/20200116061004.636-1-jian.j.wang@intel.com
CryptoPkg/Include/Library/BaseCryptLib.h      | 111 +++++-------------
.../Library/BaseCryptLib/Hmac/CryptHmacMd5.c  |  58 ++-------
.../BaseCryptLib/Hmac/CryptHmacMd5Null.c      |  28 +----
.../Library/BaseCryptLib/Hmac/CryptHmacSha1.c |  59 ++--------
.../BaseCryptLib/Hmac/CryptHmacSha1Null.c     |  28 +----
.../BaseCryptLib/Hmac/CryptHmacSha256.c       |  58 ++-------
.../BaseCryptLib/Hmac/CryptHmacSha256Null.c   |  28 +----
.../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c  |  28 +----
.../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c |  28 +----
.../Hmac/CryptHmacSha256Null.c                |  28 +----
10 files changed, 84 insertions(+), 370 deletions(-)
[edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib
Posted by Wang, Jian J 4 years, 2 months ago
v3 changes per Laszlo's comments:
 - Fix typos
 - Change api name also for BaseCryptLibNull
 - Split the patch into two
(v3 branch: https://github.com/jwang36/edk2/tree/fix-bz1792-v3)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1792
Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>

Jian J Wang (2):
  CryptoPkg/BaseCryptLib: replace HmacXxxInit API with HmacXxxSetKey
  CryptoPkg/BaseCryptLib: remove HmacXxxGetContextSize interface

 CryptoPkg/Include/Library/BaseCryptLib.h      | 111 +++++-------------
 .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c  |  58 ++-------
 .../BaseCryptLib/Hmac/CryptHmacMd5Null.c      |  28 +----
 .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c |  59 ++--------
 .../BaseCryptLib/Hmac/CryptHmacSha1Null.c     |  28 +----
 .../BaseCryptLib/Hmac/CryptHmacSha256.c       |  58 ++-------
 .../BaseCryptLib/Hmac/CryptHmacSha256Null.c   |  28 +----
 .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c  |  28 +----
 .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c |  28 +----
 .../Hmac/CryptHmacSha256Null.c                |  28 +----
 10 files changed, 84 insertions(+), 370 deletions(-)

-- 
2.24.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53299): https://edk2.groups.io/g/devel/message/53299
Mute This Topic: https://groups.io/mt/69742158/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib
Posted by Xiaoyu Lu 4 years, 2 months ago
Hi Jian,

  The date of copyright info should be update to 2020 in each changed file. with these changed:
  Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>

Thanks.

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wang, Jian J
> Sent: Thursday, January 16, 2020 2:10 PM
> To: devel@edk2.groups.io
> Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in
> BaseCryptLib
> 
> v3 changes per Laszlo's comments:
> 
>  - Fix typos
> 
>  - Change api name also for BaseCryptLibNull
> 
>  - Split the patch into two
> 
> (v3 branch: https://github.com/jwang36/edk2/tree/fix-bz1792-v3)
> 
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1792
> 
> Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> 
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> 
> Jian J Wang (2):
>   CryptoPkg/BaseCryptLib: replace HmacXxxInit API with HmacXxxSetKey
>   CryptoPkg/BaseCryptLib: remove HmacXxxGetContextSize interface
> 
>  CryptoPkg/Include/Library/BaseCryptLib.h      | 111 +++++-------------
>  .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c  |  58 ++-------
>  .../BaseCryptLib/Hmac/CryptHmacMd5Null.c      |  28 +----
>  .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c |  59 ++--------
>  .../BaseCryptLib/Hmac/CryptHmacSha1Null.c     |  28 +----
>  .../BaseCryptLib/Hmac/CryptHmacSha256.c       |  58 ++-------
>  .../BaseCryptLib/Hmac/CryptHmacSha256Null.c   |  28 +----
>  .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c  |  28 +----
>  .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c |  28 +----
>  .../Hmac/CryptHmacSha256Null.c                |  28 +----
>  10 files changed, 84 insertions(+), 370 deletions(-)
> 
> --
> 2.24.0.windows.2
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> 
> View/Reply Online (#53299): https://edk2.groups.io/g/devel/message/53299
> Mute This Topic: https://groups.io/mt/69742158/1780156
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub  [xiaoyux.lu@intel.com]
> -=-=-=-=-=-=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53382): https://edk2.groups.io/g/devel/message/53382
Mute This Topic: https://groups.io/mt/69742158/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in BaseCryptLib
Posted by Wang, Jian J 4 years, 2 months ago
Thanks for the comment. It will be updated before push.

Regards,
Jian

> -----Original Message-----
> From: Lu, XiaoyuX <xiaoyux.lu@intel.com>
> Sent: Sunday, January 19, 2020 10:05 AM
> To: devel@edk2.groups.io; Wang, Jian J <jian.j.wang@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Subject: RE: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in
> BaseCryptLib
> 
> Hi Jian,
> 
>   The date of copyright info should be update to 2020 in each changed file. with
> these changed:
>   Reviewed-by: Xiaoyu Lu <xiaoyux.lu@intel.com>
> 
> Thanks.
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wang, Jian J
> > Sent: Thursday, January 16, 2020 2:10 PM
> > To: devel@edk2.groups.io
> > Cc: Lu, XiaoyuX <xiaoyux.lu@intel.com>; Laszlo Ersek <lersek@redhat.com>
> > Subject: [edk2-devel] [PATCH v3 0/2] Remove deprecated code in
> > BaseCryptLib
> >
> > v3 changes per Laszlo's comments:
> >
> >  - Fix typos
> >
> >  - Change api name also for BaseCryptLibNull
> >
> >  - Split the patch into two
> >
> > (v3 branch: https://github.com/jwang36/edk2/tree/fix-bz1792-v3)
> >
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1792
> >
> > Cc: Xiaoyu Lu <xiaoyux.lu@intel.com>
> >
> > Cc: Laszlo Ersek <lersek@redhat.com>
> >
> > Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
> >
> > Jian J Wang (2):
> >   CryptoPkg/BaseCryptLib: replace HmacXxxInit API with HmacXxxSetKey
> >   CryptoPkg/BaseCryptLib: remove HmacXxxGetContextSize interface
> >
> >  CryptoPkg/Include/Library/BaseCryptLib.h      | 111 +++++-------------
> >  .../Library/BaseCryptLib/Hmac/CryptHmacMd5.c  |  58 ++-------
> >  .../BaseCryptLib/Hmac/CryptHmacMd5Null.c      |  28 +----
> >  .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c |  59 ++--------
> >  .../BaseCryptLib/Hmac/CryptHmacSha1Null.c     |  28 +----
> >  .../BaseCryptLib/Hmac/CryptHmacSha256.c       |  58 ++-------
> >  .../BaseCryptLib/Hmac/CryptHmacSha256Null.c   |  28 +----
> >  .../BaseCryptLibNull/Hmac/CryptHmacMd5Null.c  |  28 +----
> >  .../BaseCryptLibNull/Hmac/CryptHmacSha1Null.c |  28 +----
> >  .../Hmac/CryptHmacSha256Null.c                |  28 +----
> >  10 files changed, 84 insertions(+), 370 deletions(-)
> >
> > --
> > 2.24.0.windows.2
> >
> >
> > -=-=-=-=-=-=
> > Groups.io Links: You receive all messages sent to this group.
> >
> > View/Reply Online (#53299): https://edk2.groups.io/g/devel/message/53299
> > Mute This Topic: https://groups.io/mt/69742158/1780156
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub  [xiaoyux.lu@intel.com]
> > -=-=-=-=-=-=


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#53418): https://edk2.groups.io/g/devel/message/53418
Mute This Topic: https://groups.io/mt/69742158/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-